mbox series

[SRU,J/Unstable/OEM-6.1,0/3] Some QHD panels fail to refresh when PSR2 enabled

Message ID 20230303025105.2436150-1-kai.heng.feng@canonical.com
Headers show
Series Some QHD panels fail to refresh when PSR2 enabled | expand

Message

Kai-Heng Feng March 3, 2023, 2:51 a.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/2009014

[Impact]
Some QHD (2560x1440) panels which support PSR2 refresh the display
abnormally. The display frequently stop responding for few seconds on
all user interactions, ex. mouse movement, TTY and any APP GUI. There's
no problem on the external monitor. After disabling PSR, the problem
will be gone.

[Fix]
Intel release a fix to calculate the wake up line count and configure
them into PSR2_CTL accordingly.

[Test]
Verified on the problematic panels to check if the display responds
smoothly to mouse movement.

[Where problems could occur]
Only affects the panels on some particular panels which supports PSR2

Jouni Högander (3):
  drm/i915/psr: Use full update In case of area calculation fails
  drm/i915: Ensure damage clip area is within pipe area
  drm/i915/psr: Use calculated io and fast wake lines

 .../drm/i915/display/intel_display_types.h    |   2 +
 drivers/gpu/drm/i915/display/intel_psr.c      | 115 ++++++++++++++----
 2 files changed, 93 insertions(+), 24 deletions(-)

Comments

Timo Aaltonen March 3, 2023, 8:40 a.m. UTC | #1 
Kai-Heng Feng kirjoitti 3.3.2023 klo 4.51:
> BugLink: https://bugs.launchpad.net/bugs/2009014
> 
> [Impact]
> Some QHD (2560x1440) panels which support PSR2 refresh the display
> abnormally. The display frequently stop responding for few seconds on
> all user interactions, ex. mouse movement, TTY and any APP GUI. There's
> no problem on the external monitor. After disabling PSR, the problem
> will be gone.
> 
> [Fix]
> Intel release a fix to calculate the wake up line count and configure
> them into PSR2_CTL accordingly.
> 
> [Test]
> Verified on the problematic panels to check if the display responds
> smoothly to mouse movement.
> 
> [Where problems could occur]
> Only affects the panels on some particular panels which supports PSR2
> 
> Jouni Högander (3):
>    drm/i915/psr: Use full update In case of area calculation fails
>    drm/i915: Ensure damage clip area is within pipe area
>    drm/i915/psr: Use calculated io and fast wake lines
> 
>   .../drm/i915/display/intel_display_types.h    |   2 +
>   drivers/gpu/drm/i915/display/intel_psr.c      | 115 ++++++++++++++----
>   2 files changed, 93 insertions(+), 24 deletions(-)
> 

applied to oem-6.1, thanks
Stefan Bader March 3, 2023, 10:13 a.m. UTC | #2 
On 03.03.23 03:51, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/2009014
> 
> [Impact]
> Some QHD (2560x1440) panels which support PSR2 refresh the display
> abnormally. The display frequently stop responding for few seconds on
> all user interactions, ex. mouse movement, TTY and any APP GUI. There's
> no problem on the external monitor. After disabling PSR, the problem
> will be gone.
> 
> [Fix]
> Intel release a fix to calculate the wake up line count and configure
> them into PSR2_CTL accordingly.
> 
> [Test]
> Verified on the problematic panels to check if the display responds
> smoothly to mouse movement.
> 
> [Where problems could occur]
> Only affects the panels on some particular panels which supports PSR2
> 
> Jouni Högander (3):
>    drm/i915/psr: Use full update In case of area calculation fails
>    drm/i915: Ensure damage clip area is within pipe area
>    drm/i915/psr: Use calculated io and fast wake lines
> 
>   .../drm/i915/display/intel_display_types.h    |   2 +
>   drivers/gpu/drm/i915/display/intel_psr.c      | 115 ++++++++++++++----
>   2 files changed, 93 insertions(+), 24 deletions(-)
> 

The cherry picks ok, the backport from subsystem tree not so much. I 
understand this is a critical problem. Do we have your "promise" to 
follow up on this once there is an official version of the change?

- Stefan
Kai-Heng Feng March 3, 2023, 11:30 a.m. UTC | #3 
On Fri, Mar 3, 2023 at 6:13 PM Stefan Bader <stefan.bader@canonical.com> wrote:
>
> On 03.03.23 03:51, Kai-Heng Feng wrote:
> > BugLink: https://bugs.launchpad.net/bugs/2009014
> >
> > [Impact]
> > Some QHD (2560x1440) panels which support PSR2 refresh the display
> > abnormally. The display frequently stop responding for few seconds on
> > all user interactions, ex. mouse movement, TTY and any APP GUI. There's
> > no problem on the external monitor. After disabling PSR, the problem
> > will be gone.
> >
> > [Fix]
> > Intel release a fix to calculate the wake up line count and configure
> > them into PSR2_CTL accordingly.
> >
> > [Test]
> > Verified on the problematic panels to check if the display responds
> > smoothly to mouse movement.
> >
> > [Where problems could occur]
> > Only affects the panels on some particular panels which supports PSR2
> >
> > Jouni Högander (3):
> >    drm/i915/psr: Use full update In case of area calculation fails
> >    drm/i915: Ensure damage clip area is within pipe area
> >    drm/i915/psr: Use calculated io and fast wake lines
> >
> >   .../drm/i915/display/intel_display_types.h    |   2 +
> >   drivers/gpu/drm/i915/display/intel_psr.c      | 115 ++++++++++++++----
> >   2 files changed, 93 insertions(+), 24 deletions(-)
> >
>
> The cherry picks ok, the backport from subsystem tree not so much. I
> understand this is a critical problem. Do we have your "promise" to
> follow up on this once there is an official version of the change?

Of course. If the the fix that hit the mainline/next tree is different
to the current one, I'll do a subsequent SRU to make sure it's aligned
with upstream.

Kai-Heng

>
> - Stefan
>
Stefan Bader March 3, 2023, 1:28 p.m. UTC | #4 
On 03.03.23 03:51, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/2009014
> 
> [Impact]
> Some QHD (2560x1440) panels which support PSR2 refresh the display
> abnormally. The display frequently stop responding for few seconds on
> all user interactions, ex. mouse movement, TTY and any APP GUI. There's
> no problem on the external monitor. After disabling PSR, the problem
> will be gone.
> 
> [Fix]
> Intel release a fix to calculate the wake up line count and configure
> them into PSR2_CTL accordingly.
> 
> [Test]
> Verified on the problematic panels to check if the display responds
> smoothly to mouse movement.
> 
> [Where problems could occur]
> Only affects the panels on some particular panels which supports PSR2
> 
> Jouni Högander (3):
>    drm/i915/psr: Use full update In case of area calculation fails
>    drm/i915: Ensure damage clip area is within pipe area
>    drm/i915/psr: Use calculated io and fast wake lines
> 
>   .../drm/i915/display/intel_display_types.h    |   2 +
>   drivers/gpu/drm/i915/display/intel_psr.c      | 115 ++++++++++++++----
>   2 files changed, 93 insertions(+), 24 deletions(-)
> 
Ok, so for avoiding these panel problems (with the claim of being well 
tested and the promise to clean up later)...

Acked-by: Stefan Bader <stefan.bader@canonical.com>
Tim Gardner March 6, 2023, 2:25 p.m. UTC | #5 
On 3/2/23 7:51 PM, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/2009014
> 
> [Impact]
> Some QHD (2560x1440) panels which support PSR2 refresh the display
> abnormally. The display frequently stop responding for few seconds on
> all user interactions, ex. mouse movement, TTY and any APP GUI. There's
> no problem on the external monitor. After disabling PSR, the problem
> will be gone.
> 
> [Fix]
> Intel release a fix to calculate the wake up line count and configure
> them into PSR2_CTL accordingly.
> 
> [Test]
> Verified on the problematic panels to check if the display responds
> smoothly to mouse movement.
> 
> [Where problems could occur]
> Only affects the panels on some particular panels which supports PSR2
> 
> Jouni Högander (3):
>    drm/i915/psr: Use full update In case of area calculation fails
>    drm/i915: Ensure damage clip area is within pipe area
>    drm/i915/psr: Use calculated io and fast wake lines
> 
>   .../drm/i915/display/intel_display_types.h    |   2 +
>   drivers/gpu/drm/i915/display/intel_psr.c      | 115 ++++++++++++++----
>   2 files changed, 93 insertions(+), 24 deletions(-)
> 
Acked-by: Tim Gardner <tim.gardner@canonical.com>
Stefan Bader March 8, 2023, 10:44 a.m. UTC | #6 
On 03.03.23 03:51, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/2009014
> 
> [Impact]
> Some QHD (2560x1440) panels which support PSR2 refresh the display
> abnormally. The display frequently stop responding for few seconds on
> all user interactions, ex. mouse movement, TTY and any APP GUI. There's
> no problem on the external monitor. After disabling PSR, the problem
> will be gone.
> 
> [Fix]
> Intel release a fix to calculate the wake up line count and configure
> them into PSR2_CTL accordingly.
> 
> [Test]
> Verified on the problematic panels to check if the display responds
> smoothly to mouse movement.
> 
> [Where problems could occur]
> Only affects the panels on some particular panels which supports PSR2
> 
> Jouni Högander (3):
>    drm/i915/psr: Use full update In case of area calculation fails
>    drm/i915: Ensure damage clip area is within pipe area
>    drm/i915/psr: Use calculated io and fast wake lines
> 
>   .../drm/i915/display/intel_display_types.h    |   2 +
>   drivers/gpu/drm/i915/display/intel_psr.c      | 115 ++++++++++++++----
>   2 files changed, 93 insertions(+), 24 deletions(-)
> 

Applied to kinetic:linux/master-next. Thanks.

-Stefan
Andrea Righi March 14, 2023, 3:22 p.m. UTC | #7 
On Fri, Mar 03, 2023 at 10:51:01AM +0800, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/2009014
> 
> [Impact]
> Some QHD (2560x1440) panels which support PSR2 refresh the display
> abnormally. The display frequently stop responding for few seconds on
> all user interactions, ex. mouse movement, TTY and any APP GUI. There's
> no problem on the external monitor. After disabling PSR, the problem
> will be gone.
> 
> [Fix]
> Intel release a fix to calculate the wake up line count and configure
> them into PSR2_CTL accordingly.
> 
> [Test]
> Verified on the problematic panels to check if the display responds
> smoothly to mouse movement.
> 
> [Where problems could occur]
> Only affects the panels on some particular panels which supports PSR2

Applied to lunar/linux.

Thanks,
-Andrea