diff mbox series

[4/4] Fix typos in the slof folder

Message ID 20230222154057.904578-5-thuth@redhat.com
State Accepted
Headers show
Series Fix typos | expand

Commit Message

Thomas Huth Feb. 22, 2023, 3:40 p.m. UTC
Found with the "codespell" utility. I kept "busses" which codespell
also complains about since it seems to be an old but still valid
plural of the word "bus".

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 slof/entry.S                 | 2 +-
 slof/fs/available.fs         | 2 +-
 slof/fs/base.fs              | 4 ++--
 slof/fs/claim.fs             | 2 +-
 slof/fs/fcode/1275.fs        | 2 +-
 slof/fs/fcode/locals.fs      | 2 +-
 slof/fs/generic-disk.fs      | 2 +-
 slof/fs/node.fs              | 2 +-
 slof/fs/packages/iso-9660.fs | 4 ++--
 slof/fs/pci-bridge.fs        | 2 +-
 slof/fs/pci-device.fs        | 2 +-
 slof/fs/pci-helper.fs        | 6 +++---
 slof/fs/pci-properties.fs    | 4 ++--
 slof/fs/pci-scan.fs          | 2 +-
 slof/fs/root.fs              | 2 +-
 slof/fs/scsi-host-helpers.fs | 2 +-
 slof/fs/term-io.fs           | 2 +-
 slof/prim.code               | 2 +-
 18 files changed, 23 insertions(+), 23 deletions(-)

Comments

Segher Boessenkool Feb. 22, 2023, 4:34 p.m. UTC | #1
On Wed, Feb 22, 2023 at 04:40:57PM +0100, Thomas Huth wrote:
> Found with the "codespell" utility. I kept "busses" which codespell
> also complains about since it seems to be an old but still valid
> plural of the word "bus".

For all four:
Reviewed-by: Segher Boessenkool <segher@kernel.crashing.org>

> -\ We corespond memory nodes with their respective memory controllers
> +\ We correspond memory nodes with their respective memory controllers
>  \ and use /chosen/memory as default memory node to hold the "available" map

"We pair"?  "We correlate"?

>  \ NOTE -> /chosen/memory is expected 2B initialized before using claim/release

"to be".  (It took me a while to realise this , I thought "0x80000000
earlier" or such!)

>  \ check for multifunction and for each function
> -\ (dependig from header type) call device or bridge setup
> +\ (depending from header type) call device or bridge setup

"dependent on header type"?

> -// bool dependend pick
> +// bool dependent pick
>  // ?PICK ( v1 v2 bool -- v1|v2 )

: ?pick  1 umin pick ;
or
: ?pick  IF swap THEN drop ;
(the latter is the actual implementation).

But maybe just delete this word?  It isn't used anywhere afaics, and it
isn't a good name for what it does anyway?


Segher
Alexey Kardashevskiy Feb. 28, 2023, 6:08 a.m. UTC | #2
On 23/02/2023 03:34, Segher Boessenkool wrote:
> On Wed, Feb 22, 2023 at 04:40:57PM +0100, Thomas Huth wrote:
>> Found with the "codespell" utility. I kept "busses" which codespell
>> also complains about since it seems to be an old but still valid
>> plural of the word "bus".
> 
> For all four:
> Reviewed-by: Segher Boessenkool <segher@kernel.crashing.org>
> 
>> -\ We corespond memory nodes with their respective memory controllers
>> +\ We correspond memory nodes with their respective memory controllers
>>   \ and use /chosen/memory as default memory node to hold the "available" map
> 
> "We pair"?  "We correlate"?
> 
>>   \ NOTE -> /chosen/memory is expected 2B initialized before using claim/release
> 
> "to be".  (It took me a while to realise this , I thought "0x80000000
> earlier" or such!)
> 
>>   \ check for multifunction and for each function
>> -\ (dependig from header type) call device or bridge setup
>> +\ (depending from header type) call device or bridge setup
> 
> "dependent on header type"?
> 
>> -// bool dependend pick
>> +// bool dependent pick
>>   // ?PICK ( v1 v2 bool -- v1|v2 )
> 
> : ?pick  1 umin pick ;

What is "umin" exactly?

> or
> : ?pick  IF swap THEN drop ;
> (the latter is the actual implementation).
> 
> But maybe just delete this word?  It isn't used anywhere afaics, and it
> isn't a good name for what it does anyway?

Delete it is then:

https://github.com/aik/SLOF-debug/commits/master
diff mbox series

Patch

diff --git a/slof/entry.S b/slof/entry.S
index 5372de3..77fae8f 100644
--- a/slof/entry.S
+++ b/slof/entry.S
@@ -30,7 +30,7 @@  eregs:
 	 * defined in $(TARG).c
 	 * the_exception_frame can be accessed from paflof through
 	 * the word eregs
-	 * in the case an excpetion is handled paflof will read
+	 * in the case an exception is handled paflof will read
 	 * from eregs the values of all registers and print them
 	 * out in the exception handler */
 	.quad	the_exception_frame
diff --git a/slof/fs/available.fs b/slof/fs/available.fs
index 5eb8fa9..9d2d934 100644
--- a/slof/fs/available.fs
+++ b/slof/fs/available.fs
@@ -16,7 +16,7 @@  VARIABLE chosen-memory-ih 0 chosen-memory-ih !
 \ Maintain "available" property.
 \ Sun has a single memory node with "available" property
 \ and separate memory controller nodes.
-\ We corespond memory nodes with their respective memory controllers
+\ We correspond memory nodes with their respective memory controllers
 \ and use /chosen/memory as default memory node to hold the "available" map
 \ NOTE -> /chosen/memory is expected 2B initialized before using claim/release
 \ +
diff --git a/slof/fs/base.fs b/slof/fs/base.fs
index e2104fb..d7f4e37 100644
--- a/slof/fs/base.fs
+++ b/slof/fs/base.fs
@@ -553,11 +553,11 @@  defer cursor-off ( -- )
 : reset-all reboot ;
 
 \ load-base is an env. variable now, but it can
-\ be overriden temporarily provided users use
+\ be overridden temporarily provided users use
 \ get-load-base rather than load-base directly
 \
 \ default-load-base is set here and can be
-\ overriden by the board code. It will be used
+\ overridden by the board code. It will be used
 \ to set the default value of the envvar "load-base"
 \ when booting without a valid nvram
 
diff --git a/slof/fs/claim.fs b/slof/fs/claim.fs
index d012d3d..75edf3e 100644
--- a/slof/fs/claim.fs
+++ b/slof/fs/claim.fs
@@ -178,7 +178,7 @@  VARIABLE mem-pre-released 0 mem-pre-released !
 \ position
 \ +
 \ insert-available should also check adjacent elements and merge if new
-\ region is contiguos w. others
+\ region is contiguous with others
 \ +
 : (insert-available) ( available-ptr -- available-ptr )
 	dup				\ current element
diff --git a/slof/fs/fcode/1275.fs b/slof/fs/fcode/1275.fs
index c2a67bc..84e5f91 100644
--- a/slof/fs/fcode/1275.fs
+++ b/slof/fs/fcode/1275.fs
@@ -175,7 +175,7 @@ 
    new-token
 ;
 
-\ decide wether or not to give a new token an own name in the dictionary
+\ decide whether or not to give a new token an own name in the dictionary
 : named-token
    fcode-debug? IF
       external-token
diff --git a/slof/fs/fcode/locals.fs b/slof/fs/fcode/locals.fs
index 5381df0..34400e5 100644
--- a/slof/fs/fcode/locals.fs
+++ b/slof/fs/fcode/locals.fs
@@ -98,7 +98,7 @@  localsstackbuf VALUE localsstack
 : fc-pop-locals  ( -- )
    \ ." popping locals" cr
    localsstack 8 cells - TO localsstack
-   localsstack localsstackbuf - 0 < ABORT" Locals stack undeflow!"
+   localsstack localsstackbuf - 0 < ABORT" Locals stack underflow!"
 ;
 
 
diff --git a/slof/fs/generic-disk.fs b/slof/fs/generic-disk.fs
index 0543c89..92b7c54 100644
--- a/slof/fs/generic-disk.fs
+++ b/slof/fs/generic-disk.fs
@@ -38,7 +38,7 @@  new-device set-unit                                          ( str len )
   s" 0 pci-alias-" 2swap $cat evaluate
   s" block" device-type      
 
-\ Requiered interface for deblocker
+\ Required interface for deblocker
 
    s" block-size" $call-parent   CONSTANT block-size
    s" max-transfer" $call-parent CONSTANT max-transfer 
diff --git a/slof/fs/node.fs b/slof/fs/node.fs
index 23238bb..9cee3c0 100644
--- a/slof/fs/node.fs
+++ b/slof/fs/node.fs
@@ -349,7 +349,7 @@  d# 10 CONSTANT MAX-ALIAS
     ELSE 2drop list-alias THEN THEN ;
 
 \ sub-alias does a single iteration of an alias at the beginning od dev path
-\ expression. de-alias will repeat this until all indirect alising is resolved
+\ expression. de-alias will repeat this until all indirect aliasing is resolved
 : sub-alias ( arg-str arg-len -- arg' len' | false )
    2dup
    2dup [char] / findchar ?dup IF ELSE 2dup [char] : findchar THEN
diff --git a/slof/fs/packages/iso-9660.fs b/slof/fs/packages/iso-9660.fs
index 6eda8be..47edb2a 100644
--- a/slof/fs/packages/iso-9660.fs
+++ b/slof/fs/packages/iso-9660.fs
@@ -109,7 +109,7 @@  INSTANCE VARIABLE index
 ;
 
 
-\ This method coverts the iso file name to user readble form
+\ This method converts the ISO file name to user readable form
 
 : file-name  ( str len --  str' len' )
    2dup  [char] ; findchar  IF
@@ -169,7 +169,7 @@  INSTANCE VARIABLE index
 ;
 
 
-\ METHOD for searching for a file with in a direcotory
+\ METHOD for searching for a file with in a directory
 
 : search-file-dir ( str len  -- TRUE | FALSE )
    dir-addr @  800 *  dir-addr !             ( str len )
diff --git a/slof/fs/pci-bridge.fs b/slof/fs/pci-bridge.fs
index e6af7b6..58c5137 100644
--- a/slof/fs/pci-bridge.fs
+++ b/slof/fs/pci-bridge.fs
@@ -48,7 +48,7 @@  s" dma-function.fs" included
 \ this device and so for the scanning for the devices behind
 pci-device-disable
 
-\ Enalbe #PERR and #SERR reporting
+\ Enable #PERR and #SERR reporting
 pci-error-enable
 
 \ Print out device information
diff --git a/slof/fs/pci-device.fs b/slof/fs/pci-device.fs
index 7b17758..6699333 100644
--- a/slof/fs/pci-device.fs
+++ b/slof/fs/pci-device.fs
@@ -95,7 +95,7 @@  s" dma-function.fs" included
 \ if Bus Master function is needed it should be enabled/disabled by open/close in the device driver code
 pci-device-disable
 
-\ Enalbe #PERR and #SERR reporting
+\ Enable #PERR and #SERR reporting
 pci-error-enable
 
 \ Print out device information
diff --git a/slof/fs/pci-helper.fs b/slof/fs/pci-helper.fs
index a4f69f1..5535bf2 100644
--- a/slof/fs/pci-helper.fs
+++ b/slof/fs/pci-helper.fs
@@ -128,13 +128,13 @@ 
         THEN
 ;
 
-\ check wether this device is a pci-express device
+\ check whether this device is a pci-express device
 : pci-express? ( addr -- 0|1 ) 10 pci-cap-find 0<> ;
 
-\ check wether this device is a pci-express device
+\ check whether this device is a pci-express device
 : pci-x? ( addr -- 0|1 ) 07 pci-cap-find 0<> ;
 
-\ check wether this device has extended config space
+\ check whether this device has extended config space
 : pci-config-ext? ( addr -- 0|1 ) pci-express? ;
 
 
diff --git a/slof/fs/pci-properties.fs b/slof/fs/pci-properties.fs
index 6f8f013..92da6dc 100644
--- a/slof/fs/pci-properties.fs
+++ b/slof/fs/pci-properties.fs
@@ -668,7 +668,7 @@ 
 : pci-bridge-generic-setup ( addr -- )
         pci-device-slots >r             \ save the slot array on return stack
         dup pci-common-props            \ set the common properties before scanning the bus
-        s" pci" device-type             \ the type is allways "pci"
+        s" pci" device-type             \ the type is always "pci"
         dup func-pci-bridge-probe       \ find all device connected to it
         dup assign-all-bridge-bars      \ set up all memory access BARs
         dup pci-set-irq-line            \ set the interrupt pin
@@ -679,7 +679,7 @@ 
 
 DEFER func-pci-device-props
 
-\ used for an gerneric device set up
+\ used for an generic device set up
 \ if a device has no special handling for setup
 \ the device file (pci-device_VENDOR_DEVICE.fs) can call
 \ this word to setup the device
diff --git a/slof/fs/pci-scan.fs b/slof/fs/pci-scan.fs
index a97afa3..aca83c8 100644
--- a/slof/fs/pci-scan.fs
+++ b/slof/fs/pci-scan.fs
@@ -265,7 +265,7 @@  DEFER func-pci-bridge-probe
 ;
 
 \ check for multifunction and for each function
-\ (dependig from header type) call device or bridge setup
+\ (depending from header type) call device or bridge setup
 : pci-setup-device ( addr -- )
         dup pci-htype@                      \ read HEADER-Type
         80 and IF 8 ELSE 1 THEN             \ check for multifunction
diff --git a/slof/fs/root.fs b/slof/fs/root.fs
index 3818790..1d9afca 100644
--- a/slof/fs/root.fs
+++ b/slof/fs/root.fs
@@ -44,7 +44,7 @@  VARIABLE chosen-cpu-ihandle
 
 : chosen-cpu-unit ( -- ret ) chosen-cpu-ihandle @ ihandle>phandle >unit ;
 
-\ Look for an exising root, create one if needed
+\ Look for an existing root, create one if needed
 " /" find-node dup 0= IF
     drop
     new-device
diff --git a/slof/fs/scsi-host-helpers.fs b/slof/fs/scsi-host-helpers.fs
index 579ce37..da7f288 100644
--- a/slof/fs/scsi-host-helpers.fs
+++ b/slof/fs/scsi-host-helpers.fs
@@ -43,7 +43,7 @@ 
     >r \ stash #retries
     to rcmd-cmd-len to rcmd-cmd-addr to rcmd-dir to rcmd-buf-len to rcmd-buf-addr
     0  \ dummy status & sense
-    r> \ retreive #retries              ( stat #retries )
+    r> \ retrieve #retries              ( stat #retries )
     0 DO
         \ drop previous status & sense
         0<> IF 2drop THEN
diff --git a/slof/fs/term-io.fs b/slof/fs/term-io.fs
index 5b94b26..3483ba6 100644
--- a/slof/fs/term-io.fs
+++ b/slof/fs/term-io.fs
@@ -107,7 +107,7 @@  VARIABLE stdout
          false
       ELSE
          1 - \ remove 1 from length to ignore null-termination char
-         \ device_type found, check wether it is serial or keyboard
+         \ device_type found, check whether it is serial or keyboard
          2dup s" serial" str= IF
 	    2drop serial-key? r> drop EXIT
 	 THEN \ call serial-key, cleanup return-stack, exit
diff --git a/slof/prim.code b/slof/prim.code
index b9db151..eb899c7 100644
--- a/slof/prim.code
+++ b/slof/prim.code
@@ -561,7 +561,7 @@  PRIM(STRING_X3d_CI)
 	}
 MIRP
 
-// bool dependend pick
+// bool dependent pick
 // ?PICK ( v1 v2 bool -- v1|v2 )
 PRIM(_X3f_PICK)
         type_u b = TOS.u; POP;