diff mbox series

[v2,2/2] xilinx: zynqmp: Add missing prototype for board_boot_order

Message ID 20230224045318.3230-3-ashok.reddy.soma@amd.com
State Superseded
Delegated to: Michal Simek
Headers show
Series Fix sparse warnings | expand

Commit Message

Ashok Reddy Soma Feb. 24, 2023, 4:53 a.m. UTC
From: Algapally Santosh Sagar <santoshsagar.algapally@amd.com>

Add missing prototype to fix the sparse warning, warning: no
previous prototype for 'board_boot_order' [-Wmissing-prototypes].

Signed-off-by: Algapally Santosh Sagar <santoshsagar.algapally@amd.com>
Signed-off-by: Ashok Reddy Soma <ashok.reddy.soma@amd.com>
---

Changes in v2:
 - Moved function prototype from sys_proto.h to include/spl.h

 include/spl.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Michal Simek Feb. 24, 2023, 7:43 a.m. UTC | #1
Hi,


On 2/24/23 05:53, Ashok Reddy Soma wrote:
> From: Algapally Santosh Sagar <santoshsagar.algapally@amd.com>
> 
> Add missing prototype to fix the sparse warning, warning: no
> previous prototype for 'board_boot_order' [-Wmissing-prototypes].
> 
> Signed-off-by: Algapally Santosh Sagar <santoshsagar.algapally@amd.com>
> Signed-off-by: Ashok Reddy Soma <ashok.reddy.soma@amd.com>
> ---
> 
> Changes in v2:
>   - Moved function prototype from sys_proto.h to include/spl.h
> 
>   include/spl.h | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/include/spl.h b/include/spl.h
> index 827bd25c88..bad12fb01f 100644
> --- a/include/spl.h
> +++ b/include/spl.h
> @@ -884,5 +884,6 @@ void spl_perform_fixups(struct spl_image_info *spl_image);
>    */
>   struct legacy_img_hdr *spl_get_load_buffer(ssize_t offset, size_t size);
>   
> +void board_boot_order(u32 *spl_boot_list);
>   void spl_save_restore_data(void);
>   #endif

The patch is fine but subject not.

Should be something like

spl: Add missing prototype for board_boot_order

M
diff mbox series

Patch

diff --git a/include/spl.h b/include/spl.h
index 827bd25c88..bad12fb01f 100644
--- a/include/spl.h
+++ b/include/spl.h
@@ -884,5 +884,6 @@  void spl_perform_fixups(struct spl_image_info *spl_image);
  */
 struct legacy_img_hdr *spl_get_load_buffer(ssize_t offset, size_t size);
 
+void board_boot_order(u32 *spl_boot_list);
 void spl_save_restore_data(void);
 #endif