mbox series

[SRU,Kinetic,v2,0/1] Fix lp:2000709 cmsg_ipv6.sh

Message ID 20230206181002.476551-1-andrei.gherzan@canonical.com
Headers show
Series Fix lp:2000709 cmsg_ipv6.sh | expand

Message

Andrei Gherzan Feb. 6, 2023, 6:10 p.m. UTC
BugLink: https://bugs.launchpad.net/bugs/2000709

[Impact]

The IPV6_TCLASS test was introduced in
9657ad09e1fa04911034d8aac28d4377dc991eb5 which made it to 5.18. The test
may conflict with apparmor configuration.

[Fix]

The fix was merged upstream and cherry-picked here. It consists of using
a known file extension for tcpdump temporary file that should be in sync
with the main distro apparmor configurations.

Note that the test is also dependent on another fix brought in by
https://bugs.launchpad.net/ubuntu/+source/linux-kvm/+bug/1998244.
Namely, it requires dummy net support.

[Potential regression]

None expected.

[Tests]

Tested in a clean Kinetic VM.

v2:
* Fixed BugLink URL both in cover letter and in the patch

Andrei Gherzan (1):
  selftest: net: Improve IPV6_TCLASS/IPV6_HOPLIMIT tests apparmor
    compatibility

 tools/testing/selftests/net/cmsg_ipv6.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tim Gardner Feb. 8, 2023, 3:43 p.m. UTC | #1
On 2/6/23 11:10 AM, Andrei Gherzan wrote:
> BugLink: https://bugs.launchpad.net/bugs/2000709
> 
> [Impact]
> 
> The IPV6_TCLASS test was introduced in
> 9657ad09e1fa04911034d8aac28d4377dc991eb5 which made it to 5.18. The test
> may conflict with apparmor configuration.
> 
> [Fix]
> 
> The fix was merged upstream and cherry-picked here. It consists of using
> a known file extension for tcpdump temporary file that should be in sync
> with the main distro apparmor configurations.
> 
> Note that the test is also dependent on another fix brought in by
> https://bugs.launchpad.net/ubuntu/+source/linux-kvm/+bug/1998244.
> Namely, it requires dummy net support.
> 
> [Potential regression]
> 
> None expected.
> 
> [Tests]
> 
> Tested in a clean Kinetic VM.
> 
> v2:
> * Fixed BugLink URL both in cover letter and in the patch
> 
> Andrei Gherzan (1):
>    selftest: net: Improve IPV6_TCLASS/IPV6_HOPLIMIT tests apparmor
>      compatibility
> 
>   tools/testing/selftests/net/cmsg_ipv6.sh | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
Acked-by: Tim Gardner <tim.gardner@canonical.com>

Commit a6efc42a86c0c87cfe2f1c3d1f09a4c9b13ba890 is also now upstream
Luke Nowakowski-Krijger Feb. 23, 2023, 8:29 p.m. UTC | #2
Acked-by: Luke Nowakowski-Krijger <luke.nowakowskikrijger@canonical.com>

On Mon, Feb 6, 2023 at 10:11 AM Andrei Gherzan <andrei.gherzan@canonical.com>
wrote:

> BugLink: https://bugs.launchpad.net/bugs/2000709
>
> [Impact]
>
> The IPV6_TCLASS test was introduced in
> 9657ad09e1fa04911034d8aac28d4377dc991eb5 which made it to 5.18. The test
> may conflict with apparmor configuration.
>
> [Fix]
>
> The fix was merged upstream and cherry-picked here. It consists of using
> a known file extension for tcpdump temporary file that should be in sync
> with the main distro apparmor configurations.
>
> Note that the test is also dependent on another fix brought in by
> https://bugs.launchpad.net/ubuntu/+source/linux-kvm/+bug/1998244.
> Namely, it requires dummy net support.
>
> [Potential regression]
>
> None expected.
>
> [Tests]
>
> Tested in a clean Kinetic VM.
>
> v2:
> * Fixed BugLink URL both in cover letter and in the patch
>
> Andrei Gherzan (1):
>   selftest: net: Improve IPV6_TCLASS/IPV6_HOPLIMIT tests apparmor
>     compatibility
>
>  tools/testing/selftests/net/cmsg_ipv6.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --
> 2.34.1
>
>
> --
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>
Luke Nowakowski-Krijger Feb. 23, 2023, 8:33 p.m. UTC | #3
Applied to kinetic:linux master-next

Removed the net-dev in the cherry-pick line as it is now upstream.

Thanks!~
- Luke

On Mon, Feb 6, 2023 at 10:11 AM Andrei Gherzan <andrei.gherzan@canonical.com>
wrote:

> BugLink: https://bugs.launchpad.net/bugs/2000709
>
> [Impact]
>
> The IPV6_TCLASS test was introduced in
> 9657ad09e1fa04911034d8aac28d4377dc991eb5 which made it to 5.18. The test
> may conflict with apparmor configuration.
>
> [Fix]
>
> The fix was merged upstream and cherry-picked here. It consists of using
> a known file extension for tcpdump temporary file that should be in sync
> with the main distro apparmor configurations.
>
> Note that the test is also dependent on another fix brought in by
> https://bugs.launchpad.net/ubuntu/+source/linux-kvm/+bug/1998244.
> Namely, it requires dummy net support.
>
> [Potential regression]
>
> None expected.
>
> [Tests]
>
> Tested in a clean Kinetic VM.
>
> v2:
> * Fixed BugLink URL both in cover letter and in the patch
>
> Andrei Gherzan (1):
>   selftest: net: Improve IPV6_TCLASS/IPV6_HOPLIMIT tests apparmor
>     compatibility
>
>  tools/testing/selftests/net/cmsg_ipv6.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --
> 2.34.1
>
>
> --
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>