| Message ID | 20230223125154.9033-3-l.ellero@asem.it |
|---|---|
| State | Superseded |
| Delegated to: | Stefano Babic |
| Headers | show |
| Series | imx93: add ADC support | expand |
Hi Luca, On Thu, Feb 23, 2023 at 9:52 AM Luca Ellero <l.ellero@asem.it> wrote: Please write a commit log. > Signed-off-by: Luca Ellero <l.ellero@asem.it> > --- > arch/arm/dts/imx93-11x11-evk.dts | 4 ++++ > configs/imx93_11x11_evk_defconfig | 1 + > 2 files changed, 5 insertions(+) > > diff --git a/arch/arm/dts/imx93-11x11-evk.dts b/arch/arm/dts/imx93-11x11-evk.dts > index b3a5a3d71e..f7ffe7b3d2 100644 > --- a/arch/arm/dts/imx93-11x11-evk.dts > +++ b/arch/arm/dts/imx93-11x11-evk.dts > @@ -525,3 +525,7 @@ > &wdog3 { > status = "okay"; > }; > + > +&adc1 { > + status = "okay"; > +}; The nodes should be kept in alphabetical order. Actually, it would be better if you could sync imx93-11x11-evk.dts with linux-next, which already contains the adc1 node: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts?h=next-20230223#n37 We want to keep U-Boot and Linux devicetree in sync as much as possible. Thanks
On 23/02/2023 15:05, Fabio Estevam wrote: > Hi Luca, > > On Thu, Feb 23, 2023 at 9:52 AM Luca Ellero <l.ellero@asem.it> wrote: > > Please write a commit log. > >> Signed-off-by: Luca Ellero <l.ellero@asem.it> >> --- >> arch/arm/dts/imx93-11x11-evk.dts | 4 ++++ >> configs/imx93_11x11_evk_defconfig | 1 + >> 2 files changed, 5 insertions(+) >> >> diff --git a/arch/arm/dts/imx93-11x11-evk.dts b/arch/arm/dts/imx93-11x11-evk.dts >> index b3a5a3d71e..f7ffe7b3d2 100644 >> --- a/arch/arm/dts/imx93-11x11-evk.dts >> +++ b/arch/arm/dts/imx93-11x11-evk.dts >> @@ -525,3 +525,7 @@ >> &wdog3 { >> status = "okay"; >> }; >> + >> +&adc1 { >> + status = "okay"; >> +}; > > The nodes should be kept in alphabetical order. > > Actually, it would be better if you could sync imx93-11x11-evk.dts > with linux-next, which already contains the adc1 node: > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts?h=next-20230223#n37 > > We want to keep U-Boot and Linux devicetree in sync as much as possible. > > Thanks Hi Fabio, thank you for your reply. Ok, I will add a comment to the patch and fix DT node. Should I resend only this patch or both? Regards
Hi Luca, On Fri, Feb 24, 2023 at 4:59 AM Luca Ellero <luca.ellero@brickedbrain.com> wrote: > Hi Fabio, > thank you for your reply. > Ok, I will add a comment to the patch and fix DT node. > Should I resend only this patch or both? Please resend the whole series. My suggestion: 1/3 - ADC driver 2/3 - Sync U-Boot imx93 evk dts with the one from linux-next 20230224 3/3 - Enable the ADC driver in the imx93 evk defconfig
On 24/02/2023 15:31, Fabio Estevam wrote: > Hi Luca, > > On Fri, Feb 24, 2023 at 4:59 AM Luca Ellero > <luca.ellero@brickedbrain.com> wrote: > >> Hi Fabio, >> thank you for your reply. >> Ok, I will add a comment to the patch and fix DT node. >> Should I resend only this patch or both? > > Please resend the whole series. > > My suggestion: > > 1/3 - ADC driver > 2/3 - Sync U-Boot imx93 evk dts with the one from linux-next 20230224 > 3/3 - Enable the ADC driver in the imx93 evk defconfig Hi Fabio, ok, thanks for your suggestions. Regards
diff --git a/arch/arm/dts/imx93-11x11-evk.dts b/arch/arm/dts/imx93-11x11-evk.dts index b3a5a3d71e..f7ffe7b3d2 100644 --- a/arch/arm/dts/imx93-11x11-evk.dts +++ b/arch/arm/dts/imx93-11x11-evk.dts @@ -525,3 +525,7 @@ &wdog3 { status = "okay"; }; + +&adc1 { + status = "okay"; +}; diff --git a/configs/imx93_11x11_evk_defconfig b/configs/imx93_11x11_evk_defconfig index 477fb25807..fa929dd4ec 100644 --- a/configs/imx93_11x11_evk_defconfig +++ b/configs/imx93_11x11_evk_defconfig @@ -82,6 +82,7 @@ CONFIG_NET_RANDOM_ETHADDR=y CONFIG_SPL_DM=y CONFIG_REGMAP=y CONFIG_SYSCON=y +CONFIG_ADC_IMX93=y CONFIG_IMX_RGPIO2P=y CONFIG_DM_PCA953X=y CONFIG_DM_I2C=y
Signed-off-by: Luca Ellero <l.ellero@asem.it> --- arch/arm/dts/imx93-11x11-evk.dts | 4 ++++ configs/imx93_11x11_evk_defconfig | 1 + 2 files changed, 5 insertions(+)