| Message ID | 20230221120612.27366-2-r-gunasekaran@ti.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | arm64: j721s2: Add support for additional IPs | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 17:36-20230221, Ravi Gunasekaran wrote: > mux-controller nodes may not have "reg" property. Update the regex > for such nodes to resolve the dtbs warnings > > Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com> > --- > .../bindings/mfd/ti,j721e-system-controller.yaml | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) Are you expecting for me to pick this up? Looks like something Lee Jones needs to pick up? He is'nt in the CC either? If Lee Jones is willing to give me an immutable tag, I can pick the same up and pick up dependent patches. Else, please split the series for each of the maintainers to pick up without dependency. > > diff --git a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml > index 76ef4352e13c..532bfa45e6a0 100644 > --- a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml > +++ b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml > @@ -45,7 +45,7 @@ properties: > > patternProperties: > # Optional children > - "^mux-controller@[0-9a-f]+$": > + "^mux-controller(@|-)[0-9a-f]+$": > type: object > description: > This is the SERDES lane control mux. > @@ -94,6 +94,12 @@ examples: > /* SERDES4 lane0/1/2/3 select */ > }; > > + usb_serdes_mux: mux-controller-80 { > + compatible = "mmio-mux"; > + #mux-control-cells = <1>; > + mux-reg-masks = <0x0 0x8000000>; > + }; > + > clock-controller@4140 { > compatible = "ti,am654-ehrpwm-tbclk", "syscon"; > reg = <0x4140 0x18>; > -- > 2.17.1 >
On 21/02/23 5:36 pm, Ravi Gunasekaran wrote: > mux-controller nodes may not have "reg" property. Update the regex > for such nodes to resolve the dtbs warnings > > Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com> > --- > .../bindings/mfd/ti,j721e-system-controller.yaml | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml > index 76ef4352e13c..532bfa45e6a0 100644 > --- a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml > +++ b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml > @@ -45,7 +45,7 @@ properties: > > patternProperties: > # Optional children > - "^mux-controller@[0-9a-f]+$": > + "^mux-controller(@|-)[0-9a-f]+$": Hmm. mmio-mux bindings allow reg property. Why can't we add the same to mux-controller node in 2/9 ? > type: object > description: > This is the SERDES lane control mux. > @@ -94,6 +94,12 @@ examples: > /* SERDES4 lane0/1/2/3 select */ > }; > > + usb_serdes_mux: mux-controller-80 { > + compatible = "mmio-mux"; > + #mux-control-cells = <1>; > + mux-reg-masks = <0x0 0x8000000>; > + }; > + > clock-controller@4140 { > compatible = "ti,am654-ehrpwm-tbclk", "syscon"; > reg = <0x4140 0x18>;
On Tue, Feb 21, 2023 at 8:00 AM Vignesh Raghavendra <vigneshr@ti.com> wrote: > On 21/02/23 5:36 pm, Ravi Gunasekaran wrote: > > mux-controller nodes may not have "reg" property. Update the regex > > for such nodes to resolve the dtbs warnings > > > > Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com> > > --- Where's the change history? I doubt I ignored the last 9 versions... > > .../bindings/mfd/ti,j721e-system-controller.yaml | 8 +++++++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml > > index 76ef4352e13c..532bfa45e6a0 100644 > > --- a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml > > +++ b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml > > @@ -45,7 +45,7 @@ properties: > > > > patternProperties: > > # Optional children > > - "^mux-controller@[0-9a-f]+$": > > + "^mux-controller(@|-)[0-9a-f]+$": > > Hmm. mmio-mux bindings allow reg property. Why can't we add the same to > mux-controller node in 2/9 ? Yes, do that. Rob
On 21/02/23 7:11 pm, Nishanth Menon wrote: > On 17:36-20230221, Ravi Gunasekaran wrote: >> mux-controller nodes may not have "reg" property. Update the regex >> for such nodes to resolve the dtbs warnings >> >> Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com> >> --- >> .../bindings/mfd/ti,j721e-system-controller.yaml | 8 +++++++- >> 1 file changed, 7 insertions(+), 1 deletion(-) > > > Are you expecting for me to pick this up? Looks like something > Lee Jones needs to pick up? He is'nt in the CC either? > > If Lee Jones is willing to give me an immutable tag, I can pick the same > up and pick up dependent patches. Else, please split the series for each > of the maintainers to pick up without dependency. > I apologize for the inconvenience. Based on the other review comments in this series, I can update the mux node instead of updating the bindings document. Regardless of it, in future I will take care of sending the patch to the right maintainer. >> >> diff --git a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml >> index 76ef4352e13c..532bfa45e6a0 100644 >> --- a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml >> +++ b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml >> @@ -45,7 +45,7 @@ properties: >> >> patternProperties: >> # Optional children >> - "^mux-controller@[0-9a-f]+$": >> + "^mux-controller(@|-)[0-9a-f]+$": >> type: object >> description: >> This is the SERDES lane control mux. >> @@ -94,6 +94,12 @@ examples: >> /* SERDES4 lane0/1/2/3 select */ >> }; >> >> + usb_serdes_mux: mux-controller-80 { >> + compatible = "mmio-mux"; >> + #mux-control-cells = <1>; >> + mux-reg-masks = <0x0 0x8000000>; >> + }; >> + >> clock-controller@4140 { >> compatible = "ti,am654-ehrpwm-tbclk", "syscon"; >> reg = <0x4140 0x18>; >> -- >> 2.17.1 >>
On 21/02/23 7:29 pm, Vignesh Raghavendra wrote: > > > On 21/02/23 5:36 pm, Ravi Gunasekaran wrote: >> mux-controller nodes may not have "reg" property. Update the regex >> for such nodes to resolve the dtbs warnings >> >> Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com> >> --- >> .../bindings/mfd/ti,j721e-system-controller.yaml | 8 +++++++- >> 1 file changed, 7 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml >> index 76ef4352e13c..532bfa45e6a0 100644 >> --- a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml >> +++ b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml >> @@ -45,7 +45,7 @@ properties: >> >> patternProperties: >> # Optional children >> - "^mux-controller@[0-9a-f]+$": >> + "^mux-controller(@|-)[0-9a-f]+$": > > Hmm. mmio-mux bindings allow reg property. Why can't we add the same to > mux-controller node in 2/9 ? "reg" property can be added to the mux-controller node. I will do so in the next series > >> type: object >> description: >> This is the SERDES lane control mux. >> @@ -94,6 +94,12 @@ examples: >> /* SERDES4 lane0/1/2/3 select */ >> }; >> >> + usb_serdes_mux: mux-controller-80 { >> + compatible = "mmio-mux"; >> + #mux-control-cells = <1>; >> + mux-reg-masks = <0x0 0x8000000>; >> + }; >> + >> clock-controller@4140 { >> compatible = "ti,am654-ehrpwm-tbclk", "syscon"; >> reg = <0x4140 0x18>;
On 21/02/23 10:34 pm, Rob Herring wrote: > On Tue, Feb 21, 2023 at 8:00 AM Vignesh Raghavendra <vigneshr@ti.com> wrote: >> On 21/02/23 5:36 pm, Ravi Gunasekaran wrote: >>> mux-controller nodes may not have "reg" property. Update the regex >>> for such nodes to resolve the dtbs warnings >>> >>> Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com> >>> --- > > Where's the change history? I doubt I ignored the last 9 versions... This change was added newly in v8. But based on the review comments, dtbs warnings can be fixed without changes to bindings document. So this patch will be dropped in the next series. Ravi > >>> .../bindings/mfd/ti,j721e-system-controller.yaml | 8 +++++++- >>> 1 file changed, 7 insertions(+), 1 deletion(-) >>> >>> diff --git a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml >>> index 76ef4352e13c..532bfa45e6a0 100644 >>> --- a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml >>> +++ b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml >>> @@ -45,7 +45,7 @@ properties: >>> >>> patternProperties: >>> # Optional children >>> - "^mux-controller@[0-9a-f]+$": >>> + "^mux-controller(@|-)[0-9a-f]+$": >> >> Hmm. mmio-mux bindings allow reg property. Why can't we add the same to >> mux-controller node in 2/9 ? > > Yes, do that. > > Rob
diff --git a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml index 76ef4352e13c..532bfa45e6a0 100644 --- a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml +++ b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml @@ -45,7 +45,7 @@ properties: patternProperties: # Optional children - "^mux-controller@[0-9a-f]+$": + "^mux-controller(@|-)[0-9a-f]+$": type: object description: This is the SERDES lane control mux. @@ -94,6 +94,12 @@ examples: /* SERDES4 lane0/1/2/3 select */ }; + usb_serdes_mux: mux-controller-80 { + compatible = "mmio-mux"; + #mux-control-cells = <1>; + mux-reg-masks = <0x0 0x8000000>; + }; + clock-controller@4140 { compatible = "ti,am654-ehrpwm-tbclk", "syscon"; reg = <0x4140 0x18>;
mux-controller nodes may not have "reg" property. Update the regex for such nodes to resolve the dtbs warnings Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com> --- .../bindings/mfd/ti,j721e-system-controller.yaml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)