| Message ID | 20230214171505.224602-1-ahalaney@redhat.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [v2,1/2] dt-bindings: net: snps,dwmac: Fix snps,reset-delays-us dependency | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 8 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
Hello: This series was applied to netdev/net-next.git (master) by Jakub Kicinski <kuba@kernel.org>: On Tue, 14 Feb 2023 11:15:04 -0600 you wrote: > The schema had snps,reset-delay-us as dependent on snps,reset-gpio. The > actual property is called snps,reset-delays-us, so fix this to catch any > devicetree defining snsps,reset-delays-us without snps,reset-gpio. > > Fixes: 7db3545aef5f ("dt-bindings: net: stmmac: Convert the binding to a schemas") > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: Andrew Halaney <ahalaney@redhat.com> > > [...] Here is the summary with links: - [v2,1/2] dt-bindings: net: snps,dwmac: Fix snps,reset-delays-us dependency https://git.kernel.org/netdev/net-next/c/affb6a3fd8f4 - [v2,2/2] arm64: dts: imx8dxl-evk: Fix eqos phy reset gpio (no matching commit) You are awesome, thank you!
On 14/02/2023 18:15, Andrew Halaney wrote: > The deprecated property is named snps,reset-gpio, but this devicetree > used snps,reset-gpios instead which results in the reset not being used > and the following make dtbs_check error: > > ./arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb: ethernet@5b050000: 'snps,reset-gpio' is a dependency of 'snps,reset-delays-us' > From schema: ./Documentation/devicetree/bindings/net/snps,dwmac.yaml > > Use the preferred method of defining the reset gpio in the phy node > itself. Note that this drops the 10 us pre-delay, but prior this wasn't > used at all and a pre-delay doesn't make much sense in this context so > it should be fine. > > Fixes: 8dd495d12374 ("arm64: dts: freescale: add support for i.MX8DXL EVK board") > Signed-off-by: Andrew Halaney <ahalaney@redhat.com> > --- Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Tue, Feb 14, 2023 at 11:15:05AM -0600, Andrew Halaney wrote: > The deprecated property is named snps,reset-gpio, but this devicetree > used snps,reset-gpios instead which results in the reset not being used > and the following make dtbs_check error: > > ./arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb: ethernet@5b050000: 'snps,reset-gpio' is a dependency of 'snps,reset-delays-us' > From schema: ./Documentation/devicetree/bindings/net/snps,dwmac.yaml > > Use the preferred method of defining the reset gpio in the phy node > itself. Note that this drops the 10 us pre-delay, but prior this wasn't > used at all and a pre-delay doesn't make much sense in this context so > it should be fine. > > Fixes: 8dd495d12374 ("arm64: dts: freescale: add support for i.MX8DXL EVK board") > Signed-off-by: Andrew Halaney <ahalaney@redhat.com> Applied, thanks!
diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml index e88a86623fce..16b7d2904696 100644 --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml @@ -552,7 +552,7 @@ required: dependencies: snps,reset-active-low: ["snps,reset-gpio"] - snps,reset-delay-us: ["snps,reset-gpio"] + snps,reset-delays-us: ["snps,reset-gpio"] allOf: - $ref: "ethernet-controller.yaml#"
The schema had snps,reset-delay-us as dependent on snps,reset-gpio. The actual property is called snps,reset-delays-us, so fix this to catch any devicetree defining snsps,reset-delays-us without snps,reset-gpio. Fixes: 7db3545aef5f ("dt-bindings: net: stmmac: Convert the binding to a schemas") Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Signed-off-by: Andrew Halaney <ahalaney@redhat.com> --- Changes since v1: * collected Krzysztof's review Documentation/devicetree/bindings/net/snps,dwmac.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)