mbox series

[v3,0/5] Bluetooth: hci_mrvl: Add serdev support for 88W8997

Message ID 20230213120926.8166-1-francesco@dolcini.it
Headers show
Series Bluetooth: hci_mrvl: Add serdev support for 88W8997 | expand

Message

Francesco Dolcini Feb. 13, 2023, 12:09 p.m. UTC
From: Francesco Dolcini <francesco.dolcini@toradex.com>

Add serdev support for the 88W8997 from NXP (previously Marvell). It includes
support for changing the baud rate. The command to change the baud rate is
taken from the user manual UM11483 Rev. 9 in section 7 (Bring-up of Bluetooth
interfaces) from NXP.

v3:
 - Use __hci_cmd_sync_status instead of __hci_cmd_sync 

v2:
 - Fix the subject as pointed out by Krzysztof. Thanks!
 - Fix indentation in marvell-bluetooth.yaml
 - Fix compiler warning for kernel builds without CONFIG_OF enabled

Stefan Eichenberger (5):
  dt-bindings: bluetooth: marvell: add 88W8997
  dt-bindings: bluetooth: marvell: add max-speed property
  Bluetooth: hci_mrvl: use maybe_unused macro for device tree ids
  Bluetooth: hci_mrvl: Add serdev support for 88W8997
  arm64: dts: imx8mp-verdin: add 88W8997 serdev to uart4

 .../bindings/net/marvell-bluetooth.yaml       | 20 ++++-
 .../dts/freescale/imx8mp-verdin-wifi.dtsi     |  5 ++
 drivers/bluetooth/hci_mrvl.c                  | 90 ++++++++++++++++---
 3 files changed, 104 insertions(+), 11 deletions(-)

Comments

Luiz Augusto von Dentz Feb. 15, 2023, 8:36 p.m. UTC | #1
Hi Francesco,

On Mon, Feb 13, 2023 at 4:09 AM Francesco Dolcini <francesco@dolcini.it> wrote:
>
> From: Francesco Dolcini <francesco.dolcini@toradex.com>
>
> Add serdev support for the 88W8997 from NXP (previously Marvell). It includes
> support for changing the baud rate. The command to change the baud rate is
> taken from the user manual UM11483 Rev. 9 in section 7 (Bring-up of Bluetooth
> interfaces) from NXP.
>
> v3:
>  - Use __hci_cmd_sync_status instead of __hci_cmd_sync
>
> v2:
>  - Fix the subject as pointed out by Krzysztof. Thanks!
>  - Fix indentation in marvell-bluetooth.yaml
>  - Fix compiler warning for kernel builds without CONFIG_OF enabled
>
> Stefan Eichenberger (5):
>   dt-bindings: bluetooth: marvell: add 88W8997
>   dt-bindings: bluetooth: marvell: add max-speed property
>   Bluetooth: hci_mrvl: use maybe_unused macro for device tree ids
>   Bluetooth: hci_mrvl: Add serdev support for 88W8997
>   arm64: dts: imx8mp-verdin: add 88W8997 serdev to uart4
>
>  .../bindings/net/marvell-bluetooth.yaml       | 20 ++++-
>  .../dts/freescale/imx8mp-verdin-wifi.dtsi     |  5 ++
>  drivers/bluetooth/hci_mrvl.c                  | 90 ++++++++++++++++---
>  3 files changed, 104 insertions(+), 11 deletions(-)
>
> --
> 2.25.1

There seems to be missing one patch 5/5:

https://patchwork.kernel.org/project/bluetooth/list/?series=721269

Other than that the Bluetooth parts seem fine, and perhaps can be
merged if the patch above is not really required.
Francesco Dolcini Feb. 15, 2023, 8:41 p.m. UTC | #2
Hello Luiz

On Wed, Feb 15, 2023 at 12:36:34PM -0800, Luiz Augusto von Dentz wrote:
> On Mon, Feb 13, 2023 at 4:09 AM Francesco Dolcini <francesco@dolcini.it> wrote:
> >
> > From: Francesco Dolcini <francesco.dolcini@toradex.com>
> >
> > Add serdev support for the 88W8997 from NXP (previously Marvell). It includes
> > support for changing the baud rate. The command to change the baud rate is
> > taken from the user manual UM11483 Rev. 9 in section 7 (Bring-up of Bluetooth
> > interfaces) from NXP.
> >
> > v3:
> >  - Use __hci_cmd_sync_status instead of __hci_cmd_sync
> >
> > v2:
> >  - Fix the subject as pointed out by Krzysztof. Thanks!
> >  - Fix indentation in marvell-bluetooth.yaml
> >  - Fix compiler warning for kernel builds without CONFIG_OF enabled
> >
> > Stefan Eichenberger (5):
> >   dt-bindings: bluetooth: marvell: add 88W8997
> >   dt-bindings: bluetooth: marvell: add max-speed property
> >   Bluetooth: hci_mrvl: use maybe_unused macro for device tree ids
> >   Bluetooth: hci_mrvl: Add serdev support for 88W8997
> >   arm64: dts: imx8mp-verdin: add 88W8997 serdev to uart4
> >
> >  .../bindings/net/marvell-bluetooth.yaml       | 20 ++++-
> >  .../dts/freescale/imx8mp-verdin-wifi.dtsi     |  5 ++
> >  drivers/bluetooth/hci_mrvl.c                  | 90 ++++++++++++++++---
> >  3 files changed, 104 insertions(+), 11 deletions(-)
> >
> > --
> > 2.25.1
> 
> There seems to be missing one patch 5/5:
> 
> https://patchwork.kernel.org/project/bluetooth/list/?series=721269
> 
> Other than that the Bluetooth parts seem fine, and perhaps can be
> merged if the patch above is not really required.

In v3 I decided to not send it to the BT mailing list, since this is
supposed to go through Shawn and the iMX/SOC tree.

Given that it would be great if you could apply patches 1-4.

Thanks,
Francesco
patchwork-bot+bluetooth@kernel.org Feb. 15, 2023, 9:20 p.m. UTC | #3
Hello:

This series was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Mon, 13 Feb 2023 13:09:21 +0100 you wrote:
> From: Francesco Dolcini <francesco.dolcini@toradex.com>
> 
> Add serdev support for the 88W8997 from NXP (previously Marvell). It includes
> support for changing the baud rate. The command to change the baud rate is
> taken from the user manual UM11483 Rev. 9 in section 7 (Bring-up of Bluetooth
> interfaces) from NXP.
> 
> [...]

Here is the summary with links:
  - [v3,1/5] dt-bindings: bluetooth: marvell: add 88W8997
    https://git.kernel.org/bluetooth/bluetooth-next/c/f48823aa0c4f
  - [v3,2/5] dt-bindings: bluetooth: marvell: add max-speed property
    https://git.kernel.org/bluetooth/bluetooth-next/c/d7303dce9fcb
  - [v3,3/5] Bluetooth: hci_mrvl: use maybe_unused macro for device tree ids
    https://git.kernel.org/bluetooth/bluetooth-next/c/e275614465ec
  - [v3,4/5] Bluetooth: hci_mrvl: Add serdev support for 88W8997
    https://git.kernel.org/bluetooth/bluetooth-next/c/58c6156a4d4b

You are awesome, thank you!
Francesco Dolcini Feb. 16, 2023, 8:49 a.m. UTC | #4
Hello Shawn,

On Mon, Feb 13, 2023 at 01:09:26PM +0100, Francesco Dolcini wrote:
> From: Stefan Eichenberger <stefan.eichenberger@toradex.com>
> 
> Use the serdev feature to load the driver for the 88W8997 bluetooth
> driver.
> 
> Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>

Patches 1-4 are now in linux-next, just pick this when it is
appropriate for you (I know you already sent a pull request to Arnd a
couple of weeks ago).

Thanks,
Francesco
Shawn Guo March 13, 2023, 2:05 p.m. UTC | #5
On Mon, Feb 13, 2023 at 01:09:26PM +0100, Francesco Dolcini wrote:
> From: Stefan Eichenberger <stefan.eichenberger@toradex.com>
> 
> Use the serdev feature to load the driver for the 88W8997 bluetooth
> driver.
> 
> Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>

Applied, thanks!