| Message ID | 20230202-asahi-t8112-dt-v1-16-cb5442d1c229@jannau.net |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | Device trees for Apple M2 (t8112) based devices | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 12/02/2023 16:41, Janne Grunau wrote: > This adds the following apple,t8112 platforms: > > - apple,j413 - MacBook Air (M2, 2022) > - apple,j473 - Mac mini (M2, 2023) > - apple,j493 - MacBook Pro (13-inch, M2, 2022) > > Signed-off-by: Janne Grunau <j@jannau.net> > --- > Documentation/devicetree/bindings/arm/apple.yaml | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/apple.yaml b/Documentation/devicetree/bindings/arm/apple.yaml > index da78c69774f2..883fd67e3752 100644 > --- a/Documentation/devicetree/bindings/arm/apple.yaml > +++ b/Documentation/devicetree/bindings/arm/apple.yaml > @@ -19,6 +19,12 @@ description: | > - MacBook Air (M1, 2020) > - iMac (24-inch, M1, 2021) > > + Devices based on the "M2" SoC: > + > + - MacBook Air (M2, 2022) > + - MacBook Pro (13-inch, M2, 2022) > + - Mac mini (M2, 2023) Aren't you now repeating exactly what is in the schema? Keep only one... > + > And devices based on the "M1 Pro", "M1 Max" and "M1 Ultra" SoCs: > > - MacBook Pro (14-inch, M1 Pro, 2021) > @@ -70,6 +76,15 @@ properties: > - const: apple,t8103 > - const: apple,arm-platform > > + - description: Apple M2 SoC based platforms > + items: > + - enum: > + - apple,j413 # MacBook Air (M2, 2022) > + - apple,j473 # Mac mini (M2, 2023) > + - apple,j493 # MacBook Pro (13-inch, M2, 2022) Best regards, Krzysztof
On 2023-02-13 12:15:55 +0100, Krzysztof Kozlowski wrote: > On 12/02/2023 16:41, Janne Grunau wrote: > > This adds the following apple,t8112 platforms: > > > > - apple,j413 - MacBook Air (M2, 2022) > > - apple,j473 - Mac mini (M2, 2023) > > - apple,j493 - MacBook Pro (13-inch, M2, 2022) > > > > Signed-off-by: Janne Grunau <j@jannau.net> > > --- > > Documentation/devicetree/bindings/arm/apple.yaml | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/apple.yaml b/Documentation/devicetree/bindings/arm/apple.yaml > > index da78c69774f2..883fd67e3752 100644 > > --- a/Documentation/devicetree/bindings/arm/apple.yaml > > +++ b/Documentation/devicetree/bindings/arm/apple.yaml > > @@ -19,6 +19,12 @@ description: | > > - MacBook Air (M1, 2020) > > - iMac (24-inch, M1, 2021) > > > > + Devices based on the "M2" SoC: > > + > > + - MacBook Air (M2, 2022) > > + - MacBook Pro (13-inch, M2, 2022) > > + - Mac mini (M2, 2023) > > Aren't you now repeating exactly what is in the schema? Keep only one... yes but I think the duplication is OK. I consider the description for human consumption and the schema for computer consumption. The comments in the schema are aids to for editing the schema. This follows the existing pattern for M1 and M1 Pro/Max/Ultra based devices in this file. Janne
On 12/02/2023 16:41, Janne Grunau wrote: > - MacBook Pro (14-inch, M1 Pro, 2021) > @@ -70,6 +76,15 @@ properties: > - const: apple,t8103 > - const: apple,arm-platform > > + - description: Apple M2 SoC based platforms > + items: > + - enum: > + - apple,j413 # MacBook Air (M2, 2022) > + - apple,j473 # Mac mini (M2, 2023) > + - apple,j493 # MacBook Pro (13-inch, M2, 2022) > + - const: apple,t8112 > + - const: apple,arm-platform Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/apple.yaml b/Documentation/devicetree/bindings/arm/apple.yaml index da78c69774f2..883fd67e3752 100644 --- a/Documentation/devicetree/bindings/arm/apple.yaml +++ b/Documentation/devicetree/bindings/arm/apple.yaml @@ -19,6 +19,12 @@ description: | - MacBook Air (M1, 2020) - iMac (24-inch, M1, 2021) + Devices based on the "M2" SoC: + + - MacBook Air (M2, 2022) + - MacBook Pro (13-inch, M2, 2022) + - Mac mini (M2, 2023) + And devices based on the "M1 Pro", "M1 Max" and "M1 Ultra" SoCs: - MacBook Pro (14-inch, M1 Pro, 2021) @@ -70,6 +76,15 @@ properties: - const: apple,t8103 - const: apple,arm-platform + - description: Apple M2 SoC based platforms + items: + - enum: + - apple,j413 # MacBook Air (M2, 2022) + - apple,j473 # Mac mini (M2, 2023) + - apple,j493 # MacBook Pro (13-inch, M2, 2022) + - const: apple,t8112 + - const: apple,arm-platform + - description: Apple M1 Pro SoC based platforms items: - enum:
This adds the following apple,t8112 platforms: - apple,j413 - MacBook Air (M2, 2022) - apple,j473 - Mac mini (M2, 2023) - apple,j493 - MacBook Pro (13-inch, M2, 2022) Signed-off-by: Janne Grunau <j@jannau.net> --- Documentation/devicetree/bindings/arm/apple.yaml | 15 +++++++++++++++ 1 file changed, 15 insertions(+)