Message ID | 20230209194825.511043-7-shikemeng@huaweicloud.com |
---|---|
State | Not Applicable |
Headers | show |
Series | Some bugfix and cleanup to mballoc | expand |
On Fri, Feb 10, 2023 at 03:48:10AM +0800, Kemeng Shi wrote: > As we don't correct pa_lstart here, so there is no need to subtract > pa_lstart with consumed len. > > Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com> > --- > fs/ext4/mballoc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c > index 2bffc93778d5..433337ac8da2 100644 > --- a/fs/ext4/mballoc.c > +++ b/fs/ext4/mballoc.c > @@ -4319,7 +4319,7 @@ static void ext4_mb_use_group_pa(struct ext4_allocation_context *ac, > * Other CPUs are prevented from allocating from this pa by lg_mutex > */ > mb_debug(ac->ac_sb, "use %u/%u from group pa %p\n", > - pa->pa_lstart-len, len, pa); > + pa->pa_lstart, len, pa); > } > > /* > -- > 2.30.0 > Looks good, feel free to add: Reviewed-by: Ojaswin Mujoo <ojaswin@linux.ibm.com>
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index 2bffc93778d5..433337ac8da2 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c @@ -4319,7 +4319,7 @@ static void ext4_mb_use_group_pa(struct ext4_allocation_context *ac, * Other CPUs are prevented from allocating from this pa by lg_mutex */ mb_debug(ac->ac_sb, "use %u/%u from group pa %p\n", - pa->pa_lstart-len, len, pa); + pa->pa_lstart, len, pa); } /*
As we don't correct pa_lstart here, so there is no need to subtract pa_lstart with consumed len. Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com> --- fs/ext4/mballoc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)