mbox series

[0/6,SRU,Unstable/Lunar/OEM-6.1] Mediatek FM350-GL wwan module failed to init

Message ID 20230116091504.1361157-1-vicamo.yang@canonical.com
Headers show
Series Mediatek FM350-GL wwan module failed to init | expand

Message

You-Sheng Yang Jan. 16, 2023, 9:14 a.m. UTC 
From: "You-Sheng Yang (vicamo)" <vicamo.yang@canonical.com>

BugLink: https://bugs.launchpad.net/bugs/2002089

[Impact]

Mediatek FM350-GL wwan module failed to init: Invalid device status 0x1:

  [ 1.623253] mtk_t7xx 0000:71:00.0: enabling device (0000 -> 0002)
  [ 3.632963] mtk_t7xx 0000:71:00.0: Invalid device status 0x1

[Fix]

The t7xx driver once received following fixes to complete its functions in
v6.1-rc1:

  d20ef656f994 net: wwan: t7xx: Add AP CLDMA
  007f26f0d68e net: wwan: t7xx: Infrastructure for early port configuration
  140424d90165 net: wwan: t7xx: PCIe reset rescan
  87dae9e70bf7 net: wwan: t7xx: Enable devlink based fw flashing and coredump
               collection
  b0bc1709b768 net: wwan: t7xx: Devlink documentation

However it was soon reverted for a second revision. Before that, in bug 1990700
we need the first (reverted) patch "net: wwan: t7xx: Add AP CLDMA" to fix device
suspend in a minimum level for development. Then, in this bug 2002089, a fully
revised resubmission is now available.

An additional patch from v6.1, commit bb67012331f7 ("net: devlink:
extend info_get() version put to indicate a flash component"), is
necessary for oem-6.0 backport.

[Test Case]

Modprobe on new platforms that suffers this invalid device status issue,
and run suspend/resume tests to ensure bug 1990700 is still in a good
state.

[Where problems could occur]

This re-introduce the device firmware update support via devlink, so far
it has been tested many times from 3rd party/vendor, but might still
bump into platform compatibility issue as we have here.

[Other Info]

While this is only planned for oem-6.0/oem-6.1 and on, only U/L/OEM-6.x
are nominated for fix.

Haijun Liu (1):
  UBUNTU: SAUCE: net: wwan: t7xx: Add AP CLDMA

M Chetan Kumar (4):
  UBUNTU: SAUCE: net: wwan: t7xx: Infrastructure for early port
    configuration
  UBUNTU: SAUCE: net: wwan: t7xx: PCIe reset rescan
  UBUNTU: SAUCE: net: wwan: t7xx: Enable devlink based fw flashing and
    coredump collection
  UBUNTU: SAUCE: net: wwan: t7xx: Devlink documentation

You-Sheng Yang (vicamo) (1):
  UBUNTU: SAUCE: Revert "net: wwan: t7xx: Add AP CLDMA"

 Documentation/networking/devlink/index.rst |   1 +
 Documentation/networking/devlink/t7xx.rst  | 161 +++++
 drivers/net/wwan/Kconfig                   |   1 +
 drivers/net/wwan/t7xx/Makefile             |   5 +-
 drivers/net/wwan/t7xx/t7xx_hif_cldma.c     |  47 +-
 drivers/net/wwan/t7xx/t7xx_hif_cldma.h     |  18 +-
 drivers/net/wwan/t7xx/t7xx_modem_ops.c     |  18 +-
 drivers/net/wwan/t7xx/t7xx_modem_ops.h     |   1 -
 drivers/net/wwan/t7xx/t7xx_pci.c           |  72 ++-
 drivers/net/wwan/t7xx/t7xx_pci.h           |   2 +
 drivers/net/wwan/t7xx/t7xx_pci_rescan.c    |  96 +++
 drivers/net/wwan/t7xx/t7xx_pci_rescan.h    |  28 +
 drivers/net/wwan/t7xx/t7xx_port.h          |   8 +-
 drivers/net/wwan/t7xx/t7xx_port_ap_msg.c   |  78 +++
 drivers/net/wwan/t7xx/t7xx_port_ap_msg.h   |  11 +
 drivers/net/wwan/t7xx/t7xx_port_devlink.c  | 665 +++++++++++++++++++++
 drivers/net/wwan/t7xx/t7xx_port_devlink.h  |  86 +++
 drivers/net/wwan/t7xx/t7xx_port_proxy.c    | 125 +++-
 drivers/net/wwan/t7xx/t7xx_port_proxy.h    |  16 +-
 drivers/net/wwan/t7xx/t7xx_port_wwan.c     |  25 +-
 drivers/net/wwan/t7xx/t7xx_reg.h           |  30 +-
 drivers/net/wwan/t7xx/t7xx_state_monitor.c | 123 +++-
 drivers/net/wwan/t7xx/t7xx_state_monitor.h |   1 +
 23 files changed, 1525 insertions(+), 93 deletions(-)
 create mode 100644 Documentation/networking/devlink/t7xx.rst
 create mode 100644 drivers/net/wwan/t7xx/t7xx_pci_rescan.c
 create mode 100644 drivers/net/wwan/t7xx/t7xx_pci_rescan.h
 create mode 100644 drivers/net/wwan/t7xx/t7xx_port_ap_msg.c
 create mode 100644 drivers/net/wwan/t7xx/t7xx_port_ap_msg.h
 create mode 100644 drivers/net/wwan/t7xx/t7xx_port_devlink.c
 create mode 100644 drivers/net/wwan/t7xx/t7xx_port_devlink.h

Comments

Timo Aaltonen Jan. 19, 2023, 3:14 p.m. UTC | #1 
You-Sheng Yang kirjoitti 16.1.2023 klo 11.14:
> From: "You-Sheng Yang (vicamo)" <vicamo.yang@canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/2002089
> 
> [Impact]
> 
> Mediatek FM350-GL wwan module failed to init: Invalid device status 0x1:
> 
>    [ 1.623253] mtk_t7xx 0000:71:00.0: enabling device (0000 -> 0002)
>    [ 3.632963] mtk_t7xx 0000:71:00.0: Invalid device status 0x1
> 
> [Fix]
> 
> The t7xx driver once received following fixes to complete its functions in
> v6.1-rc1:
> 
>    d20ef656f994 net: wwan: t7xx: Add AP CLDMA
>    007f26f0d68e net: wwan: t7xx: Infrastructure for early port configuration
>    140424d90165 net: wwan: t7xx: PCIe reset rescan
>    87dae9e70bf7 net: wwan: t7xx: Enable devlink based fw flashing and coredump
>                 collection
>    b0bc1709b768 net: wwan: t7xx: Devlink documentation
> 
> However it was soon reverted for a second revision. Before that, in bug 1990700
> we need the first (reverted) patch "net: wwan: t7xx: Add AP CLDMA" to fix device
> suspend in a minimum level for development. Then, in this bug 2002089, a fully
> revised resubmission is now available.
> 
> An additional patch from v6.1, commit bb67012331f7 ("net: devlink:
> extend info_get() version put to indicate a flash component"), is
> necessary for oem-6.0 backport.
> 
> [Test Case]
> 
> Modprobe on new platforms that suffers this invalid device status issue,
> and run suspend/resume tests to ensure bug 1990700 is still in a good
> state.
> 
> [Where problems could occur]
> 
> This re-introduce the device firmware update support via devlink, so far
> it has been tested many times from 3rd party/vendor, but might still
> bump into platform compatibility issue as we have here.
> 
> [Other Info]
> 
> While this is only planned for oem-6.0/oem-6.1 and on, only U/L/OEM-6.x
> are nominated for fix.
> 
> Haijun Liu (1):
>    UBUNTU: SAUCE: net: wwan: t7xx: Add AP CLDMA
> 
> M Chetan Kumar (4):
>    UBUNTU: SAUCE: net: wwan: t7xx: Infrastructure for early port
>      configuration
>    UBUNTU: SAUCE: net: wwan: t7xx: PCIe reset rescan
>    UBUNTU: SAUCE: net: wwan: t7xx: Enable devlink based fw flashing and
>      coredump collection
>    UBUNTU: SAUCE: net: wwan: t7xx: Devlink documentation
> 
> You-Sheng Yang (vicamo) (1):
>    UBUNTU: SAUCE: Revert "net: wwan: t7xx: Add AP CLDMA"
> 
>   Documentation/networking/devlink/index.rst |   1 +
>   Documentation/networking/devlink/t7xx.rst  | 161 +++++
>   drivers/net/wwan/Kconfig                   |   1 +
>   drivers/net/wwan/t7xx/Makefile             |   5 +-
>   drivers/net/wwan/t7xx/t7xx_hif_cldma.c     |  47 +-
>   drivers/net/wwan/t7xx/t7xx_hif_cldma.h     |  18 +-
>   drivers/net/wwan/t7xx/t7xx_modem_ops.c     |  18 +-
>   drivers/net/wwan/t7xx/t7xx_modem_ops.h     |   1 -
>   drivers/net/wwan/t7xx/t7xx_pci.c           |  72 ++-
>   drivers/net/wwan/t7xx/t7xx_pci.h           |   2 +
>   drivers/net/wwan/t7xx/t7xx_pci_rescan.c    |  96 +++
>   drivers/net/wwan/t7xx/t7xx_pci_rescan.h    |  28 +
>   drivers/net/wwan/t7xx/t7xx_port.h          |   8 +-
>   drivers/net/wwan/t7xx/t7xx_port_ap_msg.c   |  78 +++
>   drivers/net/wwan/t7xx/t7xx_port_ap_msg.h   |  11 +
>   drivers/net/wwan/t7xx/t7xx_port_devlink.c  | 665 +++++++++++++++++++++
>   drivers/net/wwan/t7xx/t7xx_port_devlink.h  |  86 +++
>   drivers/net/wwan/t7xx/t7xx_port_proxy.c    | 125 +++-
>   drivers/net/wwan/t7xx/t7xx_port_proxy.h    |  16 +-
>   drivers/net/wwan/t7xx/t7xx_port_wwan.c     |  25 +-
>   drivers/net/wwan/t7xx/t7xx_reg.h           |  30 +-
>   drivers/net/wwan/t7xx/t7xx_state_monitor.c | 123 +++-
>   drivers/net/wwan/t7xx/t7xx_state_monitor.h |   1 +
>   23 files changed, 1525 insertions(+), 93 deletions(-)
>   create mode 100644 Documentation/networking/devlink/t7xx.rst
>   create mode 100644 drivers/net/wwan/t7xx/t7xx_pci_rescan.c
>   create mode 100644 drivers/net/wwan/t7xx/t7xx_pci_rescan.h
>   create mode 100644 drivers/net/wwan/t7xx/t7xx_port_ap_msg.c
>   create mode 100644 drivers/net/wwan/t7xx/t7xx_port_ap_msg.h
>   create mode 100644 drivers/net/wwan/t7xx/t7xx_port_devlink.c
>   create mode 100644 drivers/net/wwan/t7xx/t7xx_port_devlink.h
> 

applied to oem-6.1, thanks
Andrea Righi Feb. 2, 2023, 6:59 a.m. UTC | #2 
On Mon, Jan 16, 2023 at 05:14:56PM +0800, You-Sheng Yang wrote:
> From: "You-Sheng Yang (vicamo)" <vicamo.yang@canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/2002089
> 
> [Impact]
> 
> Mediatek FM350-GL wwan module failed to init: Invalid device status 0x1:
> 
>   [ 1.623253] mtk_t7xx 0000:71:00.0: enabling device (0000 -> 0002)
>   [ 3.632963] mtk_t7xx 0000:71:00.0: Invalid device status 0x1
> 
> [Fix]
> 
> The t7xx driver once received following fixes to complete its functions in
> v6.1-rc1:
> 
>   d20ef656f994 net: wwan: t7xx: Add AP CLDMA
>   007f26f0d68e net: wwan: t7xx: Infrastructure for early port configuration
>   140424d90165 net: wwan: t7xx: PCIe reset rescan
>   87dae9e70bf7 net: wwan: t7xx: Enable devlink based fw flashing and coredump
>                collection
>   b0bc1709b768 net: wwan: t7xx: Devlink documentation
> 
> However it was soon reverted for a second revision. Before that, in bug 1990700
> we need the first (reverted) patch "net: wwan: t7xx: Add AP CLDMA" to fix device
> suspend in a minimum level for development. Then, in this bug 2002089, a fully
> revised resubmission is now available.
> 
> An additional patch from v6.1, commit bb67012331f7 ("net: devlink:
> extend info_get() version put to indicate a flash component"), is
> necessary for oem-6.0 backport.
> 
> [Test Case]
> 
> Modprobe on new platforms that suffers this invalid device status issue,
> and run suspend/resume tests to ensure bug 1990700 is still in a good
> state.
> 
> [Where problems could occur]
> 
> This re-introduce the device firmware update support via devlink, so far
> it has been tested many times from 3rd party/vendor, but might still
> bump into platform compatibility issue as we have here.
> 
> [Other Info]
> 
> While this is only planned for oem-6.0/oem-6.1 and on, only U/L/OEM-6.x
> are nominated for fix.

Applied to lunar/linux and lunar/linux-unstable.

Thanks,
-Andrea