| Message ID | 20230124183257.83421-1-jacob.martin@canonical.com |
|---|---|
| Headers | show |
| Series | UBUNTU: [Config] kvm: Add support for dummy net driver | expand |
On 1/24/23 11:32, Jacob Martin wrote: > https://bugs.launchpad.net/bugs/1998244 > > Note: This issue was originally triaged and fixed by ~joseogando for lunar/linux-kvm. I am applying the fix to kinetic and jammy as training. > > SRU Justification: > > [Impact] > > * Without Kernel support for the Dummy net driver, it is not possible to successfully run selftests that use it. This includes as per this bug net/fib_nexthop_nongw.sh, but also could potentially include other such as rtnetlink.sh, fib_rule_tests.sh, forwarding/* etc. > > [Fix] > > * Custom patch to enable CONFIG_DUMMY=m > > [Test Plan] > > * Before the fix, the net/fib_nexthop_nongw.sh script will fail in the specific line which does > > $ ip -n h1 link add name eth0 type dummy > Error: Unknown device type. > > After the fix it does not fail. > > [Where problems could occur] > > * The regression can be considered as low, since we are adding functionality not previously present. > > [Other Info] > > * There does not seem to be a historical reason for removing it from linux-kvm. > > Jacob Martin (1): > UBUNTU: [Config] kvm: Add support for dummy net driver > > debian.kvm/config/annotations | 3 +++ > debian.kvm/config/config.common.ubuntu | 2 +- > 2 files changed, 4 insertions(+), 1 deletion(-) > Acked-by: Tim Gardner <tim.gardner@canonical.com>
Looks good to me, in the future if the coverletter and content is very similar you could send both patches for kinetic and jammy under the same patchset and just change the tags in the header to [kinetic:linux-kvm/jammy:linux-kvm] so that we know the patches apply to both (where the denotation is series:kernel and '/' is used to show different places where it is applied). I think I forgot to mention that in Jose's original patch. But yea, the less emails the better ;) Acked-by: Luke Nowakowski-Krijger <luke.nowakowskikrijger@canonical.com> On Tue, Jan 24, 2023 at 10:33 AM Jacob Martin <jacob.martin@canonical.com> wrote: > https://bugs.launchpad.net/bugs/1998244 > > Note: This issue was originally triaged and fixed by ~joseogando for > lunar/linux-kvm. I am applying the fix to kinetic and jammy as training. > > SRU Justification: > > [Impact] > > * Without Kernel support for the Dummy net driver, it is not possible to > successfully run selftests that use it. This includes as per this bug > net/fib_nexthop_nongw.sh, but also could potentially include other such as > rtnetlink.sh, fib_rule_tests.sh, forwarding/* etc. > > [Fix] > > * Custom patch to enable CONFIG_DUMMY=m > > [Test Plan] > > * Before the fix, the net/fib_nexthop_nongw.sh script will fail in the > specific line which does > > $ ip -n h1 link add name eth0 type dummy > Error: Unknown device type. > > After the fix it does not fail. > > [Where problems could occur] > > * The regression can be considered as low, since we are adding > functionality not previously present. > > [Other Info] > > * There does not seem to be a historical reason for removing it from > linux-kvm. > > Jacob Martin (1): > UBUNTU: [Config] kvm: Add support for dummy net driver > > debian.kvm/config/annotations | 3 +++ > debian.kvm/config/config.common.ubuntu | 2 +- > 2 files changed, 4 insertions(+), 1 deletion(-) > > -- > 2.25.1 > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team >
Applied to kinetic:linux-kvm master-next Thanks! - Luke On Tue, Jan 24, 2023 at 10:33 AM Jacob Martin <jacob.martin@canonical.com> wrote: > https://bugs.launchpad.net/bugs/1998244 > > Note: This issue was originally triaged and fixed by ~joseogando for > lunar/linux-kvm. I am applying the fix to kinetic and jammy as training. > > SRU Justification: > > [Impact] > > * Without Kernel support for the Dummy net driver, it is not possible to > successfully run selftests that use it. This includes as per this bug > net/fib_nexthop_nongw.sh, but also could potentially include other such as > rtnetlink.sh, fib_rule_tests.sh, forwarding/* etc. > > [Fix] > > * Custom patch to enable CONFIG_DUMMY=m > > [Test Plan] > > * Before the fix, the net/fib_nexthop_nongw.sh script will fail in the > specific line which does > > $ ip -n h1 link add name eth0 type dummy > Error: Unknown device type. > > After the fix it does not fail. > > [Where problems could occur] > > * The regression can be considered as low, since we are adding > functionality not previously present. > > [Other Info] > > * There does not seem to be a historical reason for removing it from > linux-kvm. > > Jacob Martin (1): > UBUNTU: [Config] kvm: Add support for dummy net driver > > debian.kvm/config/annotations | 3 +++ > debian.kvm/config/config.common.ubuntu | 2 +- > 2 files changed, 4 insertions(+), 1 deletion(-) > > -- > 2.25.1 > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team >