Message ID | 20230131132510.98243-1-fanquake@gmail.com |
---|---|
State | New |
Headers | show |
Series | doc: correct _FORTIFY_SOURCE doc in features.h | expand |
Thanks, that looks correct. Carlos, may I push this before you cut the release? Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org> On 2023-01-31 08:25, fanquake via Libc-alpha wrote: > --- > include/features.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/features.h b/include/features.h > index 7d2c7a4f87..07c73b3e55 100644 > --- a/include/features.h > +++ b/include/features.h > @@ -57,7 +57,8 @@ > __STRICT_ANSI__). > > _FORTIFY_SOURCE Add security hardening to many library functions. > - Set to 1 or 2; 2 performs stricter checks than 1. > + Set to 1, 2 or 3; 3 performs stricter checks than 2, which > + performs stricter checks than 1. > > _REENTRANT, _THREAD_SAFE > Obsolete; equivalent to _POSIX_C_SOURCE=199506L.
On 1/31/23 09:20, Siddhesh Poyarekar wrote: > Thanks, that looks correct. Carlos, may I push this before you cut the release? > > Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org> Yes, comment only fix in headers. OK for 2.37. Please push ASAP. > On 2023-01-31 08:25, fanquake via Libc-alpha wrote: >> --- >> include/features.h | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/include/features.h b/include/features.h >> index 7d2c7a4f87..07c73b3e55 100644 >> --- a/include/features.h >> +++ b/include/features.h >> @@ -57,7 +57,8 @@ >> __STRICT_ANSI__). >> _FORTIFY_SOURCE Add security hardening to many library functions. >> - Set to 1 or 2; 2 performs stricter checks than 1. >> + Set to 1, 2 or 3; 3 performs stricter checks than 2, which >> + performs stricter checks than 1. >> _REENTRANT, _THREAD_SAFE >> Obsolete; equivalent to _POSIX_C_SOURCE=199506L. >
On 2023-01-31 15:29, Carlos O'Donell wrote: > On 1/31/23 09:20, Siddhesh Poyarekar wrote: >> Thanks, that looks correct. Carlos, may I push this before you cut the release? >> >> Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org> > > Yes, comment only fix in headers. OK for 2.37. Please push ASAP. > Pushed, thanks. Sid
diff --git a/include/features.h b/include/features.h index 7d2c7a4f87..07c73b3e55 100644 --- a/include/features.h +++ b/include/features.h @@ -57,7 +57,8 @@ __STRICT_ANSI__). _FORTIFY_SOURCE Add security hardening to many library functions. - Set to 1 or 2; 2 performs stricter checks than 1. + Set to 1, 2 or 3; 3 performs stricter checks than 2, which + performs stricter checks than 1. _REENTRANT, _THREAD_SAFE Obsolete; equivalent to _POSIX_C_SOURCE=199506L.