[v5,0/9] TI-Nspire cleanups

Message ID	20230123214924.27476-1-afd@ti.com
Headers	show Return-Path: <devicetree-owner@vger.kernel.org> From: Andrew Davis <afd@ti.com> To: Lee Jones <lee@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Arnd Bergmann <arnd@arndb.de>, Linus Walleij <linus.walleij@linaro.org>, Geert Uytterhoeven <geert+renesas@glider.be>, Daniel Tang <dt.tangr@gmail.com>, Fabian Vogt <fabian@ritter-vogt.de> CC: <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>, Andrew Davis <afd@ti.com> Subject: [PATCH v5 0/9] TI-Nspire cleanups Date: Mon, 23 Jan 2023 15:49:15 -0600 Message-ID: <20230123214924.27476-1-afd@ti.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Precedence: bulk
Series	TI-Nspire cleanups \| expand [v5,0/9] TI-Nspire cleanups [v5,1/9] dt-bindings: mfd: Add TI-Nspire misc registers

Andrew Davis Jan. 23, 2023, 9:49 p.m. UTC

Hello all,

This series is an extended version of the series started here[0]
and here[1].

We break out what was the first patch into one for DTS change and
one for code changes as suggested by Krzysztof. Those are now patches
2 and 8 of this series (I kept the ACKs, hope that is okay).

As also pointed out by Krzysztof syscon nodes need a specific
compatible, add that as patch 1.

While I was adding that, I noticed some other dtbs_check issues,
so while here fixed some of those up too (patches 3-6).

Thanks,
Andrew

[0] https://lore.kernel.org/lkml/20221026161302.5319-1-afd@ti.com/
[1] https://lore.kernel.org/linux-arm-kernel/20221027181337.8651-1-afd@ti.com/

Changes from v4:
 - Rebase on latest master

Changes from v3:
 - Add Reviewed-by
 - Make new binding for patch #1

Changes from v2:
 - See cover letter message

Changes from v1:
 - Add ACKs
 - Rebase on latest

Andrew Davis (9):
  dt-bindings: mfd: Add TI-Nspire misc registers
  ARM: dts: nspire: Use syscon-reboot to handle restart
  ARM: dts: nspire: Fix cpu node to conform with DT binding
  ARM: dts: nspire: Fix sram node to conform with DT binding
  ARM: dts: nspire: Fix vbus_reg node to conform with DT binding
  ARM: dts: nspire: Fix uart node to conform with DT binding
  ARM: dts: nspire: Use MATRIX_KEY macro for linux,keymap
  ARM: nspire: Use syscon-reboot to handle restart
  ARM: nspire: Remove unused header file mmio.h

 .../bindings/mfd/ti,nspire-misc.yaml          | 51 ++++++++++
 arch/arm/boot/dts/nspire-clp.dts              | 90 +++++++++++++-----
 arch/arm/boot/dts/nspire-cx.dts               | 92 ++++++++++++++-----
 arch/arm/boot/dts/nspire-tp.dts               | 90 +++++++++++++-----
 arch/arm/boot/dts/nspire.dtsi                 | 24 ++++-
 arch/arm/mach-nspire/Kconfig                  |  2 +
 arch/arm/mach-nspire/mmio.h                   | 16 ----
 arch/arm/mach-nspire/nspire.c                 | 24 -----
 8 files changed, 279 insertions(+), 110 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/mfd/ti,nspire-misc.yaml
 delete mode 100644 arch/arm/mach-nspire/mmio.h

Arnd Bergmann Jan. 23, 2023, 9:57 p.m. UTC | #1

On Mon, Jan 23, 2023, at 22:49, Andrew Davis wrote:
> Hello all,
>
> This series is an extended version of the series started here[0]
> and here[1].
>
> We break out what was the first patch into one for DTS change and
> one for code changes as suggested by Krzysztof. Those are now patches
> 2 and 8 of this series (I kept the ACKs, hope that is okay).
>
> As also pointed out by Krzysztof syscon nodes need a specific
> compatible, add that as patch 1.
>
> While I was adding that, I noticed some other dtbs_check issues,
> so while here fixed some of those up too (patches 3-6).

Looks all good to me, if there are no final comments within the
next few days, can you send this all to:soc@kernel.org, either as
separate patches or as two pull requests (dts and code) based
on 6.2-rc-1?

I think I previously commented on the lack of an entry in
the MAINTAINERS. It would be nice to have one more patch to
add this, whichever way you want to split this with Daniel,
adding one or both of you as maintainer and/or reviewer.
I'd keep that separate from this series though, to not hold
it up any longer.

     Arnd

Andrew Davis Jan. 23, 2023, 11:56 p.m. UTC | #2

On 1/23/23 3:57 PM, Arnd Bergmann wrote:
> On Mon, Jan 23, 2023, at 22:49, Andrew Davis wrote:
>> Hello all,
>>
>> This series is an extended version of the series started here[0]
>> and here[1].
>>
>> We break out what was the first patch into one for DTS change and
>> one for code changes as suggested by Krzysztof. Those are now patches
>> 2 and 8 of this series (I kept the ACKs, hope that is okay).
>>
>> As also pointed out by Krzysztof syscon nodes need a specific
>> compatible, add that as patch 1.
>>
>> While I was adding that, I noticed some other dtbs_check issues,
>> so while here fixed some of those up too (patches 3-6).
> 
> Looks all good to me, if there are no final comments within the
> next few days, can you send this all to:soc@kernel.org, either as
> separate patches or as two pull requests (dts and code) based
> on 6.2-rc-1?
> 

Sure thing.

> I think I previously commented on the lack of an entry in
> the MAINTAINERS. It would be nice to have one more patch to
> add this, whichever way you want to split this with Daniel,
> adding one or both of you as maintainer and/or reviewer.
> I'd keep that separate from this series though, to not hold
> it up any longer.
> 

Daniel,

Do you want to do this? If not I can add myself as a reviewer, the
point of this series is to boil down the support to just the DTS file,
at which point hopefully we won't need too much maintenance.

Andrew

>       Arnd

Lee Jones Jan. 24, 2023, 10:33 a.m. UTC | #3

On Mon, 23 Jan 2023, Arnd Bergmann wrote:

> On Mon, Jan 23, 2023, at 22:49, Andrew Davis wrote:
> > Hello all,
> >
> > This series is an extended version of the series started here[0]
> > and here[1].
> >
> > We break out what was the first patch into one for DTS change and
> > one for code changes as suggested by Krzysztof. Those are now patches
> > 2 and 8 of this series (I kept the ACKs, hope that is okay).
> >
> > As also pointed out by Krzysztof syscon nodes need a specific
> > compatible, add that as patch 1.
> >
> > While I was adding that, I noticed some other dtbs_check issues,
> > so while here fixed some of those up too (patches 3-6).
> 
> Looks all good to me, if there are no final comments within the
> next few days, can you send this all to:soc@kernel.org, either as
> separate patches or as two pull requests (dts and code) based
> on 6.2-rc-1?

Once the dt-bindings patch has been Acked by the DT maintainers, I'll
take this via MFD.

Daniel Tang Jan. 28, 2023, 2 a.m. UTC | #4

On Tue, 24 Jan 2023 at 10:56, Andrew Davis <afd@ti.com> wrote:
>
> On 1/23/23 3:57 PM, Arnd Bergmann wrote:
> > On Mon, Jan 23, 2023, at 22:49, Andrew Davis wrote:
> >> Hello all,
> >>
> >> This series is an extended version of the series started here[0]
> >> and here[1].
> >>
> >> We break out what was the first patch into one for DTS change and
> >> one for code changes as suggested by Krzysztof. Those are now patches
> >> 2 and 8 of this series (I kept the ACKs, hope that is okay).
> >>
> >> As also pointed out by Krzysztof syscon nodes need a specific
> >> compatible, add that as patch 1.
> >>
> >> While I was adding that, I noticed some other dtbs_check issues,
> >> so while here fixed some of those up too (patches 3-6).
> >
> > Looks all good to me, if there are no final comments within the
> > next few days, can you send this all to:soc@kernel.org, either as
> > separate patches or as two pull requests (dts and code) based
> > on 6.2-rc-1?
> >
>
> Sure thing.
>
> > I think I previously commented on the lack of an entry in
> > the MAINTAINERS. It would be nice to have one more patch to
> > add this, whichever way you want to split this with Daniel,
> > adding one or both of you as maintainer and/or reviewer.
> > I'd keep that separate from this series though, to not hold
> > it up any longer.
> >
>
> Daniel,
>
> Do you want to do this? If not I can add myself as a reviewer, the
> point of this series is to boil down the support to just the DTS file,
> at which point hopefully we won't need too much maintenance.
>
> Andrew
>

I would prefer that someone who is more active in this project be the
maintainer (I've not been working on this platform for many years now,
and don't currently have the means to test changes).

Fabian, would you be OK being listed as a maintainer for now? If not,
I'll get in touch with some other project team members to find a
maintainer.

Cheers,
Daniel

> >       Arnd

Fabian Vogt Jan. 28, 2023, 11:24 a.m. UTC | #5

Hi,

Am Samstag, 28. Januar 2023, 03:00:49 CET schrieb Daniel Tang:
> On Tue, 24 Jan 2023 at 10:56, Andrew Davis <afd@ti.com> wrote:
> >
> > On 1/23/23 3:57 PM, Arnd Bergmann wrote:
> > > On Mon, Jan 23, 2023, at 22:49, Andrew Davis wrote:
> > >> Hello all,
> > >>
> > >> This series is an extended version of the series started here[0]
> > >> and here[1].
> > >>
> > >> We break out what was the first patch into one for DTS change and
> > >> one for code changes as suggested by Krzysztof. Those are now patches
> > >> 2 and 8 of this series (I kept the ACKs, hope that is okay).
> > >>
> > >> As also pointed out by Krzysztof syscon nodes need a specific
> > >> compatible, add that as patch 1.
> > >>
> > >> While I was adding that, I noticed some other dtbs_check issues,
> > >> so while here fixed some of those up too (patches 3-6).
> > >
> > > Looks all good to me, if there are no final comments within the
> > > next few days, can you send this all to:soc@kernel.org, either as
> > > separate patches or as two pull requests (dts and code) based
> > > on 6.2-rc-1?
> > >
> >
> > Sure thing.
> >
> > > I think I previously commented on the lack of an entry in
> > > the MAINTAINERS. It would be nice to have one more patch to
> > > add this, whichever way you want to split this with Daniel,
> > > adding one or both of you as maintainer and/or reviewer.
> > > I'd keep that separate from this series though, to not hold
> > > it up any longer.
> > >
> >
> > Daniel,
> >
> > Do you want to do this? If not I can add myself as a reviewer, the
> > point of this series is to boil down the support to just the DTS file,
> > at which point hopefully we won't need too much maintenance.
> >
> > Andrew
> >
> 
> I would prefer that someone who is more active in this project be the
> maintainer (I've not been working on this platform for many years now,
> and don't currently have the means to test changes).
> 
> Fabian, would you be OK being listed as a maintainer for now? If not,
> I'll get in touch with some other project team members to find a
> maintainer.

Sure.

Cheers,
Fabian

> Cheers,
> Daniel
> 
> > >       Arnd

[v5,0/9] TI-Nspire cleanups

Message

Comments