mbox series

[v2,0/4] Fix sparse warnings

Message ID 20230120053617.32463-1-ashok.reddy.soma@amd.com
Headers show
Series Fix sparse warnings | expand

Message

Ashok Reddy Soma Jan. 20, 2023, 5:36 a.m. UTC 
Run and fix sparse warnings in below files
 -drivers/mmc/zynq_sdhci.c
 -board/xilinx/common/board.h
 -drivers/gpio/zynqmp_gpio_modepin.c
 -board/xilinx/versal/board.c

Changes in v2:
 - Included header file instead of declaring prototype
 - Modified description to reflect the same
 - Instead of removing ret variable, take it and return incase of error.
 - Updated description as per this.
 - Changed subject from missing prototype to missing header
 - Moved include file in alphabetical order
 - Updated description

Algapally Santosh Sagar (4):
  xilinx: common: Include header file to fix warning
  gpio: zynqmp: Handle error from get_gpio_modepin
  xilinx: versal: Add missing header
  drivers: mmc: Change datatype of tuning_loop_counter to int

 board/xilinx/common/board.c        | 1 +
 board/xilinx/versal/board.c        | 1 +
 drivers/gpio/zynqmp_gpio_modepin.c | 3 +++
 drivers/mmc/zynq_sdhci.c           | 2 +-
 4 files changed, 6 insertions(+), 1 deletion(-)

Comments

Michal Simek Jan. 27, 2023, 8:48 a.m. UTC | #1 
On 1/20/23 06:36, Ashok Reddy Soma wrote:
> Run and fix sparse warnings in below files
>   -drivers/mmc/zynq_sdhci.c
>   -board/xilinx/common/board.h
>   -drivers/gpio/zynqmp_gpio_modepin.c
>   -board/xilinx/versal/board.c
> 
> Changes in v2:
>   - Included header file instead of declaring prototype
>   - Modified description to reflect the same
>   - Instead of removing ret variable, take it and return incase of error.
>   - Updated description as per this.
>   - Changed subject from missing prototype to missing header
>   - Moved include file in alphabetical order
>   - Updated description
> 
> Algapally Santosh Sagar (4):
>    xilinx: common: Include header file to fix warning
>    gpio: zynqmp: Handle error from get_gpio_modepin
>    xilinx: versal: Add missing header
>    drivers: mmc: Change datatype of tuning_loop_counter to int
> 
>   board/xilinx/common/board.c        | 1 +
>   board/xilinx/versal/board.c        | 1 +
>   drivers/gpio/zynqmp_gpio_modepin.c | 3 +++
>   drivers/mmc/zynq_sdhci.c           | 2 +-
>   4 files changed, 6 insertions(+), 1 deletion(-)
> 

Applied all.
M