diff mbox

iwlagn regression in v3.1.5

Message ID 4EE4DB55.4090804@udo.edu
State Not Applicable, archived
Delegated to: David Miller
Headers show

Commit Message

Andrej Gelenberg Dec. 11, 2011, 4:33 p.m. UTC 
Hello,

the original commit 34a5b4b6af104cf18eb50748509528b9bdbc4036 in upstream 
(v3.2.0-rc5) break the driver too. Please revert it, before the release. 
Patch for 3.2-rc5 attached.

Regards,
Andrej Gelenberg

On 12/11/2011 02:24 PM, Andrej Gelenberg wrote:
> Hello,
>
> there in an regression in kernel release v3.1.5. Commit
> 43c308bd8d0a3e7d98c5abcd41a4a3fada3d198f "iwlwifi: do not re-configure
> HT40 after associated" break iwlagn driver for Intel Corporation
> Centrino Ultimate-N 6300 (rev 35) on my Thinkpad t510. I still can
> connect to the AP, but i can't pin or access anything. Reverting that
> commit solved the Problem. I attached the patch.
>
> Regards,
> Andrej Gelenberg

Comments

Udo Steinberg Dec. 11, 2011, 4:41 p.m. UTC | #1 
Hi,

The patch fixes the following bug:
http://bugzilla.intellinuxwireless.org/show_bug.cgi?id=2326

If the patch introduces a regression for you, then the problem needs to be
investigated further. Reverting the patch will reintroduce an already fixed
problem for others.

Cheers,

	- Udo

On Sun, 11 Dec 2011 17:33:25 +0100 Andrej Gelenberg (AG) wrote:

AG> Hello,
AG> 
AG> the original commit 34a5b4b6af104cf18eb50748509528b9bdbc4036 in upstream (v3.2.0-rc5) break the driver too. Please revert it, before the release. Patch for 3.2-rc5 attached.
AG> 
AG> Regards,
AG> Andrej Gelenberg
AG> 
AG> On 12/11/2011 02:24 PM, Andrej Gelenberg wrote:
AG> > Hello,
AG> >
AG> > there in an regression in kernel release v3.1.5. Commit
AG> > 43c308bd8d0a3e7d98c5abcd41a4a3fada3d198f "iwlwifi: do not re-configure
AG> > HT40 after associated" break iwlagn driver for Intel Corporation
AG> > Centrino Ultimate-N 6300 (rev 35) on my Thinkpad t510. I still can
AG> > connect to the AP, but i can't pin or access anything. Reverting that
AG> > commit solved the Problem. I attached the patch.
AG> >
AG> > Regards,
AG> > Andrej Gelenberg
AG>
Andrej Gelenberg Dec. 11, 2011, 4:58 p.m. UTC | #2 
Hi,

this is pretty mean regression for the stable kernel. You may the fix 
only for cards, which need it and not for all of them.

Regards,
Andrej

On 12/11/2011 05:41 PM, Udo Steinberg wrote:
> Hi,
>
> The patch fixes the following bug:
> http://bugzilla.intellinuxwireless.org/show_bug.cgi?id=2326
>
> If the patch introduces a regression for you, then the problem needs to be
> investigated further. Reverting the patch will reintroduce an already fixed
> problem for others.
>
> Cheers,
>
> 	- Udo
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Guy, Wey-Yi Dec. 11, 2011, 6:23 p.m. UTC | #3 
On Sun, 2011-12-11 at 08:58 -0800, Andrej Gelenberg wrote:
> Hi,
> 
> this is pretty mean regression for the stable kernel. You may the fix 
> only for cards, which need it and not for all of them.

Could you elaborate more on the failure case and setup. this patch is to
address HT40 related problem which cause the iwlwifi firmware crash.

Thanks
Wey
> >


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Andrej Gelenberg Dec. 11, 2011, 7:05 p.m. UTC | #4 
Hi,

i haven't experienced firmware crushes, but after that commit i don't 
get any networking with my wlan card. I added some lspci and dmesg 
output to the patch. There was no strange output in my dmesg. dhcpcd 
says in logs, that carrier lost after about 30 seconds. How can i 
reproduce the HT40 bug?

Regards,
Andrej

On 12/11/2011 07:23 PM, wwguy wrote:
> On Sun, 2011-12-11 at 08:58 -0800, Andrej Gelenberg wrote:
>> Hi,
>>
>> this is pretty mean regression for the stable kernel. You may the fix
>> only for cards, which need it and not for all of them.
>
> Could you elaborate more on the failure case and setup. this patch is to
> address HT40 related problem which cause the iwlwifi firmware crash.
>
> Thanks
> Wey
>>>
>
>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Andrej Gelenberg Dec. 11, 2011, 7:20 p.m. UTC | #5 
Hi,

some info to the AP i use:

Technaxx Router-150 Wifi-N based on ranik soc

$ iw dev wlan0 station dump
Station xx:xx..xx:xx (on wlan0)
         inactive time:  6603 ms
         rx bytes:       377786468
         rx packets:     443535
         tx bytes:       15677515
         tx packets:     155009
         tx retries:     2723757
         tx failed:      51495
         signal:         -72 dBm
         signal avg:     -71 dBm
         tx bitrate:     135.0 MBit/s MCS 6 40Mhz short GI
         authorized:     yes
         authenticated:  yes
         preamble:       long
         WMM/WME:        yes
         MFP:            no

$ iwconfig wlan0
wlan0     IEEE 802.11abgn  ESSID:"xxx"
           Mode:Managed  Frequency:2.437 GHz  Access Point: xx:xx..xx:xx
           Bit Rate=121.5 Mb/s   Tx-Power=15 dBm
           Retry  long limit:7   RTS thr:off   Fragment thr:off
           Power Management:off
           Link Quality=42/70  Signal level=-68 dBm
           Rx invalid nwid:0  Rx invalid crypt:0  Rx invalid frag:0
           Tx excessive retries:51520  Invalid misc:3567 Missed beacon:0

some dmesg output:

[  903.748514] wlan0: authenticate with xx:xx..xx:xx (try 1)
[  903.750991] wlan0: authenticated
[  903.753357] wlan0: associate with xx:xx..xx:xx (try 1)
[  903.759482] wlan0: RX AssocResp from xx:xx..xx:xx (capab=0xc31 
status=0 aid=1)
[  903.759487] wlan0: associated

$ iwlist wlan0 scan

           Cell 06 - Address: xx:xx..xx:xx
                     Channel:6
                     Frequency:2.437 GHz (Channel 6)
                     Quality=45/70  Signal level=-65 dBm
                     Encryption key:on
                     ESSID:"xxx"
                     Bit Rates:1 Mb/s; 2 Mb/s; 5.5 Mb/s; 11 Mb/s; 9 Mb/s
                               18 Mb/s; 36 Mb/s; 54 Mb/s
                     Bit Rates:6 Mb/s; 12 Mb/s; 24 Mb/s; 48 Mb/s
                     Mode:Master
                     Extra:tsf=0000005666eac197
                     Extra: Last beacon: 33ms ago
                     IE: Unknown: 000873757065726B7568
                     IE: Unknown: 010882848B961224486C
                     IE: Unknown: 030106
                     IE: Unknown: 2A0100
                     IE: Unknown: 32040C183060
                     IE: Unknown: 
2D1A7E1117FF000000010000000000000000000000000C0000000000
                     IE: Unknown: 
3D1606070500000000000000000000000000000000000000
                     IE: Unknown: 3E0100
                     IE: IEEE 802.11i/WPA2 Version 1
                         Group Cipher : CCMP
                         Pairwise Ciphers (1) : CCMP
                         Authentication Suites (1) : PSK
                     IE: Unknown: 
DD180050F2020101800003A4000027A4000042435E0062322F00
                     IE: Unknown: 0B05020012127A
                     IE: Unknown: 4A0E14000A002C01C800140005001900
                     IE: Unknown: 7F0101
                     IE: Unknown: DD07000C4307000000
                     IE: Unknown: 0706465220010D10
                     IE: Unknown: 
DD1E00904C337E1117FF000000010000000000000000000000000C0000000000
                     IE: Unknown: 
DD1A00904C3406070500000000000000000000000000000000000000

Regards,
Andrej Gelenberg

On 12/11/2011 07:23 PM, wwguy wrote:
> On Sun, 2011-12-11 at 08:58 -0800, Andrej Gelenberg wrote:
>> Hi,
>>
>> this is pretty mean regression for the stable kernel. You may the fix
>> only for cards, which need it and not for all of them.
>
> Could you elaborate more on the failure case and setup. this patch is to
> address HT40 related problem which cause the iwlwifi firmware crash.
>
> Thanks
> Wey
>>>
>
>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Guy, Wey-Yi Dec. 12, 2011, 1:35 a.m. UTC | #6 
Hi Andjej,


Could you please load the module with debug=0x1082 and send me the log.

$sudo modprobe iwlagn debug=0x1082

Thanks
Wey

On Sun, 2011-12-11 at 11:20 -0800, Andrej Gelenberg wrote:
> Hi,
> 
> some info to the AP i use:
> 
> Technaxx Router-150 Wifi-N based on ranik soc
> 
> $ iw dev wlan0 station dump
> Station xx:xx..xx:xx (on wlan0)
>          inactive time:  6603 ms
>          rx bytes:       377786468
>          rx packets:     443535
>          tx bytes:       15677515
>          tx packets:     155009
>          tx retries:     2723757
>          tx failed:      51495
>          signal:         -72 dBm
>          signal avg:     -71 dBm
>          tx bitrate:     135.0 MBit/s MCS 6 40Mhz short GI
>          authorized:     yes
>          authenticated:  yes
>          preamble:       long
>          WMM/WME:        yes
>          MFP:            no
> 
> $ iwconfig wlan0
> wlan0     IEEE 802.11abgn  ESSID:"xxx"
>            Mode:Managed  Frequency:2.437 GHz  Access Point: xx:xx..xx:xx
>            Bit Rate=121.5 Mb/s   Tx-Power=15 dBm
>            Retry  long limit:7   RTS thr:off   Fragment thr:off
>            Power Management:off
>            Link Quality=42/70  Signal level=-68 dBm
>            Rx invalid nwid:0  Rx invalid crypt:0  Rx invalid frag:0
>            Tx excessive retries:51520  Invalid misc:3567 Missed beacon:0
> 
> some dmesg output:
> 
> [  903.748514] wlan0: authenticate with xx:xx..xx:xx (try 1)
> [  903.750991] wlan0: authenticated
> [  903.753357] wlan0: associate with xx:xx..xx:xx (try 1)
> [  903.759482] wlan0: RX AssocResp from xx:xx..xx:xx (capab=0xc31 
> status=0 aid=1)
> [  903.759487] wlan0: associated
> 
> $ iwlist wlan0 scan
> 
>            Cell 06 - Address: xx:xx..xx:xx
>                      Channel:6
>                      Frequency:2.437 GHz (Channel 6)
>                      Quality=45/70  Signal level=-65 dBm
>                      Encryption key:on
>                      ESSID:"xxx"
>                      Bit Rates:1 Mb/s; 2 Mb/s; 5.5 Mb/s; 11 Mb/s; 9 Mb/s
>                                18 Mb/s; 36 Mb/s; 54 Mb/s
>                      Bit Rates:6 Mb/s; 12 Mb/s; 24 Mb/s; 48 Mb/s
>                      Mode:Master
>                      Extra:tsf=0000005666eac197
>                      Extra: Last beacon: 33ms ago
>                      IE: Unknown: 000873757065726B7568
>                      IE: Unknown: 010882848B961224486C
>                      IE: Unknown: 030106
>                      IE: Unknown: 2A0100
>                      IE: Unknown: 32040C183060
>                      IE: Unknown: 
> 2D1A7E1117FF000000010000000000000000000000000C0000000000
>                      IE: Unknown: 
> 3D1606070500000000000000000000000000000000000000
>                      IE: Unknown: 3E0100
>                      IE: IEEE 802.11i/WPA2 Version 1
>                          Group Cipher : CCMP
>                          Pairwise Ciphers (1) : CCMP
>                          Authentication Suites (1) : PSK
>                      IE: Unknown: 
> DD180050F2020101800003A4000027A4000042435E0062322F00
>                      IE: Unknown: 0B05020012127A
>                      IE: Unknown: 4A0E14000A002C01C800140005001900
>                      IE: Unknown: 7F0101
>                      IE: Unknown: DD07000C4307000000
>                      IE: Unknown: 0706465220010D10
>                      IE: Unknown: 
> DD1E00904C337E1117FF000000010000000000000000000000000C0000000000
>                      IE: Unknown: 
> DD1A00904C3406070500000000000000000000000000000000000000
> 
> Regards,
> Andrej Gelenberg
> 
> On 12/11/2011 07:23 PM, wwguy wrote:
> > On Sun, 2011-12-11 at 08:58 -0800, Andrej Gelenberg wrote:
> >> Hi,
> >>
> >> this is pretty mean regression for the stable kernel. You may the fix
> >> only for cards, which need it and not for all of them.
> >
> > Could you elaborate more on the failure case and setup. this patch is to
> > address HT40 related problem which cause the iwlwifi firmware crash.
> >
> > Thanks
> > Wey
> >>>
> >
> >
> 


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

From 88a9409dbe93193d28e2fde6525e98c84a0ce115 Mon Sep 17 00:00:00 2001
From: Andrej Gelenberg <andrej.gelenberg@udo.edu>
Date: Sun, 11 Dec 2011 17:21:38 +0100
Subject: [PATCH] Revert "iwlwifi: do not re-configure HT40 after associated"

This reverts commit 34a5b4b6af104cf18eb50748509528b9bdbc4036.
It break wlan driver on my Thinkpad t510. I can connect to the network
and i get ip from dhcpcd, but no ping or tcp connection can be
established.

lspci:
03:00.0 Network controller: Intel Corporation Centrino Ultimate-N 6300
(rev 35)

dmesg:
[    3.697288] iwlagn 0000:03:00.0: PCI INT A -> GSI 17 (level, low) ->
IRQ 17
[    3.697841] iwlagn 0000:03:00.0: setting latency timer to 64
[    3.697873] iwlagn 0000:03:00.0: pci_resource_len = 0x00002000
[    3.698389] iwlagn 0000:03:00.0: pci_resource_base = ffffc90010084000
[    3.698954] iwlagn 0000:03:00.0: HW Revision ID = 0x35
[    3.699629] iwlagn 0000:03:00.0: irq 43 for MSI/MSI-X
[    3.699705] iwlagn 0000:03:00.0: Detected Intel(R) Centrino(R)
Ultimate-N 6300 AGN, REV=0x74
[    3.700181] iwlagn 0000:03:00.0: L1 Enabled; Disabling L0S
[    3.717265] iwlagn 0000:03:00.0: device EEPROM VER=0x436, CALIB=0x6
[    3.717461] iwlagn 0000:03:00.0: Device SKU: 0X1f0
[    3.717984] iwlagn 0000:03:00.0: Valid Tx ant: 0X7, Valid Rx ant: 0X7
[    3.718531] iwlagn 0000:03:00.0: Tunable channels: 13 802.11bg, 24
802.11a channels
[    3.719141] iwlagn 0000:03:00.0: loaded firmware version 9.221.4.1
build 25532
...
[   71.965289] iwlagn 0000:03:00.0: L1 Enabled; Disabling L0S
[   71.972290] iwlagn 0000:03:00.0: Radio type=0x0-0x3-0x1
[   72.213804] iwlagn 0000:03:00.0: L1 Enabled; Disabling L0S
[   72.220770] iwlagn 0000:03:00.0: Radio type=0x0-0x3-0x1

Signed-off-by: Andrej Gelenberg <andrej.gelenberg@udo.edu>
---
 drivers/net/wireless/iwlwifi/iwl-agn-rxon.c |   36 +++++++++-----------------
 drivers/net/wireless/iwlwifi/iwl-agn.c      |   18 +++++++++++--
 drivers/net/wireless/iwlwifi/iwl-agn.h      |    2 -
 3 files changed, 28 insertions(+), 28 deletions(-)

diff --git a/drivers/net/wireless/iwlwifi/iwl-agn-rxon.c b/drivers/net/wireless/iwlwifi/iwl-agn-rxon.c
index a7a6def..58a381c 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn-rxon.c
+++ b/drivers/net/wireless/iwlwifi/iwl-agn-rxon.c
@@ -528,24 +528,6 @@  int iwlagn_commit_rxon(struct iwl_priv *priv, struct iwl_rxon_context *ctx)
 	return 0;
 }
 
-void iwlagn_config_ht40(struct ieee80211_conf *conf,
-	struct iwl_rxon_context *ctx)
-{
-	if (conf_is_ht40_minus(conf)) {
-		ctx->ht.extension_chan_offset =
-			IEEE80211_HT_PARAM_CHA_SEC_BELOW;
-		ctx->ht.is_40mhz = true;
-	} else if (conf_is_ht40_plus(conf)) {
-		ctx->ht.extension_chan_offset =
-			IEEE80211_HT_PARAM_CHA_SEC_ABOVE;
-		ctx->ht.is_40mhz = true;
-	} else {
-		ctx->ht.extension_chan_offset =
-			IEEE80211_HT_PARAM_CHA_SEC_NONE;
-		ctx->ht.is_40mhz = false;
-	}
-}
-
 int iwlagn_mac_config(struct ieee80211_hw *hw, u32 changed)
 {
 	struct iwl_priv *priv = hw->priv;
@@ -604,11 +586,19 @@  int iwlagn_mac_config(struct ieee80211_hw *hw, u32 changed)
 				ctx->ht.enabled = conf_is_ht(conf);
 
 			if (ctx->ht.enabled) {
-				/* if HT40 is used, it should not change
-				 * after associated except channel switch */
-				if (iwl_is_associated_ctx(ctx) &&
-				     !ctx->ht.is_40mhz)
-					iwlagn_config_ht40(conf, ctx);
+				if (conf_is_ht40_minus(conf)) {
+					ctx->ht.extension_chan_offset =
+						IEEE80211_HT_PARAM_CHA_SEC_BELOW;
+					ctx->ht.is_40mhz = true;
+				} else if (conf_is_ht40_plus(conf)) {
+					ctx->ht.extension_chan_offset =
+						IEEE80211_HT_PARAM_CHA_SEC_ABOVE;
+					ctx->ht.is_40mhz = true;
+				} else {
+					ctx->ht.extension_chan_offset =
+						IEEE80211_HT_PARAM_CHA_SEC_NONE;
+					ctx->ht.is_40mhz = false;
+				}
 			} else
 				ctx->ht.is_40mhz = false;
 
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn.c b/drivers/net/wireless/iwlwifi/iwl-agn.c
index bacc06c..3a5e802 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn.c
+++ b/drivers/net/wireless/iwlwifi/iwl-agn.c
@@ -2610,9 +2610,21 @@  static void iwlagn_mac_channel_switch(struct ieee80211_hw *hw,
 
 	/* Configure HT40 channels */
 	ctx->ht.enabled = conf_is_ht(conf);
-	if (ctx->ht.enabled)
-		iwlagn_config_ht40(conf, ctx);
-	else
+	if (ctx->ht.enabled) {
+		if (conf_is_ht40_minus(conf)) {
+			ctx->ht.extension_chan_offset =
+				IEEE80211_HT_PARAM_CHA_SEC_BELOW;
+			ctx->ht.is_40mhz = true;
+		} else if (conf_is_ht40_plus(conf)) {
+			ctx->ht.extension_chan_offset =
+				IEEE80211_HT_PARAM_CHA_SEC_ABOVE;
+			ctx->ht.is_40mhz = true;
+		} else {
+			ctx->ht.extension_chan_offset =
+				IEEE80211_HT_PARAM_CHA_SEC_NONE;
+			ctx->ht.is_40mhz = false;
+		}
+	} else
 		ctx->ht.is_40mhz = false;
 
 	if ((le16_to_cpu(ctx->staging.channel) != ch))
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn.h b/drivers/net/wireless/iwlwifi/iwl-agn.h
index 3856aba..5b936ec 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn.h
+++ b/drivers/net/wireless/iwlwifi/iwl-agn.h
@@ -86,8 +86,6 @@  void iwlagn_bss_info_changed(struct ieee80211_hw *hw,
 			     struct ieee80211_vif *vif,
 			     struct ieee80211_bss_conf *bss_conf,
 			     u32 changes);
-void iwlagn_config_ht40(struct ieee80211_conf *conf,
-			struct iwl_rxon_context *ctx);
 
 /* uCode */
 int iwlagn_rx_calib_result(struct iwl_priv *priv,
-- 
1.7.8