mbox series

[SRU,J:linux-bluefield,0/1] UBUNTU: SAUCE: mlxbf-ptm: power and thermal management debugfs driver

Message ID cover.1673881613.git.jlanka@nvidia.com
Headers show
Series UBUNTU: SAUCE: mlxbf-ptm: power and thermal management debugfs driver | expand

Message

Jitendra Lanka Jan. 16, 2023, 3:12 p.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/2002852

SRU Justification:

[Impact]

mlxbf-ptm is a kernel driver that provides debufgs interface for system software to monitor Bluefield devices' power and thermal management parameters.

[Fix]

* New driver added

[Test Case]

* After installing the kernel module, debugfs entry at /sys/kernel/debug/mlxbf-ptm will be created
* monitors/status folder contains read-only parameters reported from the Bluefield device

[Regression Potential]

* Minimal - as these are read-only parameters that report Bluefield device information.

[Other]
* This code is likely to change depending on feedback we received from maintainers.

Jitendra Lanka (1):
  mlxbf-ptm: power and thermal management debugfs driver

 debian.bluefield/config/config.common.ubuntu |   1 +
 drivers/platform/mellanox/Kconfig            |  10 +
 drivers/platform/mellanox/Makefile           |   1 +
 drivers/platform/mellanox/mlxbf-ptm.c        | 215 +++++++++++++++++++
 4 files changed, 227 insertions(+)
 create mode 100644 drivers/platform/mellanox/mlxbf-ptm.c

Comments

Tim Gardner Jan. 16, 2023, 3:55 p.m. UTC | #1 
On 1/16/23 8:12 AM, Jitendra Lanka wrote:
> BugLink: https://bugs.launchpad.net/bugs/2002852
> 
> SRU Justification:
> 
> [Impact]
> 
> mlxbf-ptm is a kernel driver that provides debufgs interface for system software to monitor Bluefield devices' power and thermal management parameters.
> 
> [Fix]
> 
> * New driver added
> 
> [Test Case]
> 
> * After installing the kernel module, debugfs entry at /sys/kernel/debug/mlxbf-ptm will be created
> * monitors/status folder contains read-only parameters reported from the Bluefield device
> 
> [Regression Potential]
> 
> * Minimal - as these are read-only parameters that report Bluefield device information.
> 
> [Other]
> * This code is likely to change depending on feedback we received from maintainers.
> 
> Jitendra Lanka (1):
>    mlxbf-ptm: power and thermal management debugfs driver
> 
>   debian.bluefield/config/config.common.ubuntu |   1 +
>   drivers/platform/mellanox/Kconfig            |  10 +
>   drivers/platform/mellanox/Makefile           |   1 +
>   drivers/platform/mellanox/mlxbf-ptm.c        | 215 +++++++++++++++++++
>   4 files changed, 227 insertions(+)
>   create mode 100644 drivers/platform/mellanox/mlxbf-ptm.c
> 
Acked-by: Tim Gardner <tim.gardner@canonical.com>

I suggest dropping 'Change-Id: 
I241e1406962548cef9b33c4b3dea925e675c3c88' when applying the patch.

You should run scripts/checkpatch.pl on your patches. You'll see that 
this one generates quite a few complaints (though I don't agree with 
it's suggestion that you use 0444 instead of S_IRUGO).

--
-----------
Tim Gardner
Canonical, Inc
Bartlomiej Zolnierkiewicz Jan. 18, 2023, 6:12 p.m. UTC | #2 
Acked-by: Bartlomiej Zolnierkiewicz <bartlomiej.zolnierkiewicz@canonical.com>

On Mon, Jan 16, 2023 at 4:13 PM Jitendra Lanka <jlanka@nvidia.com> wrote:
>
> BugLink: https://bugs.launchpad.net/bugs/2002852
>
> SRU Justification:
>
> [Impact]
>
> mlxbf-ptm is a kernel driver that provides debufgs interface for system software to monitor Bluefield devices' power and thermal management parameters.
>
> [Fix]
>
> * New driver added
>
> [Test Case]
>
> * After installing the kernel module, debugfs entry at /sys/kernel/debug/mlxbf-ptm will be created
> * monitors/status folder contains read-only parameters reported from the Bluefield device
>
> [Regression Potential]
>
> * Minimal - as these are read-only parameters that report Bluefield device information.
>
> [Other]
> * This code is likely to change depending on feedback we received from maintainers.
>
> Jitendra Lanka (1):
>   mlxbf-ptm: power and thermal management debugfs driver
>
>  debian.bluefield/config/config.common.ubuntu |   1 +
>  drivers/platform/mellanox/Kconfig            |  10 +
>  drivers/platform/mellanox/Makefile           |   1 +
>  drivers/platform/mellanox/mlxbf-ptm.c        | 215 +++++++++++++++++++
>  4 files changed, 227 insertions(+)
>  create mode 100644 drivers/platform/mellanox/mlxbf-ptm.c
>
Bartlomiej Zolnierkiewicz Jan. 18, 2023, 6:14 p.m. UTC | #3 
Applied to jammy:linux-bluefield/master-next. Thanks.

--
Best regards,
Bartlomiej

On Mon, Jan 16, 2023 at 4:13 PM Jitendra Lanka <jlanka@nvidia.com> wrote:
>
> BugLink: https://bugs.launchpad.net/bugs/2002852
>
> SRU Justification:
>
> [Impact]
>
> mlxbf-ptm is a kernel driver that provides debufgs interface for system software to monitor Bluefield devices' power and thermal management parameters.
>
> [Fix]
>
> * New driver added
>
> [Test Case]
>
> * After installing the kernel module, debugfs entry at /sys/kernel/debug/mlxbf-ptm will be created
> * monitors/status folder contains read-only parameters reported from the Bluefield device
>
> [Regression Potential]
>
> * Minimal - as these are read-only parameters that report Bluefield device information.
>
> [Other]
> * This code is likely to change depending on feedback we received from maintainers.
>
> Jitendra Lanka (1):
>   mlxbf-ptm: power and thermal management debugfs driver
>
>  debian.bluefield/config/config.common.ubuntu |   1 +
>  drivers/platform/mellanox/Kconfig            |  10 +
>  drivers/platform/mellanox/Makefile           |   1 +
>  drivers/platform/mellanox/mlxbf-ptm.c        | 215 +++++++++++++++++++
>  4 files changed, 227 insertions(+)
>  create mode 100644 drivers/platform/mellanox/mlxbf-ptm.c
>