| Message ID | 20230116003606.11998-1-warthog618@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [libgpiod] bindings: rust: fix documentation of line_request set_values | expand |
On Mon, Jan 16, 2023 at 1:36 AM Kent Gibson <warthog618@gmail.com> wrote: > > Replace "Get" with "Set". > > Signed-off-by: Kent Gibson <warthog618@gmail.com> > --- > bindings/rust/libgpiod/src/line_request.rs | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/bindings/rust/libgpiod/src/line_request.rs b/bindings/rust/libgpiod/src/line_request.rs > index 2816cc1..35f07b3 100644 > --- a/bindings/rust/libgpiod/src/line_request.rs > +++ b/bindings/rust/libgpiod/src/line_request.rs > @@ -106,7 +106,7 @@ impl Request { > } > } > > - /// Get values of a subset of lines associated with the request. > + /// Set values of a subset of lines associated with the request. > pub fn set_values_subset(&self, map: ValueMap) -> Result<()> { > let mut offsets = Vec::new(); > let mut values = Vec::new(); > @@ -136,7 +136,7 @@ impl Request { > } > } > > - /// Get values of all lines associated with the request. > + /// Set values of all lines associated with the request. > pub fn set_values(&self, values: &[Value]) -> Result<()> { > if values.len() != self.num_lines() { > return Err(Error::InvalidArguments); > -- > 2.39.0 > What commit is this patch's parent? It doesn't apply on top of master. Bart
On Mon, Jan 16, 2023 at 10:05:43AM +0100, Bartosz Golaszewski wrote: > On Mon, Jan 16, 2023 at 1:36 AM Kent Gibson <warthog618@gmail.com> wrote: > > > > Replace "Get" with "Set". > > > > Signed-off-by: Kent Gibson <warthog618@gmail.com> > > --- > > bindings/rust/libgpiod/src/line_request.rs | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/bindings/rust/libgpiod/src/line_request.rs b/bindings/rust/libgpiod/src/line_request.rs > > index 2816cc1..35f07b3 100644 > > --- a/bindings/rust/libgpiod/src/line_request.rs > > +++ b/bindings/rust/libgpiod/src/line_request.rs > > @@ -106,7 +106,7 @@ impl Request { > > } > > } > > > > - /// Get values of a subset of lines associated with the request. > > + /// Set values of a subset of lines associated with the request. > > pub fn set_values_subset(&self, map: ValueMap) -> Result<()> { > > let mut offsets = Vec::new(); > > let mut values = Vec::new(); > > @@ -136,7 +136,7 @@ impl Request { > > } > > } > > > > - /// Get values of all lines associated with the request. > > + /// Set values of all lines associated with the request. > > pub fn set_values(&self, values: &[Value]) -> Result<()> { > > if values.len() != self.num_lines() { > > return Err(Error::InvalidArguments); > > -- > > 2.39.0 > > > > What commit is this patch's parent? It doesn't apply on top of master. > My bad - I've got a commit in there where I was playing with fixing the clippy warnings from rust 1.66 (I suspect they are false positives so haven't submitted a patch). I'll rebase and resubmit. Cheers, Kent.
diff --git a/bindings/rust/libgpiod/src/line_request.rs b/bindings/rust/libgpiod/src/line_request.rs index 2816cc1..35f07b3 100644 --- a/bindings/rust/libgpiod/src/line_request.rs +++ b/bindings/rust/libgpiod/src/line_request.rs @@ -106,7 +106,7 @@ impl Request { } } - /// Get values of a subset of lines associated with the request. + /// Set values of a subset of lines associated with the request. pub fn set_values_subset(&self, map: ValueMap) -> Result<()> { let mut offsets = Vec::new(); let mut values = Vec::new(); @@ -136,7 +136,7 @@ impl Request { } } - /// Get values of all lines associated with the request. + /// Set values of all lines associated with the request. pub fn set_values(&self, values: &[Value]) -> Result<()> { if values.len() != self.num_lines() { return Err(Error::InvalidArguments);
Replace "Get" with "Set". Signed-off-by: Kent Gibson <warthog618@gmail.com> --- bindings/rust/libgpiod/src/line_request.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)