| Message ID | 20230113084033.256973-1-juerg.haefliger@canonical.com |
|---|---|
| Headers | show |
| Series | Fix debug package builds | expand |
On Fri, Jan 13, 2023 at 09:40:30AM +0100, Juerg Haefliger wrote: > Currently, debug packages are only built when doing a 'full build'. > A 'full build' is performed if the file /CurrentlyBuilding is present, > which indicates that we're building in a PPA. So far, so good. However, > PPAs have a configuration option 'Build debug symbols' and if that option > is unset, we simply remove the debug package names from debian/files so > they don't get published. > > It seems wrong to even build the packages in this case. > > The first patch fixes that. The second patch is just a simplification that > drops an unnecessary if-then, and the third patch removes variables that > are no longer needed due to patch 1. Already applied via pull request. -Andrea
Superseded by a PR. ...juerg > Currently, debug packages are only built when doing a 'full build'. > A 'full build' is performed if the file /CurrentlyBuilding is present, > which indicates that we're building in a PPA. So far, so good. However, > PPAs have a configuration option 'Build debug symbols' and if that option > is unset, we simply remove the debug package names from debian/files so > they don't get published. > > It seems wrong to even build the packages in this case. > > The first patch fixes that. The second patch is just a simplification that > drops an unnecessary if-then, and the third patch removes variables that > are no longer needed due to patch 1. > > Juerg Haefliger (3): > UBUNTU: [Packaging] debian/rules: Fix PPA debug package builds > UBUNTU: [Packaging] debian/rules: Remove debug package install > directory earlier > UBUNTU: [Packaging] debian/rules: Remove unnecessary 'lockme_<foo>' > variables > > debian/rules.d/0-common-vars.mk | 9 ++++++--- > debian/rules.d/2-binary-arch.mk | 19 ++++--------------- > 2 files changed, 10 insertions(+), 18 deletions(-) >
Currently, debug packages are only built when doing a 'full build'. A 'full build' is performed if the file /CurrentlyBuilding is present, which indicates that we're building in a PPA. So far, so good. However, PPAs have a configuration option 'Build debug symbols' and if that option is unset, we simply remove the debug package names from debian/files so they don't get published. It seems wrong to even build the packages in this case. The first patch fixes that. The second patch is just a simplification that drops an unnecessary if-then, and the third patch removes variables that are no longer needed due to patch 1. Juerg Haefliger (3): UBUNTU: [Packaging] debian/rules: Fix PPA debug package builds UBUNTU: [Packaging] debian/rules: Remove debug package install directory earlier UBUNTU: [Packaging] debian/rules: Remove unnecessary 'lockme_<foo>' variables debian/rules.d/0-common-vars.mk | 9 ++++++--- debian/rules.d/2-binary-arch.mk | 19 ++++--------------- 2 files changed, 10 insertions(+), 18 deletions(-)