| Message ID | 20230110123004.3765851-1-jorge@foundries.io |
|---|---|
| State | Superseded |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | firmware: ti_sci: fix typo in boot authentication message name | expand |
On Tue, Jan 10, 2023 at 2:30 PM Jorge Ramirez-Ortiz <jorge@foundries.io> wrote: > > Fix AUTH_BOOT message identifier (s/IMIAGE/IMAGE) > > Signed-off-by: Jorge Ramirez-Ortiz <jorge@foundries.io> Reviewed-by: Oleksandr Suvorov <oleksandr.suvorov@foundries.io> > --- > drivers/firmware/ti_sci.c | 2 +- > drivers/firmware/ti_sci.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c > index 727e090e8a..bd7379ae55 100644 > --- a/drivers/firmware/ti_sci.c > +++ b/drivers/firmware/ti_sci.c > @@ -1935,7 +1935,7 @@ static int ti_sci_cmd_proc_auth_boot_image(const struct ti_sci_handle *handle, > > info = handle_to_ti_sci_info(handle); > > - xfer = ti_sci_setup_one_xfer(info, TISCI_MSG_PROC_AUTH_BOOT_IMIAGE, > + xfer = ti_sci_setup_one_xfer(info, TISCI_MSG_PROC_AUTH_BOOT_IMAGE, > TI_SCI_FLAG_REQ_ACK_ON_PROCESSED, > (u32 *)&req, sizeof(req), sizeof(*resp)); > if (IS_ERR(xfer)) { > diff --git a/drivers/firmware/ti_sci.h b/drivers/firmware/ti_sci.h > index e4a087c2ba..101210eb21 100644 > --- a/drivers/firmware/ti_sci.h > +++ b/drivers/firmware/ti_sci.h > @@ -49,7 +49,7 @@ > #define TISCI_MSG_PROC_HANDOVER 0xc005 > #define TISCI_MSG_SET_PROC_BOOT_CONFIG 0xc100 > #define TISCI_MSG_SET_PROC_BOOT_CTRL 0xc101 > -#define TISCI_MSG_PROC_AUTH_BOOT_IMIAGE 0xc120 > +#define TISCI_MSG_PROC_AUTH_BOOT_IMAGE 0xc120 > #define TISCI_MSG_GET_PROC_BOOT_STATUS 0xc400 > #define TISCI_MSG_WAIT_PROC_BOOT_STATUS 0xc401 > > -- > 2.34.1 > -- Best regards Oleksandr Oleksandr Suvorov cryosay@gmail.com
On 1/10/23 6:30 AM, Jorge Ramirez-Ortiz wrote: > Fix AUTH_BOOT message identifier (s/IMIAGE/IMAGE) > > Signed-off-by: Jorge Ramirez-Ortiz <jorge@foundries.io> > --- Looks like this typo got copy/pasted over to ATF also[0].. I'll add your reported-by and go fix it over there (unless you are wanting to do that). Acked-by: Andrew Davis <afd@ti.com> [0] https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git/tree/plat/ti/k3/common/drivers/ti_sci/ti_sci_protocol.h#n50 > drivers/firmware/ti_sci.c | 2 +- > drivers/firmware/ti_sci.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c > index 727e090e8a..bd7379ae55 100644 > --- a/drivers/firmware/ti_sci.c > +++ b/drivers/firmware/ti_sci.c > @@ -1935,7 +1935,7 @@ static int ti_sci_cmd_proc_auth_boot_image(const struct ti_sci_handle *handle, > > info = handle_to_ti_sci_info(handle); > > - xfer = ti_sci_setup_one_xfer(info, TISCI_MSG_PROC_AUTH_BOOT_IMIAGE, > + xfer = ti_sci_setup_one_xfer(info, TISCI_MSG_PROC_AUTH_BOOT_IMAGE, > TI_SCI_FLAG_REQ_ACK_ON_PROCESSED, > (u32 *)&req, sizeof(req), sizeof(*resp)); > if (IS_ERR(xfer)) { > diff --git a/drivers/firmware/ti_sci.h b/drivers/firmware/ti_sci.h > index e4a087c2ba..101210eb21 100644 > --- a/drivers/firmware/ti_sci.h > +++ b/drivers/firmware/ti_sci.h > @@ -49,7 +49,7 @@ > #define TISCI_MSG_PROC_HANDOVER 0xc005 > #define TISCI_MSG_SET_PROC_BOOT_CONFIG 0xc100 > #define TISCI_MSG_SET_PROC_BOOT_CTRL 0xc101 > -#define TISCI_MSG_PROC_AUTH_BOOT_IMIAGE 0xc120 > +#define TISCI_MSG_PROC_AUTH_BOOT_IMAGE 0xc120 > #define TISCI_MSG_GET_PROC_BOOT_STATUS 0xc400 > #define TISCI_MSG_WAIT_PROC_BOOT_STATUS 0xc401 >
On 10/01/23, Andrew Davis wrote: > On 1/10/23 6:30 AM, Jorge Ramirez-Ortiz wrote: > > Fix AUTH_BOOT message identifier (s/IMIAGE/IMAGE) > > > > Signed-off-by: Jorge Ramirez-Ortiz <jorge@foundries.io> > > --- > > Looks like this typo got copy/pasted over to ATF also[0].. > I'll add your reported-by and go fix it over there > (unless you are wanting to do that). no no, please do. I was just reading code for secure boot and this typo was annoying me for some reason (go figure..) thanks! > > Acked-by: Andrew Davis <afd@ti.com> > > [0] https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git/tree/plat/ti/k3/common/drivers/ti_sci/ti_sci_protocol.h#n50 > > > drivers/firmware/ti_sci.c | 2 +- > > drivers/firmware/ti_sci.h | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c > > index 727e090e8a..bd7379ae55 100644 > > --- a/drivers/firmware/ti_sci.c > > +++ b/drivers/firmware/ti_sci.c > > @@ -1935,7 +1935,7 @@ static int ti_sci_cmd_proc_auth_boot_image(const struct ti_sci_handle *handle, > > info = handle_to_ti_sci_info(handle); > > - xfer = ti_sci_setup_one_xfer(info, TISCI_MSG_PROC_AUTH_BOOT_IMIAGE, > > + xfer = ti_sci_setup_one_xfer(info, TISCI_MSG_PROC_AUTH_BOOT_IMAGE, > > TI_SCI_FLAG_REQ_ACK_ON_PROCESSED, > > (u32 *)&req, sizeof(req), sizeof(*resp)); > > if (IS_ERR(xfer)) { > > diff --git a/drivers/firmware/ti_sci.h b/drivers/firmware/ti_sci.h > > index e4a087c2ba..101210eb21 100644 > > --- a/drivers/firmware/ti_sci.h > > +++ b/drivers/firmware/ti_sci.h > > @@ -49,7 +49,7 @@ > > #define TISCI_MSG_PROC_HANDOVER 0xc005 > > #define TISCI_MSG_SET_PROC_BOOT_CONFIG 0xc100 > > #define TISCI_MSG_SET_PROC_BOOT_CTRL 0xc101 > > -#define TISCI_MSG_PROC_AUTH_BOOT_IMIAGE 0xc120 > > +#define TISCI_MSG_PROC_AUTH_BOOT_IMAGE 0xc120 > > #define TISCI_MSG_GET_PROC_BOOT_STATUS 0xc400 > > #define TISCI_MSG_WAIT_PROC_BOOT_STATUS 0xc401
diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c index 727e090e8a..bd7379ae55 100644 --- a/drivers/firmware/ti_sci.c +++ b/drivers/firmware/ti_sci.c @@ -1935,7 +1935,7 @@ static int ti_sci_cmd_proc_auth_boot_image(const struct ti_sci_handle *handle, info = handle_to_ti_sci_info(handle); - xfer = ti_sci_setup_one_xfer(info, TISCI_MSG_PROC_AUTH_BOOT_IMIAGE, + xfer = ti_sci_setup_one_xfer(info, TISCI_MSG_PROC_AUTH_BOOT_IMAGE, TI_SCI_FLAG_REQ_ACK_ON_PROCESSED, (u32 *)&req, sizeof(req), sizeof(*resp)); if (IS_ERR(xfer)) { diff --git a/drivers/firmware/ti_sci.h b/drivers/firmware/ti_sci.h index e4a087c2ba..101210eb21 100644 --- a/drivers/firmware/ti_sci.h +++ b/drivers/firmware/ti_sci.h @@ -49,7 +49,7 @@ #define TISCI_MSG_PROC_HANDOVER 0xc005 #define TISCI_MSG_SET_PROC_BOOT_CONFIG 0xc100 #define TISCI_MSG_SET_PROC_BOOT_CTRL 0xc101 -#define TISCI_MSG_PROC_AUTH_BOOT_IMIAGE 0xc120 +#define TISCI_MSG_PROC_AUTH_BOOT_IMAGE 0xc120 #define TISCI_MSG_GET_PROC_BOOT_STATUS 0xc400 #define TISCI_MSG_WAIT_PROC_BOOT_STATUS 0xc401
Fix AUTH_BOOT message identifier (s/IMIAGE/IMAGE) Signed-off-by: Jorge Ramirez-Ortiz <jorge@foundries.io> --- drivers/firmware/ti_sci.c | 2 +- drivers/firmware/ti_sci.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)