diff mbox series

package/qemu: allow building only the tools

Message ID 20221231201700.3105911-1-unixmania@gmail.com
State Accepted
Headers show
Series package/qemu: allow building only the tools | expand

Commit Message

Carlos Santos Dec. 31, 2022, 8:17 p.m. UTC
From: Carlos Santos <unixmania@gmail.com>

Commit 44be514b21fd94096702b80c62d46c31d72f15a5 mistakenly forced to
always build at least user or system emulation but it must be possible
to choose only the tools (e.g. for a guest VM image).

Signed-off-by: Carlos Santos <unixmania@gmail.com>
---
 package/qemu/Config.in | 1 -
 1 file changed, 1 deletion(-)

Comments

Yann E. MORIN Jan. 1, 2023, 8:57 a.m. UTC | #1
On 2022-12-31 17:17 -0300, unixmania@gmail.com spake thusly:
> From: Carlos Santos <unixmania@gmail.com>
> 
> Commit 44be514b21fd94096702b80c62d46c31d72f15a5 mistakenly forced to
> always build at least user or system emulation but it must be possible
> to choose only the tools (e.g. for a guest VM image).
> 
> Signed-off-by: Carlos Santos <unixmania@gmail.com>
> ---
>  package/qemu/Config.in | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/package/qemu/Config.in b/package/qemu/Config.in
> index 0f9e353510..435e92781c 100644
> --- a/package/qemu/Config.in
> +++ b/package/qemu/Config.in
> @@ -27,7 +27,6 @@ menuconfig BR2_PACKAGE_QEMU
>  	select BR2_PACKAGE_LIBGLIB2
>  	select BR2_PACKAGE_PIXMAN
>  	select BR2_PACKAGE_ZLIB
> -	select BR2_PACKAGE_QEMU_SYSTEM if !BR2_PACKAGE_QEMU_LINUX_USER

But then, we're back to a situation where we can have qemu enabled, but
we're building neither the the system nor user emulation, nor the tools,
which does not make sense.

So, I've changed that to force the tools if neither system nor user
emulation is enabled.

Applied to master, thanks.

Note: in fact, even with all disabled, qemu still installs its binary
blobs, which does not make much sense, so that does not count. Also, I
was pretty sure we had an option for that, but it turns out that my
commit [0] did not make it when I initially worked on this, 10 years
ago [1]... Funny how memory can be flaky. :-) And of course, the option
has changed since then. Sigh... I guess I'll have to respin this...

[0] https://gitlab.com/ymorin/buildroot/-/commit/1b87393f67d7fad5dcd1e2390e4f65cd2d865cab
[1] https://lore.kernel.org/buildroot/?q=s%3A%22add+option+to+not+install+blobs%22

Regards,
Yann E. MORIN.

>  	help
>  	  QEMU is a generic and open source machine emulator and
>  	  virtualizer.
> -- 
> 2.31.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
diff mbox series

Patch

diff --git a/package/qemu/Config.in b/package/qemu/Config.in
index 0f9e353510..435e92781c 100644
--- a/package/qemu/Config.in
+++ b/package/qemu/Config.in
@@ -27,7 +27,6 @@  menuconfig BR2_PACKAGE_QEMU
 	select BR2_PACKAGE_LIBGLIB2
 	select BR2_PACKAGE_PIXMAN
 	select BR2_PACKAGE_ZLIB
-	select BR2_PACKAGE_QEMU_SYSTEM if !BR2_PACKAGE_QEMU_LINUX_USER
 	help
 	  QEMU is a generic and open source machine emulator and
 	  virtualizer.