mbox series

[0/2,SRU,OEM-6.1] Enable CCCI driver Modem Logging (MDL) Port

Message ID 20221212075024.3165087-1-vicamo.yang@canonical.com
Headers show
Series Enable CCCI driver Modem Logging (MDL) Port | expand

Message

You-Sheng Yang Dec. 12, 2022, 7:50 a.m. UTC 
From: "You-Sheng Yang (vicamo)" <vicamo.yang@canonical.com>

BugLink: https://bugs.launchpad.net/bugs/1997686

[Impact]

Missed Modem Logging support.

[Fix]

Two upstream commits currently in linux-next for maybe v6.2.

[Test Case]

With corresponding libmbim fix in
https://gitlab.freedesktop.org/mobile-broadband/libmbim/-/merge_requests/161,

  $ mbimcli -d <dev-path> query-trace-config

[Where problems could occur]

This adds an logging channel that is only compiled when WWAN_DEBUGFS is
on, and takes a specific command to enable logging. Should be no harm in
general, and might have side-effects when turned on.

[Other Info]

This is not yet available in mainline kernel but in linux-next, so
OEM-6.0 and above are all nominated for fix. Unstable/Lunar/OEM-6.0 have
been nominated in a previous thread.

M Chetan Kumar (2):
  net: wwan: t7xx: use union to group port type specific data
  net: wwan: t7xx: Add port for modem logging

 drivers/net/wwan/Kconfig                |   1 +
 drivers/net/wwan/t7xx/Makefile          |   3 +
 drivers/net/wwan/t7xx/t7xx_hif_cldma.c  |   2 +
 drivers/net/wwan/t7xx/t7xx_pci.h        |   3 +
 drivers/net/wwan/t7xx/t7xx_port.h       |   9 +-
 drivers/net/wwan/t7xx/t7xx_port_proxy.c |  12 +++
 drivers/net/wwan/t7xx/t7xx_port_proxy.h |   4 +
 drivers/net/wwan/t7xx/t7xx_port_trace.c | 116 ++++++++++++++++++++++++
 drivers/net/wwan/t7xx/t7xx_port_wwan.c  |  16 ++--
 9 files changed, 157 insertions(+), 9 deletions(-)
 create mode 100644 drivers/net/wwan/t7xx/t7xx_port_trace.c

Comments

Timo Aaltonen Dec. 13, 2022, 2:27 p.m. UTC | #1 
You-Sheng Yang kirjoitti 12.12.2022 klo 9.50:
> From: "You-Sheng Yang (vicamo)" <vicamo.yang@canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1997686
> 
> [Impact]
> 
> Missed Modem Logging support.
> 
> [Fix]
> 
> Two upstream commits currently in linux-next for maybe v6.2.
> 
> [Test Case]
> 
> With corresponding libmbim fix in
> https://gitlab.freedesktop.org/mobile-broadband/libmbim/-/merge_requests/161,
> 
>    $ mbimcli -d <dev-path> query-trace-config
> 
> [Where problems could occur]
> 
> This adds an logging channel that is only compiled when WWAN_DEBUGFS is
> on, and takes a specific command to enable logging. Should be no harm in
> general, and might have side-effects when turned on.
> 
> [Other Info]
> 
> This is not yet available in mainline kernel but in linux-next, so
> OEM-6.0 and above are all nominated for fix. Unstable/Lunar/OEM-6.0 have
> been nominated in a previous thread.
> 
> M Chetan Kumar (2):
>    net: wwan: t7xx: use union to group port type specific data
>    net: wwan: t7xx: Add port for modem logging
> 
>   drivers/net/wwan/Kconfig                |   1 +
>   drivers/net/wwan/t7xx/Makefile          |   3 +
>   drivers/net/wwan/t7xx/t7xx_hif_cldma.c  |   2 +
>   drivers/net/wwan/t7xx/t7xx_pci.h        |   3 +
>   drivers/net/wwan/t7xx/t7xx_port.h       |   9 +-
>   drivers/net/wwan/t7xx/t7xx_port_proxy.c |  12 +++
>   drivers/net/wwan/t7xx/t7xx_port_proxy.h |   4 +
>   drivers/net/wwan/t7xx/t7xx_port_trace.c | 116 ++++++++++++++++++++++++
>   drivers/net/wwan/t7xx/t7xx_port_wwan.c  |  16 ++--
>   9 files changed, 157 insertions(+), 9 deletions(-)
>   create mode 100644 drivers/net/wwan/t7xx/t7xx_port_trace.c
> 

applied to oem-6.1, thanks