mbox series

[0/1,SRU,Unstable/OEM-6.0/Kinectic] ALSA: hda/realtek: fix mute/micmute LEDs for a HP ProBook

Message ID 20221206071428.43774-1-andy.chi@canonical.com
Headers show
Series ALSA: hda/realtek: fix mute/micmute LEDs for a HP ProBook | expand

Message

Andy Chi Dec. 6, 2022, 7:14 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1998882

[Impact]
The mic mute/audio mute LEDS are not work on HP ProBook Notebook PC

[Fix]
It needs the specific quirk for the hardware layout.
Thus, add the quirks to make it works.

[Test]
After applying the quirk, the audio/mic mute LEDs are working good.

[Where problems could occur]
If HP ships the different system boards design with the same subsystem ID of audio codec which is using different GPIO pins (different layout), then the quirk will not work (LEDs will not work when muting audio-output or microphone).

Andy Chi (1):
  ALSA: hda/realtek: fix mute/micmute LEDs for a HP ProBook

 sound/pci/hda/patch_realtek.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Stefan Bader Dec. 6, 2022, 8:41 a.m. UTC | #1
On 06.12.22 08:14, Andy Chi wrote:
> BugLink: https://bugs.launchpad.net/bugs/1998882

Bug report is not completely filled in. No oem-6.0 task and no nominations for 
expected series.

> 
> [Impact]
> The mic mute/audio mute LEDS are not work on HP ProBook Notebook PC
> 
> [Fix]
> It needs the specific quirk for the hardware layout.
> Thus, add the quirks to make it works.

Were both variants test-built?

> 
> [Test]
> After applying the quirk, the audio/mic mute LEDs are working good.

Which kernel was tested?

Please update the bug report and provide missing information as a follow-up to 
this thread.

-Stefan

> 
> [Where problems could occur]
> If HP ships the different system boards design with the same subsystem ID of audio codec which is using different GPIO pins (different layout), then the quirk will not work (LEDs will not work when muting audio-output or microphone).
> 
> Andy Chi (1):
>    ALSA: hda/realtek: fix mute/micmute LEDs for a HP ProBook
> 
>   sound/pci/hda/patch_realtek.c | 2 ++
>   1 file changed, 2 insertions(+)
>
Stefan Bader Dec. 12, 2022, 10:16 a.m. UTC | #2
On 06.12.22 08:14, Andy Chi wrote:
> BugLink: https://bugs.launchpad.net/bugs/1998882
> 
> [Impact]
> The mic mute/audio mute LEDS are not work on HP ProBook Notebook PC
> 
> [Fix]
> It needs the specific quirk for the hardware layout.
> Thus, add the quirks to make it works.
> 
> [Test]
> After applying the quirk, the audio/mic mute LEDs are working good.
> 
> [Where problems could occur]
> If HP ships the different system boards design with the same subsystem ID of audio codec which is using different GPIO pins (different layout), then the quirk will not work (LEDs will not work when muting audio-output or microphone).
> 
> Andy Chi (1):
>    ALSA: hda/realtek: fix mute/micmute LEDs for a HP ProBook
> 
>   sound/pci/hda/patch_realtek.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
v2 on list