| Message ID | db876775-3e1b-172f-18e3-d593ef766832@ventanamicro.com |
|---|---|
| State | New |
| Headers | show |
| Series | [committed] Fix comment typos noticed by Bernhard | expand |
On Tue, Nov 22, 2022 at 3:25 PM Jeff Law <jlaw@ventanamicro.com> wrote: > > Minor comment typo fixes as noticed by Bernhard. > > > Installed onto the trunk, Hmm: - int alternative + int bool That seems wrong and might cause a build failure. Thanks, Andrew > > > Jeff > >
On 11/22/22 16:28, Andrew Pinski wrote: > On Tue, Nov 22, 2022 at 3:25 PM Jeff Law <jlaw@ventanamicro.com> wrote: >> Minor comment typo fixes as noticed by Bernhard. >> >> >> Installed onto the trunk, > Hmm: > - int alternative > + int bool > > That seems wrong and might cause a build failure. Ugh. Probably will. I'll double-check momentarily. That's what I get for scanning the stashed patch thinking it was just comment fixes and not bootstrapping. My bad entirely. jeff
On 11/22/22 16:28, Andrew Pinski wrote: > On Tue, Nov 22, 2022 at 3:25 PM Jeff Law <jlaw@ventanamicro.com> wrote: >> Minor comment typo fixes as noticed by Bernhard. >> >> >> Installed onto the trunk, > Hmm: > - int alternative > + int bool > > That seems wrong and might cause a build failure. Fixed thusly. jeff ps. I keep thinking that the workflow right now is fairly cumbersome moving things between the laptop and one of the servers I use. I could make an argument that a topic branch with a merge-request would be better. But we're not set up for that :( commit ee86077c2c2e38376cb5a575af62e9187c98e8df Author: Jeff Law <jlaw@ventanamicro.com> Date: Tue Nov 22 16:30:38 2022 -0700 Fix thinko in last patch gcc/ * tree-ssa-dom.cc (record_edge_info): Fix thinko in last commit. diff --git a/gcc/tree-ssa-dom.cc b/gcc/tree-ssa-dom.cc index e82f4f73a66..c9e52d1ee94 100644 --- a/gcc/tree-ssa-dom.cc +++ b/gcc/tree-ssa-dom.cc @@ -676,7 +676,7 @@ record_edge_info (basic_block bb) if it never traverses the backedge to begin with. This implies that any PHI nodes create equivalances that we can attach to the loop exit edge. */ - int bool + bool alternative = (EDGE_PRED (bb, 0)->flags & EDGE_DFS_BACK) ? 1 : 0; gphi_iterator gsi;
diff --git a/gcc/tree-ssa-dom.cc b/gcc/tree-ssa-dom.cc index c7f095d79fc..e82f4f73a66 100644 --- a/gcc/tree-ssa-dom.cc +++ b/gcc/tree-ssa-dom.cc @@ -673,10 +673,10 @@ record_edge_info (basic_block bb) { /* At this point we know the exit condition is loop invariant. The only way to get out of the loop is - if never traverses the backedge to begin with. This - implies that any PHI nodes create equivalances we can - attach to the loop exit edge. */ - int alternative + if it never traverses the backedge to begin with. This + implies that any PHI nodes create equivalances that we + can attach to the loop exit edge. */ + int bool = (EDGE_PRED (bb, 0)->flags & EDGE_DFS_BACK) ? 1 : 0; gphi_iterator gsi;
Minor comment typo fixes as noticed by Bernhard. Installed onto the trunk, Jeff commit a03b35a28db262546415e8f16829cbb027a75025 Author: Jeff Law <jlaw@ventanamicro.com> Date: Tue Nov 22 16:22:18 2022 -0700 Fix comment typos noticed by Bernhard gcc/ * tree-ssa-dom.cc (record_edge_info): Fix comment typos.