Message ID | 20221117110806.65470-4-andriy.shevchenko@linux.intel.com |
---|---|
State | Handled Elsewhere |
Headers | show |
Series | pinctrl: intel: Enable PWM optional feature | expand |
On Thu, Nov 17, 2022 at 01:08:02PM +0200, Andy Shevchenko wrote: > For the sake of integrity, include headers we are the direct > user of. > > Replace the inclusion of device.h by a forward declaration > of struct device plus a (cheaper) of types.h as device.h is > an expensive include (measured in compiler effort). > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Acked-by: Thierry Reding <thierry.reding@gmail.com> > Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com> > Reviewed-by: Hans de Goede <hdegoede@redhat.com> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Best regards Uwe
On Tue, Nov 22, 2022 at 02:39:33PM +0100, Uwe Kleine-König wrote: > On Thu, Nov 17, 2022 at 01:08:02PM +0200, Andy Shevchenko wrote: > > For the sake of integrity, include headers we are the direct > > user of. > > > > Replace the inclusion of device.h by a forward declaration > > of struct device plus a (cheaper) of types.h as device.h is > > an expensive include (measured in compiler effort). ... > Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Thank you! Patch 6 is still in question.
diff --git a/drivers/pwm/pwm-lpss.h b/drivers/pwm/pwm-lpss.h index 2c746c51b883..4ce6daa46ca8 100644 --- a/drivers/pwm/pwm-lpss.h +++ b/drivers/pwm/pwm-lpss.h @@ -10,8 +10,10 @@ #ifndef __PWM_LPSS_H #define __PWM_LPSS_H -#include <linux/device.h> #include <linux/pwm.h> +#include <linux/types.h> + +struct device; #define LPSS_MAX_PWMS 4