diff mbox series

[1/2] lib: utils/fdt: Remove redundant code

Message ID 20221031112145.126615-2-wxjstz@126.com
State Accepted
Headers show
Series miscellaneous | expand

Commit Message

Xiang W Oct. 31, 2022, 11:21 a.m. UTC 
uart->reg_offset and uart->reg_io_width are only used on uart8250 and
not required on other platforms. Remove for sifive and gaisler.

Signed-off-by: Xiang W <wxjstz@126.com>
---
 lib/utils/fdt/fdt_helper.c | 12 ------------
 1 file changed, 12 deletions(-)

Comments

Atish Patra Nov. 12, 2022, 8:55 a.m. UTC | #1 
On Mon, Oct 31, 2022 at 4:22 AM Xiang W <wxjstz@126.com> wrote:
>
> uart->reg_offset and uart->reg_io_width are only used on uart8250 and
> not required on other platforms. Remove for sifive and gaisler.
>
> Signed-off-by: Xiang W <wxjstz@126.com>
> ---
>  lib/utils/fdt/fdt_helper.c | 12 ------------
>  1 file changed, 12 deletions(-)
>
> diff --git a/lib/utils/fdt/fdt_helper.c b/lib/utils/fdt/fdt_helper.c
> index d390436..cdd0b35 100644
> --- a/lib/utils/fdt/fdt_helper.c
> +++ b/lib/utils/fdt/fdt_helper.c
> @@ -25,10 +25,6 @@
>
>  #define DEFAULT_SIFIVE_UART_FREQ               0
>  #define DEFAULT_SIFIVE_UART_BAUD               115200
> -#define DEFAULT_SIFIVE_UART_REG_SHIFT          0
> -#define DEFAULT_SIFIVE_UART_REG_IO_WIDTH       4
> -
> -#define DEFAULT_GAISLER_UART_REG_IO_WIDTH      4
>
>  #define DEFAULT_SHAKTI_UART_FREQ               50000000
>  #define DEFAULT_SHAKTI_UART_BAUD               115200
> @@ -363,10 +359,6 @@ int fdt_parse_gaisler_uart_node(void *fdt, int nodeoffset,
>         if (rc)
>                 return rc;
>
> -       /* For Gaisler APBUART, the reg-shift and reg-io-width are fixed .*/
> -       uart->reg_shift    = DEFAULT_UART_REG_SHIFT;
> -       uart->reg_io_width = DEFAULT_GAISLER_UART_REG_IO_WIDTH;
> -
>         return 0;
>  }
>
> @@ -394,10 +386,6 @@ int fdt_parse_sifive_uart_node(void *fdt, int nodeoffset,
>         if (rc)
>                 return rc;
>
> -       /* For SiFive UART, the reg-shift and reg-io-width are fixed .*/
> -       uart->reg_shift = DEFAULT_SIFIVE_UART_REG_SHIFT;
> -       uart->reg_io_width = DEFAULT_SIFIVE_UART_REG_IO_WIDTH;
> -
>         return 0;
>  }
>
> --
> 2.30.2
>
>
> --
> opensbi mailing list
> opensbi@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/opensbi


Reviewed-by: Atish Patra <atishp@rivosinc.com>
Anup Patel Nov. 14, 2022, 4:47 p.m. UTC | #2 
On Mon, Oct 31, 2022 at 4:52 PM Xiang W <wxjstz@126.com> wrote:
>
> uart->reg_offset and uart->reg_io_width are only used on uart8250 and
> not required on other platforms. Remove for sifive and gaisler.
>
> Signed-off-by: Xiang W <wxjstz@126.com>

Looks good to me.

Reviewed-by: Anup Patel <anup@brainfault.org>

Applied this patch to the riscv/opensbi repo.

Thanks,
Anup

> ---
>  lib/utils/fdt/fdt_helper.c | 12 ------------
>  1 file changed, 12 deletions(-)
>
> diff --git a/lib/utils/fdt/fdt_helper.c b/lib/utils/fdt/fdt_helper.c
> index d390436..cdd0b35 100644
> --- a/lib/utils/fdt/fdt_helper.c
> +++ b/lib/utils/fdt/fdt_helper.c
> @@ -25,10 +25,6 @@
>
>  #define DEFAULT_SIFIVE_UART_FREQ               0
>  #define DEFAULT_SIFIVE_UART_BAUD               115200
> -#define DEFAULT_SIFIVE_UART_REG_SHIFT          0
> -#define DEFAULT_SIFIVE_UART_REG_IO_WIDTH       4
> -
> -#define DEFAULT_GAISLER_UART_REG_IO_WIDTH      4
>
>  #define DEFAULT_SHAKTI_UART_FREQ               50000000
>  #define DEFAULT_SHAKTI_UART_BAUD               115200
> @@ -363,10 +359,6 @@ int fdt_parse_gaisler_uart_node(void *fdt, int nodeoffset,
>         if (rc)
>                 return rc;
>
> -       /* For Gaisler APBUART, the reg-shift and reg-io-width are fixed .*/
> -       uart->reg_shift    = DEFAULT_UART_REG_SHIFT;
> -       uart->reg_io_width = DEFAULT_GAISLER_UART_REG_IO_WIDTH;
> -
>         return 0;
>  }
>
> @@ -394,10 +386,6 @@ int fdt_parse_sifive_uart_node(void *fdt, int nodeoffset,
>         if (rc)
>                 return rc;
>
> -       /* For SiFive UART, the reg-shift and reg-io-width are fixed .*/
> -       uart->reg_shift = DEFAULT_SIFIVE_UART_REG_SHIFT;
> -       uart->reg_io_width = DEFAULT_SIFIVE_UART_REG_IO_WIDTH;
> -
>         return 0;
>  }
>
> --
> 2.30.2
>
diff mbox series

Patch

diff --git a/lib/utils/fdt/fdt_helper.c b/lib/utils/fdt/fdt_helper.c
index d390436..cdd0b35 100644
--- a/lib/utils/fdt/fdt_helper.c
+++ b/lib/utils/fdt/fdt_helper.c
@@ -25,10 +25,6 @@ 
 
 #define DEFAULT_SIFIVE_UART_FREQ		0
 #define DEFAULT_SIFIVE_UART_BAUD		115200
-#define DEFAULT_SIFIVE_UART_REG_SHIFT		0
-#define DEFAULT_SIFIVE_UART_REG_IO_WIDTH	4
-
-#define DEFAULT_GAISLER_UART_REG_IO_WIDTH	4
 
 #define DEFAULT_SHAKTI_UART_FREQ		50000000
 #define DEFAULT_SHAKTI_UART_BAUD		115200
@@ -363,10 +359,6 @@  int fdt_parse_gaisler_uart_node(void *fdt, int nodeoffset,
 	if (rc)
 		return rc;
 
-	/* For Gaisler APBUART, the reg-shift and reg-io-width are fixed .*/
-	uart->reg_shift	   = DEFAULT_UART_REG_SHIFT;
-	uart->reg_io_width = DEFAULT_GAISLER_UART_REG_IO_WIDTH;
-
 	return 0;
 }
 
@@ -394,10 +386,6 @@  int fdt_parse_sifive_uart_node(void *fdt, int nodeoffset,
 	if (rc)
 		return rc;
 
-	/* For SiFive UART, the reg-shift and reg-io-width are fixed .*/
-	uart->reg_shift = DEFAULT_SIFIVE_UART_REG_SHIFT;
-	uart->reg_io_width = DEFAULT_SIFIVE_UART_REG_IO_WIDTH;
-
 	return 0;
 }