| Message ID | 20221109105555.49557-1-krzysztof.kozlowski@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | [RESEND] dt-bindings: PCI: qcom,pcie-ep: correct qcom,perst-regs | expand |
On 09/11/2022 13:55, Krzysztof Kozlowski wrote: > qcom,perst-regs is an phandle array of one item with a phandle and its > arguments. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Acked-by: Manivannan Sadhasivam <mani@kernel.org> > Reviewed-by: Rob Herring <robh@kernel.org> > --- > Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml > index 977c976ea799..5aa590957ee4 100644 > --- a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml > @@ -47,8 +47,10 @@ properties: > enable registers > $ref: "/schemas/types.yaml#/definitions/phandle-array" > items: > - minItems: 3 > - maxItems: 3 > + - items: > + - description: Syscon to TCSR system registers > + - description: Perst enable offset > + - description: Perst separateion enable offset typo: separation. With that fixed: Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > interrupts: > items:
On 09/11/2022 11:55, Krzysztof Kozlowski wrote: > qcom,perst-regs is an phandle array of one item with a phandle and its > arguments. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Acked-by: Manivannan Sadhasivam <mani@kernel.org> > Reviewed-by: Rob Herring <robh@kernel.org> > --- > Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml > index 977c976ea799..5aa590957ee4 100644 > --- a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml > @@ -47,8 +47,10 @@ properties: > enable registers > $ref: "/schemas/types.yaml#/definitions/phandle-array" > items: > - minItems: 3 > - maxItems: 3 > + - items: > + - description: Syscon to TCSR system registers > + - description: Perst enable offset > + - description: Perst separateion enable offset separation? Konrad > > interrupts: > items:
On 09/11/2022 12:06, Dmitry Baryshkov wrote: > On 09/11/2022 13:55, Krzysztof Kozlowski wrote: >> qcom,perst-regs is an phandle array of one item with a phandle and its >> arguments. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Acked-by: Manivannan Sadhasivam <mani@kernel.org> >> Reviewed-by: Rob Herring <robh@kernel.org> >> --- >> Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml >> index 977c976ea799..5aa590957ee4 100644 >> --- a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml >> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml >> @@ -47,8 +47,10 @@ properties: >> enable registers >> $ref: "/schemas/types.yaml#/definitions/phandle-array" >> items: >> - minItems: 3 >> - maxItems: 3 >> + - items: >> + - description: Syscon to TCSR system registers >> + - description: Perst enable offset >> + - description: Perst separateion enable offset > > typo: separation. > > With that fixed: > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Thanks! Best regards, Krzysztof
On 09/11/2022 12:10, Konrad Dybcio wrote: > > On 09/11/2022 11:55, Krzysztof Kozlowski wrote: >> qcom,perst-regs is an phandle array of one item with a phandle and its >> arguments. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Acked-by: Manivannan Sadhasivam <mani@kernel.org> >> Reviewed-by: Rob Herring <robh@kernel.org> >> --- >> Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml >> index 977c976ea799..5aa590957ee4 100644 >> --- a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml >> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml >> @@ -47,8 +47,10 @@ properties: >> enable registers >> $ref: "/schemas/types.yaml#/definitions/phandle-array" >> items: >> - minItems: 3 >> - maxItems: 3 >> + - items: >> + - description: Syscon to TCSR system registers >> + - description: Perst enable offset >> + - description: Perst separateion enable offset > > separation? Indeed, thanks! Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml index 977c976ea799..5aa590957ee4 100644 --- a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml @@ -47,8 +47,10 @@ properties: enable registers $ref: "/schemas/types.yaml#/definitions/phandle-array" items: - minItems: 3 - maxItems: 3 + - items: + - description: Syscon to TCSR system registers + - description: Perst enable offset + - description: Perst separateion enable offset interrupts: items: