| Message ID | 20221106154111.872209-2-bjorn@mork.no |
|---|---|
| State | New |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | Prevent alignment issues with "in place" FIT configurations | expand |
Hi Bjørn, On Sun, 6 Nov 2022 at 11:20, Bjørn Mork <bjorn@mork.no> wrote: > > Properties are sometimes used to store data with stricter alignment > requirements than the 4-byte fdt tag alignment. Aligning the offset > of the property data will alloe a client to directly address it, > without reloaction, provided the fdt is loaded on a similarily > aligned boundary. > > One known use-case for this is the U-Boot FIT images, which may > embed nested fdt blobs inside properties of the outer FIT fdt. > Although strongly discouraged, U-Boot can be configured to use these > embedded blobs "in place". This is discouraged because if only will > work if the offset of the property value, i.e. the embedded fdt, > happens to match the 8-byte boundary required by the devicetree > spec. > > Adding the ability to align property data allows U-Boot tools to > reliably create FIT images for such use. > > Other use cases are currently not known, but anticipated. > > Signed-off-by: Bjørn Mork <bjorn@mork.no> > --- > scripts/dtc/libfdt/fdt_rw.c | 26 ++++++++++++++++++++++++ > scripts/dtc/libfdt/fdt_wip.c | 2 +- > scripts/dtc/libfdt/libfdt.h | 30 ++++++++++++++++++++++++++++ > scripts/dtc/libfdt/libfdt_internal.h | 1 + > 4 files changed, 58 insertions(+), 1 deletion(-) Can you use an external FIT? Regards, Simon
Simon Glass <sjg@chromium.org> writes:
> Can you use an external FIT?
Maybe. I couldn't make that work in a quick test, but that is probably
just me doing something wrong.
But there are other workarounds for this specific device, yes.
Appending the DTB to the kernel image is verified to work. So it is
possible to create a bootable image.
It's also possible to build a working FIT image with embedded fdt blobs
using existing tools, provided that you are willing to run a few
iterations while adjusting e.g. descriptions. I just believe it's
unecessarily hard, resulting in complicated build rules when a simple
call to mkimage should have been enough.
Bjørn
diff --git a/scripts/dtc/libfdt/fdt_rw.c b/scripts/dtc/libfdt/fdt_rw.c index 2eb2b38703be..9e0e8dfeec8c 100644 --- a/scripts/dtc/libfdt/fdt_rw.c +++ b/scripts/dtc/libfdt/fdt_rw.c @@ -331,6 +331,32 @@ int fdt_delprop(void *fdt, int nodeoffset, const char *name) return fdt_splice_struct_(fdt, prop, proplen, 0); } +int fdt_alignprop(void *fdt, int nodeoffset, const char *name, size_t align) +{ + struct fdt_property *prop; + int err, len, diff; + + FDT_RW_PROBE(fdt); + + if (align != FDT_TAGALIGN(align)) + return -FDT_ERR_BADOFFSET; + + prop = fdt_get_property_w(fdt, nodeoffset, name, &len); + if (!prop) + return len; + + diff = FDT_ALIGN((uintptr_t)prop->data, align) - (uintptr_t)prop->data; + if (!diff) + return 0; + + err = fdt_splice_struct_(fdt, prop, 0, diff); + if (err) + return err; + + fdt_nop_region_(prop, diff); + return 0; +} + int fdt_add_subnode_namelen(void *fdt, int parentoffset, const char *name, int namelen) { diff --git a/scripts/dtc/libfdt/fdt_wip.c b/scripts/dtc/libfdt/fdt_wip.c index c2d7566a67dc..10a75058f0f0 100644 --- a/scripts/dtc/libfdt/fdt_wip.c +++ b/scripts/dtc/libfdt/fdt_wip.c @@ -48,7 +48,7 @@ int fdt_setprop_inplace(void *fdt, int nodeoffset, const char *name, val, len); } -static void fdt_nop_region_(void *start, int len) +void fdt_nop_region_(void *start, int len) { fdt32_t *p; diff --git a/scripts/dtc/libfdt/libfdt.h b/scripts/dtc/libfdt/libfdt.h index d706f85962bd..4490f9feb7ce 100644 --- a/scripts/dtc/libfdt/libfdt.h +++ b/scripts/dtc/libfdt/libfdt.h @@ -1928,6 +1928,36 @@ int fdt_appendprop_addrrange(void *fdt, int parent, int nodeoffset, */ int fdt_delprop(void *fdt, int nodeoffset, const char *name); +/** + * fdt_alignprop - align property data to a given boundary + * @fdt: pointer to the device tree blob + * @nodeoffset: offset of the node whose property to nop + * @name: name of the property to nop + * @align: requested alignment boundary in bytes (must be multiple of 4) + * + * fdt_alignprop() will align the property data to a chosen boundary + * by injecting nop tags in front of the given property. The + * alignment must be a multiple of 4. + * + * This function may insert nop tags in the blob, and will therefore + * change the offsets of some existing nodes. + * + * returns: + * 0, on success + * -FDT_ERR_NOSPACE, there is insufficient free space in the blob to + * move the property to the new boundary + * -FDT_ERR_NOTFOUND, node does not have the named property + * -FDT_ERR_BADOFFSET, nodeoffset did not point to FDT_BEGIN_NODE tag + * or the requested alignment was not a multiple of 4 + * -FDT_ERR_BADLAYOUT, + * -FDT_ERR_BADMAGIC, + * -FDT_ERR_BADVERSION, + * -FDT_ERR_BADSTATE, + * -FDT_ERR_BADSTRUCTURE, + * -FDT_ERR_TRUNCATED, standard meanings + */ +int fdt_alignprop(void *fdt, int nodeoffset, const char *name, size_t align); + /** * fdt_add_subnode_namelen - creates a new node based on substring * @fdt: pointer to the device tree blob diff --git a/scripts/dtc/libfdt/libfdt_internal.h b/scripts/dtc/libfdt/libfdt_internal.h index 5436e2ceeacf..7abee9c21057 100644 --- a/scripts/dtc/libfdt/libfdt_internal.h +++ b/scripts/dtc/libfdt/libfdt_internal.h @@ -25,6 +25,7 @@ int fdt_check_node_offset_(const void *fdt, int offset); int fdt_check_prop_offset_(const void *fdt, int offset); const char *fdt_find_string_(const char *strtab, int tabsize, const char *s); int fdt_node_end_offset_(void *fdt, int nodeoffset); +void fdt_nop_region_(void *start, int len); static inline const void *fdt_offset_ptr_(const void *fdt, int offset) {
Properties are sometimes used to store data with stricter alignment requirements than the 4-byte fdt tag alignment. Aligning the offset of the property data will alloe a client to directly address it, without reloaction, provided the fdt is loaded on a similarily aligned boundary. One known use-case for this is the U-Boot FIT images, which may embed nested fdt blobs inside properties of the outer FIT fdt. Although strongly discouraged, U-Boot can be configured to use these embedded blobs "in place". This is discouraged because if only will work if the offset of the property value, i.e. the embedded fdt, happens to match the 8-byte boundary required by the devicetree spec. Adding the ability to align property data allows U-Boot tools to reliably create FIT images for such use. Other use cases are currently not known, but anticipated. Signed-off-by: Bjørn Mork <bjorn@mork.no> --- scripts/dtc/libfdt/fdt_rw.c | 26 ++++++++++++++++++++++++ scripts/dtc/libfdt/fdt_wip.c | 2 +- scripts/dtc/libfdt/libfdt.h | 30 ++++++++++++++++++++++++++++ scripts/dtc/libfdt/libfdt_internal.h | 1 + 4 files changed, 58 insertions(+), 1 deletion(-)