diff mbox series

[1/3] package/qemu: make "custom targets" config depend on !BR2_STATIC_LIBS

Message ID 20221104235727.587650-2-unixmania@gmail.com
State Superseded, archived
Headers show
Series package/qemu: add option to enable guest agent | expand

Commit Message

Carlos Santos Nov. 4, 2022, 11:57 p.m. UTC 
From: Carlos Santos <unixmania@gmail.com>

Custom targets selects system and Linux user-land emulation, which in
their turn require shared libraries.

Signed-off-by: Carlos Santos <unixmania@gmail.com>
---
 package/qemu/Config.in | 1 +
 1 file changed, 1 insertion(+)

Comments

Thomas Petazzoni Nov. 5, 2022, 9:12 p.m. UTC | #1 
Hello Carlos,

On Fri,  4 Nov 2022 20:57:25 -0300
unixmania@gmail.com wrote:

> From: Carlos Santos <unixmania@gmail.com>
> 
> Custom targets selects system and Linux user-land emulation, which in
> their turn require shared libraries.
> 
> Signed-off-by: Carlos Santos <unixmania@gmail.com>

Could you clarify which configuration fails to build?

>  config BR2_PACKAGE_QEMU_CUSTOM_TARGETS
>  	string "Enable specific targets"
> +	depends on !BR2_STATIC_LIBS # dtc

What is the relationship with DTC here?

Also, when we have a !BR2_STATIC_LIBS dependency, we normally add a
Config.in comment:

comment "specific targets need a toolchain w/ shared library"
	depends on BR2_STATIC_LIBS

But really the most important thing is to get more details to
understand better the problem.

Thanks!

Thomas
diff mbox series

Patch

diff --git a/package/qemu/Config.in b/package/qemu/Config.in
index 15d6c7d6b5..8b8a999885 100644
--- a/package/qemu/Config.in
+++ b/package/qemu/Config.in
@@ -51,6 +51,7 @@  comment "Emulators selection"
 
 config BR2_PACKAGE_QEMU_CUSTOM_TARGETS
 	string "Enable specific targets"
+	depends on !BR2_STATIC_LIBS # dtc
 	help
 	  Enter here the list of QEMU targets you want to build. For
 	  example: