mbox series

[v2,0/4] rtc: ingenic: various updates

Message ID 20221028225519.89210-1-paul@crapouillou.net
Headers show
Series rtc: ingenic: various updates | expand

Message

Paul Cercueil Oct. 28, 2022, 10:55 p.m. UTC 
Hi Alessandro / Alexandre,

Here's the V2 of a previous patchset I sent back in April.

Patch [1/4] was updated with Krzysztof's feedback.

Patches 2-4 are unmodified from V1 as they didn't receive any feedback.
Patch 4 is RFC; I *think* it works, but I don't know how to test it.

V1 had a 5th patch which would reset the scratchpad register on power
loss, but was dropped following upstream feedback.

Cheers,
- Paul

Paul Cercueil (4):
  dt-bindings: rtc: ingenic: Rework compatible strings and add #clock-cells
  rtc: jz4740: Use readl_poll_timeout
  rtc: jz4740: Register clock provider for the CLK32K pin
  rtc: jz4740: Support for fine-tuning the RTC clock

 .../devicetree/bindings/rtc/ingenic,rtc.yaml  |  32 ++++-
 drivers/rtc/rtc-jz4740.c                      | 113 +++++++++++++++---
 2 files changed, 129 insertions(+), 16 deletions(-)

Comments

Alexandre Belloni Nov. 2, 2022, 5:40 p.m. UTC | #1 
On 28/10/2022 23:55:15+0100, Paul Cercueil wrote:
> Hi Alessandro / Alexandre,
> 
> Here's the V2 of a previous patchset I sent back in April.
> 
> Patch [1/4] was updated with Krzysztof's feedback.
> 
> Patches 2-4 are unmodified from V1 as they didn't receive any feedback.
> Patch 4 is RFC; I *think* it works, but I don't know how to test it.
> 

You should simply adjust the RTC and see whether the drift changes. The
best is to simply use chrony as this will actually tell you how much the
RTC drifts. This actually gives you the exact value to put in offset to
remove the drift.

> V1 had a 5th patch which would reset the scratchpad register on power
> loss, but was dropped following upstream feedback.
> 
> Cheers,
> - Paul
> 
> Paul Cercueil (4):
>   dt-bindings: rtc: ingenic: Rework compatible strings and add #clock-cells
>   rtc: jz4740: Use readl_poll_timeout
>   rtc: jz4740: Register clock provider for the CLK32K pin
>   rtc: jz4740: Support for fine-tuning the RTC clock
> 
>  .../devicetree/bindings/rtc/ingenic,rtc.yaml  |  32 ++++-
>  drivers/rtc/rtc-jz4740.c                      | 113 +++++++++++++++---
>  2 files changed, 129 insertions(+), 16 deletions(-)
> 
> -- 
> 2.35.1
>