Message ID | 20221028205540.3197304-1-nfraprado@collabora.com |
---|---|
Headers | show |
Series | Adjust usage of rt5682(s) power supply properties | expand |
Il 28/10/22 22:55, Nícolas F. R. A. Prado ha scritto: > The dbvdd and ldo1-in supplies for rt5682 are required but are missing. > They are supplied by the same power rail as AVDD. Add them. > > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Il 28/10/22 22:55, Nícolas F. R. A. Prado ha scritto: > These devicetrees override a rt5682 node to use the rt5682s compatible, > however, unlike rt5682, rt5682s doesn't have a VBAT supply. Remove the > inexistent supply in the rt5682s nodes. > > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> > --- > > arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dtsi | 1 + > .../dts/qcom/sc7180-trogdor-wormdingler-rev1-boe-rt5682s.dts | 1 + > .../dts/qcom/sc7180-trogdor-wormdingler-rev1-inx-rt5682s.dts | 1 + > 3 files changed, 3 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dtsi > index 74f0e07ea5cf..e0fb83a9a0b1 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dtsi > @@ -11,6 +11,7 @@ > > &alc5682 { > compatible = "realtek,rt5682s"; > + /delete-property/ VBAT-supply; I really dislike seeing /delete-property/ but I don't know if changing all of the non-kingoftown and non-wormdingler devicetrees is worth the noise... Any strong opinions on that? Regards, Angelo