| Message ID | 20220910001655.13487-1-aaron.ma@canonical.com |
|---|---|
| Headers | show |
| Series | Fix blank screen on Thinkpad ADL 4K+ panel | expand |
This would not cause LP#1961653 to regress. On Sat, Sep 10, 2022 at 8:17 AM Aaron Ma <aaron.ma@canonical.com> wrote: > > BugLink: https://bugs.launchpad.net/bugs/1980621 > > [Impact] > Set screen off on ThinkPad P1G5 with 4k+ panel. > The screen will never be back. > > [Fix] > Reload link rate as WA to fix the issue. > > [Test] > Verified on hardware, screen on/off 20 times OK. > > [Where problems could occur] > It may break DP output on Intel platform. > > Ville Syrjälä (2): > drm/i915: Implement WaEdpLinkRateDataReload > Revert "drm/i915/display: Re-add check for low voltage sku for max dp > source rate" > > drivers/gpu/drm/i915/display/intel_dp.c | 32 ++----------------- > .../drm/i915/display/intel_dp_link_training.c | 22 +++++++++++++ > 2 files changed, 25 insertions(+), 29 deletions(-) > > -- > 2.34.1 > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team
On Sat, Sep 10, 2022 at 08:16:53AM +0800, Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/1980621
Aaron Ma kirjoitti 10.9.2022 klo 3.16: > BugLink: https://bugs.launchpad.net/bugs/1980621 > > [Impact] > Set screen off on ThinkPad P1G5 with 4k+ panel. > The screen will never be back. > > [Fix] > Reload link rate as WA to fix the issue. > > [Test] > Verified on hardware, screen on/off 20 times OK. > > [Where problems could occur] > It may break DP output on Intel platform. > > Ville Syrjälä (2): > drm/i915: Implement WaEdpLinkRateDataReload > Revert "drm/i915/display: Re-add check for low voltage sku for max dp > source rate" > > drivers/gpu/drm/i915/display/intel_dp.c | 32 ++----------------- > .../drm/i915/display/intel_dp_link_training.c | 22 +++++++++++++ > 2 files changed, 25 insertions(+), 29 deletions(-) > applied to oem-5.17, thanks
Aaron Ma kirjoitti 10.9.2022 klo 3.16: > BugLink: https://bugs.launchpad.net/bugs/1980621 > > [Impact] > Set screen off on ThinkPad P1G5 with 4k+ panel. > The screen will never be back. > > [Fix] > Reload link rate as WA to fix the issue. > > [Test] > Verified on hardware, screen on/off 20 times OK. > > [Where problems could occur] > It may break DP output on Intel platform. > > Ville Syrjälä (2): > drm/i915: Implement WaEdpLinkRateDataReload > Revert "drm/i915/display: Re-add check for low voltage sku for max dp > source rate" > > drivers/gpu/drm/i915/display/intel_dp.c | 32 ++----------------- > .../drm/i915/display/intel_dp_link_training.c | 22 +++++++++++++ > 2 files changed, 25 insertions(+), 29 deletions(-) > this is already in 6.0 and up
The patches are in the linux-next and Aaron already did the test on hardware. Acked-by: Hui Wang <hui.wang@canonical.com> On 9/10/22 08:16, Aaron Ma wrote: > BugLink: https://bugs.launchpad.net/bugs/1980621 > > [Impact] > Set screen off on ThinkPad P1G5 with 4k+ panel. > The screen will never be back. > > [Fix] > Reload link rate as WA to fix the issue. > > [Test] > Verified on hardware, screen on/off 20 times OK. > > [Where problems could occur] > It may break DP output on Intel platform. > > Ville Syrjälä (2): > drm/i915: Implement WaEdpLinkRateDataReload > Revert "drm/i915/display: Re-add check for low voltage sku for max dp > source rate" > > drivers/gpu/drm/i915/display/intel_dp.c | 32 ++----------------- > .../drm/i915/display/intel_dp_link_training.c | 22 +++++++++++++ > 2 files changed, 25 insertions(+), 29 deletions(-) >
On 10.09.22 02:16, Aaron Ma wrote: > BugLink: https://bugs.launchpad.net/bugs/1980621 > > [Impact] > Set screen off on ThinkPad P1G5 with 4k+ panel. > The screen will never be back. > > [Fix] > Reload link rate as WA to fix the issue. > > [Test] > Verified on hardware, screen on/off 20 times OK. > > [Where problems could occur] > It may break DP output on Intel platform. > > Ville Syrjälä (2): > drm/i915: Implement WaEdpLinkRateDataReload > Revert "drm/i915/display: Re-add check for low voltage sku for max dp > source rate" > > drivers/gpu/drm/i915/display/intel_dp.c | 32 ++----------------- > .../drm/i915/display/intel_dp_link_training.c | 22 +++++++++++++ > 2 files changed, 25 insertions(+), 29 deletions(-) > The patch #1 (for Jammy) is now upstream: commit 672d6ca758651f0ec12cd0d59787067a5bde1c96 Author: Ville Syrjälä ville.syrjala@linux.intel.com Date: Fri Sep 2 10:03:18 2022 +0300 drm/i915: Implement WaEdpLinkRateDataReload I would propose to cherry pick the upstream patch and add bug report and sob when applying. Acked-by: Stefan Bader <stefan.bader@canonical.com>
On 10.09.22 02:16, Aaron Ma wrote: > BugLink: https://bugs.launchpad.net/bugs/1980621 > > [Impact] > Set screen off on ThinkPad P1G5 with 4k+ panel. > The screen will never be back. > > [Fix] > Reload link rate as WA to fix the issue. > > [Test] > Verified on hardware, screen on/off 20 times OK. > > [Where problems could occur] > It may break DP output on Intel platform. > > Ville Syrjälä (2): > drm/i915: Implement WaEdpLinkRateDataReload > Revert "drm/i915/display: Re-add check for low voltage sku for max dp > source rate" > > drivers/gpu/drm/i915/display/intel_dp.c | 32 ++----------------- > .../drm/i915/display/intel_dp_link_training.c | 22 +++++++++++++ > 2 files changed, 25 insertions(+), 29 deletions(-) > Hi Aaron, How about the revert of the backport of "73867c8709b5 drm/i915/display: Remove check for low voltage sku for max dp source rate" which was sent on V1, is the revert no needed anymore? Thanks, Kleber
On 10/17/22 17:05, Kleber Souza wrote: > On 10.09.22 02:16, Aaron Ma wrote: >> BugLink: https://bugs.launchpad.net/bugs/1980621 >> >> [Impact] >> Set screen off on ThinkPad P1G5 with 4k+ panel. >> The screen will never be back. >> >> [Fix] >> Reload link rate as WA to fix the issue. >> >> [Test] >> Verified on hardware, screen on/off 20 times OK. >> >> [Where problems could occur] >> It may break DP output on Intel platform. >> >> Ville Syrjälä (2): >> drm/i915: Implement WaEdpLinkRateDataReload >> Revert "drm/i915/display: Re-add check for low voltage sku for max dp >> source rate" >> >> drivers/gpu/drm/i915/display/intel_dp.c | 32 ++----------------- >> .../drm/i915/display/intel_dp_link_training.c | 22 +++++++++++++ >> 2 files changed, 25 insertions(+), 29 deletions(-) >> > > Hi Aaron, > > How about the revert of the backport of "73867c8709b5 drm/i915/display: Remove > check for low voltage sku for max dp source rate" which was sent on V1, is > the revert no needed anymore? There are 3 commits in this story: remove -> re-add (revert remove) -> revert re-add. The final goal is to make this "remove" patch happen with the 1st patch which fix the regression of this "remove" patch. Regards, Aaron > > > Thanks, > Kleber
On 10.09.22 02:16, Aaron Ma wrote: > BugLink: https://bugs.launchpad.net/bugs/1980621 > > [Impact] > Set screen off on ThinkPad P1G5 with 4k+ panel. > The screen will never be back. > > [Fix] > Reload link rate as WA to fix the issue. > > [Test] > Verified on hardware, screen on/off 20 times OK. > > [Where problems could occur] > It may break DP output on Intel platform. > > Ville Syrjälä (2): > drm/i915: Implement WaEdpLinkRateDataReload > Revert "drm/i915/display: Re-add check for low voltage sku for max dp > source rate" > > drivers/gpu/drm/i915/display/intel_dp.c | 32 ++----------------- > .../drm/i915/display/intel_dp_link_training.c | 22 +++++++++++++ > 2 files changed, 25 insertions(+), 29 deletions(-) > Applied to jammy:linux/master-next. Thanks. -Stefan
BugLink: https://bugs.launchpad.net/bugs/1980621 [Impact] Set screen off on ThinkPad P1G5 with 4k+ panel. The screen will never be back. [Fix] Reload link rate as WA to fix the issue. [Test] Verified on hardware, screen on/off 20 times OK. [Where problems could occur] It may break DP output on Intel platform. Ville Syrjälä (2): drm/i915: Implement WaEdpLinkRateDataReload Revert "drm/i915/display: Re-add check for low voltage sku for max dp source rate" drivers/gpu/drm/i915/display/intel_dp.c | 32 ++----------------- .../drm/i915/display/intel_dp_link_training.c | 22 +++++++++++++ 2 files changed, 25 insertions(+), 29 deletions(-)