| Message ID | 20220930165116.13329-3-Alexander.Steffen@infineon.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Clean up TPM compatibles | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Fri, 30 Sep 2022 18:51:11 +0200, Alexander Steffen wrote: > Add missing information: > * Device name, for discoverability > * Interface, to distinguish otherwise similar devices > * TPM version, so that outdated devices can be deprecated in the future > > Signed-off-by: Alexander Steffen <Alexander.Steffen@infineon.com> > --- > .../bindings/security/tpm/trivial-tpms.yaml | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/ tpm@20: 'powered-while-suspended' does not match any of the regexes: 'pinctrl-[0-9]+' arch/arm/boot/dts/rk3288-veyron-brain.dtb arch/arm/boot/dts/rk3288-veyron-fievel.dtb arch/arm/boot/dts/rk3288-veyron-jaq.dtb arch/arm/boot/dts/rk3288-veyron-jerry.dtb arch/arm/boot/dts/rk3288-veyron-mickey.dtb arch/arm/boot/dts/rk3288-veyron-mighty.dtb arch/arm/boot/dts/rk3288-veyron-minnie.dtb arch/arm/boot/dts/rk3288-veyron-pinky.dtb arch/arm/boot/dts/rk3288-veyron-speedy.dtb arch/arm/boot/dts/rk3288-veyron-tiger.dtb arch/arm64/boot/dts/mediatek/mt8173-elm-hana-rev7.dtb arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dtb arch/arm64/boot/dts/mediatek/mt8173-elm.dtb arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dtb
On 01.10.22 00:05, Rob Herring wrote: > On Fri, 30 Sep 2022 18:51:11 +0200, Alexander Steffen wrote: >> Add missing information: >> * Device name, for discoverability >> * Interface, to distinguish otherwise similar devices >> * TPM version, so that outdated devices can be deprecated in the future >> >> Signed-off-by: Alexander Steffen <Alexander.Steffen@infineon.com> >> --- >> .../bindings/security/tpm/trivial-tpms.yaml | 14 +++++++------- >> 1 file changed, 7 insertions(+), 7 deletions(-) >> > > Running 'make dtbs_check' with the schema in this patch gives the > following warnings. Consider if they are expected or the schema is > incorrect. These may not be new warnings. > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > This will change in the future. > > Full log is available here: https://patchwork.ozlabs.org/patch/ > > > tpm@20: 'powered-while-suspended' does not match any of the regexes: 'pinctrl-[0-9]+' > arch/arm/boot/dts/rk3288-veyron-brain.dtb > arch/arm/boot/dts/rk3288-veyron-fievel.dtb > arch/arm/boot/dts/rk3288-veyron-jaq.dtb > arch/arm/boot/dts/rk3288-veyron-jerry.dtb > arch/arm/boot/dts/rk3288-veyron-mickey.dtb > arch/arm/boot/dts/rk3288-veyron-mighty.dtb > arch/arm/boot/dts/rk3288-veyron-minnie.dtb > arch/arm/boot/dts/rk3288-veyron-pinky.dtb > arch/arm/boot/dts/rk3288-veyron-speedy.dtb > arch/arm/boot/dts/rk3288-veyron-tiger.dtb > arch/arm64/boot/dts/mediatek/mt8173-elm-hana-rev7.dtb > arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dtb > arch/arm64/boot/dts/mediatek/mt8173-elm.dtb > arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dtb This is fixed by PATCH 3/7. Not sure it is worth changing the order, since the intention of the first two patches was just to convert the existing data, without making any functional changes.
diff --git a/Documentation/devicetree/bindings/security/tpm/trivial-tpms.yaml b/Documentation/devicetree/bindings/security/tpm/trivial-tpms.yaml index fadd4ca96554..2092341c6491 100644 --- a/Documentation/devicetree/bindings/security/tpm/trivial-tpms.yaml +++ b/Documentation/devicetree/bindings/security/tpm/trivial-tpms.yaml @@ -28,21 +28,21 @@ properties: compatible: contains: enum: - # i2c trusted platform module (TPM) + # Atmel AT97SC3204T I2C TPM 1.2 - atmel,at97sc3204t - # Infineon SLB9635 (Soft-) I2C TPM (old protocol, max 100khz) + # Infineon SLB9635 I2C TPM 1.2 (old protocol, max 100khz) - infineon,slb9635tt - # Infineon SLB9645 I2C TPM (new protocol, max 400khz) + # Infineon SLB9645 I2C TPM 1.2 (new protocol, max 400khz) - infineon,slb9645tt # Infineon SLB9673 I2C TPM 2.0 - infineon,slb9673 - # i2c trusted platform module (TPM) + # Nuvoton NPCT501 I2C TPM 1.2 - nuvoton,npct501 - # i2c trusted platform module (TPM2) + # Nuvoton NPCT601 I2C TPM 2.0 - nuvoton,npct601 - # Socionext SynQuacer TPM MMIO module + # Socionext SynQuacer MMIO TPM - socionext,synquacer-tpm-mmio - # i2c trusted platform module (TPM) + # Winbond WPCT301 I2C TPM 1.2 - winbond,wpct301 required:
Add missing information: * Device name, for discoverability * Interface, to distinguish otherwise similar devices * TPM version, so that outdated devices can be deprecated in the future Signed-off-by: Alexander Steffen <Alexander.Steffen@infineon.com> --- .../bindings/security/tpm/trivial-tpms.yaml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)