diff mbox series

[v1,01/10] dt-bindings: dma: apple,admac: Add iommus and power-domains properties

Message ID 20220916142550.269905-2-j@jannau.net
State Not Applicable, archived
Headers show
Series Apple M1 Pro/Max/Ultra device trees | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Janne Grunau Sept. 16, 2022, 2:25 p.m. UTC 
Apple's ADMAC is on all supported Apple silicon SoCs behind an IOMMU
and has its own power-domain.

Signed-off-by: Janne Grunau <j@jannau.net>
Acked-by: Martin Povišer <povik+lin@cutebit.org>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

Changes in v1:
 - added Martin's and Krzysztof's ack

 Documentation/devicetree/bindings/dma/apple,admac.yaml | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Vinod Koul Sept. 29, 2022, 4:31 p.m. UTC | #1 
On 16-09-22, 16:25, Janne Grunau wrote:
> Apple's ADMAC is on all supported Apple silicon SoCs behind an IOMMU
> and has its own power-domain.

Applied, thanks
Martin Povišer Sept. 29, 2022, 5:40 p.m. UTC | #2 
> On 29. 9. 2022, at 18:31, Vinod Koul <vkoul@kernel.org> wrote:
> 
> On 16-09-22, 16:25, Janne Grunau wrote:
>> Apple's ADMAC is on all supported Apple silicon SoCs behind an IOMMU
>> and has its own power-domain.
> 
> Applied, thanks

Hi Vinod,

this has been picked up by Hector and is staged in asahi-soc/dt [0].
I see you haven’t pushed yet. Would it be possible to drop the patch
on your end so we don’t end up with two commits for the same change?
(I assume that would be an issue.)

To recapitulate: There are two ADMAC binding changes to go in for 6.1,
they are both in asahi-soc/dt. I know I initially asked you to apply
this patch when the series was an RFC.

Thanks,
Martin

[0] https://github.com/AsahiLinux/linux/commit/3ac3865735a83bd1c0dae7ad73b74621774755cb

> -- 
> ~Vinod
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/dma/apple,admac.yaml b/Documentation/devicetree/bindings/dma/apple,admac.yaml
index bdc8c129c4f5..3b1e667f7ea0 100644
--- a/Documentation/devicetree/bindings/dma/apple,admac.yaml
+++ b/Documentation/devicetree/bindings/dma/apple,admac.yaml
@@ -49,6 +49,13 @@  properties:
       in an interrupts-extended list the disconnected positions will contain
       an empty phandle reference <0>.
 
+  iommus:
+    minItems: 1
+    maxItems: 2
+
+  power-domains:
+    maxItems: 1
+
 required:
   - compatible
   - reg