Message ID | 20220928175223.15225-3-a-bhatia1@ti.com |
---|---|
State | Not Applicable, archived |
Headers | show |
Series | Add DSS support for AM625 SoC | expand |
Context | Check | Description |
---|---|---|
robh/checkpatch | success | |
robh/patch-applied | success | |
robh/dtbs-check | warning | build log |
robh/dt-meta-schema | success |
On 28/09/2022 19:52, Aradhya Bhatia wrote: > Add 3rd "port" property for am625-dss. > This port represents the output from the 2nd OLDI TX (OLDI TX 1) latched > onto the first video port (VP0) from the DSS controller on AM625 SOC. > > Signed-off-by: Aradhya Bhatia <a-bhatia1@ti.com> > --- > .../bindings/display/ti/ti,am65x-dss.yaml | 18 +++++++++++++++++- > 1 file changed, 17 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml > index 6bbce921479d..99576c6ec108 100644 > --- a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml > +++ b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml > @@ -82,13 +82,18 @@ properties: > port@0: > $ref: /schemas/graph.yaml#/properties/port > description: > - The DSS OLDI output port node form video port 1 > + The DSS OLDI output port node form video port 1 (OLDI TX 0). > > port@1: > $ref: /schemas/graph.yaml#/properties/port > description: > The DSS DPI output port node from video port 2 > > + port@2: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + The DSS OLDI output port node form video port 1 (OLDI TX 1). > + > ti,am65x-oldi-io-ctrl: > $ref: "/schemas/types.yaml#/definitions/phandle" > description: > @@ -104,6 +109,17 @@ properties: > Input memory (from main memory to dispc) bandwidth limit in > bytes per second > > +if: Entire if: block is usually put under allOf:, so when the list of conditions grow, you do not need to change indentation. With the change: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml index 6bbce921479d..99576c6ec108 100644 --- a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml +++ b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml @@ -82,13 +82,18 @@ properties: port@0: $ref: /schemas/graph.yaml#/properties/port description: - The DSS OLDI output port node form video port 1 + The DSS OLDI output port node form video port 1 (OLDI TX 0). port@1: $ref: /schemas/graph.yaml#/properties/port description: The DSS DPI output port node from video port 2 + port@2: + $ref: /schemas/graph.yaml#/properties/port + description: + The DSS OLDI output port node form video port 1 (OLDI TX 1). + ti,am65x-oldi-io-ctrl: $ref: "/schemas/types.yaml#/definitions/phandle" description: @@ -104,6 +109,17 @@ properties: Input memory (from main memory to dispc) bandwidth limit in bytes per second +if: + properties: + compatible: + contains: + const: ti,am65x-dss +then: + properties: + ports: + properties: + port@2: false + required: - compatible - reg
Add 3rd "port" property for am625-dss. This port represents the output from the 2nd OLDI TX (OLDI TX 1) latched onto the first video port (VP0) from the DSS controller on AM625 SOC. Signed-off-by: Aradhya Bhatia <a-bhatia1@ti.com> --- .../bindings/display/ti/ti,am65x-dss.yaml | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-)