diff mbox series

phy: tegra: xusb: Enable usb role switch attribute

Message ID 20220921112500.798282-1-haotienh@nvidia.com
State Changes Requested
Headers show
Series phy: tegra: xusb: Enable usb role switch attribute | expand

Commit Message

Haotien Hsu Sept. 21, 2022, 11:25 a.m. UTC
From: Wayne Chang <waynec@nvidia.com>

This patch enables the usb-role-switch atrribute
to have the user-space check current device role
of otg cability ports

Signed-off-by: Wayne Chang <waynec@nvidia.com>
Signed-off-by: Haotien Hsu <haotienh@nvidia.com>
---
 drivers/phy/tegra/xusb.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Vinod Koul Sept. 24, 2022, 7:17 a.m. UTC | #1
On 21-09-22, 19:25, Haotien Hsu wrote:
> From: Wayne Chang <waynec@nvidia.com>
> 
> This patch enables the usb-role-switch atrribute
> to have the user-space check current device role
> of otg cability ports

typo cability


You can use 72 chars for changelog rather than limiting at 50chars :-(

> 
> Signed-off-by: Wayne Chang <waynec@nvidia.com>
> Signed-off-by: Haotien Hsu <haotienh@nvidia.com>
> ---
>  drivers/phy/tegra/xusb.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
> index aa5237eacd29..220ab7719ade 100644
> --- a/drivers/phy/tegra/xusb.c
> +++ b/drivers/phy/tegra/xusb.c
> @@ -656,6 +656,7 @@ static int tegra_xusb_setup_usb_role_switch(struct tegra_xusb_port *port)
>  	struct usb_role_switch_desc role_sx_desc = {
>  		.fwnode = dev_fwnode(&port->dev),
>  		.set = tegra_xusb_role_sw_set,
> +		.allow_userspace_control = true,
>  	};
>  	int err = 0;
>  
> -- 
> 2.25.1
Haotien Hsu Sept. 26, 2022, 5 a.m. UTC | #2
On 9/24/22 15:17, Vinod Koul wrote:
> On 21-09-22, 19:25, Haotien Hsu wrote:
>> From: Wayne Chang <waynec@nvidia.com>
>>
>> This patch enables the usb-role-switch atrribute
>> to have the user-space check current device role
>> of otg cability ports
> 
> typo cability
> 
> 
> You can use 72 chars for changelog rather than limiting at 50chars :-(
>
Sorry for the typo and bad format.
I will resend this patch.
>>
>> Signed-off-by: Wayne Chang <waynec@nvidia.com>
>> Signed-off-by: Haotien Hsu <haotienh@nvidia.com>
>> ---
>>   drivers/phy/tegra/xusb.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
>> index aa5237eacd29..220ab7719ade 100644
>> --- a/drivers/phy/tegra/xusb.c
>> +++ b/drivers/phy/tegra/xusb.c
>> @@ -656,6 +656,7 @@ static int tegra_xusb_setup_usb_role_switch(struct tegra_xusb_port *port)
>>   	struct usb_role_switch_desc role_sx_desc = {
>>   		.fwnode = dev_fwnode(&port->dev),
>>   		.set = tegra_xusb_role_sw_set,
>> +		.allow_userspace_control = true,
>>   	};
>>   	int err = 0;
>>   
>> -- 
>> 2.25.1
>
diff mbox series

Patch

diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
index aa5237eacd29..220ab7719ade 100644
--- a/drivers/phy/tegra/xusb.c
+++ b/drivers/phy/tegra/xusb.c
@@ -656,6 +656,7 @@  static int tegra_xusb_setup_usb_role_switch(struct tegra_xusb_port *port)
 	struct usb_role_switch_desc role_sx_desc = {
 		.fwnode = dev_fwnode(&port->dev),
 		.set = tegra_xusb_role_sw_set,
+		.allow_userspace_control = true,
 	};
 	int err = 0;