diff mbox series

[RFC,01/10] dt-bindings: apple,aic: Fix required item "apple,fiq-index" in affinity description

Message ID 20220909135103.98179-2-j@jannau.net
State Accepted, archived
Headers show
Series Apple M1 Pro/Max/Ultra device trees | expand

Checks

Context Check Description
robh/checkpatch warning total: 0 errors, 1 warnings, 8 lines checked
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Janne Grunau Sept. 9, 2022, 1:50 p.m. UTC
Fixes: dba07ad11384 ("dt-bindings: apple,aic: Add affinity description for per-cpu pseudo-interrupts")
Signed-off-by: Janne Grunau <j@jannau.net>
---

 .../devicetree/bindings/interrupt-controller/apple,aic.yaml     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Krzysztof Kozlowski Sept. 10, 2022, 9:54 a.m. UTC | #1
On 09/09/2022 15:50, Janne Grunau wrote:
> Fixes: dba07ad11384 ("dt-bindings: apple,aic: Add affinity description for per-cpu pseudo-interrupts")

You miss commit description.

Best regards,
Krzysztof
Marc Zyngier Sept. 10, 2022, 10:37 a.m. UTC | #2
On Fri, 09 Sep 2022 14:50:54 +0100,
Janne Grunau <j@jannau.net> wrote:
> 
> Fixes: dba07ad11384 ("dt-bindings: apple,aic: Add affinity description for per-cpu pseudo-interrupts")
> Signed-off-by: Janne Grunau <j@jannau.net>
> ---
> 
>  .../devicetree/bindings/interrupt-controller/apple,aic.yaml     | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml b/Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml
> index 85c85b694217..e18107eafe7c 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml
> @@ -96,7 +96,7 @@ properties:
>                Documentation/devicetree/bindings/arm/cpus.yaml).
>  
>          required:
> -          - fiq-index
> +          - apple,fiq-index
>            - cpus
>  
>  required:

With a commit message added,

Acked-by: Marc Zyngier <maz@kernel.org>

	M.
Janne Grunau Sept. 10, 2022, 11:43 a.m. UTC | #3
On 2022-09-10 11:37:20 +0100, Marc Zyngier wrote:
> On Fri, 09 Sep 2022 14:50:54 +0100,
> Janne Grunau <j@jannau.net> wrote:
> > 
> > Fixes: dba07ad11384 ("dt-bindings: apple,aic: Add affinity description for per-cpu pseudo-interrupts")
> > Signed-off-by: Janne Grunau <j@jannau.net>
> > ---
> > 
> >  .../devicetree/bindings/interrupt-controller/apple,aic.yaml     | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml b/Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml
> > index 85c85b694217..e18107eafe7c 100644
> > --- a/Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml
> > +++ b/Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml
> > @@ -96,7 +96,7 @@ properties:
> >                Documentation/devicetree/bindings/arm/cpus.yaml).
> >  
> >          required:
> > -          - fiq-index
> > +          - apple,fiq-index
> >            - cpus
> >  
> >  required:
> 
> With a commit message added,

I've added

| The required list used "fiq-index" instead of "apple,fiq-index"
| described as property and used in the dts. Add the missing "apple,"
| prefix.

as commit description.

> Acked-by: Marc Zyngier <maz@kernel.org>

Thanks,
Janne
Marc Zyngier Sept. 10, 2022, 2:21 p.m. UTC | #4
On Sat, 10 Sep 2022 12:43:24 +0100,
Janne Grunau <j@jannau.net> wrote:
> 
> On 2022-09-10 11:37:20 +0100, Marc Zyngier wrote:
> > On Fri, 09 Sep 2022 14:50:54 +0100,
> > Janne Grunau <j@jannau.net> wrote:
> > > 
> > > Fixes: dba07ad11384 ("dt-bindings: apple,aic: Add affinity description for per-cpu pseudo-interrupts")
> > > Signed-off-by: Janne Grunau <j@jannau.net>
> > > ---
> > > 
> > >  .../devicetree/bindings/interrupt-controller/apple,aic.yaml     | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml b/Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml
> > > index 85c85b694217..e18107eafe7c 100644
> > > --- a/Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml
> > > +++ b/Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml
> > > @@ -96,7 +96,7 @@ properties:
> > >                Documentation/devicetree/bindings/arm/cpus.yaml).
> > >  
> > >          required:
> > > -          - fiq-index
> > > +          - apple,fiq-index
> > >            - cpus
> > >  
> > >  required:
> > 
> > With a commit message added,
> 
> I've added
> 
> | The required list used "fiq-index" instead of "apple,fiq-index"
> | described as property and used in the dts. Add the missing "apple,"
> | prefix.
> 
> as commit description.

Perfect, ship it.

	M.
Rob Herring Sept. 13, 2022, 1:08 p.m. UTC | #5
On Fri, 09 Sep 2022 15:50:54 +0200, Janne Grunau wrote:
> Fixes: dba07ad11384 ("dt-bindings: apple,aic: Add affinity description for per-cpu pseudo-interrupts")
> Signed-off-by: Janne Grunau <j@jannau.net>
> ---
> 
>  .../devicetree/bindings/interrupt-controller/apple,aic.yaml     | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Applied with added commit msg, thanks!
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml b/Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml
index 85c85b694217..e18107eafe7c 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml
+++ b/Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml
@@ -96,7 +96,7 @@  properties:
               Documentation/devicetree/bindings/arm/cpus.yaml).
 
         required:
-          - fiq-index
+          - apple,fiq-index
           - cpus
 
 required: