diff mbox series

[08/12] rockchip: puma-rk3399: remove useless CONFIG_SYS_SPI_U_BOOT_OFFS

Message ID 20220722160655.3904213-9-foss+uboot@0leil.net
State Superseded
Delegated to: Kever Yang
Headers show
Series Puma RK3399 migration to TPL and numerous fixes | expand

Commit Message

Quentin Schulz July 22, 2022, 4:06 p.m. UTC 
From: Quentin Schulz <quentin.schulz@theobroma-systems.com>

The SPL payload offset when booting from SPI defaults to
CONFIG_SYS_SPI_U_BOOT_OFFS but can be overridden by
u-boot,spl-payload-offset. The Device Tree for Puma Haikou has this
property so there's no need to have this one option in the defconfig,
especially since they are not in sync and therefore confusing.

Cc: Quentin Schulz <foss+uboot@0leil.net>
Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
---
 configs/puma-rk3399_defconfig | 1 -
 1 file changed, 1 deletion(-)

Comments

Kever Yang Sept. 1, 2022, 1:05 p.m. UTC | #1 
On 2022/7/23 00:06, Quentin Schulz wrote:
> From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
>
> The SPL payload offset when booting from SPI defaults to
> CONFIG_SYS_SPI_U_BOOT_OFFS but can be overridden by
> u-boot,spl-payload-offset. The Device Tree for Puma Haikou has this
> property so there's no need to have this one option in the defconfig,
> especially since they are not in sync and therefore confusing.
>
> Cc: Quentin Schulz <foss+uboot@0leil.net>
> Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>

Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>   configs/puma-rk3399_defconfig | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/configs/puma-rk3399_defconfig b/configs/puma-rk3399_defconfig
> index e218532d70..3567cd078b 100644
> --- a/configs/puma-rk3399_defconfig
> +++ b/configs/puma-rk3399_defconfig
> @@ -27,7 +27,6 @@ CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR=0x200
>   CONFIG_SPL_I2C=y
>   CONFIG_SPL_POWER=y
>   CONFIG_SPL_SPI_LOAD=y
> -CONFIG_SYS_SPI_U_BOOT_OFFS=0x20000
>   CONFIG_CMD_BOOTZ=y
>   CONFIG_CMD_GPT=y
>   CONFIG_CMD_I2C=y
diff mbox series

Patch

diff --git a/configs/puma-rk3399_defconfig b/configs/puma-rk3399_defconfig
index e218532d70..3567cd078b 100644
--- a/configs/puma-rk3399_defconfig
+++ b/configs/puma-rk3399_defconfig
@@ -27,7 +27,6 @@  CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR=0x200
 CONFIG_SPL_I2C=y
 CONFIG_SPL_POWER=y
 CONFIG_SPL_SPI_LOAD=y
-CONFIG_SYS_SPI_U_BOOT_OFFS=0x20000
 CONFIG_CMD_BOOTZ=y
 CONFIG_CMD_GPT=y
 CONFIG_CMD_I2C=y