diff mbox series

[08/11] DT: mtd: Convert orion-nand to YAML

Message ID 20220820194804.3352415-9-andrew@lunn.ch
State Changes Requested, archived
Headers show
Series Start converting MVEBU bindings to YAML | expand

Checks

Context Check Description
robh/checkpatch warning total: 0 errors, 1 warnings, 85 lines checked
robh/patch-applied success
robh/dt-meta-schema fail build log

Commit Message

Andrew Lunn Aug. 20, 2022, 7:48 p.m. UTC 
This works for Kirkwood, but orion5x has an odd bus structure
which results in some warnings.

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---
 .../bindings/mtd/marvell,orion-nand.yaml      | 85 +++++++++++++++++++
 .../devicetree/bindings/mtd/orion-nand.txt    | 50 -----------
 2 files changed, 85 insertions(+), 50 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/mtd/marvell,orion-nand.yaml
 delete mode 100644 Documentation/devicetree/bindings/mtd/orion-nand.txt

Comments

Rob Herring Aug. 21, 2022, 8:21 p.m. UTC | #1 
On Sat, 20 Aug 2022 21:48:01 +0200, Andrew Lunn wrote:
> This works for Kirkwood, but orion5x has an odd bus structure
> which results in some warnings.
> 
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> ---
>  .../bindings/mtd/marvell,orion-nand.yaml      | 85 +++++++++++++++++++
>  .../devicetree/bindings/mtd/orion-nand.txt    | 50 -----------
>  2 files changed, 85 insertions(+), 50 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/mtd/marvell,orion-nand.yaml
>  delete mode 100644 Documentation/devicetree/bindings/mtd/orion-nand.txt
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mtd/marvell,orion-nand.example.dtb: nand-controller@f4000000: #size-cells:0:0: 0 was expected
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mtd/nand-controller.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mtd/marvell,orion-nand.example.dtb: nand-controller@f4000000: #size-cells:0:0: 0 was expected
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mtd/marvell,orion-nand.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.
Andrew Lunn Aug. 22, 2022, 12:48 a.m. UTC | #2 
On Sun, Aug 21, 2022 at 03:21:26PM -0500, Rob Herring wrote:
> On Sat, 20 Aug 2022 21:48:01 +0200, Andrew Lunn wrote:
> > This works for Kirkwood, but orion5x has an odd bus structure
> > which results in some warnings.
> > 
> > Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> > ---
> >  .../bindings/mtd/marvell,orion-nand.yaml      | 85 +++++++++++++++++++
> >  .../devicetree/bindings/mtd/orion-nand.txt    | 50 -----------
> >  2 files changed, 85 insertions(+), 50 deletions(-)
> >  create mode 100644 Documentation/devicetree/bindings/mtd/marvell,orion-nand.yaml
> >  delete mode 100644 Documentation/devicetree/bindings/mtd/orion-nand.txt
> > 
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mtd/marvell,orion-nand.example.dtb: nand-controller@f4000000: #size-cells:0:0: 0 was expected
> 	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mtd/nand-controller.yaml
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mtd/marvell,orion-nand.example.dtb: nand-controller@f4000000: #size-cells:0:0: 0 was expected
> 	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mtd/marvell,orion-nand.yaml

Does the bot not apply patches N-1 before testing patch N? In this
case, if patch N-2 was applied, you would not see this warning.

      Andrew
Rob Herring Aug. 22, 2022, 1:43 p.m. UTC | #3 
On Mon, Aug 22, 2022 at 02:48:19AM +0200, Andrew Lunn wrote:
> On Sun, Aug 21, 2022 at 03:21:26PM -0500, Rob Herring wrote:
> > On Sat, 20 Aug 2022 21:48:01 +0200, Andrew Lunn wrote:
> > > This works for Kirkwood, but orion5x has an odd bus structure
> > > which results in some warnings.
> > > 
> > > Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> > > ---
> > >  .../bindings/mtd/marvell,orion-nand.yaml      | 85 +++++++++++++++++++
> > >  .../devicetree/bindings/mtd/orion-nand.txt    | 50 -----------
> > >  2 files changed, 85 insertions(+), 50 deletions(-)
> > >  create mode 100644 Documentation/devicetree/bindings/mtd/marvell,orion-nand.yaml
> > >  delete mode 100644 Documentation/devicetree/bindings/mtd/orion-nand.txt
> > > 
> > 
> > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> > 
> > yamllint warnings/errors:
> > 
> > dtschema/dtc warnings/errors:
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mtd/marvell,orion-nand.example.dtb: nand-controller@f4000000: #size-cells:0:0: 0 was expected
> > 	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mtd/nand-controller.yaml
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mtd/marvell,orion-nand.example.dtb: nand-controller@f4000000: #size-cells:0:0: 0 was expected
> > 	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mtd/marvell,orion-nand.yaml
> 
> Does the bot not apply patches N-1 before testing patch N? In this
> case, if patch N-2 was applied, you would not see this warning.

It does unless there is a failure and it drops the prior patches.

Rob
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mtd/marvell,orion-nand.yaml b/Documentation/devicetree/bindings/mtd/marvell,orion-nand.yaml
new file mode 100644
index 000000000000..127c12e6f5ce
--- /dev/null
+++ b/Documentation/devicetree/bindings/mtd/marvell,orion-nand.yaml
@@ -0,0 +1,85 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mtd/marvell,orion-nand.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Marvell Orion NAND Controller Device Tree Bindings
+
+allOf:
+  - $ref: "nand-controller.yaml"
+
+maintainers:
+  - Andrew Lunn <andrew@lunn.ch>
+
+properties:
+  "#address-cells": true
+  "#size-cells": true
+
+  compatible:
+    enum:
+      - marvell,orion-nand
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  cle:
+    description:
+      Address line number connected to CLE. Default is 0
+    $ref: /schemas/types.yaml#/definitions/uint32
+    minimum: 0
+    maximum: 255
+
+  ale:
+    description:
+      Address line number connected to ALE. Default is 1
+    $ref: /schemas/types.yaml#/definitions/uint32
+    minimum: 0
+    maximum: 255
+
+  bank-width:
+    description: Width (in bytes) of the bank.  Equal to the device width times
+      the number of interleaved chips.
+    $ref: /schemas/types.yaml#/definitions/uint32
+    enum: [ 1, 2, 4 ]
+
+  chip-delay:
+    description:
+      Chip dependent delay for transferring data from array to read
+      registers in usecs
+    $ref: /schemas/types.yaml#/definitions/uint32
+    minimum: 0
+    maximum: 255
+
+  partitions:
+    type: object
+
+patternProperties:
+  "@[0-9a-f]+$":
+    $ref: "/schemas/mtd/partitions/partition.yaml"
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    nand-controller@f4000000 {
+        #address-cells = <1>;
+        #size-cells = <1>;
+        cle = <0>;
+        ale = <1>;
+        bank-width = <1>;
+        chip-delay = <25>;
+        compatible = "marvell,orion-nand";
+        reg = <0xf4000000 0x400>;
+    };
+...
diff --git a/Documentation/devicetree/bindings/mtd/orion-nand.txt b/Documentation/devicetree/bindings/mtd/orion-nand.txt
deleted file mode 100644
index 2d6ab660e603..000000000000
--- a/Documentation/devicetree/bindings/mtd/orion-nand.txt
+++ /dev/null
@@ -1,50 +0,0 @@ 
-NAND support for Marvell Orion SoC platforms
-
-Required properties:
-- compatible : "marvell,orion-nand".
-- reg : Base physical address of the NAND and length of memory mapped
-	region
-
-Optional properties:
-- cle : Address line number connected to CLE. Default is 0
-- ale : Address line number connected to ALE. Default is 1
-- bank-width : Width in bytes of the device. Default is 1
-- chip-delay : Chip dependent delay for transferring data from array to read
-               registers in usecs
-
-The device tree may optionally contain sub-nodes describing partitions of the
-address space. See partition.txt for more detail.
-
-Example:
-
-nand@f4000000 {
-	#address-cells = <1>;
-	#size-cells = <1>;
-	cle = <0>;
-	ale = <1>;
-	bank-width = <1>;
-	chip-delay = <25>;
-	compatible = "marvell,orion-nand";
-	reg = <0xf4000000 0x400>;
-
-	partition@0 {
-		label = "u-boot";
-		reg = <0x0000000 0x100000>;
-		read-only;
-	};
-
-	partition@100000 {
-		label = "uImage";
-		reg = <0x0100000 0x200000>;
-	};
-
-	partition@300000 {
-		label = "dtb";
-		reg = <0x0300000 0x100000>;
-	};
-
-	partition@400000 {
-		label = "root";
-		reg = <0x0400000 0x7d00000>;
-	};
-};