diff mbox series

[v3,3/8] rockchip: remove binman temporary files when cleaning

Message ID 20220801160610.2330151-4-foss+uboot@0leil.net
State Superseded
Delegated to: Kever Yang
Headers show
Series migrate u-boot-rockchip.bin to binman and generate an image for SPI | expand

Commit Message

Quentin Schulz Aug. 1, 2022, 4:06 p.m. UTC 
From: Quentin Schulz <quentin.schulz@theobroma-systems.com>

Binman mkimage entry generates temporary files so let's remove them
when calling `make clean`.

Fixes: 9b312e26fc77 ("rockchip: Enable building a SPI ROM image on jerry")
Cc: Quentin Schulz <foss+uboot@0leil.net>
Reported-by: Johan Jonker <jbx6244@gmail.com>
Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
---

added in v3

 Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Johan Jonker Aug. 1, 2022, 6:59 p.m. UTC | #1 
Hi Quentin,

Beside removing the "real" annoyance is that these files popup when adding with "git add ." and are blocking branch changing with "git branch ...".
Maybe add to ".gitignore" as well or delete immediately. What's the use to keep them around?

Johan

On 8/1/22 18:06, Quentin Schulz wrote:
> From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
> 
> Binman mkimage entry generates temporary files so let's remove them
> when calling `make clean`.
> 
> Fixes: 9b312e26fc77 ("rockchip: Enable building a SPI ROM image on jerry")
> Cc: Quentin Schulz <foss+uboot@0leil.net>
> Reported-by: Johan Jonker <jbx6244@gmail.com>
> Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
> ---
> 
> added in v3
> 
>  Makefile | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index ff25f92974..bbb2a4c088 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2220,7 +2220,8 @@ CLEAN_FILES += include/bmp_logo.h include/bmp_logo_data.h \
>  	       lpc32xx-* bl31.c bl31.elf bl31_*.bin image.map tispl.bin* \
>  	       idbloader.img flash.bin flash.log defconfig keep-syms-lto.c \
>  	       mkimage-out.spl.mkimage mkimage.spl.mkimage imx-boot.map \
> -	       itb.fit.fit itb.fit.itb itb.map spl.map
> +	       itb.fit.fit itb.fit.itb itb.map spl.map mkimage-out.rom.mkimage \
> +	       mkimage.rom.mkimage rom.map simple-bin.map
>  
>  # Directories & files removed with 'make mrproper'
>  MRPROPER_DIRS  += include/config include/generated spl tpl \
Simon Glass Aug. 1, 2022, 7:13 p.m. UTC | #2 
Hi Johan,

On Mon, 1 Aug 2022 at 12:59, Johan Jonker <jbx6244@gmail.com> wrote:
>
> Hi Quentin,
>
> Beside removing the "real" annoyance is that these files popup when adding with "git add ." and are blocking branch changing with "git branch ...".
> Maybe add to ".gitignore" as well or delete immediately. What's the use to keep them around?

At this point I have to remind people to consider moving to
out-of-tree builds (make O=...)

Regards,
Simon
diff mbox series

Patch

diff --git a/Makefile b/Makefile
index ff25f92974..bbb2a4c088 100644
--- a/Makefile
+++ b/Makefile
@@ -2220,7 +2220,8 @@  CLEAN_FILES += include/bmp_logo.h include/bmp_logo_data.h \
 	       lpc32xx-* bl31.c bl31.elf bl31_*.bin image.map tispl.bin* \
 	       idbloader.img flash.bin flash.log defconfig keep-syms-lto.c \
 	       mkimage-out.spl.mkimage mkimage.spl.mkimage imx-boot.map \
-	       itb.fit.fit itb.fit.itb itb.map spl.map
+	       itb.fit.fit itb.fit.itb itb.map spl.map mkimage-out.rom.mkimage \
+	       mkimage.rom.mkimage rom.map simple-bin.map
 
 # Directories & files removed with 'make mrproper'
 MRPROPER_DIRS  += include/config include/generated spl tpl \