| Message ID | b28b8d554dd3d1fc6bed8fc7f5b9cb71e1880e38.1656502685.git.wqu@suse.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | U-boot: fs: add generic unaligned read offset handling | expand |
On Wed, Jun 29, 2022 at 07:38:22PM +0800, Qu Wenruo wrote: > That function is only utilized inside fat driver, unexport it. > > Signed-off-by: Qu Wenruo <wqu@suse.com> The series has a fails to build on nokia_rx51: https://source.denx.de/u-boot/u-boot/-/jobs/471877#L483 which to me says doing 64bit division (likely related to block size, etc) without using the appropriate helper macros to turn them in to bit shifts instead.
On 2022/7/26 06:28, Tom Rini wrote: > On Wed, Jun 29, 2022 at 07:38:22PM +0800, Qu Wenruo wrote: > >> That function is only utilized inside fat driver, unexport it. >> >> Signed-off-by: Qu Wenruo <wqu@suse.com> > > The series has a fails to build on nokia_rx51: > https://source.denx.de/u-boot/u-boot/-/jobs/471877#L483 > which to me says doing 64bit division (likely related to block size, > etc) without using the appropriate helper macros to turn them in to bit > shifts instead. > Should I update and resend the series or just send the incremental update to fix the U64/U32 division? Thanks, Qu
On Tue, Jul 26, 2022 at 09:35:51AM +0800, Qu Wenruo wrote: > > > On 2022/7/26 06:28, Tom Rini wrote: > > On Wed, Jun 29, 2022 at 07:38:22PM +0800, Qu Wenruo wrote: > > > > > That function is only utilized inside fat driver, unexport it. > > > > > > Signed-off-by: Qu Wenruo <wqu@suse.com> > > > > The series has a fails to build on nokia_rx51: > > https://source.denx.de/u-boot/u-boot/-/jobs/471877#L483 > > which to me says doing 64bit division (likely related to block size, > > etc) without using the appropriate helper macros to turn them in to bit > > shifts instead. > > > Should I update and resend the series or just send the incremental > update to fix the U64/U32 division? Please rebase and resend the whole series, thanks.
diff --git a/fs/fat/fat.c b/fs/fat/fat.c index df9ea2c028fc..dcceccbcee0a 100644 --- a/fs/fat/fat.c +++ b/fs/fat/fat.c @@ -1243,8 +1243,8 @@ out_free_itr: return ret; } -int file_fat_read_at(const char *filename, loff_t pos, void *buffer, - loff_t maxsize, loff_t *actread) +static int file_fat_read_at(const char *filename, loff_t pos, void *buffer, + loff_t maxsize, loff_t *actread) { fsdata fsdata; fat_itr *itr; diff --git a/include/fat.h b/include/fat.h index bd8e450b33a3..a9756fb4cd1b 100644 --- a/include/fat.h +++ b/include/fat.h @@ -200,8 +200,6 @@ static inline u32 sect_to_clust(fsdata *fsdata, int sect) int file_fat_detectfs(void); int fat_exists(const char *filename); int fat_size(const char *filename, loff_t *size); -int file_fat_read_at(const char *filename, loff_t pos, void *buffer, - loff_t maxsize, loff_t *actread); int file_fat_read(const char *filename, void *buffer, int maxsize); int fat_set_blk_dev(struct blk_desc *rbdd, struct disk_partition *info); int fat_register_device(struct blk_desc *dev_desc, int part_no);
That function is only utilized inside fat driver, unexport it. Signed-off-by: Qu Wenruo <wqu@suse.com> --- fs/fat/fat.c | 4 ++-- include/fat.h | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-)