Message ID | 20220720133758.11481-1-asmaa@nvidia.com |
---|---|
Headers | show |
Series | UBUNTU: SAUCE: i2c-mlxbf.c: support lock mechanism | expand |
On 7/20/22 07:37, Asmaa Mnebhi wrote: > Buglink: https://bugs.launchpad.net/bugs/1981105 > > SRU Justification: > > [Impact] > > Support the I2C lock mechanism, otherwise there could be unexpected behavior when an i2c bus is accessed by several entities like the linux driver, ATF driver and UEFI driver. Make sure to pick up the ATF/UEFI image to accompany this change > because at boot time ATF will ensure that the lock is released. > > [Fix] > > * Support lock and unlock > * replace ioremap_nocache with ioremap > > [Test Case] > > * Make sure the i2c-mlxbf.c driver is loaded and /dev/i2c-1 is created > * check that ipmitool from the BF->BMC and from the BMC->BF work (this only applies on boards with a BMC of course) > > [Regression Potential] > > Any of the test cases above could be impacted due to these changes. > Make sure you load the latest ATF/UEFI image to accompany this change. > > Acked-by: Tim Gardner <tim.gardner@canonical.com>
Tim just acked the rest of my i2c patches. -----Original Message----- From: Tim Gardner <tim.gardner@canonical.com> Sent: Wednesday, July 20, 2022 11:13 AM To: Asmaa Mnebhi <asmaa@nvidia.com>; kernel-team@lists.ubuntu.com Subject: ACK: [SRU][F:linux-bluefield][PATCH v3 0/1] UBUNTU: SAUCE: i2c-mlxbf.c: support lock mechanism On 7/20/22 07:37, Asmaa Mnebhi wrote: > Buglink: > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs > .launchpad.net%2Fbugs%2F1981105&data=05%7C01%7Casmaa%40nvidia.com% > 7Cd2e08f06fe5d4b19df2108da6a624da2%7C43083d15727340c1b7db39efd9ccc17a% > 7C0%7C0%7C637939267686864130%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwM > DAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C& > sdata=yMwEqeDzSmCeEAEMdc5FKdr18WvZlrk1sheujuCwdYo%3D&reserved=0 > > SRU Justification: > > [Impact] > > Support the I2C lock mechanism, otherwise there could be unexpected > behavior when an i2c bus is accessed by several entities like the linux driver, ATF driver and UEFI driver. Make sure to pick up the ATF/UEFI image to accompany this change because at boot time ATF will ensure that the lock is released. > > [Fix] > > * Support lock and unlock > * replace ioremap_nocache with ioremap > > [Test Case] > > * Make sure the i2c-mlxbf.c driver is loaded and /dev/i2c-1 is created > * check that ipmitool from the BF->BMC and from the BMC->BF work (this > only applies on boards with a BMC of course) > > [Regression Potential] > > Any of the test cases above could be impacted due to these changes. > Make sure you load the latest ATF/UEFI image to accompany this change. > > Acked-by: Tim Gardner <tim.gardner@canonical.com> -- ----------- Tim Gardner Canonical, Inc
Thanks Tim! -----Original Message----- From: Asmaa Mnebhi Sent: Wednesday, July 20, 2022 11:14 AM To: 'Tim Gardner' <tim.gardner@canonical.com>; kernel-team@lists.ubuntu.com Subject: RE: ACK: [SRU][F:linux-bluefield][PATCH v3 0/1] UBUNTU: SAUCE: i2c-mlxbf.c: support lock mechanism Tim just acked the rest of my i2c patches. -----Original Message----- From: Tim Gardner <tim.gardner@canonical.com> Sent: Wednesday, July 20, 2022 11:13 AM To: Asmaa Mnebhi <asmaa@nvidia.com>; kernel-team@lists.ubuntu.com Subject: ACK: [SRU][F:linux-bluefield][PATCH v3 0/1] UBUNTU: SAUCE: i2c-mlxbf.c: support lock mechanism On 7/20/22 07:37, Asmaa Mnebhi wrote: > Buglink: > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs > .launchpad.net%2Fbugs%2F1981105&data=05%7C01%7Casmaa%40nvidia.com% > 7Cd2e08f06fe5d4b19df2108da6a624da2%7C43083d15727340c1b7db39efd9ccc17a% > 7C0%7C0%7C637939267686864130%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwM > DAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C& > sdata=yMwEqeDzSmCeEAEMdc5FKdr18WvZlrk1sheujuCwdYo%3D&reserved=0 > > SRU Justification: > > [Impact] > > Support the I2C lock mechanism, otherwise there could be unexpected > behavior when an i2c bus is accessed by several entities like the linux driver, ATF driver and UEFI driver. Make sure to pick up the ATF/UEFI image to accompany this change because at boot time ATF will ensure that the lock is released. > > [Fix] > > * Support lock and unlock > * replace ioremap_nocache with ioremap > > [Test Case] > > * Make sure the i2c-mlxbf.c driver is loaded and /dev/i2c-1 is created > * check that ipmitool from the BF->BMC and from the BMC->BF work (this > only applies on boards with a BMC of course) > > [Regression Potential] > > Any of the test cases above could be impacted due to these changes. > Make sure you load the latest ATF/UEFI image to accompany this change. > > Acked-by: Tim Gardner <tim.gardner@canonical.com> -- ----------- Tim Gardner Canonical, Inc