| Message ID | 20220701152839.3419-1-asmaa@nvidia.com |
|---|---|
| Headers | show |
| Series | UBUNTU: SAUCE: ipmb_host.c: rename structs to be driver specific | expand |
On 7/1/22 09:28, Asmaa Mnebhi wrote: > Buglink: https://bugs.launchpad.net/bugs/1980537 > > SRU Justification: > > [Fix] > > * In later kernels, "struct request" is already declared in a common linux include file: > ./include/linux/blkdev.h > * So rename the structs to ipmb_host_request and ipmb_host_response so that they are specific to the > ipmb_host driver and don't cause compile errors in the future. > > [Test Case] > > * check that ipmb_host.c driver is loaded at boot time and with no errors > * lsmod > * check that the /dev/ipmi0 device file is created successfully > * send ipmi commands from the BF DPU to the BMC and make sure the response is as expected. > > [Regression Potential] > > Any of the test cases above could be impacted due to these changes. > > Asmaa Mnebhi (1): > UBUNTU: SAUCE: ipmb_host.c: rename structs to be driver specific > > drivers/char/ipmi/ipmb_host.c | 34 +++++++++++++++++----------------- > 1 file changed, 17 insertions(+), 17 deletions(-) > Acked-by: Tim Gardner <tim.gardner@canonical.com>
Acked-by: Zachary Tahenakos <zachary.tahenakos@canonical.com> On Fri, Jul 1, 2022 at 11:29 AM Asmaa Mnebhi <asmaa@nvidia.com> wrote: > Buglink: https://bugs.launchpad.net/bugs/1980537 > > SRU Justification: > > [Fix] > > * In later kernels, "struct request" is already declared in a common linux > include file: > ./include/linux/blkdev.h > * So rename the structs to ipmb_host_request and ipmb_host_response so > that they are specific to the > ipmb_host driver and don't cause compile errors in the future. > > [Test Case] > > * check that ipmb_host.c driver is loaded at boot time and with no errors > * lsmod > * check that the /dev/ipmi0 device file is created successfully > * send ipmi commands from the BF DPU to the BMC and make sure the response > is as expected. > > [Regression Potential] > > Any of the test cases above could be impacted due to these changes. > > Asmaa Mnebhi (1): > UBUNTU: SAUCE: ipmb_host.c: rename structs to be driver specific > > drivers/char/ipmi/ipmb_host.c | 34 +++++++++++++++++----------------- > 1 file changed, 17 insertions(+), 17 deletions(-) > > -- > 2.30.1 > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team >
Applied to f:bluefield. Thanks. -Zack On Fri, Jul 1, 2022 at 11:29 AM Asmaa Mnebhi <asmaa@nvidia.com> wrote: > Buglink: https://bugs.launchpad.net/bugs/1980537 > > SRU Justification: > > [Fix] > > * In later kernels, "struct request" is already declared in a common linux > include file: > ./include/linux/blkdev.h > * So rename the structs to ipmb_host_request and ipmb_host_response so > that they are specific to the > ipmb_host driver and don't cause compile errors in the future. > > [Test Case] > > * check that ipmb_host.c driver is loaded at boot time and with no errors > * lsmod > * check that the /dev/ipmi0 device file is created successfully > * send ipmi commands from the BF DPU to the BMC and make sure the response > is as expected. > > [Regression Potential] > > Any of the test cases above could be impacted due to these changes. > > Asmaa Mnebhi (1): > UBUNTU: SAUCE: ipmb_host.c: rename structs to be driver specific > > drivers/char/ipmi/ipmb_host.c | 34 +++++++++++++++++----------------- > 1 file changed, 17 insertions(+), 17 deletions(-) > > -- > 2.30.1 > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team >