| Message ID | 20220629060435.25297-3-vidyas@nvidia.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | PCI: tegra: Add Tegra234 PCIe support | expand |
On 29/06/2022 08:04, Vidya Sagar wrote: > From: Thierry Reding <treding@nvidia.com> > > Convert the Tegra194 PCIe bindings from the free-form text format to > json-schema. > > Signed-off-by: Vidya Sagar <vidyas@nvidia.com> > Signed-off-by: Thierry Reding <treding@nvidia.com> > --- > V3: > * New patch in this series. Added as part of addressing Rob's review > comment to convert the existing .txt file to .yaml schema You need to rebase on newer tree (judging by address list). Changes on some old kernel are not accepted. > > .../bindings/pci/nvidia,tegra194-pcie-ep.yaml | 239 ++++++++++++++++ > .../bindings/pci/nvidia,tegra194-pcie.txt | 245 ----------------- > .../bindings/pci/nvidia,tegra194-pcie.yaml | 254 ++++++++++++++++++ > .../devicetree/bindings/pci/snps,dw-pcie.yaml | 2 +- > 4 files changed, 494 insertions(+), 246 deletions(-) > create mode 100644 Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie-ep.yaml > delete mode 100644 Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.txt > create mode 100644 Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml > > diff --git a/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie-ep.yaml > new file mode 100644 > index 000000000000..4f7cb7fe378e > --- /dev/null > +++ b/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie-ep.yaml > @@ -0,0 +1,239 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pci/nvidia,tegra194-pcie-ep.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NVIDIA Tegra194 (and later) PCIe endpoint controller (Synopsys DesignWare Core based) > + > +maintainers: > + - Thierry Reding <thierry.reding@gmail.com> > + - Jon Hunter <jonathanh@nvidia.com> > + - Vidya Sagar <vidyas@nvidia.com> > + > +description: | > + This PCIe controller is based on the Synopsis Designware PCIe IP and thus inherits all the common > + properties defined in snps,dw-pcie-ep.yaml. Some of the controller instances are dual mode where > + in they can work either in root port mode or endpoint mode but one at a time. Wrap according to Linux coding style, so at 80 character. > + > + On Tegra194, controllers C0, C4 and C5 support endpoint mode. > + > + Note: On Tegra194's P2972-0000 platform, only C5 controller can be enabled to operate in the > + endpoint mode because of the way the platform is designed. > + > +properties: > + compatible: > + enum: > + - nvidia,tegra194-pcie-ep > + > + reg: > + items: > + - description: controller's application logic registers > + - description: iATU and DMA registers. This is where the iATU (internal Address Translation > + Unit) registers of the PCIe core are made available for software access. > + - description: The aperture where the root port's own configuration registers are available. > + - description: Aperture used to map the remote root-complex' address space. > + > + reg-names: > + items: > + - const: appl > + - const: atu_dma > + - const: dbi > + - const: addr_space > + > + interrupts: > + items: > + - description: controller interrupt > + > + interrupt-names: > + items: > + - const: intr > + > + clocks: > + items: > + - description: module clock > + > + clock-names: > + items: > + - const: core > + > + resets: > + items: > + - description: APB bus interface reset > + - description: module reset > + > + reset-names: > + items: > + - const: apb > + - const: core > + > + reset-gpios: > + description: Must contain a phandle to a GPIO controller followed by GPIO that is being used as > + PERST input signal. Please refer to pci.txt document. > + > + phys: > + minItems: 1 > + maxItems: 16 > + > + phy-names: > + minItems: 1 > + maxItems: 16 > + items: > + pattern: "^p2u-[0-9]+$" No, because this allows any/unspecified order. Please list the items, so the order is fixed. > + > + power-domains: maxItems: 1 > + description: | > + A phandle to the node that controls power to the respective PCIe controller and a specifier > + name for the PCIe controller. Following are the specifiers for the different PCIe > + controllers: > + > + - TEGRA194_POWER_DOMAIN_PCIEX8B: C0 > + - TEGRA194_POWER_DOMAIN_PCIEX1A: C1 > + - TEGRA194_POWER_DOMAIN_PCIEX1A: C2 > + - TEGRA194_POWER_DOMAIN_PCIEX1A: C3 > + - TEGRA194_POWER_DOMAIN_PCIEX4A: C4 > + - TEGRA194_POWER_DOMAIN_PCIEX8A: C5 No need to list contents of the header file. > + > + these specifiers are defined in "include/dt-bindings/power/tegra194-powergate.h" file. > + > + interconnects: > + items: > + - description: memory read client > + - description: memory write client > + > + interconnect-names: > + items: > + - const: dma-mem # read > + - const: write > + > + dma-coherent: true > + > + num-ib-windows: > + description: number of inbound address translation windows > + maxItems: 1 > + deprecated: true This property was not in old bindings and you did not mention any changes done during conversion. > + > + num-ob-windows: > + description: number of outbound address translation windows > + maxItems: 1 > + deprecated: true The same. > + > + nvidia,bpmp: > + $ref: /schemas/types.yaml#/definitions/phandle-array > + description: | > + Must contain a pair of phandle to BPMP controller node followed by controller ID. Following > + are the controller IDs for each controller: > + > + 0: C0 > + 1: C1 > + 2: C2 > + 3: C3 > + 4: C4 > + 5: C5 > + items: > + - items: > + - minimum: 0 > + maximum: 0xffffffff > + - enum: [ 0, 1, 2, 3, 4, 5 ] > + > + nvidia,aspm-cmrt-us: > + description: Common Mode Restore Time for proper operation of ASPM to be specified in > + microseconds > + > + nvidia,aspm-pwr-on-t-us: > + description: Power On time for proper operation of ASPM to be specified in microseconds > + > + nvidia,aspm-l0s-entrance-latency-us: > + description: ASPM L0s entrance latency to be specified in microseconds > + > + vddio-pex-ctl-supply: > + description: A phandle to the regulator supply for PCIe side band signals. > + > + nvidia,refclk-select-gpios: > + description: Must contain a phandle to a GPIO controller followed by GPIO that is being used to > + enable REFCLK to controller from host > + $ref: /schemas/types.yaml#/definitions/phandle-array No need for ref. But you need maxItems. > + > +allOf: > + - $ref: "/schemas/pci/pci-ep.yaml#" No need for quotes. > + > +unevaluatedProperties: false > + > +required: > + - compatible > + - reg > + - reg-names > + - num-ib-windows > + - num-ob-windows > + - interrupts > + - interrupt-names > + - clocks > + - clock-names > + - resets > + - reset-names > + - power-domains > + - reset-gpios > + - num-lanes > + - phys > + - phy-names > + - nvidia,bpmp > + > +examples: > + - | > + #include <dt-bindings/clock/tegra194-clock.h> > + #include <dt-bindings/gpio/tegra194-gpio.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/power/tegra194-powergate.h> > + #include <dt-bindings/reset/tegra194-reset.h> > + > + bus@0 { > + #address-cells = <2>; > + #size-cells = <2>; > + ranges = <0x0 0x0 0x0 0x8 0x0>; > + > + pcie-ep@141a0000 { > + compatible = "nvidia,tegra194-pcie-ep"; > + reg = <0x00 0x141a0000 0x0 0x00020000>, /* appl registers (128K) */ > + <0x00 0x3a040000 0x0 0x00040000>, /* iATU_DMA reg space (256K) */ > + <0x00 0x3a080000 0x0 0x00040000>, /* DBI reg space (256K) */ > + <0x1c 0x00000000 0x4 0x00000000>; /* Address Space (16G) */ > + reg-names = "appl", "atu_dma", "dbi", "addr_space"; > + interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>; /* controller interrupt */ > + interrupt-names = "intr"; > + > + clocks = <&bpmp TEGRA194_CLK_PEX1_CORE_5>; > + clock-names = "core"; > + > + resets = <&bpmp TEGRA194_RESET_PEX1_CORE_5_APB>, > + <&bpmp TEGRA194_RESET_PEX1_CORE_5>; > + reset-names = "apb", "core"; > + > + power-domains = <&bpmp TEGRA194_POWER_DOMAIN_PCIEX8A>; > + pinctrl-names = "default"; > + pinctrl-0 = <&clkreq_c5_bi_dir_state>; > + > + nvidia,bpmp = <&bpmp 5>; > + > + nvidia,aspm-cmrt-us = <60>; > + nvidia,aspm-pwr-on-t-us = <20>; > + nvidia,aspm-l0s-entrance-latency-us = <3>; > + > + vddio-pex-ctl-supply = <&vdd_1v8ao>; > + > + reset-gpios = <&gpio TEGRA194_MAIN_GPIO(GG, 1) GPIO_ACTIVE_LOW>; > + > + nvidia,refclk-select-gpios = <&gpio_aon TEGRA194_AON_GPIO(AA, 5) > + GPIO_ACTIVE_HIGH>; > + > + num-lanes = <8>; > + num-ib-windows = <2>; > + num-ob-windows = <8>; Skip deprecated properties from example. > + > + phys = <&p2u_nvhs_0>, <&p2u_nvhs_1>, <&p2u_nvhs_2>, > + <&p2u_nvhs_3>, <&p2u_nvhs_4>, <&p2u_nvhs_5>, > + <&p2u_nvhs_6>, <&p2u_nvhs_7>; > + > + phy-names = "p2u-0", "p2u-1", "p2u-2", "p2u-3", "p2u-4", > + "p2u-5", "p2u-6", "p2u-7"; > + }; > + }; > diff --git a/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.txt b/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.txt > deleted file mode 100644 > index 8e4f9bfb316d..000000000000 > --- a/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.txt > +++ /dev/null > @@ -1,245 +0,0 @@ > -NVIDIA Tegra PCIe controller (Synopsys DesignWare Core based) > - > -This PCIe controller is based on the Synopsis Designware PCIe IP > -and thus inherits all the common properties defined in snps,dw-pcie.yaml and > -snps,dw-pcie-ep.yaml. > -Some of the controller instances are dual mode where in they can work either > -in root port mode or endpoint mode but one at a time. > - > -Required properties: > -- power-domains: A phandle to the node that controls power to the respective > - PCIe controller and a specifier name for the PCIe controller. Following are > - the specifiers for the different PCIe controllers > - TEGRA194_POWER_DOMAIN_PCIEX8B: C0 > - TEGRA194_POWER_DOMAIN_PCIEX1A: C1 > - TEGRA194_POWER_DOMAIN_PCIEX1A: C2 > - TEGRA194_POWER_DOMAIN_PCIEX1A: C3 > - TEGRA194_POWER_DOMAIN_PCIEX4A: C4 > - TEGRA194_POWER_DOMAIN_PCIEX8A: C5 > - these specifiers are defined in > - "include/dt-bindings/power/tegra194-powergate.h" file. > -- reg: A list of physical base address and length pairs for each set of > - controller registers. Must contain an entry for each entry in the reg-names > - property. > -- reg-names: Must include the following entries: > - "appl": Controller's application logic registers > - "config": As per the definition in snps,dw-pcie.yaml > - "atu_dma": iATU and DMA registers. This is where the iATU (internal Address > - Translation Unit) registers of the PCIe core are made available > - for SW access. > - "dbi": The aperture where root port's own configuration registers are > - available > -- interrupts: A list of interrupt outputs of the controller. Must contain an > - entry for each entry in the interrupt-names property. > -- interrupt-names: Must include the following entries: > - "intr": The Tegra interrupt that is asserted for controller interrupts > -- clocks: Must contain an entry for each entry in clock-names. > - See ../clocks/clock-bindings.txt for details. > -- clock-names: Must include the following entries: > - - core > -- resets: Must contain an entry for each entry in reset-names. > - See ../reset/reset.txt for details. > -- reset-names: Must include the following entries: > - - apb > - - core > -- phys: Must contain a phandle to P2U PHY for each entry in phy-names. > -- phy-names: Must include an entry for each active lane. > - "p2u-N": where N ranges from 0 to one less than the total number of lanes > -- nvidia,bpmp: Must contain a pair of phandle to BPMP controller node followed > - by controller-id. Following are the controller ids for each controller. > - 0: C0 > - 1: C1 > - 2: C2 > - 3: C3 > - 4: C4 > - 5: C5 > -- vddio-pex-ctl-supply: Regulator supply for PCIe side band signals > - > -RC mode: > -- compatible: Tegra19x must contain "nvidia,tegra194-pcie" > -- device_type: Must be "pci" for RC mode > -- interrupt-names: Must include the following entries: > - "msi": The Tegra interrupt that is asserted when an MSI is received > -- bus-range: Range of bus numbers associated with this controller > -- #address-cells: Address representation for root ports (must be 3) > - - cell 0 specifies the bus and device numbers of the root port: > - [23:16]: bus number > - [15:11]: device number > - - cell 1 denotes the upper 32 address bits and should be 0 > - - cell 2 contains the lower 32 address bits and is used to translate to the > - CPU address space > -- #size-cells: Size representation for root ports (must be 2) > -- ranges: Describes the translation of addresses for root ports and standard > - PCI regions. The entries must be 7 cells each, where the first three cells > - correspond to the address as described for the #address-cells property > - above, the fourth and fifth cells are for the physical CPU address to > - translate to and the sixth and seventh cells are as described for the > - #size-cells property above. > - - Entries setup the mapping for the standard I/O, memory and > - prefetchable PCI regions. The first cell determines the type of region > - that is setup: > - - 0x81000000: I/O memory region > - - 0x82000000: non-prefetchable memory region > - - 0xc2000000: prefetchable memory region > - Please refer to the standard PCI bus binding document for a more detailed > - explanation. > -- #interrupt-cells: Size representation for interrupts (must be 1) > -- interrupt-map-mask and interrupt-map: Standard PCI IRQ mapping properties > - Please refer to the standard PCI bus binding document for a more detailed > - explanation. > - > -EP mode: > -In Tegra194, Only controllers C0, C4 & C5 support EP mode. > -- compatible: Tegra19x must contain "nvidia,tegra194-pcie-ep" > -- reg-names: Must include the following entries: > - "addr_space": Used to map remote RC address space > -- reset-gpios: Must contain a phandle to a GPIO controller followed by > - GPIO that is being used as PERST input signal. Please refer to pci.txt > - document. > - > -Optional properties: > -- pinctrl-names: A list of pinctrl state names. > - It is mandatory for C5 controller and optional for other controllers. > - - "default": Configures PCIe I/O for proper operation. > -- pinctrl-0: phandle for the 'default' state of pin configuration. > - It is mandatory for C5 controller and optional for other controllers. > -- supports-clkreq: Refer to Documentation/devicetree/bindings/pci/pci.txt > -- nvidia,update-fc-fixup: This is a boolean property and needs to be present to > - improve performance when a platform is designed in such a way that it > - satisfies at least one of the following conditions thereby enabling root > - port to exchange optimum number of FC (Flow Control) credits with > - downstream devices > - 1. If C0/C4/C5 run at x1/x2 link widths (irrespective of speed and MPS) > - 2. If C0/C1/C2/C3/C4/C5 operate at their respective max link widths and > - a) speed is Gen-2 and MPS is 256B > - b) speed is >= Gen-3 with any MPS > -- nvidia,aspm-cmrt-us: Common Mode Restore Time for proper operation of ASPM > - to be specified in microseconds > -- nvidia,aspm-pwr-on-t-us: Power On time for proper operation of ASPM to be > - specified in microseconds > -- nvidia,aspm-l0s-entrance-latency-us: ASPM L0s entrance latency to be > - specified in microseconds > - > -RC mode: > -- vpcie3v3-supply: A phandle to the regulator node that supplies 3.3V to the slot > - if the platform has one such slot. (Ex:- x16 slot owned by C5 controller > - in p2972-0000 platform). > -- vpcie12v-supply: A phandle to the regulator node that supplies 12V to the slot > - if the platform has one such slot. (Ex:- x16 slot owned by C5 controller > - in p2972-0000 platform). > - > -EP mode: > -- nvidia,refclk-select-gpios: Must contain a phandle to a GPIO controller > - followed by GPIO that is being used to enable REFCLK to controller from host > - > -NOTE:- On Tegra194's P2972-0000 platform, only C5 controller can be enabled to > -operate in the endpoint mode because of the way the platform is designed. > - > -Examples: > -========= > - > -Tegra194 RC mode: > ------------------ > - > - pcie@14180000 { > - compatible = "nvidia,tegra194-pcie"; > - power-domains = <&bpmp TEGRA194_POWER_DOMAIN_PCIEX8B>; > - reg = <0x00 0x14180000 0x0 0x00020000 /* appl registers (128K) */ > - 0x00 0x38000000 0x0 0x00040000 /* configuration space (256K) */ > - 0x00 0x38040000 0x0 0x00040000>; /* iATU_DMA reg space (256K) */ > - reg-names = "appl", "config", "atu_dma"; > - > - #address-cells = <3>; > - #size-cells = <2>; > - device_type = "pci"; > - num-lanes = <8>; > - linux,pci-domain = <0>; > - > - pinctrl-names = "default"; > - pinctrl-0 = <&pex_rst_c5_out_state>, <&clkreq_c5_bi_dir_state>; > - > - clocks = <&bpmp TEGRA194_CLK_PEX0_CORE_0>; > - clock-names = "core"; > - > - resets = <&bpmp TEGRA194_RESET_PEX0_CORE_0_APB>, > - <&bpmp TEGRA194_RESET_PEX0_CORE_0>; > - reset-names = "apb", "core"; > - > - interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>, /* controller interrupt */ > - <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>; /* MSI interrupt */ > - interrupt-names = "intr", "msi"; > - > - #interrupt-cells = <1>; > - interrupt-map-mask = <0 0 0 0>; > - interrupt-map = <0 0 0 0 &gic GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>; > - > - nvidia,bpmp = <&bpmp 0>; > - > - supports-clkreq; > - nvidia,aspm-cmrt-us = <60>; > - nvidia,aspm-pwr-on-t-us = <20>; > - nvidia,aspm-l0s-entrance-latency-us = <3>; > - > - bus-range = <0x0 0xff>; > - ranges = <0x81000000 0x0 0x38100000 0x0 0x38100000 0x0 0x00100000 /* downstream I/O (1MB) */ > - 0x82000000 0x0 0x38200000 0x0 0x38200000 0x0 0x01E00000 /* non-prefetchable memory (30MB) */ > - 0xc2000000 0x18 0x00000000 0x18 0x00000000 0x4 0x00000000>; /* prefetchable memory (16GB) */ > - > - vddio-pex-ctl-supply = <&vdd_1v8ao>; > - vpcie3v3-supply = <&vdd_3v3_pcie>; > - vpcie12v-supply = <&vdd_12v_pcie>; > - > - phys = <&p2u_hsio_2>, <&p2u_hsio_3>, <&p2u_hsio_4>, > - <&p2u_hsio_5>; > - phy-names = "p2u-0", "p2u-1", "p2u-2", "p2u-3"; > - }; > - > -Tegra194 EP mode: > ------------------ > - > - pcie-ep@141a0000 { > - compatible = "nvidia,tegra194-pcie-ep", "snps,dw-pcie-ep"; > - power-domains = <&bpmp TEGRA194_POWER_DOMAIN_PCIEX8A>; > - reg = <0x00 0x141a0000 0x0 0x00020000 /* appl registers (128K) */ > - 0x00 0x3a040000 0x0 0x00040000 /* iATU_DMA reg space (256K) */ > - 0x00 0x3a080000 0x0 0x00040000 /* DBI reg space (256K) */ > - 0x1c 0x00000000 0x4 0x00000000>; /* Address Space (16G) */ > - reg-names = "appl", "atu_dma", "dbi", "addr_space"; > - > - num-lanes = <8>; > - num-ib-windows = <2>; > - num-ob-windows = <8>; > - > - pinctrl-names = "default"; > - pinctrl-0 = <&clkreq_c5_bi_dir_state>; > - > - clocks = <&bpmp TEGRA194_CLK_PEX1_CORE_5>; > - clock-names = "core"; > - > - resets = <&bpmp TEGRA194_RESET_PEX1_CORE_5_APB>, > - <&bpmp TEGRA194_RESET_PEX1_CORE_5>; > - reset-names = "apb", "core"; > - > - interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>; /* controller interrupt */ > - interrupt-names = "intr"; > - > - nvidia,bpmp = <&bpmp 5>; > - > - nvidia,aspm-cmrt-us = <60>; > - nvidia,aspm-pwr-on-t-us = <20>; > - nvidia,aspm-l0s-entrance-latency-us = <3>; > - > - vddio-pex-ctl-supply = <&vdd_1v8ao>; > - > - reset-gpios = <&gpio TEGRA194_MAIN_GPIO(GG, 1) GPIO_ACTIVE_LOW>; > - > - nvidia,refclk-select-gpios = <&gpio_aon TEGRA194_AON_GPIO(AA, 5) > - GPIO_ACTIVE_HIGH>; > - > - phys = <&p2u_nvhs_0>, <&p2u_nvhs_1>, <&p2u_nvhs_2>, > - <&p2u_nvhs_3>, <&p2u_nvhs_4>, <&p2u_nvhs_5>, > - <&p2u_nvhs_6>, <&p2u_nvhs_7>; > - > - phy-names = "p2u-0", "p2u-1", "p2u-2", "p2u-3", "p2u-4", > - "p2u-5", "p2u-6", "p2u-7"; > - }; > diff --git a/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml b/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml > new file mode 100644 > index 000000000000..4a49dddf33bb > --- /dev/null > +++ b/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml > @@ -0,0 +1,254 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pci/nvidia,tegra194-pcie.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NVIDIA Tegra194 (and later) PCIe controller (Synopsys DesignWare Core based) > + > +maintainers: > + - Thierry Reding <thierry.reding@gmail.com> > + - Jon Hunter <jonathanh@nvidia.com> > + - Vidya Sagar <vidyas@nvidia.com> > + > +description: | > + This PCIe controller is based on the Synopsis Designware PCIe IP and thus inherits all the common > + properties defined in snps,dw-pcie.yaml. Some of the controller instances are dual mode where in > + they can work either in root port mode or endpoint mode but one at a time. Also not properly wrapped. > + > + See nvidia,tegra194-pcie-ep.yaml for details on the endpoint mode device tree bindings. > + > +properties: > + compatible: > + enum: > + - nvidia,tegra194-pcie > + > + reg: > + items: > + - description: controller's application logic registers > + - description: configuration registers > + - description: iATU and DMA registers. This is where the iATU (internal Address Translation > + Unit) registers of the PCIe core are made available for software access. > + - description: The aperture where the root port's own configuration registers are available. > + > + reg-names: > + items: > + - const: appl > + - const: config > + - const: atu_dma > + - const: dbi > + > + interrupts: > + items: > + - description: controller interrupt > + - description: MSI interrupt > + > + interrupt-names: > + items: > + - const: intr > + - const: msi > + > + clocks: > + items: > + - description: module clock > + > + clock-names: > + items: > + - const: core > + > + resets: > + items: > + - description: APB bus interface reset > + - description: module reset > + > + reset-names: > + items: > + - const: apb > + - const: core > + > + phys: > + minItems: 1 > + maxItems: 16 > + > + phy-names: > + minItems: 1 > + maxItems: 16 > + items: > + pattern: "^p2u-[0-9]+$" Same problem. > + > + power-domains: > + description: | > + A phandle to the node that controls power to the respective PCIe controller and a specifier > + name for the PCIe controller. Following are the specifiers for the different PCIe > + controllers: > + > + - TEGRA194_POWER_DOMAIN_PCIEX8B: C0 > + - TEGRA194_POWER_DOMAIN_PCIEX1A: C1 > + - TEGRA194_POWER_DOMAIN_PCIEX1A: C2 > + - TEGRA194_POWER_DOMAIN_PCIEX1A: C3 > + - TEGRA194_POWER_DOMAIN_PCIEX4A: C4 > + - TEGRA194_POWER_DOMAIN_PCIEX8A: C5 Remove as well. > + > + these specifiers are defined in "include/dt-bindings/power/tegra194-powergate.h" file. > + > + interconnects: > + items: > + - description: memory read client > + - description: memory write client > + > + interconnect-names: > + items: > + - const: dma-mem # read > + - const: write > + > + dma-coherent: true > + > + supports-clkreq: > + description: see pci.txt for details This comes from schema (pci-bus.yaml). Remove here and in EP schema all properties which are defined by pci-bus or any other referenced schemas, unless you customize them more. > + > + nvidia,bpmp: > + $ref: /schemas/types.yaml#/definitions/phandle-array > + description: | > + Must contain a pair of phandle to BPMP controller node followed by controller ID. Following > + are the controller IDs for each controller: > + > + 0: C0 > + 1: C1 > + 2: C2 > + 3: C3 > + 4: C4 > + 5: C5 > + items: > + - items: > + - minimum: 0 > + maximum: 0xffffffff > + - enum: [ 0, 1, 2, 3, 4, 5 ] > + > + nvidia,update-fc-fixup: > + description: | > + This is a boolean property and needs to be present to improve performance when a platform is > + designed in such a way that it satisfies at least one of the following conditions thereby > + enabling root port to exchange optimum number of FC (Flow Control) credits with downstream Not wrapped. > + devices: > + > + 1. If C0/C4/C5 run at x1/x2 link widths (irrespective of speed and MPS) > + 2. If C0/C1/C2/C3/C4/C5 operate at their respective max link widths and > + a) speed is Gen-2 and MPS is 256B > + b) speed is >= Gen-3 with any MPS > + > + $ref: /schemas/types.yaml#/definitions/flag > + > + nvidia,aspm-cmrt-us: > + description: Common Mode Restore Time for proper operation of ASPM to be specified in > + microseconds > + > + nvidia,aspm-pwr-on-t-us: > + description: Power On time for proper operation of ASPM to be specified in microseconds > + > + nvidia,aspm-l0s-entrance-latency-us: > + description: ASPM L0s entrance latency to be specified in microseconds > + > + vddio-pex-ctl-supply: > + description: A phandle to the regulator supply for PCIe side band signals. > + > + vpcie3v3-supply: > + description: A phandle to the regulator node that supplies 3.3V to the slot if the platform has > + one such slot. (Ex:- x16 slot owned by C5 controller in p2972-0000 platform). > + > + vpcie12v-supply: > + description: A phandle to the regulator node that supplies 12V to the slot if the platform has > + one such slot. (Ex:- x16 slot owned by C5 controller in p2972-0000 platform). > + > +allOf: > + - $ref: "/schemas/pci/pci-bus.yaml#" > + - $ref: "/schemas/pci/snps,dw-pcie.yaml#" No need for quotes. > + > +unevaluatedProperties: false > + > +required: > + - compatible > + - reg > + - reg-names > + - interrupts > + - interrupt-names > + - interrupt-map > + - interrupt-map-mask > + - clocks > + - clock-names > + - resets > + - reset-names > + - power-domains > + - bus-range > + - ranges > + - vddio-pex-ctl-supply > + - num-lanes > + - phys > + - phy-names > + - nvidia,bpmp > + > +examples: > + - | > + #include <dt-bindings/clock/tegra194-clock.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/power/tegra194-powergate.h> > + #include <dt-bindings/reset/tegra194-reset.h> > + > + bus@0 { > + #address-cells = <2>; > + #size-cells = <2>; > + ranges = <0x0 0x0 0x0 0x8 0x0>; > + > + pcie@14180000 { > + compatible = "nvidia,tegra194-pcie"; > + power-domains = <&bpmp TEGRA194_POWER_DOMAIN_PCIEX8B>; > + reg = <0x0 0x14180000 0x0 0x00020000>, /* appl registers (128K) */ > + <0x0 0x38000000 0x0 0x00040000>, /* configuration space (256K) */ > + <0x0 0x38040000 0x0 0x00040000>, /* iATU_DMA reg space (256K) */ > + <0x0 0x38080000 0x0 0x00040000>; /* DBI reg space (256K) */ > + reg-names = "appl", "config", "atu_dma", "dbi"; > + > + #address-cells = <3>; > + #size-cells = <2>; > + device_type = "pci"; > + num-lanes = <8>; > + linux,pci-domain = <0>; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&pex_rst_c5_out_state>, <&clkreq_c5_bi_dir_state>; > + > + clocks = <&bpmp TEGRA194_CLK_PEX0_CORE_0>; > + clock-names = "core"; > + > + resets = <&bpmp TEGRA194_RESET_PEX0_CORE_0_APB>, > + <&bpmp TEGRA194_RESET_PEX0_CORE_0>; > + reset-names = "apb", "core"; > + > + interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>, /* controller interrupt */ > + <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>; /* MSI interrupt */ > + interrupt-names = "intr", "msi"; > + > + #interrupt-cells = <1>; > + interrupt-map-mask = <0 0 0 0>; > + interrupt-map = <0 0 0 0 &gic GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>; > + > + nvidia,bpmp = <&bpmp 0>; > + > + supports-clkreq; > + nvidia,aspm-cmrt-us = <60>; > + nvidia,aspm-pwr-on-t-us = <20>; > + nvidia,aspm-l0s-entrance-latency-us = <3>; > + > + bus-range = <0x0 0xff>; > + ranges = <0x81000000 0x0 0x38100000 0x0 0x38100000 0x0 0x00100000>, /* downstream I/O */ > + <0x82000000 0x0 0x38200000 0x0 0x38200000 0x0 0x01e00000>, /* non-prefetch memory */ > + <0xc2000000 0x18 0x00000000 0x18 0x00000000 0x4 0x00000000>; /* prefetchable memory */ > + > + vddio-pex-ctl-supply = <&vdd_1v8ao>; > + vpcie3v3-supply = <&vdd_3v3_pcie>; > + vpcie12v-supply = <&vdd_12v_pcie>; > + > + phys = <&p2u_hsio_2>, <&p2u_hsio_3>, <&p2u_hsio_4>, > + <&p2u_hsio_5>; > + phy-names = "p2u-0", "p2u-1", "p2u-2", "p2u-3"; > + }; > + }; > diff --git a/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml b/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml > index c90e5e2d25f6..7e0bf941fbfe 100644 > --- a/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml > @@ -35,7 +35,7 @@ properties: > maxItems: 5 > items: > enum: [ dbi, dbi2, config, atu, app, elbi, mgmt, ctrl, parf, cfg, link, > - ulreg, smu, mpu, apb, phy ] > + ulreg, smu, mpu, apb, phy, appl, atu_dma ] > > num-lanes: > description: | Best regards, Krzysztof
On Wed, Jun 29, 2022 at 11:34:26AM +0530, Vidya Sagar wrote: > From: Thierry Reding <treding@nvidia.com> > > Convert the Tegra194 PCIe bindings from the free-form text format to > json-schema. > > Signed-off-by: Vidya Sagar <vidyas@nvidia.com> > Signed-off-by: Thierry Reding <treding@nvidia.com> > --- > V3: > * New patch in this series. Added as part of addressing Rob's review > comment to convert the existing .txt file to .yaml schema > > .../bindings/pci/nvidia,tegra194-pcie-ep.yaml | 239 ++++++++++++++++ > .../bindings/pci/nvidia,tegra194-pcie.txt | 245 ----------------- > .../bindings/pci/nvidia,tegra194-pcie.yaml | 254 ++++++++++++++++++ > .../devicetree/bindings/pci/snps,dw-pcie.yaml | 2 +- > 4 files changed, 494 insertions(+), 246 deletions(-) > create mode 100644 Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie-ep.yaml > delete mode 100644 Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.txt > create mode 100644 Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml > > diff --git a/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie-ep.yaml > new file mode 100644 > index 000000000000..4f7cb7fe378e > --- /dev/null > +++ b/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie-ep.yaml > @@ -0,0 +1,239 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pci/nvidia,tegra194-pcie-ep.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NVIDIA Tegra194 (and later) PCIe endpoint controller (Synopsys DesignWare Core based) > + > +maintainers: > + - Thierry Reding <thierry.reding@gmail.com> > + - Jon Hunter <jonathanh@nvidia.com> > + - Vidya Sagar <vidyas@nvidia.com> > + > +description: | > + This PCIe controller is based on the Synopsis Designware PCIe IP and thus inherits all the common Wrap lines at 80 unless there's a benefit to a longer line. > + properties defined in snps,dw-pcie-ep.yaml. Some of the controller instances are dual mode where > + in they can work either in root port mode or endpoint mode but one at a time. > + > + On Tegra194, controllers C0, C4 and C5 support endpoint mode. > + > + Note: On Tegra194's P2972-0000 platform, only C5 controller can be enabled to operate in the > + endpoint mode because of the way the platform is designed. > + > +properties: > + compatible: > + enum: > + - nvidia,tegra194-pcie-ep > + > + reg: > + items: > + - description: controller's application logic registers > + - description: iATU and DMA registers. This is where the iATU (internal Address Translation > + Unit) registers of the PCIe core are made available for software access. > + - description: The aperture where the root port's own configuration registers are available. > + - description: Aperture used to map the remote root-complex' address space. > + > + reg-names: > + items: > + - const: appl > + - const: atu_dma > + - const: dbi > + - const: addr_space > + > + interrupts: > + items: > + - description: controller interrupt Just 'maxItems: 1' is enough. > + > + interrupt-names: > + items: > + - const: intr > + > + clocks: > + items: > + - description: module clock > + > + clock-names: > + items: > + - const: core > + > + resets: > + items: > + - description: APB bus interface reset > + - description: module reset > + > + reset-names: > + items: > + - const: apb > + - const: core > + > + reset-gpios: > + description: Must contain a phandle to a GPIO controller followed by GPIO that is being used as > + PERST input signal. Please refer to pci.txt document. > + > + phys: > + minItems: 1 > + maxItems: 16 One per lane? > + > + phy-names: > + minItems: 1 > + maxItems: 16 > + items: > + pattern: "^p2u-[0-9]+$" > + > + power-domains: > + description: | > + A phandle to the node that controls power to the respective PCIe controller and a specifier > + name for the PCIe controller. Following are the specifiers for the different PCIe > + controllers: > + > + - TEGRA194_POWER_DOMAIN_PCIEX8B: C0 > + - TEGRA194_POWER_DOMAIN_PCIEX1A: C1 > + - TEGRA194_POWER_DOMAIN_PCIEX1A: C2 > + - TEGRA194_POWER_DOMAIN_PCIEX1A: C3 > + - TEGRA194_POWER_DOMAIN_PCIEX4A: C4 > + - TEGRA194_POWER_DOMAIN_PCIEX8A: C5 > + > + these specifiers are defined in "include/dt-bindings/power/tegra194-powergate.h" file. > + > + interconnects: > + items: > + - description: memory read client > + - description: memory write client > + > + interconnect-names: > + items: > + - const: dma-mem # read > + - const: write > + > + dma-coherent: true > + > + num-ib-windows: > + description: number of inbound address translation windows > + maxItems: 1 > + deprecated: true > + > + num-ob-windows: > + description: number of outbound address translation windows > + maxItems: 1 > + deprecated: true > + > + nvidia,bpmp: > + $ref: /schemas/types.yaml#/definitions/phandle-array > + description: | > + Must contain a pair of phandle to BPMP controller node followed by controller ID. Following > + are the controller IDs for each controller: > + > + 0: C0 > + 1: C1 > + 2: C2 > + 3: C3 > + 4: C4 > + 5: C5 > + items: > + - items: > + - minimum: 0 > + maximum: 0xffffffff That's already the limit. Just a description is fine. > + - enum: [ 0, 1, 2, 3, 4, 5 ] maximum: 5 > + > + nvidia,aspm-cmrt-us: > + description: Common Mode Restore Time for proper operation of ASPM to be specified in > + microseconds > + > + nvidia,aspm-pwr-on-t-us: > + description: Power On time for proper operation of ASPM to be specified in microseconds > + > + nvidia,aspm-l0s-entrance-latency-us: > + description: ASPM L0s entrance latency to be specified in microseconds > + > + vddio-pex-ctl-supply: > + description: A phandle to the regulator supply for PCIe side band signals. > + > + nvidia,refclk-select-gpios: > + description: Must contain a phandle to a GPIO controller followed by GPIO that is being used to Don't need generic description of the GPIO binding. > + enable REFCLK to controller from host > + $ref: /schemas/types.yaml#/definitions/phandle-array Already has a type. > + > +allOf: > + - $ref: "/schemas/pci/pci-ep.yaml#" > + > +unevaluatedProperties: false > + > +required: > + - compatible > + - reg > + - reg-names > + - num-ib-windows > + - num-ob-windows > + - interrupts > + - interrupt-names > + - clocks > + - clock-names > + - resets > + - reset-names > + - power-domains > + - reset-gpios > + - num-lanes > + - phys > + - phy-names > + - nvidia,bpmp > + > +examples: > + - | > + #include <dt-bindings/clock/tegra194-clock.h> > + #include <dt-bindings/gpio/tegra194-gpio.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/power/tegra194-powergate.h> > + #include <dt-bindings/reset/tegra194-reset.h> > + > + bus@0 { > + #address-cells = <2>; > + #size-cells = <2>; > + ranges = <0x0 0x0 0x0 0x8 0x0>; > + > + pcie-ep@141a0000 { > + compatible = "nvidia,tegra194-pcie-ep"; > + reg = <0x00 0x141a0000 0x0 0x00020000>, /* appl registers (128K) */ > + <0x00 0x3a040000 0x0 0x00040000>, /* iATU_DMA reg space (256K) */ > + <0x00 0x3a080000 0x0 0x00040000>, /* DBI reg space (256K) */ > + <0x1c 0x00000000 0x4 0x00000000>; /* Address Space (16G) */ > + reg-names = "appl", "atu_dma", "dbi", "addr_space"; > + interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>; /* controller interrupt */ > + interrupt-names = "intr"; > + > + clocks = <&bpmp TEGRA194_CLK_PEX1_CORE_5>; > + clock-names = "core"; > + > + resets = <&bpmp TEGRA194_RESET_PEX1_CORE_5_APB>, > + <&bpmp TEGRA194_RESET_PEX1_CORE_5>; > + reset-names = "apb", "core"; > + > + power-domains = <&bpmp TEGRA194_POWER_DOMAIN_PCIEX8A>; > + pinctrl-names = "default"; > + pinctrl-0 = <&clkreq_c5_bi_dir_state>; > + > + nvidia,bpmp = <&bpmp 5>; > + > + nvidia,aspm-cmrt-us = <60>; > + nvidia,aspm-pwr-on-t-us = <20>; > + nvidia,aspm-l0s-entrance-latency-us = <3>; > + > + vddio-pex-ctl-supply = <&vdd_1v8ao>; > + > + reset-gpios = <&gpio TEGRA194_MAIN_GPIO(GG, 1) GPIO_ACTIVE_LOW>; > + > + nvidia,refclk-select-gpios = <&gpio_aon TEGRA194_AON_GPIO(AA, 5) > + GPIO_ACTIVE_HIGH>; > + > + num-lanes = <8>; > + num-ib-windows = <2>; > + num-ob-windows = <8>; > + > + phys = <&p2u_nvhs_0>, <&p2u_nvhs_1>, <&p2u_nvhs_2>, > + <&p2u_nvhs_3>, <&p2u_nvhs_4>, <&p2u_nvhs_5>, > + <&p2u_nvhs_6>, <&p2u_nvhs_7>; > + > + phy-names = "p2u-0", "p2u-1", "p2u-2", "p2u-3", "p2u-4", > + "p2u-5", "p2u-6", "p2u-7"; > + }; > + }; > diff --git a/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.txt b/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.txt > deleted file mode 100644 > index 8e4f9bfb316d..000000000000 > --- a/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.txt > +++ /dev/null > @@ -1,245 +0,0 @@ > -NVIDIA Tegra PCIe controller (Synopsys DesignWare Core based) > - > -This PCIe controller is based on the Synopsis Designware PCIe IP > -and thus inherits all the common properties defined in snps,dw-pcie.yaml and > -snps,dw-pcie-ep.yaml. > -Some of the controller instances are dual mode where in they can work either > -in root port mode or endpoint mode but one at a time. > - > -Required properties: > -- power-domains: A phandle to the node that controls power to the respective > - PCIe controller and a specifier name for the PCIe controller. Following are > - the specifiers for the different PCIe controllers > - TEGRA194_POWER_DOMAIN_PCIEX8B: C0 > - TEGRA194_POWER_DOMAIN_PCIEX1A: C1 > - TEGRA194_POWER_DOMAIN_PCIEX1A: C2 > - TEGRA194_POWER_DOMAIN_PCIEX1A: C3 > - TEGRA194_POWER_DOMAIN_PCIEX4A: C4 > - TEGRA194_POWER_DOMAIN_PCIEX8A: C5 > - these specifiers are defined in > - "include/dt-bindings/power/tegra194-powergate.h" file. > -- reg: A list of physical base address and length pairs for each set of > - controller registers. Must contain an entry for each entry in the reg-names > - property. > -- reg-names: Must include the following entries: > - "appl": Controller's application logic registers > - "config": As per the definition in snps,dw-pcie.yaml > - "atu_dma": iATU and DMA registers. This is where the iATU (internal Address > - Translation Unit) registers of the PCIe core are made available > - for SW access. > - "dbi": The aperture where root port's own configuration registers are > - available > -- interrupts: A list of interrupt outputs of the controller. Must contain an > - entry for each entry in the interrupt-names property. > -- interrupt-names: Must include the following entries: > - "intr": The Tegra interrupt that is asserted for controller interrupts > -- clocks: Must contain an entry for each entry in clock-names. > - See ../clocks/clock-bindings.txt for details. > -- clock-names: Must include the following entries: > - - core > -- resets: Must contain an entry for each entry in reset-names. > - See ../reset/reset.txt for details. > -- reset-names: Must include the following entries: > - - apb > - - core > -- phys: Must contain a phandle to P2U PHY for each entry in phy-names. > -- phy-names: Must include an entry for each active lane. > - "p2u-N": where N ranges from 0 to one less than the total number of lanes > -- nvidia,bpmp: Must contain a pair of phandle to BPMP controller node followed > - by controller-id. Following are the controller ids for each controller. > - 0: C0 > - 1: C1 > - 2: C2 > - 3: C3 > - 4: C4 > - 5: C5 > -- vddio-pex-ctl-supply: Regulator supply for PCIe side band signals > - > -RC mode: > -- compatible: Tegra19x must contain "nvidia,tegra194-pcie" > -- device_type: Must be "pci" for RC mode > -- interrupt-names: Must include the following entries: > - "msi": The Tegra interrupt that is asserted when an MSI is received > -- bus-range: Range of bus numbers associated with this controller > -- #address-cells: Address representation for root ports (must be 3) > - - cell 0 specifies the bus and device numbers of the root port: > - [23:16]: bus number > - [15:11]: device number > - - cell 1 denotes the upper 32 address bits and should be 0 > - - cell 2 contains the lower 32 address bits and is used to translate to the > - CPU address space > -- #size-cells: Size representation for root ports (must be 2) > -- ranges: Describes the translation of addresses for root ports and standard > - PCI regions. The entries must be 7 cells each, where the first three cells > - correspond to the address as described for the #address-cells property > - above, the fourth and fifth cells are for the physical CPU address to > - translate to and the sixth and seventh cells are as described for the > - #size-cells property above. > - - Entries setup the mapping for the standard I/O, memory and > - prefetchable PCI regions. The first cell determines the type of region > - that is setup: > - - 0x81000000: I/O memory region > - - 0x82000000: non-prefetchable memory region > - - 0xc2000000: prefetchable memory region > - Please refer to the standard PCI bus binding document for a more detailed > - explanation. > -- #interrupt-cells: Size representation for interrupts (must be 1) > -- interrupt-map-mask and interrupt-map: Standard PCI IRQ mapping properties > - Please refer to the standard PCI bus binding document for a more detailed > - explanation. > - > -EP mode: > -In Tegra194, Only controllers C0, C4 & C5 support EP mode. > -- compatible: Tegra19x must contain "nvidia,tegra194-pcie-ep" > -- reg-names: Must include the following entries: > - "addr_space": Used to map remote RC address space > -- reset-gpios: Must contain a phandle to a GPIO controller followed by > - GPIO that is being used as PERST input signal. Please refer to pci.txt > - document. > - > -Optional properties: > -- pinctrl-names: A list of pinctrl state names. > - It is mandatory for C5 controller and optional for other controllers. > - - "default": Configures PCIe I/O for proper operation. > -- pinctrl-0: phandle for the 'default' state of pin configuration. > - It is mandatory for C5 controller and optional for other controllers. > -- supports-clkreq: Refer to Documentation/devicetree/bindings/pci/pci.txt > -- nvidia,update-fc-fixup: This is a boolean property and needs to be present to > - improve performance when a platform is designed in such a way that it > - satisfies at least one of the following conditions thereby enabling root > - port to exchange optimum number of FC (Flow Control) credits with > - downstream devices > - 1. If C0/C4/C5 run at x1/x2 link widths (irrespective of speed and MPS) > - 2. If C0/C1/C2/C3/C4/C5 operate at their respective max link widths and > - a) speed is Gen-2 and MPS is 256B > - b) speed is >= Gen-3 with any MPS > -- nvidia,aspm-cmrt-us: Common Mode Restore Time for proper operation of ASPM > - to be specified in microseconds > -- nvidia,aspm-pwr-on-t-us: Power On time for proper operation of ASPM to be > - specified in microseconds > -- nvidia,aspm-l0s-entrance-latency-us: ASPM L0s entrance latency to be > - specified in microseconds > - > -RC mode: > -- vpcie3v3-supply: A phandle to the regulator node that supplies 3.3V to the slot > - if the platform has one such slot. (Ex:- x16 slot owned by C5 controller > - in p2972-0000 platform). > -- vpcie12v-supply: A phandle to the regulator node that supplies 12V to the slot > - if the platform has one such slot. (Ex:- x16 slot owned by C5 controller > - in p2972-0000 platform). > - > -EP mode: > -- nvidia,refclk-select-gpios: Must contain a phandle to a GPIO controller > - followed by GPIO that is being used to enable REFCLK to controller from host > - > -NOTE:- On Tegra194's P2972-0000 platform, only C5 controller can be enabled to > -operate in the endpoint mode because of the way the platform is designed. > - > -Examples: > -========= > - > -Tegra194 RC mode: > ------------------ > - > - pcie@14180000 { > - compatible = "nvidia,tegra194-pcie"; > - power-domains = <&bpmp TEGRA194_POWER_DOMAIN_PCIEX8B>; > - reg = <0x00 0x14180000 0x0 0x00020000 /* appl registers (128K) */ > - 0x00 0x38000000 0x0 0x00040000 /* configuration space (256K) */ > - 0x00 0x38040000 0x0 0x00040000>; /* iATU_DMA reg space (256K) */ > - reg-names = "appl", "config", "atu_dma"; > - > - #address-cells = <3>; > - #size-cells = <2>; > - device_type = "pci"; > - num-lanes = <8>; > - linux,pci-domain = <0>; > - > - pinctrl-names = "default"; > - pinctrl-0 = <&pex_rst_c5_out_state>, <&clkreq_c5_bi_dir_state>; > - > - clocks = <&bpmp TEGRA194_CLK_PEX0_CORE_0>; > - clock-names = "core"; > - > - resets = <&bpmp TEGRA194_RESET_PEX0_CORE_0_APB>, > - <&bpmp TEGRA194_RESET_PEX0_CORE_0>; > - reset-names = "apb", "core"; > - > - interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>, /* controller interrupt */ > - <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>; /* MSI interrupt */ > - interrupt-names = "intr", "msi"; > - > - #interrupt-cells = <1>; > - interrupt-map-mask = <0 0 0 0>; > - interrupt-map = <0 0 0 0 &gic GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>; > - > - nvidia,bpmp = <&bpmp 0>; > - > - supports-clkreq; > - nvidia,aspm-cmrt-us = <60>; > - nvidia,aspm-pwr-on-t-us = <20>; > - nvidia,aspm-l0s-entrance-latency-us = <3>; > - > - bus-range = <0x0 0xff>; > - ranges = <0x81000000 0x0 0x38100000 0x0 0x38100000 0x0 0x00100000 /* downstream I/O (1MB) */ > - 0x82000000 0x0 0x38200000 0x0 0x38200000 0x0 0x01E00000 /* non-prefetchable memory (30MB) */ > - 0xc2000000 0x18 0x00000000 0x18 0x00000000 0x4 0x00000000>; /* prefetchable memory (16GB) */ > - > - vddio-pex-ctl-supply = <&vdd_1v8ao>; > - vpcie3v3-supply = <&vdd_3v3_pcie>; > - vpcie12v-supply = <&vdd_12v_pcie>; > - > - phys = <&p2u_hsio_2>, <&p2u_hsio_3>, <&p2u_hsio_4>, > - <&p2u_hsio_5>; > - phy-names = "p2u-0", "p2u-1", "p2u-2", "p2u-3"; > - }; > - > -Tegra194 EP mode: > ------------------ > - > - pcie-ep@141a0000 { > - compatible = "nvidia,tegra194-pcie-ep", "snps,dw-pcie-ep"; > - power-domains = <&bpmp TEGRA194_POWER_DOMAIN_PCIEX8A>; > - reg = <0x00 0x141a0000 0x0 0x00020000 /* appl registers (128K) */ > - 0x00 0x3a040000 0x0 0x00040000 /* iATU_DMA reg space (256K) */ > - 0x00 0x3a080000 0x0 0x00040000 /* DBI reg space (256K) */ > - 0x1c 0x00000000 0x4 0x00000000>; /* Address Space (16G) */ > - reg-names = "appl", "atu_dma", "dbi", "addr_space"; > - > - num-lanes = <8>; > - num-ib-windows = <2>; > - num-ob-windows = <8>; > - > - pinctrl-names = "default"; > - pinctrl-0 = <&clkreq_c5_bi_dir_state>; > - > - clocks = <&bpmp TEGRA194_CLK_PEX1_CORE_5>; > - clock-names = "core"; > - > - resets = <&bpmp TEGRA194_RESET_PEX1_CORE_5_APB>, > - <&bpmp TEGRA194_RESET_PEX1_CORE_5>; > - reset-names = "apb", "core"; > - > - interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>; /* controller interrupt */ > - interrupt-names = "intr"; > - > - nvidia,bpmp = <&bpmp 5>; > - > - nvidia,aspm-cmrt-us = <60>; > - nvidia,aspm-pwr-on-t-us = <20>; > - nvidia,aspm-l0s-entrance-latency-us = <3>; > - > - vddio-pex-ctl-supply = <&vdd_1v8ao>; > - > - reset-gpios = <&gpio TEGRA194_MAIN_GPIO(GG, 1) GPIO_ACTIVE_LOW>; > - > - nvidia,refclk-select-gpios = <&gpio_aon TEGRA194_AON_GPIO(AA, 5) > - GPIO_ACTIVE_HIGH>; > - > - phys = <&p2u_nvhs_0>, <&p2u_nvhs_1>, <&p2u_nvhs_2>, > - <&p2u_nvhs_3>, <&p2u_nvhs_4>, <&p2u_nvhs_5>, > - <&p2u_nvhs_6>, <&p2u_nvhs_7>; > - > - phy-names = "p2u-0", "p2u-1", "p2u-2", "p2u-3", "p2u-4", > - "p2u-5", "p2u-6", "p2u-7"; > - }; > diff --git a/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml b/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml > new file mode 100644 > index 000000000000..4a49dddf33bb > --- /dev/null > +++ b/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml > @@ -0,0 +1,254 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pci/nvidia,tegra194-pcie.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NVIDIA Tegra194 (and later) PCIe controller (Synopsys DesignWare Core based) > + > +maintainers: > + - Thierry Reding <thierry.reding@gmail.com> > + - Jon Hunter <jonathanh@nvidia.com> > + - Vidya Sagar <vidyas@nvidia.com> > + > +description: | > + This PCIe controller is based on the Synopsis Designware PCIe IP and thus inherits all the common > + properties defined in snps,dw-pcie.yaml. Some of the controller instances are dual mode where in > + they can work either in root port mode or endpoint mode but one at a time. > + > + See nvidia,tegra194-pcie-ep.yaml for details on the endpoint mode device tree bindings. > + > +properties: > + compatible: > + enum: > + - nvidia,tegra194-pcie > + > + reg: > + items: > + - description: controller's application logic registers > + - description: configuration registers > + - description: iATU and DMA registers. This is where the iATU (internal Address Translation > + Unit) registers of the PCIe core are made available for software access. > + - description: The aperture where the root port's own configuration registers are available. > + > + reg-names: > + items: > + - const: appl > + - const: config > + - const: atu_dma > + - const: dbi > + > + interrupts: > + items: > + - description: controller interrupt > + - description: MSI interrupt > + > + interrupt-names: > + items: > + - const: intr > + - const: msi > + > + clocks: > + items: > + - description: module clock > + > + clock-names: > + items: > + - const: core > + > + resets: > + items: > + - description: APB bus interface reset > + - description: module reset > + > + reset-names: > + items: > + - const: apb > + - const: core > + > + phys: > + minItems: 1 > + maxItems: 16 > + > + phy-names: > + minItems: 1 > + maxItems: 16 > + items: > + pattern: "^p2u-[0-9]+$" > + > + power-domains: > + description: | > + A phandle to the node that controls power to the respective PCIe controller and a specifier > + name for the PCIe controller. Following are the specifiers for the different PCIe > + controllers: > + > + - TEGRA194_POWER_DOMAIN_PCIEX8B: C0 > + - TEGRA194_POWER_DOMAIN_PCIEX1A: C1 > + - TEGRA194_POWER_DOMAIN_PCIEX1A: C2 > + - TEGRA194_POWER_DOMAIN_PCIEX1A: C3 > + - TEGRA194_POWER_DOMAIN_PCIEX4A: C4 > + - TEGRA194_POWER_DOMAIN_PCIEX8A: C5 > + > + these specifiers are defined in "include/dt-bindings/power/tegra194-powergate.h" file. > + > + interconnects: > + items: > + - description: memory read client > + - description: memory write client > + > + interconnect-names: > + items: > + - const: dma-mem # read > + - const: write > + > + dma-coherent: true > + > + supports-clkreq: > + description: see pci.txt for details > + > + nvidia,bpmp: > + $ref: /schemas/types.yaml#/definitions/phandle-array > + description: | > + Must contain a pair of phandle to BPMP controller node followed by controller ID. Following > + are the controller IDs for each controller: > + > + 0: C0 > + 1: C1 > + 2: C2 > + 3: C3 > + 4: C4 > + 5: C5 > + items: > + - items: > + - minimum: 0 > + maximum: 0xffffffff > + - enum: [ 0, 1, 2, 3, 4, 5 ] > + > + nvidia,update-fc-fixup: > + description: | > + This is a boolean property and needs to be present to improve performance when a platform is > + designed in such a way that it satisfies at least one of the following conditions thereby > + enabling root port to exchange optimum number of FC (Flow Control) credits with downstream > + devices: > + > + 1. If C0/C4/C5 run at x1/x2 link widths (irrespective of speed and MPS) > + 2. If C0/C1/C2/C3/C4/C5 operate at their respective max link widths and > + a) speed is Gen-2 and MPS is 256B > + b) speed is >= Gen-3 with any MPS > + > + $ref: /schemas/types.yaml#/definitions/flag > + > + nvidia,aspm-cmrt-us: > + description: Common Mode Restore Time for proper operation of ASPM to be specified in > + microseconds > + > + nvidia,aspm-pwr-on-t-us: > + description: Power On time for proper operation of ASPM to be specified in microseconds > + > + nvidia,aspm-l0s-entrance-latency-us: > + description: ASPM L0s entrance latency to be specified in microseconds > + > + vddio-pex-ctl-supply: > + description: A phandle to the regulator supply for PCIe side band signals. > + > + vpcie3v3-supply: > + description: A phandle to the regulator node that supplies 3.3V to the slot if the platform has > + one such slot. (Ex:- x16 slot owned by C5 controller in p2972-0000 platform). > + > + vpcie12v-supply: > + description: A phandle to the regulator node that supplies 12V to the slot if the platform has > + one such slot. (Ex:- x16 slot owned by C5 controller in p2972-0000 platform). > + > +allOf: > + - $ref: "/schemas/pci/pci-bus.yaml#" > + - $ref: "/schemas/pci/snps,dw-pcie.yaml#" > + > +unevaluatedProperties: false > + > +required: > + - compatible > + - reg > + - reg-names > + - interrupts > + - interrupt-names > + - interrupt-map > + - interrupt-map-mask > + - clocks > + - clock-names > + - resets > + - reset-names > + - power-domains > + - bus-range > + - ranges > + - vddio-pex-ctl-supply > + - num-lanes > + - phys > + - phy-names > + - nvidia,bpmp > + > +examples: > + - | > + #include <dt-bindings/clock/tegra194-clock.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/power/tegra194-powergate.h> > + #include <dt-bindings/reset/tegra194-reset.h> > + > + bus@0 { > + #address-cells = <2>; > + #size-cells = <2>; > + ranges = <0x0 0x0 0x0 0x8 0x0>; > + > + pcie@14180000 { > + compatible = "nvidia,tegra194-pcie"; > + power-domains = <&bpmp TEGRA194_POWER_DOMAIN_PCIEX8B>; > + reg = <0x0 0x14180000 0x0 0x00020000>, /* appl registers (128K) */ > + <0x0 0x38000000 0x0 0x00040000>, /* configuration space (256K) */ > + <0x0 0x38040000 0x0 0x00040000>, /* iATU_DMA reg space (256K) */ > + <0x0 0x38080000 0x0 0x00040000>; /* DBI reg space (256K) */ > + reg-names = "appl", "config", "atu_dma", "dbi"; > + > + #address-cells = <3>; > + #size-cells = <2>; > + device_type = "pci"; > + num-lanes = <8>; > + linux,pci-domain = <0>; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&pex_rst_c5_out_state>, <&clkreq_c5_bi_dir_state>; > + > + clocks = <&bpmp TEGRA194_CLK_PEX0_CORE_0>; > + clock-names = "core"; > + > + resets = <&bpmp TEGRA194_RESET_PEX0_CORE_0_APB>, > + <&bpmp TEGRA194_RESET_PEX0_CORE_0>; > + reset-names = "apb", "core"; > + > + interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>, /* controller interrupt */ > + <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>; /* MSI interrupt */ > + interrupt-names = "intr", "msi"; > + > + #interrupt-cells = <1>; > + interrupt-map-mask = <0 0 0 0>; > + interrupt-map = <0 0 0 0 &gic GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>; > + > + nvidia,bpmp = <&bpmp 0>; > + > + supports-clkreq; > + nvidia,aspm-cmrt-us = <60>; > + nvidia,aspm-pwr-on-t-us = <20>; > + nvidia,aspm-l0s-entrance-latency-us = <3>; > + > + bus-range = <0x0 0xff>; > + ranges = <0x81000000 0x0 0x38100000 0x0 0x38100000 0x0 0x00100000>, /* downstream I/O */ > + <0x82000000 0x0 0x38200000 0x0 0x38200000 0x0 0x01e00000>, /* non-prefetch memory */ > + <0xc2000000 0x18 0x00000000 0x18 0x00000000 0x4 0x00000000>; /* prefetchable memory */ > + > + vddio-pex-ctl-supply = <&vdd_1v8ao>; > + vpcie3v3-supply = <&vdd_3v3_pcie>; > + vpcie12v-supply = <&vdd_12v_pcie>; > + > + phys = <&p2u_hsio_2>, <&p2u_hsio_3>, <&p2u_hsio_4>, > + <&p2u_hsio_5>; > + phy-names = "p2u-0", "p2u-1", "p2u-2", "p2u-3"; > + }; > + }; > diff --git a/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml b/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml > index c90e5e2d25f6..7e0bf941fbfe 100644 > --- a/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml > @@ -35,7 +35,7 @@ properties: > maxItems: 5 > items: > enum: [ dbi, dbi2, config, atu, app, elbi, mgmt, ctrl, parf, cfg, link, > - ulreg, smu, mpu, apb, phy ] > + ulreg, smu, mpu, apb, phy, appl, atu_dma ] > > num-lanes: > description: | > -- > 2.17.1 > >
On 6/29/2022 11:59 AM, Krzysztof Kozlowski wrote: > External email: Use caution opening links or attachments > > > On 29/06/2022 08:04, Vidya Sagar wrote: >> From: Thierry Reding <treding@nvidia.com> >> >> Convert the Tegra194 PCIe bindings from the free-form text format to >> json-schema. >> >> Signed-off-by: Vidya Sagar <vidyas@nvidia.com> >> Signed-off-by: Thierry Reding <treding@nvidia.com> >> --- >> V3: >> * New patch in this series. Added as part of addressing Rob's review >> comment to convert the existing .txt file to .yaml schema > > You need to rebase on newer tree (judging by address list). Changes on > some old kernel are not accepted. > >> >> .../bindings/pci/nvidia,tegra194-pcie-ep.yaml | 239 ++++++++++++++++ >> .../bindings/pci/nvidia,tegra194-pcie.txt | 245 ----------------- >> .../bindings/pci/nvidia,tegra194-pcie.yaml | 254 ++++++++++++++++++ >> .../devicetree/bindings/pci/snps,dw-pcie.yaml | 2 +- >> 4 files changed, 494 insertions(+), 246 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie-ep.yaml >> delete mode 100644 Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.txt >> create mode 100644 Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml >> >> diff --git a/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie-ep.yaml >> new file mode 100644 >> index 000000000000..4f7cb7fe378e >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie-ep.yaml >> @@ -0,0 +1,239 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/pci/nvidia,tegra194-pcie-ep.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: NVIDIA Tegra194 (and later) PCIe endpoint controller (Synopsys DesignWare Core based) >> + >> +maintainers: >> + - Thierry Reding <thierry.reding@gmail.com> >> + - Jon Hunter <jonathanh@nvidia.com> >> + - Vidya Sagar <vidyas@nvidia.com> >> + >> +description: | >> + This PCIe controller is based on the Synopsis Designware PCIe IP and thus inherits all the common >> + properties defined in snps,dw-pcie-ep.yaml. Some of the controller instances are dual mode where >> + in they can work either in root port mode or endpoint mode but one at a time. > > Wrap according to Linux coding style, so at 80 character. > >> + >> + On Tegra194, controllers C0, C4 and C5 support endpoint mode. >> + >> + Note: On Tegra194's P2972-0000 platform, only C5 controller can be enabled to operate in the >> + endpoint mode because of the way the platform is designed. >> + >> +properties: >> + compatible: >> + enum: >> + - nvidia,tegra194-pcie-ep >> + >> + reg: >> + items: >> + - description: controller's application logic registers >> + - description: iATU and DMA registers. This is where the iATU (internal Address Translation >> + Unit) registers of the PCIe core are made available for software access. >> + - description: The aperture where the root port's own configuration registers are available. >> + - description: Aperture used to map the remote root-complex' address space. >> + >> + reg-names: >> + items: >> + - const: appl >> + - const: atu_dma >> + - const: dbi >> + - const: addr_space >> + >> + interrupts: >> + items: >> + - description: controller interrupt >> + >> + interrupt-names: >> + items: >> + - const: intr >> + >> + clocks: >> + items: >> + - description: module clock >> + >> + clock-names: >> + items: >> + - const: core >> + >> + resets: >> + items: >> + - description: APB bus interface reset >> + - description: module reset >> + >> + reset-names: >> + items: >> + - const: apb >> + - const: core >> + >> + reset-gpios: >> + description: Must contain a phandle to a GPIO controller followed by GPIO that is being used as >> + PERST input signal. Please refer to pci.txt document. >> + >> + phys: >> + minItems: 1 >> + maxItems: 16 >> + >> + phy-names: >> + minItems: 1 >> + maxItems: 16 >> + items: >> + pattern: "^p2u-[0-9]+$" > > No, because this allows any/unspecified order. Please list the items, so > the order is fixed. Not all controllers are going to have all of them specified. Number of these entries depend on the number of lanes assigned to that particular controller. In this scenario, I thought specifying it using 'pattern' should be fine. Please let me know if there is any other better way to specify this. > >> + >> + power-domains: > > maxItems: 1 > >> + description: | >> + A phandle to the node that controls power to the respective PCIe controller and a specifier >> + name for the PCIe controller. Following are the specifiers for the different PCIe >> + controllers: >> + >> + - TEGRA194_POWER_DOMAIN_PCIEX8B: C0 >> + - TEGRA194_POWER_DOMAIN_PCIEX1A: C1 >> + - TEGRA194_POWER_DOMAIN_PCIEX1A: C2 >> + - TEGRA194_POWER_DOMAIN_PCIEX1A: C3 >> + - TEGRA194_POWER_DOMAIN_PCIEX4A: C4 >> + - TEGRA194_POWER_DOMAIN_PCIEX8A: C5 > > No need to list contents of the header file. > >> + >> + these specifiers are defined in "include/dt-bindings/power/tegra194-powergate.h" file. >> + >> + interconnects: >> + items: >> + - description: memory read client >> + - description: memory write client >> + >> + interconnect-names: >> + items: >> + - const: dma-mem # read >> + - const: write >> + >> + dma-coherent: true >> + >> + num-ib-windows: >> + description: number of inbound address translation windows >> + maxItems: 1 >> + deprecated: true > > This property was not in old bindings and you did not mention any > changes done during conversion. > >> + >> + num-ob-windows: >> + description: number of outbound address translation windows >> + maxItems: 1 >> + deprecated: true > > The same. > >> + >> + nvidia,bpmp: >> + $ref: /schemas/types.yaml#/definitions/phandle-array >> + description: | >> + Must contain a pair of phandle to BPMP controller node followed by controller ID. Following >> + are the controller IDs for each controller: >> + >> + 0: C0 >> + 1: C1 >> + 2: C2 >> + 3: C3 >> + 4: C4 >> + 5: C5 >> + items: >> + - items: >> + - minimum: 0 >> + maximum: 0xffffffff >> + - enum: [ 0, 1, 2, 3, 4, 5 ] >> + >> + nvidia,aspm-cmrt-us: >> + description: Common Mode Restore Time for proper operation of ASPM to be specified in >> + microseconds >> + >> + nvidia,aspm-pwr-on-t-us: >> + description: Power On time for proper operation of ASPM to be specified in microseconds >> + >> + nvidia,aspm-l0s-entrance-latency-us: >> + description: ASPM L0s entrance latency to be specified in microseconds >> + >> + vddio-pex-ctl-supply: >> + description: A phandle to the regulator supply for PCIe side band signals. >> + >> + nvidia,refclk-select-gpios: >> + description: Must contain a phandle to a GPIO controller followed by GPIO that is being used to >> + enable REFCLK to controller from host >> + $ref: /schemas/types.yaml#/definitions/phandle-array > > No need for ref. But you need maxItems. > >> + >> +allOf: >> + - $ref: "/schemas/pci/pci-ep.yaml#" > > No need for quotes. > >> + >> +unevaluatedProperties: false >> + >> +required: >> + - compatible >> + - reg >> + - reg-names >> + - num-ib-windows >> + - num-ob-windows >> + - interrupts >> + - interrupt-names >> + - clocks >> + - clock-names >> + - resets >> + - reset-names >> + - power-domains >> + - reset-gpios >> + - num-lanes >> + - phys >> + - phy-names >> + - nvidia,bpmp >> + >> +examples: >> + - | >> + #include <dt-bindings/clock/tegra194-clock.h> >> + #include <dt-bindings/gpio/tegra194-gpio.h> >> + #include <dt-bindings/interrupt-controller/arm-gic.h> >> + #include <dt-bindings/power/tegra194-powergate.h> >> + #include <dt-bindings/reset/tegra194-reset.h> >> + >> + bus@0 { >> + #address-cells = <2>; >> + #size-cells = <2>; >> + ranges = <0x0 0x0 0x0 0x8 0x0>; >> + >> + pcie-ep@141a0000 { >> + compatible = "nvidia,tegra194-pcie-ep"; >> + reg = <0x00 0x141a0000 0x0 0x00020000>, /* appl registers (128K) */ >> + <0x00 0x3a040000 0x0 0x00040000>, /* iATU_DMA reg space (256K) */ >> + <0x00 0x3a080000 0x0 0x00040000>, /* DBI reg space (256K) */ >> + <0x1c 0x00000000 0x4 0x00000000>; /* Address Space (16G) */ >> + reg-names = "appl", "atu_dma", "dbi", "addr_space"; >> + interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>; /* controller interrupt */ >> + interrupt-names = "intr"; >> + >> + clocks = <&bpmp TEGRA194_CLK_PEX1_CORE_5>; >> + clock-names = "core"; >> + >> + resets = <&bpmp TEGRA194_RESET_PEX1_CORE_5_APB>, >> + <&bpmp TEGRA194_RESET_PEX1_CORE_5>; >> + reset-names = "apb", "core"; >> + >> + power-domains = <&bpmp TEGRA194_POWER_DOMAIN_PCIEX8A>; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&clkreq_c5_bi_dir_state>; >> + >> + nvidia,bpmp = <&bpmp 5>; >> + >> + nvidia,aspm-cmrt-us = <60>; >> + nvidia,aspm-pwr-on-t-us = <20>; >> + nvidia,aspm-l0s-entrance-latency-us = <3>; >> + >> + vddio-pex-ctl-supply = <&vdd_1v8ao>; >> + >> + reset-gpios = <&gpio TEGRA194_MAIN_GPIO(GG, 1) GPIO_ACTIVE_LOW>; >> + >> + nvidia,refclk-select-gpios = <&gpio_aon TEGRA194_AON_GPIO(AA, 5) >> + GPIO_ACTIVE_HIGH>; >> + >> + num-lanes = <8>; >> + num-ib-windows = <2>; >> + num-ob-windows = <8>; > > Skip deprecated properties from example. > >> + >> + phys = <&p2u_nvhs_0>, <&p2u_nvhs_1>, <&p2u_nvhs_2>, >> + <&p2u_nvhs_3>, <&p2u_nvhs_4>, <&p2u_nvhs_5>, >> + <&p2u_nvhs_6>, <&p2u_nvhs_7>; >> + >> + phy-names = "p2u-0", "p2u-1", "p2u-2", "p2u-3", "p2u-4", >> + "p2u-5", "p2u-6", "p2u-7"; >> + }; >> + }; >> diff --git a/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.txt b/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.txt >> deleted file mode 100644 >> index 8e4f9bfb316d..000000000000 >> --- a/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.txt >> +++ /dev/null >> @@ -1,245 +0,0 @@ >> -NVIDIA Tegra PCIe controller (Synopsys DesignWare Core based) >> - >> -This PCIe controller is based on the Synopsis Designware PCIe IP >> -and thus inherits all the common properties defined in snps,dw-pcie.yaml and >> -snps,dw-pcie-ep.yaml. >> -Some of the controller instances are dual mode where in they can work either >> -in root port mode or endpoint mode but one at a time. >> - >> -Required properties: >> -- power-domains: A phandle to the node that controls power to the respective >> - PCIe controller and a specifier name for the PCIe controller. Following are >> - the specifiers for the different PCIe controllers >> - TEGRA194_POWER_DOMAIN_PCIEX8B: C0 >> - TEGRA194_POWER_DOMAIN_PCIEX1A: C1 >> - TEGRA194_POWER_DOMAIN_PCIEX1A: C2 >> - TEGRA194_POWER_DOMAIN_PCIEX1A: C3 >> - TEGRA194_POWER_DOMAIN_PCIEX4A: C4 >> - TEGRA194_POWER_DOMAIN_PCIEX8A: C5 >> - these specifiers are defined in >> - "include/dt-bindings/power/tegra194-powergate.h" file. >> -- reg: A list of physical base address and length pairs for each set of >> - controller registers. Must contain an entry for each entry in the reg-names >> - property. >> -- reg-names: Must include the following entries: >> - "appl": Controller's application logic registers >> - "config": As per the definition in snps,dw-pcie.yaml >> - "atu_dma": iATU and DMA registers. This is where the iATU (internal Address >> - Translation Unit) registers of the PCIe core are made available >> - for SW access. >> - "dbi": The aperture where root port's own configuration registers are >> - available >> -- interrupts: A list of interrupt outputs of the controller. Must contain an >> - entry for each entry in the interrupt-names property. >> -- interrupt-names: Must include the following entries: >> - "intr": The Tegra interrupt that is asserted for controller interrupts >> -- clocks: Must contain an entry for each entry in clock-names. >> - See ../clocks/clock-bindings.txt for details. >> -- clock-names: Must include the following entries: >> - - core >> -- resets: Must contain an entry for each entry in reset-names. >> - See ../reset/reset.txt for details. >> -- reset-names: Must include the following entries: >> - - apb >> - - core >> -- phys: Must contain a phandle to P2U PHY for each entry in phy-names. >> -- phy-names: Must include an entry for each active lane. >> - "p2u-N": where N ranges from 0 to one less than the total number of lanes >> -- nvidia,bpmp: Must contain a pair of phandle to BPMP controller node followed >> - by controller-id. Following are the controller ids for each controller. >> - 0: C0 >> - 1: C1 >> - 2: C2 >> - 3: C3 >> - 4: C4 >> - 5: C5 >> -- vddio-pex-ctl-supply: Regulator supply for PCIe side band signals >> - >> -RC mode: >> -- compatible: Tegra19x must contain "nvidia,tegra194-pcie" >> -- device_type: Must be "pci" for RC mode >> -- interrupt-names: Must include the following entries: >> - "msi": The Tegra interrupt that is asserted when an MSI is received >> -- bus-range: Range of bus numbers associated with this controller >> -- #address-cells: Address representation for root ports (must be 3) >> - - cell 0 specifies the bus and device numbers of the root port: >> - [23:16]: bus number >> - [15:11]: device number >> - - cell 1 denotes the upper 32 address bits and should be 0 >> - - cell 2 contains the lower 32 address bits and is used to translate to the >> - CPU address space >> -- #size-cells: Size representation for root ports (must be 2) >> -- ranges: Describes the translation of addresses for root ports and standard >> - PCI regions. The entries must be 7 cells each, where the first three cells >> - correspond to the address as described for the #address-cells property >> - above, the fourth and fifth cells are for the physical CPU address to >> - translate to and the sixth and seventh cells are as described for the >> - #size-cells property above. >> - - Entries setup the mapping for the standard I/O, memory and >> - prefetchable PCI regions. The first cell determines the type of region >> - that is setup: >> - - 0x81000000: I/O memory region >> - - 0x82000000: non-prefetchable memory region >> - - 0xc2000000: prefetchable memory region >> - Please refer to the standard PCI bus binding document for a more detailed >> - explanation. >> -- #interrupt-cells: Size representation for interrupts (must be 1) >> -- interrupt-map-mask and interrupt-map: Standard PCI IRQ mapping properties >> - Please refer to the standard PCI bus binding document for a more detailed >> - explanation. >> - >> -EP mode: >> -In Tegra194, Only controllers C0, C4 & C5 support EP mode. >> -- compatible: Tegra19x must contain "nvidia,tegra194-pcie-ep" >> -- reg-names: Must include the following entries: >> - "addr_space": Used to map remote RC address space >> -- reset-gpios: Must contain a phandle to a GPIO controller followed by >> - GPIO that is being used as PERST input signal. Please refer to pci.txt >> - document. >> - >> -Optional properties: >> -- pinctrl-names: A list of pinctrl state names. >> - It is mandatory for C5 controller and optional for other controllers. >> - - "default": Configures PCIe I/O for proper operation. >> -- pinctrl-0: phandle for the 'default' state of pin configuration. >> - It is mandatory for C5 controller and optional for other controllers. >> -- supports-clkreq: Refer to Documentation/devicetree/bindings/pci/pci.txt >> -- nvidia,update-fc-fixup: This is a boolean property and needs to be present to >> - improve performance when a platform is designed in such a way that it >> - satisfies at least one of the following conditions thereby enabling root >> - port to exchange optimum number of FC (Flow Control) credits with >> - downstream devices >> - 1. If C0/C4/C5 run at x1/x2 link widths (irrespective of speed and MPS) >> - 2. If C0/C1/C2/C3/C4/C5 operate at their respective max link widths and >> - a) speed is Gen-2 and MPS is 256B >> - b) speed is >= Gen-3 with any MPS >> -- nvidia,aspm-cmrt-us: Common Mode Restore Time for proper operation of ASPM >> - to be specified in microseconds >> -- nvidia,aspm-pwr-on-t-us: Power On time for proper operation of ASPM to be >> - specified in microseconds >> -- nvidia,aspm-l0s-entrance-latency-us: ASPM L0s entrance latency to be >> - specified in microseconds >> - >> -RC mode: >> -- vpcie3v3-supply: A phandle to the regulator node that supplies 3.3V to the slot >> - if the platform has one such slot. (Ex:- x16 slot owned by C5 controller >> - in p2972-0000 platform). >> -- vpcie12v-supply: A phandle to the regulator node that supplies 12V to the slot >> - if the platform has one such slot. (Ex:- x16 slot owned by C5 controller >> - in p2972-0000 platform). >> - >> -EP mode: >> -- nvidia,refclk-select-gpios: Must contain a phandle to a GPIO controller >> - followed by GPIO that is being used to enable REFCLK to controller from host >> - >> -NOTE:- On Tegra194's P2972-0000 platform, only C5 controller can be enabled to >> -operate in the endpoint mode because of the way the platform is designed. >> - >> -Examples: >> -========= >> - >> -Tegra194 RC mode: >> ------------------ >> - >> - pcie@14180000 { >> - compatible = "nvidia,tegra194-pcie"; >> - power-domains = <&bpmp TEGRA194_POWER_DOMAIN_PCIEX8B>; >> - reg = <0x00 0x14180000 0x0 0x00020000 /* appl registers (128K) */ >> - 0x00 0x38000000 0x0 0x00040000 /* configuration space (256K) */ >> - 0x00 0x38040000 0x0 0x00040000>; /* iATU_DMA reg space (256K) */ >> - reg-names = "appl", "config", "atu_dma"; >> - >> - #address-cells = <3>; >> - #size-cells = <2>; >> - device_type = "pci"; >> - num-lanes = <8>; >> - linux,pci-domain = <0>; >> - >> - pinctrl-names = "default"; >> - pinctrl-0 = <&pex_rst_c5_out_state>, <&clkreq_c5_bi_dir_state>; >> - >> - clocks = <&bpmp TEGRA194_CLK_PEX0_CORE_0>; >> - clock-names = "core"; >> - >> - resets = <&bpmp TEGRA194_RESET_PEX0_CORE_0_APB>, >> - <&bpmp TEGRA194_RESET_PEX0_CORE_0>; >> - reset-names = "apb", "core"; >> - >> - interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>, /* controller interrupt */ >> - <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>; /* MSI interrupt */ >> - interrupt-names = "intr", "msi"; >> - >> - #interrupt-cells = <1>; >> - interrupt-map-mask = <0 0 0 0>; >> - interrupt-map = <0 0 0 0 &gic GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>; >> - >> - nvidia,bpmp = <&bpmp 0>; >> - >> - supports-clkreq; >> - nvidia,aspm-cmrt-us = <60>; >> - nvidia,aspm-pwr-on-t-us = <20>; >> - nvidia,aspm-l0s-entrance-latency-us = <3>; >> - >> - bus-range = <0x0 0xff>; >> - ranges = <0x81000000 0x0 0x38100000 0x0 0x38100000 0x0 0x00100000 /* downstream I/O (1MB) */ >> - 0x82000000 0x0 0x38200000 0x0 0x38200000 0x0 0x01E00000 /* non-prefetchable memory (30MB) */ >> - 0xc2000000 0x18 0x00000000 0x18 0x00000000 0x4 0x00000000>; /* prefetchable memory (16GB) */ >> - >> - vddio-pex-ctl-supply = <&vdd_1v8ao>; >> - vpcie3v3-supply = <&vdd_3v3_pcie>; >> - vpcie12v-supply = <&vdd_12v_pcie>; >> - >> - phys = <&p2u_hsio_2>, <&p2u_hsio_3>, <&p2u_hsio_4>, >> - <&p2u_hsio_5>; >> - phy-names = "p2u-0", "p2u-1", "p2u-2", "p2u-3"; >> - }; >> - >> -Tegra194 EP mode: >> ------------------ >> - >> - pcie-ep@141a0000 { >> - compatible = "nvidia,tegra194-pcie-ep", "snps,dw-pcie-ep"; >> - power-domains = <&bpmp TEGRA194_POWER_DOMAIN_PCIEX8A>; >> - reg = <0x00 0x141a0000 0x0 0x00020000 /* appl registers (128K) */ >> - 0x00 0x3a040000 0x0 0x00040000 /* iATU_DMA reg space (256K) */ >> - 0x00 0x3a080000 0x0 0x00040000 /* DBI reg space (256K) */ >> - 0x1c 0x00000000 0x4 0x00000000>; /* Address Space (16G) */ >> - reg-names = "appl", "atu_dma", "dbi", "addr_space"; >> - >> - num-lanes = <8>; >> - num-ib-windows = <2>; >> - num-ob-windows = <8>; >> - >> - pinctrl-names = "default"; >> - pinctrl-0 = <&clkreq_c5_bi_dir_state>; >> - >> - clocks = <&bpmp TEGRA194_CLK_PEX1_CORE_5>; >> - clock-names = "core"; >> - >> - resets = <&bpmp TEGRA194_RESET_PEX1_CORE_5_APB>, >> - <&bpmp TEGRA194_RESET_PEX1_CORE_5>; >> - reset-names = "apb", "core"; >> - >> - interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>; /* controller interrupt */ >> - interrupt-names = "intr"; >> - >> - nvidia,bpmp = <&bpmp 5>; >> - >> - nvidia,aspm-cmrt-us = <60>; >> - nvidia,aspm-pwr-on-t-us = <20>; >> - nvidia,aspm-l0s-entrance-latency-us = <3>; >> - >> - vddio-pex-ctl-supply = <&vdd_1v8ao>; >> - >> - reset-gpios = <&gpio TEGRA194_MAIN_GPIO(GG, 1) GPIO_ACTIVE_LOW>; >> - >> - nvidia,refclk-select-gpios = <&gpio_aon TEGRA194_AON_GPIO(AA, 5) >> - GPIO_ACTIVE_HIGH>; >> - >> - phys = <&p2u_nvhs_0>, <&p2u_nvhs_1>, <&p2u_nvhs_2>, >> - <&p2u_nvhs_3>, <&p2u_nvhs_4>, <&p2u_nvhs_5>, >> - <&p2u_nvhs_6>, <&p2u_nvhs_7>; >> - >> - phy-names = "p2u-0", "p2u-1", "p2u-2", "p2u-3", "p2u-4", >> - "p2u-5", "p2u-6", "p2u-7"; >> - }; >> diff --git a/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml b/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml >> new file mode 100644 >> index 000000000000..4a49dddf33bb >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml >> @@ -0,0 +1,254 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/pci/nvidia,tegra194-pcie.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: NVIDIA Tegra194 (and later) PCIe controller (Synopsys DesignWare Core based) >> + >> +maintainers: >> + - Thierry Reding <thierry.reding@gmail.com> >> + - Jon Hunter <jonathanh@nvidia.com> >> + - Vidya Sagar <vidyas@nvidia.com> >> + >> +description: | >> + This PCIe controller is based on the Synopsis Designware PCIe IP and thus inherits all the common >> + properties defined in snps,dw-pcie.yaml. Some of the controller instances are dual mode where in >> + they can work either in root port mode or endpoint mode but one at a time. > > Also not properly wrapped. > >> + >> + See nvidia,tegra194-pcie-ep.yaml for details on the endpoint mode device tree bindings. >> + >> +properties: >> + compatible: >> + enum: >> + - nvidia,tegra194-pcie >> + >> + reg: >> + items: >> + - description: controller's application logic registers >> + - description: configuration registers >> + - description: iATU and DMA registers. This is where the iATU (internal Address Translation >> + Unit) registers of the PCIe core are made available for software access. >> + - description: The aperture where the root port's own configuration registers are available. >> + >> + reg-names: >> + items: >> + - const: appl >> + - const: config >> + - const: atu_dma >> + - const: dbi >> + >> + interrupts: >> + items: >> + - description: controller interrupt >> + - description: MSI interrupt >> + >> + interrupt-names: >> + items: >> + - const: intr >> + - const: msi >> + >> + clocks: >> + items: >> + - description: module clock >> + >> + clock-names: >> + items: >> + - const: core >> + >> + resets: >> + items: >> + - description: APB bus interface reset >> + - description: module reset >> + >> + reset-names: >> + items: >> + - const: apb >> + - const: core >> + >> + phys: >> + minItems: 1 >> + maxItems: 16 >> + >> + phy-names: >> + minItems: 1 >> + maxItems: 16 >> + items: >> + pattern: "^p2u-[0-9]+$" > > Same problem. > >> + >> + power-domains: >> + description: | >> + A phandle to the node that controls power to the respective PCIe controller and a specifier >> + name for the PCIe controller. Following are the specifiers for the different PCIe >> + controllers: >> + >> + - TEGRA194_POWER_DOMAIN_PCIEX8B: C0 >> + - TEGRA194_POWER_DOMAIN_PCIEX1A: C1 >> + - TEGRA194_POWER_DOMAIN_PCIEX1A: C2 >> + - TEGRA194_POWER_DOMAIN_PCIEX1A: C3 >> + - TEGRA194_POWER_DOMAIN_PCIEX4A: C4 >> + - TEGRA194_POWER_DOMAIN_PCIEX8A: C5 > > Remove as well. > >> + >> + these specifiers are defined in "include/dt-bindings/power/tegra194-powergate.h" file. >> + >> + interconnects: >> + items: >> + - description: memory read client >> + - description: memory write client >> + >> + interconnect-names: >> + items: >> + - const: dma-mem # read >> + - const: write >> + >> + dma-coherent: true >> + >> + supports-clkreq: >> + description: see pci.txt for details > > This comes from schema (pci-bus.yaml). Remove here and in EP schema all > properties which are defined by pci-bus or any other referenced schemas, > unless you customize them more. > >> + >> + nvidia,bpmp: >> + $ref: /schemas/types.yaml#/definitions/phandle-array >> + description: | >> + Must contain a pair of phandle to BPMP controller node followed by controller ID. Following >> + are the controller IDs for each controller: >> + >> + 0: C0 >> + 1: C1 >> + 2: C2 >> + 3: C3 >> + 4: C4 >> + 5: C5 >> + items: >> + - items: >> + - minimum: 0 >> + maximum: 0xffffffff >> + - enum: [ 0, 1, 2, 3, 4, 5 ] >> + >> + nvidia,update-fc-fixup: >> + description: | >> + This is a boolean property and needs to be present to improve performance when a platform is >> + designed in such a way that it satisfies at least one of the following conditions thereby >> + enabling root port to exchange optimum number of FC (Flow Control) credits with downstream > > Not wrapped. > >> + devices: >> + >> + 1. If C0/C4/C5 run at x1/x2 link widths (irrespective of speed and MPS) >> + 2. If C0/C1/C2/C3/C4/C5 operate at their respective max link widths and >> + a) speed is Gen-2 and MPS is 256B >> + b) speed is >= Gen-3 with any MPS >> + >> + $ref: /schemas/types.yaml#/definitions/flag >> + >> + nvidia,aspm-cmrt-us: >> + description: Common Mode Restore Time for proper operation of ASPM to be specified in >> + microseconds >> + >> + nvidia,aspm-pwr-on-t-us: >> + description: Power On time for proper operation of ASPM to be specified in microseconds >> + >> + nvidia,aspm-l0s-entrance-latency-us: >> + description: ASPM L0s entrance latency to be specified in microseconds >> + >> + vddio-pex-ctl-supply: >> + description: A phandle to the regulator supply for PCIe side band signals. >> + >> + vpcie3v3-supply: >> + description: A phandle to the regulator node that supplies 3.3V to the slot if the platform has >> + one such slot. (Ex:- x16 slot owned by C5 controller in p2972-0000 platform). >> + >> + vpcie12v-supply: >> + description: A phandle to the regulator node that supplies 12V to the slot if the platform has >> + one such slot. (Ex:- x16 slot owned by C5 controller in p2972-0000 platform). >> + >> +allOf: >> + - $ref: "/schemas/pci/pci-bus.yaml#" >> + - $ref: "/schemas/pci/snps,dw-pcie.yaml#" > > No need for quotes. > >> + >> +unevaluatedProperties: false >> + >> +required: >> + - compatible >> + - reg >> + - reg-names >> + - interrupts >> + - interrupt-names >> + - interrupt-map >> + - interrupt-map-mask >> + - clocks >> + - clock-names >> + - resets >> + - reset-names >> + - power-domains >> + - bus-range >> + - ranges >> + - vddio-pex-ctl-supply >> + - num-lanes >> + - phys >> + - phy-names >> + - nvidia,bpmp >> + >> +examples: >> + - | >> + #include <dt-bindings/clock/tegra194-clock.h> >> + #include <dt-bindings/interrupt-controller/arm-gic.h> >> + #include <dt-bindings/power/tegra194-powergate.h> >> + #include <dt-bindings/reset/tegra194-reset.h> >> + >> + bus@0 { >> + #address-cells = <2>; >> + #size-cells = <2>; >> + ranges = <0x0 0x0 0x0 0x8 0x0>; >> + >> + pcie@14180000 { >> + compatible = "nvidia,tegra194-pcie"; >> + power-domains = <&bpmp TEGRA194_POWER_DOMAIN_PCIEX8B>; >> + reg = <0x0 0x14180000 0x0 0x00020000>, /* appl registers (128K) */ >> + <0x0 0x38000000 0x0 0x00040000>, /* configuration space (256K) */ >> + <0x0 0x38040000 0x0 0x00040000>, /* iATU_DMA reg space (256K) */ >> + <0x0 0x38080000 0x0 0x00040000>; /* DBI reg space (256K) */ >> + reg-names = "appl", "config", "atu_dma", "dbi"; >> + >> + #address-cells = <3>; >> + #size-cells = <2>; >> + device_type = "pci"; >> + num-lanes = <8>; >> + linux,pci-domain = <0>; >> + >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pex_rst_c5_out_state>, <&clkreq_c5_bi_dir_state>; >> + >> + clocks = <&bpmp TEGRA194_CLK_PEX0_CORE_0>; >> + clock-names = "core"; >> + >> + resets = <&bpmp TEGRA194_RESET_PEX0_CORE_0_APB>, >> + <&bpmp TEGRA194_RESET_PEX0_CORE_0>; >> + reset-names = "apb", "core"; >> + >> + interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>, /* controller interrupt */ >> + <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>; /* MSI interrupt */ >> + interrupt-names = "intr", "msi"; >> + >> + #interrupt-cells = <1>; >> + interrupt-map-mask = <0 0 0 0>; >> + interrupt-map = <0 0 0 0 &gic GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>; >> + >> + nvidia,bpmp = <&bpmp 0>; >> + >> + supports-clkreq; >> + nvidia,aspm-cmrt-us = <60>; >> + nvidia,aspm-pwr-on-t-us = <20>; >> + nvidia,aspm-l0s-entrance-latency-us = <3>; >> + >> + bus-range = <0x0 0xff>; >> + ranges = <0x81000000 0x0 0x38100000 0x0 0x38100000 0x0 0x00100000>, /* downstream I/O */ >> + <0x82000000 0x0 0x38200000 0x0 0x38200000 0x0 0x01e00000>, /* non-prefetch memory */ >> + <0xc2000000 0x18 0x00000000 0x18 0x00000000 0x4 0x00000000>; /* prefetchable memory */ >> + >> + vddio-pex-ctl-supply = <&vdd_1v8ao>; >> + vpcie3v3-supply = <&vdd_3v3_pcie>; >> + vpcie12v-supply = <&vdd_12v_pcie>; >> + >> + phys = <&p2u_hsio_2>, <&p2u_hsio_3>, <&p2u_hsio_4>, >> + <&p2u_hsio_5>; >> + phy-names = "p2u-0", "p2u-1", "p2u-2", "p2u-3"; >> + }; >> + }; >> diff --git a/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml b/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml >> index c90e5e2d25f6..7e0bf941fbfe 100644 >> --- a/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml >> +++ b/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml >> @@ -35,7 +35,7 @@ properties: >> maxItems: 5 >> items: >> enum: [ dbi, dbi2, config, atu, app, elbi, mgmt, ctrl, parf, cfg, link, >> - ulreg, smu, mpu, apb, phy ] >> + ulreg, smu, mpu, apb, phy, appl, atu_dma ] >> >> num-lanes: >> description: | > > > Best regards, > Krzysztof >
On 7/1/2022 2:34 AM, Rob Herring wrote: > External email: Use caution opening links or attachments > > > On Wed, Jun 29, 2022 at 11:34:26AM +0530, Vidya Sagar wrote: >> From: Thierry Reding <treding@nvidia.com> >> >> Convert the Tegra194 PCIe bindings from the free-form text format to >> json-schema. >> >> Signed-off-by: Vidya Sagar <vidyas@nvidia.com> >> Signed-off-by: Thierry Reding <treding@nvidia.com> >> --- >> V3: >> * New patch in this series. Added as part of addressing Rob's review >> comment to convert the existing .txt file to .yaml schema >> >> .../bindings/pci/nvidia,tegra194-pcie-ep.yaml | 239 ++++++++++++++++ >> .../bindings/pci/nvidia,tegra194-pcie.txt | 245 ----------------- >> .../bindings/pci/nvidia,tegra194-pcie.yaml | 254 ++++++++++++++++++ >> .../devicetree/bindings/pci/snps,dw-pcie.yaml | 2 +- >> 4 files changed, 494 insertions(+), 246 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie-ep.yaml >> delete mode 100644 Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.txt >> create mode 100644 Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml >> >> diff --git a/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie-ep.yaml >> new file mode 100644 >> index 000000000000..4f7cb7fe378e >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie-ep.yaml >> @@ -0,0 +1,239 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/pci/nvidia,tegra194-pcie-ep.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: NVIDIA Tegra194 (and later) PCIe endpoint controller (Synopsys DesignWare Core based) >> + >> +maintainers: >> + - Thierry Reding <thierry.reding@gmail.com> >> + - Jon Hunter <jonathanh@nvidia.com> >> + - Vidya Sagar <vidyas@nvidia.com> >> + >> +description: | >> + This PCIe controller is based on the Synopsis Designware PCIe IP and thus inherits all the common > > Wrap lines at 80 unless there's a benefit to a longer line. > >> + properties defined in snps,dw-pcie-ep.yaml. Some of the controller instances are dual mode where >> + in they can work either in root port mode or endpoint mode but one at a time. >> + >> + On Tegra194, controllers C0, C4 and C5 support endpoint mode. >> + >> + Note: On Tegra194's P2972-0000 platform, only C5 controller can be enabled to operate in the >> + endpoint mode because of the way the platform is designed. >> + >> +properties: >> + compatible: >> + enum: >> + - nvidia,tegra194-pcie-ep >> + >> + reg: >> + items: >> + - description: controller's application logic registers >> + - description: iATU and DMA registers. This is where the iATU (internal Address Translation >> + Unit) registers of the PCIe core are made available for software access. >> + - description: The aperture where the root port's own configuration registers are available. >> + - description: Aperture used to map the remote root-complex' address space. >> + >> + reg-names: >> + items: >> + - const: appl >> + - const: atu_dma >> + - const: dbi >> + - const: addr_space >> + >> + interrupts: >> + items: >> + - description: controller interrupt > > Just 'maxItems: 1' is enough. > >> + >> + interrupt-names: >> + items: >> + - const: intr >> + >> + clocks: >> + items: >> + - description: module clock >> + >> + clock-names: >> + items: >> + - const: core >> + >> + resets: >> + items: >> + - description: APB bus interface reset >> + - description: module reset >> + >> + reset-names: >> + items: >> + - const: apb >> + - const: core >> + >> + reset-gpios: >> + description: Must contain a phandle to a GPIO controller followed by GPIO that is being used as >> + PERST input signal. Please refer to pci.txt document. >> + >> + phys: >> + minItems: 1 >> + maxItems: 16 > > One per lane? > >> + >> + phy-names: >> + minItems: 1 >> + maxItems: 16 >> + items: >> + pattern: "^p2u-[0-9]+$" >> + >> + power-domains: >> + description: | >> + A phandle to the node that controls power to the respective PCIe controller and a specifier >> + name for the PCIe controller. Following are the specifiers for the different PCIe >> + controllers: >> + >> + - TEGRA194_POWER_DOMAIN_PCIEX8B: C0 >> + - TEGRA194_POWER_DOMAIN_PCIEX1A: C1 >> + - TEGRA194_POWER_DOMAIN_PCIEX1A: C2 >> + - TEGRA194_POWER_DOMAIN_PCIEX1A: C3 >> + - TEGRA194_POWER_DOMAIN_PCIEX4A: C4 >> + - TEGRA194_POWER_DOMAIN_PCIEX8A: C5 >> + >> + these specifiers are defined in "include/dt-bindings/power/tegra194-powergate.h" file. >> + >> + interconnects: >> + items: >> + - description: memory read client >> + - description: memory write client >> + >> + interconnect-names: >> + items: >> + - const: dma-mem # read >> + - const: write >> + >> + dma-coherent: true >> + >> + num-ib-windows: >> + description: number of inbound address translation windows >> + maxItems: 1 >> + deprecated: true >> + >> + num-ob-windows: >> + description: number of outbound address translation windows >> + maxItems: 1 >> + deprecated: true >> + >> + nvidia,bpmp: >> + $ref: /schemas/types.yaml#/definitions/phandle-array >> + description: | >> + Must contain a pair of phandle to BPMP controller node followed by controller ID. Following >> + are the controller IDs for each controller: >> + >> + 0: C0 >> + 1: C1 >> + 2: C2 >> + 3: C3 >> + 4: C4 >> + 5: C5 >> + items: >> + - items: >> + - minimum: 0 >> + maximum: 0xffffffff > > That's already the limit. Just a description is fine. > >> + - enum: [ 0, 1, 2, 3, 4, 5 ] > > maximum: 5 Setting the maximum to '5' is resulting in the following error. pcie-ep@141a0000: nvidia,bpmp:0:0: 4294967295 is greater than the maximum of 5 Could you please help me understand why I'm seeing this error? Thanks, Vidya Sagar > >> + >> + nvidia,aspm-cmrt-us: >> + description: Common Mode Restore Time for proper operation of ASPM to be specified in >> + microseconds >> + >> + nvidia,aspm-pwr-on-t-us: >> + description: Power On time for proper operation of ASPM to be specified in microseconds >> + >> + nvidia,aspm-l0s-entrance-latency-us: >> + description: ASPM L0s entrance latency to be specified in microseconds >> + >> + vddio-pex-ctl-supply: >> + description: A phandle to the regulator supply for PCIe side band signals. >> + >> + nvidia,refclk-select-gpios: >> + description: Must contain a phandle to a GPIO controller followed by GPIO that is being used to > > Don't need generic description of the GPIO binding. > >> + enable REFCLK to controller from host >> + $ref: /schemas/types.yaml#/definitions/phandle-array > > Already has a type. > >> + >> +allOf: >> + - $ref: "/schemas/pci/pci-ep.yaml#" >> + >> +unevaluatedProperties: false >> + >> +required: >> + - compatible >> + - reg >> + - reg-names >> + - num-ib-windows >> + - num-ob-windows >> + - interrupts >> + - interrupt-names >> + - clocks >> + - clock-names >> + - resets >> + - reset-names >> + - power-domains >> + - reset-gpios >> + - num-lanes >> + - phys >> + - phy-names >> + - nvidia,bpmp >> + >> +examples: >> + - | >> + #include <dt-bindings/clock/tegra194-clock.h> >> + #include <dt-bindings/gpio/tegra194-gpio.h> >> + #include <dt-bindings/interrupt-controller/arm-gic.h> >> + #include <dt-bindings/power/tegra194-powergate.h> >> + #include <dt-bindings/reset/tegra194-reset.h> >> + >> + bus@0 { >> + #address-cells = <2>; >> + #size-cells = <2>; >> + ranges = <0x0 0x0 0x0 0x8 0x0>; >> + >> + pcie-ep@141a0000 { >> + compatible = "nvidia,tegra194-pcie-ep"; >> + reg = <0x00 0x141a0000 0x0 0x00020000>, /* appl registers (128K) */ >> + <0x00 0x3a040000 0x0 0x00040000>, /* iATU_DMA reg space (256K) */ >> + <0x00 0x3a080000 0x0 0x00040000>, /* DBI reg space (256K) */ >> + <0x1c 0x00000000 0x4 0x00000000>; /* Address Space (16G) */ >> + reg-names = "appl", "atu_dma", "dbi", "addr_space"; >> + interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>; /* controller interrupt */ >> + interrupt-names = "intr"; >> + >> + clocks = <&bpmp TEGRA194_CLK_PEX1_CORE_5>; >> + clock-names = "core"; >> + >> + resets = <&bpmp TEGRA194_RESET_PEX1_CORE_5_APB>, >> + <&bpmp TEGRA194_RESET_PEX1_CORE_5>; >> + reset-names = "apb", "core"; >> + >> + power-domains = <&bpmp TEGRA194_POWER_DOMAIN_PCIEX8A>; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&clkreq_c5_bi_dir_state>; >> + >> + nvidia,bpmp = <&bpmp 5>; >> + >> + nvidia,aspm-cmrt-us = <60>; >> + nvidia,aspm-pwr-on-t-us = <20>; >> + nvidia,aspm-l0s-entrance-latency-us = <3>; >> + >> + vddio-pex-ctl-supply = <&vdd_1v8ao>; >> + >> + reset-gpios = <&gpio TEGRA194_MAIN_GPIO(GG, 1) GPIO_ACTIVE_LOW>; >> + >> + nvidia,refclk-select-gpios = <&gpio_aon TEGRA194_AON_GPIO(AA, 5) >> + GPIO_ACTIVE_HIGH>; >> + >> + num-lanes = <8>; >> + num-ib-windows = <2>; >> + num-ob-windows = <8>; >> + >> + phys = <&p2u_nvhs_0>, <&p2u_nvhs_1>, <&p2u_nvhs_2>, >> + <&p2u_nvhs_3>, <&p2u_nvhs_4>, <&p2u_nvhs_5>, >> + <&p2u_nvhs_6>, <&p2u_nvhs_7>; >> + >> + phy-names = "p2u-0", "p2u-1", "p2u-2", "p2u-3", "p2u-4", >> + "p2u-5", "p2u-6", "p2u-7"; >> + }; >> + }; >> diff --git a/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.txt b/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.txt >> deleted file mode 100644 >> index 8e4f9bfb316d..000000000000 >> --- a/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.txt >> +++ /dev/null >> @@ -1,245 +0,0 @@ >> -NVIDIA Tegra PCIe controller (Synopsys DesignWare Core based) >> - >> -This PCIe controller is based on the Synopsis Designware PCIe IP >> -and thus inherits all the common properties defined in snps,dw-pcie.yaml and >> -snps,dw-pcie-ep.yaml. >> -Some of the controller instances are dual mode where in they can work either >> -in root port mode or endpoint mode but one at a time. >> - >> -Required properties: >> -- power-domains: A phandle to the node that controls power to the respective >> - PCIe controller and a specifier name for the PCIe controller. Following are >> - the specifiers for the different PCIe controllers >> - TEGRA194_POWER_DOMAIN_PCIEX8B: C0 >> - TEGRA194_POWER_DOMAIN_PCIEX1A: C1 >> - TEGRA194_POWER_DOMAIN_PCIEX1A: C2 >> - TEGRA194_POWER_DOMAIN_PCIEX1A: C3 >> - TEGRA194_POWER_DOMAIN_PCIEX4A: C4 >> - TEGRA194_POWER_DOMAIN_PCIEX8A: C5 >> - these specifiers are defined in >> - "include/dt-bindings/power/tegra194-powergate.h" file. >> -- reg: A list of physical base address and length pairs for each set of >> - controller registers. Must contain an entry for each entry in the reg-names >> - property. >> -- reg-names: Must include the following entries: >> - "appl": Controller's application logic registers >> - "config": As per the definition in snps,dw-pcie.yaml >> - "atu_dma": iATU and DMA registers. This is where the iATU (internal Address >> - Translation Unit) registers of the PCIe core are made available >> - for SW access. >> - "dbi": The aperture where root port's own configuration registers are >> - available >> -- interrupts: A list of interrupt outputs of the controller. Must contain an >> - entry for each entry in the interrupt-names property. >> -- interrupt-names: Must include the following entries: >> - "intr": The Tegra interrupt that is asserted for controller interrupts >> -- clocks: Must contain an entry for each entry in clock-names. >> - See ../clocks/clock-bindings.txt for details. >> -- clock-names: Must include the following entries: >> - - core >> -- resets: Must contain an entry for each entry in reset-names. >> - See ../reset/reset.txt for details. >> -- reset-names: Must include the following entries: >> - - apb >> - - core >> -- phys: Must contain a phandle to P2U PHY for each entry in phy-names. >> -- phy-names: Must include an entry for each active lane. >> - "p2u-N": where N ranges from 0 to one less than the total number of lanes >> -- nvidia,bpmp: Must contain a pair of phandle to BPMP controller node followed >> - by controller-id. Following are the controller ids for each controller. >> - 0: C0 >> - 1: C1 >> - 2: C2 >> - 3: C3 >> - 4: C4 >> - 5: C5 >> -- vddio-pex-ctl-supply: Regulator supply for PCIe side band signals >> - >> -RC mode: >> -- compatible: Tegra19x must contain "nvidia,tegra194-pcie" >> -- device_type: Must be "pci" for RC mode >> -- interrupt-names: Must include the following entries: >> - "msi": The Tegra interrupt that is asserted when an MSI is received >> -- bus-range: Range of bus numbers associated with this controller >> -- #address-cells: Address representation for root ports (must be 3) >> - - cell 0 specifies the bus and device numbers of the root port: >> - [23:16]: bus number >> - [15:11]: device number >> - - cell 1 denotes the upper 32 address bits and should be 0 >> - - cell 2 contains the lower 32 address bits and is used to translate to the >> - CPU address space >> -- #size-cells: Size representation for root ports (must be 2) >> -- ranges: Describes the translation of addresses for root ports and standard >> - PCI regions. The entries must be 7 cells each, where the first three cells >> - correspond to the address as described for the #address-cells property >> - above, the fourth and fifth cells are for the physical CPU address to >> - translate to and the sixth and seventh cells are as described for the >> - #size-cells property above. >> - - Entries setup the mapping for the standard I/O, memory and >> - prefetchable PCI regions. The first cell determines the type of region >> - that is setup: >> - - 0x81000000: I/O memory region >> - - 0x82000000: non-prefetchable memory region >> - - 0xc2000000: prefetchable memory region >> - Please refer to the standard PCI bus binding document for a more detailed >> - explanation. >> -- #interrupt-cells: Size representation for interrupts (must be 1) >> -- interrupt-map-mask and interrupt-map: Standard PCI IRQ mapping properties >> - Please refer to the standard PCI bus binding document for a more detailed >> - explanation. >> - >> -EP mode: >> -In Tegra194, Only controllers C0, C4 & C5 support EP mode. >> -- compatible: Tegra19x must contain "nvidia,tegra194-pcie-ep" >> -- reg-names: Must include the following entries: >> - "addr_space": Used to map remote RC address space >> -- reset-gpios: Must contain a phandle to a GPIO controller followed by >> - GPIO that is being used as PERST input signal. Please refer to pci.txt >> - document. >> - >> -Optional properties: >> -- pinctrl-names: A list of pinctrl state names. >> - It is mandatory for C5 controller and optional for other controllers. >> - - "default": Configures PCIe I/O for proper operation. >> -- pinctrl-0: phandle for the 'default' state of pin configuration. >> - It is mandatory for C5 controller and optional for other controllers. >> -- supports-clkreq: Refer to Documentation/devicetree/bindings/pci/pci.txt >> -- nvidia,update-fc-fixup: This is a boolean property and needs to be present to >> - improve performance when a platform is designed in such a way that it >> - satisfies at least one of the following conditions thereby enabling root >> - port to exchange optimum number of FC (Flow Control) credits with >> - downstream devices >> - 1. If C0/C4/C5 run at x1/x2 link widths (irrespective of speed and MPS) >> - 2. If C0/C1/C2/C3/C4/C5 operate at their respective max link widths and >> - a) speed is Gen-2 and MPS is 256B >> - b) speed is >= Gen-3 with any MPS >> -- nvidia,aspm-cmrt-us: Common Mode Restore Time for proper operation of ASPM >> - to be specified in microseconds >> -- nvidia,aspm-pwr-on-t-us: Power On time for proper operation of ASPM to be >> - specified in microseconds >> -- nvidia,aspm-l0s-entrance-latency-us: ASPM L0s entrance latency to be >> - specified in microseconds >> - >> -RC mode: >> -- vpcie3v3-supply: A phandle to the regulator node that supplies 3.3V to the slot >> - if the platform has one such slot. (Ex:- x16 slot owned by C5 controller >> - in p2972-0000 platform). >> -- vpcie12v-supply: A phandle to the regulator node that supplies 12V to the slot >> - if the platform has one such slot. (Ex:- x16 slot owned by C5 controller >> - in p2972-0000 platform). >> - >> -EP mode: >> -- nvidia,refclk-select-gpios: Must contain a phandle to a GPIO controller >> - followed by GPIO that is being used to enable REFCLK to controller from host >> - >> -NOTE:- On Tegra194's P2972-0000 platform, only C5 controller can be enabled to >> -operate in the endpoint mode because of the way the platform is designed. >> - >> -Examples: >> -========= >> - >> -Tegra194 RC mode: >> ------------------ >> - >> - pcie@14180000 { >> - compatible = "nvidia,tegra194-pcie"; >> - power-domains = <&bpmp TEGRA194_POWER_DOMAIN_PCIEX8B>; >> - reg = <0x00 0x14180000 0x0 0x00020000 /* appl registers (128K) */ >> - 0x00 0x38000000 0x0 0x00040000 /* configuration space (256K) */ >> - 0x00 0x38040000 0x0 0x00040000>; /* iATU_DMA reg space (256K) */ >> - reg-names = "appl", "config", "atu_dma"; >> - >> - #address-cells = <3>; >> - #size-cells = <2>; >> - device_type = "pci"; >> - num-lanes = <8>; >> - linux,pci-domain = <0>; >> - >> - pinctrl-names = "default"; >> - pinctrl-0 = <&pex_rst_c5_out_state>, <&clkreq_c5_bi_dir_state>; >> - >> - clocks = <&bpmp TEGRA194_CLK_PEX0_CORE_0>; >> - clock-names = "core"; >> - >> - resets = <&bpmp TEGRA194_RESET_PEX0_CORE_0_APB>, >> - <&bpmp TEGRA194_RESET_PEX0_CORE_0>; >> - reset-names = "apb", "core"; >> - >> - interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>, /* controller interrupt */ >> - <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>; /* MSI interrupt */ >> - interrupt-names = "intr", "msi"; >> - >> - #interrupt-cells = <1>; >> - interrupt-map-mask = <0 0 0 0>; >> - interrupt-map = <0 0 0 0 &gic GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>; >> - >> - nvidia,bpmp = <&bpmp 0>; >> - >> - supports-clkreq; >> - nvidia,aspm-cmrt-us = <60>; >> - nvidia,aspm-pwr-on-t-us = <20>; >> - nvidia,aspm-l0s-entrance-latency-us = <3>; >> - >> - bus-range = <0x0 0xff>; >> - ranges = <0x81000000 0x0 0x38100000 0x0 0x38100000 0x0 0x00100000 /* downstream I/O (1MB) */ >> - 0x82000000 0x0 0x38200000 0x0 0x38200000 0x0 0x01E00000 /* non-prefetchable memory (30MB) */ >> - 0xc2000000 0x18 0x00000000 0x18 0x00000000 0x4 0x00000000>; /* prefetchable memory (16GB) */ >> - >> - vddio-pex-ctl-supply = <&vdd_1v8ao>; >> - vpcie3v3-supply = <&vdd_3v3_pcie>; >> - vpcie12v-supply = <&vdd_12v_pcie>; >> - >> - phys = <&p2u_hsio_2>, <&p2u_hsio_3>, <&p2u_hsio_4>, >> - <&p2u_hsio_5>; >> - phy-names = "p2u-0", "p2u-1", "p2u-2", "p2u-3"; >> - }; >> - >> -Tegra194 EP mode: >> ------------------ >> - >> - pcie-ep@141a0000 { >> - compatible = "nvidia,tegra194-pcie-ep", "snps,dw-pcie-ep"; >> - power-domains = <&bpmp TEGRA194_POWER_DOMAIN_PCIEX8A>; >> - reg = <0x00 0x141a0000 0x0 0x00020000 /* appl registers (128K) */ >> - 0x00 0x3a040000 0x0 0x00040000 /* iATU_DMA reg space (256K) */ >> - 0x00 0x3a080000 0x0 0x00040000 /* DBI reg space (256K) */ >> - 0x1c 0x00000000 0x4 0x00000000>; /* Address Space (16G) */ >> - reg-names = "appl", "atu_dma", "dbi", "addr_space"; >> - >> - num-lanes = <8>; >> - num-ib-windows = <2>; >> - num-ob-windows = <8>; >> - >> - pinctrl-names = "default"; >> - pinctrl-0 = <&clkreq_c5_bi_dir_state>; >> - >> - clocks = <&bpmp TEGRA194_CLK_PEX1_CORE_5>; >> - clock-names = "core"; >> - >> - resets = <&bpmp TEGRA194_RESET_PEX1_CORE_5_APB>, >> - <&bpmp TEGRA194_RESET_PEX1_CORE_5>; >> - reset-names = "apb", "core"; >> - >> - interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>; /* controller interrupt */ >> - interrupt-names = "intr"; >> - >> - nvidia,bpmp = <&bpmp 5>; >> - >> - nvidia,aspm-cmrt-us = <60>; >> - nvidia,aspm-pwr-on-t-us = <20>; >> - nvidia,aspm-l0s-entrance-latency-us = <3>; >> - >> - vddio-pex-ctl-supply = <&vdd_1v8ao>; >> - >> - reset-gpios = <&gpio TEGRA194_MAIN_GPIO(GG, 1) GPIO_ACTIVE_LOW>; >> - >> - nvidia,refclk-select-gpios = <&gpio_aon TEGRA194_AON_GPIO(AA, 5) >> - GPIO_ACTIVE_HIGH>; >> - >> - phys = <&p2u_nvhs_0>, <&p2u_nvhs_1>, <&p2u_nvhs_2>, >> - <&p2u_nvhs_3>, <&p2u_nvhs_4>, <&p2u_nvhs_5>, >> - <&p2u_nvhs_6>, <&p2u_nvhs_7>; >> - >> - phy-names = "p2u-0", "p2u-1", "p2u-2", "p2u-3", "p2u-4", >> - "p2u-5", "p2u-6", "p2u-7"; >> - }; >> diff --git a/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml b/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml >> new file mode 100644 >> index 000000000000..4a49dddf33bb >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml >> @@ -0,0 +1,254 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/pci/nvidia,tegra194-pcie.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: NVIDIA Tegra194 (and later) PCIe controller (Synopsys DesignWare Core based) >> + >> +maintainers: >> + - Thierry Reding <thierry.reding@gmail.com> >> + - Jon Hunter <jonathanh@nvidia.com> >> + - Vidya Sagar <vidyas@nvidia.com> >> + >> +description: | >> + This PCIe controller is based on the Synopsis Designware PCIe IP and thus inherits all the common >> + properties defined in snps,dw-pcie.yaml. Some of the controller instances are dual mode where in >> + they can work either in root port mode or endpoint mode but one at a time. >> + >> + See nvidia,tegra194-pcie-ep.yaml for details on the endpoint mode device tree bindings. >> + >> +properties: >> + compatible: >> + enum: >> + - nvidia,tegra194-pcie >> + >> + reg: >> + items: >> + - description: controller's application logic registers >> + - description: configuration registers >> + - description: iATU and DMA registers. This is where the iATU (internal Address Translation >> + Unit) registers of the PCIe core are made available for software access. >> + - description: The aperture where the root port's own configuration registers are available. >> + >> + reg-names: >> + items: >> + - const: appl >> + - const: config >> + - const: atu_dma >> + - const: dbi >> + >> + interrupts: >> + items: >> + - description: controller interrupt >> + - description: MSI interrupt >> + >> + interrupt-names: >> + items: >> + - const: intr >> + - const: msi >> + >> + clocks: >> + items: >> + - description: module clock >> + >> + clock-names: >> + items: >> + - const: core >> + >> + resets: >> + items: >> + - description: APB bus interface reset >> + - description: module reset >> + >> + reset-names: >> + items: >> + - const: apb >> + - const: core >> + >> + phys: >> + minItems: 1 >> + maxItems: 16 >> + >> + phy-names: >> + minItems: 1 >> + maxItems: 16 >> + items: >> + pattern: "^p2u-[0-9]+$" >> + >> + power-domains: >> + description: | >> + A phandle to the node that controls power to the respective PCIe controller and a specifier >> + name for the PCIe controller. Following are the specifiers for the different PCIe >> + controllers: >> + >> + - TEGRA194_POWER_DOMAIN_PCIEX8B: C0 >> + - TEGRA194_POWER_DOMAIN_PCIEX1A: C1 >> + - TEGRA194_POWER_DOMAIN_PCIEX1A: C2 >> + - TEGRA194_POWER_DOMAIN_PCIEX1A: C3 >> + - TEGRA194_POWER_DOMAIN_PCIEX4A: C4 >> + - TEGRA194_POWER_DOMAIN_PCIEX8A: C5 >> + >> + these specifiers are defined in "include/dt-bindings/power/tegra194-powergate.h" file. >> + >> + interconnects: >> + items: >> + - description: memory read client >> + - description: memory write client >> + >> + interconnect-names: >> + items: >> + - const: dma-mem # read >> + - const: write >> + >> + dma-coherent: true >> + >> + supports-clkreq: >> + description: see pci.txt for details >> + >> + nvidia,bpmp: >> + $ref: /schemas/types.yaml#/definitions/phandle-array >> + description: | >> + Must contain a pair of phandle to BPMP controller node followed by controller ID. Following >> + are the controller IDs for each controller: >> + >> + 0: C0 >> + 1: C1 >> + 2: C2 >> + 3: C3 >> + 4: C4 >> + 5: C5 >> + items: >> + - items: >> + - minimum: 0 >> + maximum: 0xffffffff >> + - enum: [ 0, 1, 2, 3, 4, 5 ] >> + >> + nvidia,update-fc-fixup: >> + description: | >> + This is a boolean property and needs to be present to improve performance when a platform is >> + designed in such a way that it satisfies at least one of the following conditions thereby >> + enabling root port to exchange optimum number of FC (Flow Control) credits with downstream >> + devices: >> + >> + 1. If C0/C4/C5 run at x1/x2 link widths (irrespective of speed and MPS) >> + 2. If C0/C1/C2/C3/C4/C5 operate at their respective max link widths and >> + a) speed is Gen-2 and MPS is 256B >> + b) speed is >= Gen-3 with any MPS >> + >> + $ref: /schemas/types.yaml#/definitions/flag >> + >> + nvidia,aspm-cmrt-us: >> + description: Common Mode Restore Time for proper operation of ASPM to be specified in >> + microseconds >> + >> + nvidia,aspm-pwr-on-t-us: >> + description: Power On time for proper operation of ASPM to be specified in microseconds >> + >> + nvidia,aspm-l0s-entrance-latency-us: >> + description: ASPM L0s entrance latency to be specified in microseconds >> + >> + vddio-pex-ctl-supply: >> + description: A phandle to the regulator supply for PCIe side band signals. >> + >> + vpcie3v3-supply: >> + description: A phandle to the regulator node that supplies 3.3V to the slot if the platform has >> + one such slot. (Ex:- x16 slot owned by C5 controller in p2972-0000 platform). >> + >> + vpcie12v-supply: >> + description: A phandle to the regulator node that supplies 12V to the slot if the platform has >> + one such slot. (Ex:- x16 slot owned by C5 controller in p2972-0000 platform). >> + >> +allOf: >> + - $ref: "/schemas/pci/pci-bus.yaml#" >> + - $ref: "/schemas/pci/snps,dw-pcie.yaml#" >> + >> +unevaluatedProperties: false >> + >> +required: >> + - compatible >> + - reg >> + - reg-names >> + - interrupts >> + - interrupt-names >> + - interrupt-map >> + - interrupt-map-mask >> + - clocks >> + - clock-names >> + - resets >> + - reset-names >> + - power-domains >> + - bus-range >> + - ranges >> + - vddio-pex-ctl-supply >> + - num-lanes >> + - phys >> + - phy-names >> + - nvidia,bpmp >> + >> +examples: >> + - | >> + #include <dt-bindings/clock/tegra194-clock.h> >> + #include <dt-bindings/interrupt-controller/arm-gic.h> >> + #include <dt-bindings/power/tegra194-powergate.h> >> + #include <dt-bindings/reset/tegra194-reset.h> >> + >> + bus@0 { >> + #address-cells = <2>; >> + #size-cells = <2>; >> + ranges = <0x0 0x0 0x0 0x8 0x0>; >> + >> + pcie@14180000 { >> + compatible = "nvidia,tegra194-pcie"; >> + power-domains = <&bpmp TEGRA194_POWER_DOMAIN_PCIEX8B>; >> + reg = <0x0 0x14180000 0x0 0x00020000>, /* appl registers (128K) */ >> + <0x0 0x38000000 0x0 0x00040000>, /* configuration space (256K) */ >> + <0x0 0x38040000 0x0 0x00040000>, /* iATU_DMA reg space (256K) */ >> + <0x0 0x38080000 0x0 0x00040000>; /* DBI reg space (256K) */ >> + reg-names = "appl", "config", "atu_dma", "dbi"; >> + >> + #address-cells = <3>; >> + #size-cells = <2>; >> + device_type = "pci"; >> + num-lanes = <8>; >> + linux,pci-domain = <0>; >> + >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pex_rst_c5_out_state>, <&clkreq_c5_bi_dir_state>; >> + >> + clocks = <&bpmp TEGRA194_CLK_PEX0_CORE_0>; >> + clock-names = "core"; >> + >> + resets = <&bpmp TEGRA194_RESET_PEX0_CORE_0_APB>, >> + <&bpmp TEGRA194_RESET_PEX0_CORE_0>; >> + reset-names = "apb", "core"; >> + >> + interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>, /* controller interrupt */ >> + <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>; /* MSI interrupt */ >> + interrupt-names = "intr", "msi"; >> + >> + #interrupt-cells = <1>; >> + interrupt-map-mask = <0 0 0 0>; >> + interrupt-map = <0 0 0 0 &gic GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>; >> + >> + nvidia,bpmp = <&bpmp 0>; >> + >> + supports-clkreq; >> + nvidia,aspm-cmrt-us = <60>; >> + nvidia,aspm-pwr-on-t-us = <20>; >> + nvidia,aspm-l0s-entrance-latency-us = <3>; >> + >> + bus-range = <0x0 0xff>; >> + ranges = <0x81000000 0x0 0x38100000 0x0 0x38100000 0x0 0x00100000>, /* downstream I/O */ >> + <0x82000000 0x0 0x38200000 0x0 0x38200000 0x0 0x01e00000>, /* non-prefetch memory */ >> + <0xc2000000 0x18 0x00000000 0x18 0x00000000 0x4 0x00000000>; /* prefetchable memory */ >> + >> + vddio-pex-ctl-supply = <&vdd_1v8ao>; >> + vpcie3v3-supply = <&vdd_3v3_pcie>; >> + vpcie12v-supply = <&vdd_12v_pcie>; >> + >> + phys = <&p2u_hsio_2>, <&p2u_hsio_3>, <&p2u_hsio_4>, >> + <&p2u_hsio_5>; >> + phy-names = "p2u-0", "p2u-1", "p2u-2", "p2u-3"; >> + }; >> + }; >> diff --git a/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml b/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml >> index c90e5e2d25f6..7e0bf941fbfe 100644 >> --- a/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml >> +++ b/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml >> @@ -35,7 +35,7 @@ properties: >> maxItems: 5 >> items: >> enum: [ dbi, dbi2, config, atu, app, elbi, mgmt, ctrl, parf, cfg, link, >> - ulreg, smu, mpu, apb, phy ] >> + ulreg, smu, mpu, apb, phy, appl, atu_dma ] >> >> num-lanes: >> description: | >> -- >> 2.17.1 >> >>
On 06/07/2022 11:51, Vidya Sagar wrote: >>> + phy-names: >>> + minItems: 1 >>> + maxItems: 16 >>> + items: >>> + pattern: "^p2u-[0-9]+$" >> >> No, because this allows any/unspecified order. Please list the items, so >> the order is fixed. > > Not all controllers are going to have all of them specified. Number of > these entries depend on the number of lanes assigned to that particular > controller. In this scenario, I thought specifying it using 'pattern' > should be fine. Please let me know if there is any other better way to > specify this. As I understood previous bindings and your message above, these are all incremented by one, so just list them and drop maxItems. Trim the context, it makes it easier to spot the actual response. You quoted a lot above and a lot below. I do not know if there is something more to discuss? Usually quote means there is but I could not find... If there is, use replying style matching mailing list. Best regards, Krzysztof
On 06/07/2022 11:53, Vidya Sagar wrote: >>> + nvidia,bpmp: >>> + $ref: /schemas/types.yaml#/definitions/phandle-array >>> + description: | >>> + Must contain a pair of phandle to BPMP controller node followed by controller ID. Following >>> + are the controller IDs for each controller: >>> + >>> + 0: C0 >>> + 1: C1 >>> + 2: C2 >>> + 3: C3 >>> + 4: C4 >>> + 5: C5 >>> + items: >>> + - items: >>> + - minimum: 0 >>> + maximum: 0xffffffff >> >> That's already the limit. Just a description is fine. >> >>> + - enum: [ 0, 1, 2, 3, 4, 5 ] >> >> maximum: 5 > > Setting the maximum to '5' is resulting in the following error. > > pcie-ep@141a0000: nvidia,bpmp:0:0: 4294967295 is greater than the > maximum of 5 > > Could you please help me understand why I'm seeing this error? Trim your replies. Why adding minimum:5 to the phandle? Rob said add a description. Nothing about minimum. Best regards, Krzysztof
On 7/6/2022 3:36 PM, Krzysztof Kozlowski wrote: > External email: Use caution opening links or attachments > > > On 06/07/2022 11:53, Vidya Sagar wrote: >>>> + nvidia,bpmp: >>>> + $ref: /schemas/types.yaml#/definitions/phandle-array >>>> + description: | >>>> + Must contain a pair of phandle to BPMP controller node followed by controller ID. Following >>>> + are the controller IDs for each controller: >>>> + >>>> + 0: C0 >>>> + 1: C1 >>>> + 2: C2 >>>> + 3: C3 >>>> + 4: C4 >>>> + 5: C5 >>>> + items: >>>> + - items: >>>> + - minimum: 0 >>>> + maximum: 0xffffffff >>> >>> That's already the limit. Just a description is fine. >>> >>>> + - enum: [ 0, 1, 2, 3, 4, 5 ] >>> >>> maximum: 5 >> >> Setting the maximum to '5' is resulting in the following error. >> >> pcie-ep@141a0000: nvidia,bpmp:0:0: 4294967295 is greater than the >> maximum of 5 >> >> Could you please help me understand why I'm seeing this error? > > Trim your replies. > > Why adding minimum:5 to the phandle? Rob said add a description. Nothing > about minimum. I'm sorry I didn't understand the review comment clearly. There is one description added above already. Are you (and Rob) saying that one more description is needed? Thanks, Vidya Sagar > > Best regards, > Krzysztof >
On 06/07/2022 12:46, Vidya Sagar wrote: > > > On 7/6/2022 3:36 PM, Krzysztof Kozlowski wrote: >> External email: Use caution opening links or attachments >> >> >> On 06/07/2022 11:53, Vidya Sagar wrote: >>>>> + nvidia,bpmp: >>>>> + $ref: /schemas/types.yaml#/definitions/phandle-array >>>>> + description: | >>>>> + Must contain a pair of phandle to BPMP controller node followed by controller ID. Following >>>>> + are the controller IDs for each controller: >>>>> + >>>>> + 0: C0 >>>>> + 1: C1 >>>>> + 2: C2 >>>>> + 3: C3 >>>>> + 4: C4 >>>>> + 5: C5 >>>>> + items: >>>>> + - items: >>>>> + - minimum: 0 >>>>> + maximum: 0xffffffff >>>> >>>> That's already the limit. Just a description is fine. >>>> >>>>> + - enum: [ 0, 1, 2, 3, 4, 5 ] >>>> >>>> maximum: 5 >>> >>> Setting the maximum to '5' is resulting in the following error. >>> >>> pcie-ep@141a0000: nvidia,bpmp:0:0: 4294967295 is greater than the >>> maximum of 5 >>> >>> Could you please help me understand why I'm seeing this error? >> >> Trim your replies. >> >> Why adding minimum:5 to the phandle? Rob said add a description. Nothing >> about minimum. > > I'm sorry I didn't understand the review comment clearly. > There is one description added above already. Are you (and Rob) saying > that one more description is needed? You have description of entire property. The property consists of phandles ("items", with only one item) and each phandle of two items (second nested "items"). The first item in phandle is actual phandle, so it does not need any constraints/schema, just a description. This was missing. Something like this: https://elixir.bootlin.com/linux/v5.18-rc1/source/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml#L42 except that in your case second item (in the nested items) have actual schema, not description, which is good. Best regards, Krzysztof
On Wed, Jul 6, 2022 at 3:53 AM Vidya Sagar <vidyas@nvidia.com> wrote: > > > > On 7/1/2022 2:34 AM, Rob Herring wrote: > > External email: Use caution opening links or attachments > > > > > > On Wed, Jun 29, 2022 at 11:34:26AM +0530, Vidya Sagar wrote: > >> From: Thierry Reding <treding@nvidia.com> > >> > >> Convert the Tegra194 PCIe bindings from the free-form text format to > >> json-schema. > >> > >> Signed-off-by: Vidya Sagar <vidyas@nvidia.com> > >> Signed-off-by: Thierry Reding <treding@nvidia.com> > >> --- > >> + nvidia,bpmp: > >> + $ref: /schemas/types.yaml#/definitions/phandle-array > >> + description: | > >> + Must contain a pair of phandle to BPMP controller node followed by controller ID. Following > >> + are the controller IDs for each controller: > >> + > >> + 0: C0 > >> + 1: C1 > >> + 2: C2 > >> + 3: C3 > >> + 4: C4 > >> + 5: C5 > >> + items: > >> + - items: > >> + - minimum: 0 > >> + maximum: 0xffffffff > > > > That's already the limit. Just a description is fine. > > > >> + - enum: [ 0, 1, 2, 3, 4, 5 ] > > > > maximum: 5 > > Setting the maximum to '5' is resulting in the following error. > > pcie-ep@141a0000: nvidia,bpmp:0:0: 4294967295 is greater than the > maximum of 5 > > Could you please help me understand why I'm seeing this error? This is what you need: items: - items: - description: phandle to BPMP controller node - description: controller ID maximum: 5
diff --git a/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie-ep.yaml new file mode 100644 index 000000000000..4f7cb7fe378e --- /dev/null +++ b/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie-ep.yaml @@ -0,0 +1,239 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/pci/nvidia,tegra194-pcie-ep.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: NVIDIA Tegra194 (and later) PCIe endpoint controller (Synopsys DesignWare Core based) + +maintainers: + - Thierry Reding <thierry.reding@gmail.com> + - Jon Hunter <jonathanh@nvidia.com> + - Vidya Sagar <vidyas@nvidia.com> + +description: | + This PCIe controller is based on the Synopsis Designware PCIe IP and thus inherits all the common + properties defined in snps,dw-pcie-ep.yaml. Some of the controller instances are dual mode where + in they can work either in root port mode or endpoint mode but one at a time. + + On Tegra194, controllers C0, C4 and C5 support endpoint mode. + + Note: On Tegra194's P2972-0000 platform, only C5 controller can be enabled to operate in the + endpoint mode because of the way the platform is designed. + +properties: + compatible: + enum: + - nvidia,tegra194-pcie-ep + + reg: + items: + - description: controller's application logic registers + - description: iATU and DMA registers. This is where the iATU (internal Address Translation + Unit) registers of the PCIe core are made available for software access. + - description: The aperture where the root port's own configuration registers are available. + - description: Aperture used to map the remote root-complex' address space. + + reg-names: + items: + - const: appl + - const: atu_dma + - const: dbi + - const: addr_space + + interrupts: + items: + - description: controller interrupt + + interrupt-names: + items: + - const: intr + + clocks: + items: + - description: module clock + + clock-names: + items: + - const: core + + resets: + items: + - description: APB bus interface reset + - description: module reset + + reset-names: + items: + - const: apb + - const: core + + reset-gpios: + description: Must contain a phandle to a GPIO controller followed by GPIO that is being used as + PERST input signal. Please refer to pci.txt document. + + phys: + minItems: 1 + maxItems: 16 + + phy-names: + minItems: 1 + maxItems: 16 + items: + pattern: "^p2u-[0-9]+$" + + power-domains: + description: | + A phandle to the node that controls power to the respective PCIe controller and a specifier + name for the PCIe controller. Following are the specifiers for the different PCIe + controllers: + + - TEGRA194_POWER_DOMAIN_PCIEX8B: C0 + - TEGRA194_POWER_DOMAIN_PCIEX1A: C1 + - TEGRA194_POWER_DOMAIN_PCIEX1A: C2 + - TEGRA194_POWER_DOMAIN_PCIEX1A: C3 + - TEGRA194_POWER_DOMAIN_PCIEX4A: C4 + - TEGRA194_POWER_DOMAIN_PCIEX8A: C5 + + these specifiers are defined in "include/dt-bindings/power/tegra194-powergate.h" file. + + interconnects: + items: + - description: memory read client + - description: memory write client + + interconnect-names: + items: + - const: dma-mem # read + - const: write + + dma-coherent: true + + num-ib-windows: + description: number of inbound address translation windows + maxItems: 1 + deprecated: true + + num-ob-windows: + description: number of outbound address translation windows + maxItems: 1 + deprecated: true + + nvidia,bpmp: + $ref: /schemas/types.yaml#/definitions/phandle-array + description: | + Must contain a pair of phandle to BPMP controller node followed by controller ID. Following + are the controller IDs for each controller: + + 0: C0 + 1: C1 + 2: C2 + 3: C3 + 4: C4 + 5: C5 + items: + - items: + - minimum: 0 + maximum: 0xffffffff + - enum: [ 0, 1, 2, 3, 4, 5 ] + + nvidia,aspm-cmrt-us: + description: Common Mode Restore Time for proper operation of ASPM to be specified in + microseconds + + nvidia,aspm-pwr-on-t-us: + description: Power On time for proper operation of ASPM to be specified in microseconds + + nvidia,aspm-l0s-entrance-latency-us: + description: ASPM L0s entrance latency to be specified in microseconds + + vddio-pex-ctl-supply: + description: A phandle to the regulator supply for PCIe side band signals. + + nvidia,refclk-select-gpios: + description: Must contain a phandle to a GPIO controller followed by GPIO that is being used to + enable REFCLK to controller from host + $ref: /schemas/types.yaml#/definitions/phandle-array + +allOf: + - $ref: "/schemas/pci/pci-ep.yaml#" + +unevaluatedProperties: false + +required: + - compatible + - reg + - reg-names + - num-ib-windows + - num-ob-windows + - interrupts + - interrupt-names + - clocks + - clock-names + - resets + - reset-names + - power-domains + - reset-gpios + - num-lanes + - phys + - phy-names + - nvidia,bpmp + +examples: + - | + #include <dt-bindings/clock/tegra194-clock.h> + #include <dt-bindings/gpio/tegra194-gpio.h> + #include <dt-bindings/interrupt-controller/arm-gic.h> + #include <dt-bindings/power/tegra194-powergate.h> + #include <dt-bindings/reset/tegra194-reset.h> + + bus@0 { + #address-cells = <2>; + #size-cells = <2>; + ranges = <0x0 0x0 0x0 0x8 0x0>; + + pcie-ep@141a0000 { + compatible = "nvidia,tegra194-pcie-ep"; + reg = <0x00 0x141a0000 0x0 0x00020000>, /* appl registers (128K) */ + <0x00 0x3a040000 0x0 0x00040000>, /* iATU_DMA reg space (256K) */ + <0x00 0x3a080000 0x0 0x00040000>, /* DBI reg space (256K) */ + <0x1c 0x00000000 0x4 0x00000000>; /* Address Space (16G) */ + reg-names = "appl", "atu_dma", "dbi", "addr_space"; + interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>; /* controller interrupt */ + interrupt-names = "intr"; + + clocks = <&bpmp TEGRA194_CLK_PEX1_CORE_5>; + clock-names = "core"; + + resets = <&bpmp TEGRA194_RESET_PEX1_CORE_5_APB>, + <&bpmp TEGRA194_RESET_PEX1_CORE_5>; + reset-names = "apb", "core"; + + power-domains = <&bpmp TEGRA194_POWER_DOMAIN_PCIEX8A>; + pinctrl-names = "default"; + pinctrl-0 = <&clkreq_c5_bi_dir_state>; + + nvidia,bpmp = <&bpmp 5>; + + nvidia,aspm-cmrt-us = <60>; + nvidia,aspm-pwr-on-t-us = <20>; + nvidia,aspm-l0s-entrance-latency-us = <3>; + + vddio-pex-ctl-supply = <&vdd_1v8ao>; + + reset-gpios = <&gpio TEGRA194_MAIN_GPIO(GG, 1) GPIO_ACTIVE_LOW>; + + nvidia,refclk-select-gpios = <&gpio_aon TEGRA194_AON_GPIO(AA, 5) + GPIO_ACTIVE_HIGH>; + + num-lanes = <8>; + num-ib-windows = <2>; + num-ob-windows = <8>; + + phys = <&p2u_nvhs_0>, <&p2u_nvhs_1>, <&p2u_nvhs_2>, + <&p2u_nvhs_3>, <&p2u_nvhs_4>, <&p2u_nvhs_5>, + <&p2u_nvhs_6>, <&p2u_nvhs_7>; + + phy-names = "p2u-0", "p2u-1", "p2u-2", "p2u-3", "p2u-4", + "p2u-5", "p2u-6", "p2u-7"; + }; + }; diff --git a/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.txt b/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.txt deleted file mode 100644 index 8e4f9bfb316d..000000000000 --- a/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.txt +++ /dev/null @@ -1,245 +0,0 @@ -NVIDIA Tegra PCIe controller (Synopsys DesignWare Core based) - -This PCIe controller is based on the Synopsis Designware PCIe IP -and thus inherits all the common properties defined in snps,dw-pcie.yaml and -snps,dw-pcie-ep.yaml. -Some of the controller instances are dual mode where in they can work either -in root port mode or endpoint mode but one at a time. - -Required properties: -- power-domains: A phandle to the node that controls power to the respective - PCIe controller and a specifier name for the PCIe controller. Following are - the specifiers for the different PCIe controllers - TEGRA194_POWER_DOMAIN_PCIEX8B: C0 - TEGRA194_POWER_DOMAIN_PCIEX1A: C1 - TEGRA194_POWER_DOMAIN_PCIEX1A: C2 - TEGRA194_POWER_DOMAIN_PCIEX1A: C3 - TEGRA194_POWER_DOMAIN_PCIEX4A: C4 - TEGRA194_POWER_DOMAIN_PCIEX8A: C5 - these specifiers are defined in - "include/dt-bindings/power/tegra194-powergate.h" file. -- reg: A list of physical base address and length pairs for each set of - controller registers. Must contain an entry for each entry in the reg-names - property. -- reg-names: Must include the following entries: - "appl": Controller's application logic registers - "config": As per the definition in snps,dw-pcie.yaml - "atu_dma": iATU and DMA registers. This is where the iATU (internal Address - Translation Unit) registers of the PCIe core are made available - for SW access. - "dbi": The aperture where root port's own configuration registers are - available -- interrupts: A list of interrupt outputs of the controller. Must contain an - entry for each entry in the interrupt-names property. -- interrupt-names: Must include the following entries: - "intr": The Tegra interrupt that is asserted for controller interrupts -- clocks: Must contain an entry for each entry in clock-names. - See ../clocks/clock-bindings.txt for details. -- clock-names: Must include the following entries: - - core -- resets: Must contain an entry for each entry in reset-names. - See ../reset/reset.txt for details. -- reset-names: Must include the following entries: - - apb - - core -- phys: Must contain a phandle to P2U PHY for each entry in phy-names. -- phy-names: Must include an entry for each active lane. - "p2u-N": where N ranges from 0 to one less than the total number of lanes -- nvidia,bpmp: Must contain a pair of phandle to BPMP controller node followed - by controller-id. Following are the controller ids for each controller. - 0: C0 - 1: C1 - 2: C2 - 3: C3 - 4: C4 - 5: C5 -- vddio-pex-ctl-supply: Regulator supply for PCIe side band signals - -RC mode: -- compatible: Tegra19x must contain "nvidia,tegra194-pcie" -- device_type: Must be "pci" for RC mode -- interrupt-names: Must include the following entries: - "msi": The Tegra interrupt that is asserted when an MSI is received -- bus-range: Range of bus numbers associated with this controller -- #address-cells: Address representation for root ports (must be 3) - - cell 0 specifies the bus and device numbers of the root port: - [23:16]: bus number - [15:11]: device number - - cell 1 denotes the upper 32 address bits and should be 0 - - cell 2 contains the lower 32 address bits and is used to translate to the - CPU address space -- #size-cells: Size representation for root ports (must be 2) -- ranges: Describes the translation of addresses for root ports and standard - PCI regions. The entries must be 7 cells each, where the first three cells - correspond to the address as described for the #address-cells property - above, the fourth and fifth cells are for the physical CPU address to - translate to and the sixth and seventh cells are as described for the - #size-cells property above. - - Entries setup the mapping for the standard I/O, memory and - prefetchable PCI regions. The first cell determines the type of region - that is setup: - - 0x81000000: I/O memory region - - 0x82000000: non-prefetchable memory region - - 0xc2000000: prefetchable memory region - Please refer to the standard PCI bus binding document for a more detailed - explanation. -- #interrupt-cells: Size representation for interrupts (must be 1) -- interrupt-map-mask and interrupt-map: Standard PCI IRQ mapping properties - Please refer to the standard PCI bus binding document for a more detailed - explanation. - -EP mode: -In Tegra194, Only controllers C0, C4 & C5 support EP mode. -- compatible: Tegra19x must contain "nvidia,tegra194-pcie-ep" -- reg-names: Must include the following entries: - "addr_space": Used to map remote RC address space -- reset-gpios: Must contain a phandle to a GPIO controller followed by - GPIO that is being used as PERST input signal. Please refer to pci.txt - document. - -Optional properties: -- pinctrl-names: A list of pinctrl state names. - It is mandatory for C5 controller and optional for other controllers. - - "default": Configures PCIe I/O for proper operation. -- pinctrl-0: phandle for the 'default' state of pin configuration. - It is mandatory for C5 controller and optional for other controllers. -- supports-clkreq: Refer to Documentation/devicetree/bindings/pci/pci.txt -- nvidia,update-fc-fixup: This is a boolean property and needs to be present to - improve performance when a platform is designed in such a way that it - satisfies at least one of the following conditions thereby enabling root - port to exchange optimum number of FC (Flow Control) credits with - downstream devices - 1. If C0/C4/C5 run at x1/x2 link widths (irrespective of speed and MPS) - 2. If C0/C1/C2/C3/C4/C5 operate at their respective max link widths and - a) speed is Gen-2 and MPS is 256B - b) speed is >= Gen-3 with any MPS -- nvidia,aspm-cmrt-us: Common Mode Restore Time for proper operation of ASPM - to be specified in microseconds -- nvidia,aspm-pwr-on-t-us: Power On time for proper operation of ASPM to be - specified in microseconds -- nvidia,aspm-l0s-entrance-latency-us: ASPM L0s entrance latency to be - specified in microseconds - -RC mode: -- vpcie3v3-supply: A phandle to the regulator node that supplies 3.3V to the slot - if the platform has one such slot. (Ex:- x16 slot owned by C5 controller - in p2972-0000 platform). -- vpcie12v-supply: A phandle to the regulator node that supplies 12V to the slot - if the platform has one such slot. (Ex:- x16 slot owned by C5 controller - in p2972-0000 platform). - -EP mode: -- nvidia,refclk-select-gpios: Must contain a phandle to a GPIO controller - followed by GPIO that is being used to enable REFCLK to controller from host - -NOTE:- On Tegra194's P2972-0000 platform, only C5 controller can be enabled to -operate in the endpoint mode because of the way the platform is designed. - -Examples: -========= - -Tegra194 RC mode: ------------------ - - pcie@14180000 { - compatible = "nvidia,tegra194-pcie"; - power-domains = <&bpmp TEGRA194_POWER_DOMAIN_PCIEX8B>; - reg = <0x00 0x14180000 0x0 0x00020000 /* appl registers (128K) */ - 0x00 0x38000000 0x0 0x00040000 /* configuration space (256K) */ - 0x00 0x38040000 0x0 0x00040000>; /* iATU_DMA reg space (256K) */ - reg-names = "appl", "config", "atu_dma"; - - #address-cells = <3>; - #size-cells = <2>; - device_type = "pci"; - num-lanes = <8>; - linux,pci-domain = <0>; - - pinctrl-names = "default"; - pinctrl-0 = <&pex_rst_c5_out_state>, <&clkreq_c5_bi_dir_state>; - - clocks = <&bpmp TEGRA194_CLK_PEX0_CORE_0>; - clock-names = "core"; - - resets = <&bpmp TEGRA194_RESET_PEX0_CORE_0_APB>, - <&bpmp TEGRA194_RESET_PEX0_CORE_0>; - reset-names = "apb", "core"; - - interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>, /* controller interrupt */ - <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>; /* MSI interrupt */ - interrupt-names = "intr", "msi"; - - #interrupt-cells = <1>; - interrupt-map-mask = <0 0 0 0>; - interrupt-map = <0 0 0 0 &gic GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>; - - nvidia,bpmp = <&bpmp 0>; - - supports-clkreq; - nvidia,aspm-cmrt-us = <60>; - nvidia,aspm-pwr-on-t-us = <20>; - nvidia,aspm-l0s-entrance-latency-us = <3>; - - bus-range = <0x0 0xff>; - ranges = <0x81000000 0x0 0x38100000 0x0 0x38100000 0x0 0x00100000 /* downstream I/O (1MB) */ - 0x82000000 0x0 0x38200000 0x0 0x38200000 0x0 0x01E00000 /* non-prefetchable memory (30MB) */ - 0xc2000000 0x18 0x00000000 0x18 0x00000000 0x4 0x00000000>; /* prefetchable memory (16GB) */ - - vddio-pex-ctl-supply = <&vdd_1v8ao>; - vpcie3v3-supply = <&vdd_3v3_pcie>; - vpcie12v-supply = <&vdd_12v_pcie>; - - phys = <&p2u_hsio_2>, <&p2u_hsio_3>, <&p2u_hsio_4>, - <&p2u_hsio_5>; - phy-names = "p2u-0", "p2u-1", "p2u-2", "p2u-3"; - }; - -Tegra194 EP mode: ------------------ - - pcie-ep@141a0000 { - compatible = "nvidia,tegra194-pcie-ep", "snps,dw-pcie-ep"; - power-domains = <&bpmp TEGRA194_POWER_DOMAIN_PCIEX8A>; - reg = <0x00 0x141a0000 0x0 0x00020000 /* appl registers (128K) */ - 0x00 0x3a040000 0x0 0x00040000 /* iATU_DMA reg space (256K) */ - 0x00 0x3a080000 0x0 0x00040000 /* DBI reg space (256K) */ - 0x1c 0x00000000 0x4 0x00000000>; /* Address Space (16G) */ - reg-names = "appl", "atu_dma", "dbi", "addr_space"; - - num-lanes = <8>; - num-ib-windows = <2>; - num-ob-windows = <8>; - - pinctrl-names = "default"; - pinctrl-0 = <&clkreq_c5_bi_dir_state>; - - clocks = <&bpmp TEGRA194_CLK_PEX1_CORE_5>; - clock-names = "core"; - - resets = <&bpmp TEGRA194_RESET_PEX1_CORE_5_APB>, - <&bpmp TEGRA194_RESET_PEX1_CORE_5>; - reset-names = "apb", "core"; - - interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>; /* controller interrupt */ - interrupt-names = "intr"; - - nvidia,bpmp = <&bpmp 5>; - - nvidia,aspm-cmrt-us = <60>; - nvidia,aspm-pwr-on-t-us = <20>; - nvidia,aspm-l0s-entrance-latency-us = <3>; - - vddio-pex-ctl-supply = <&vdd_1v8ao>; - - reset-gpios = <&gpio TEGRA194_MAIN_GPIO(GG, 1) GPIO_ACTIVE_LOW>; - - nvidia,refclk-select-gpios = <&gpio_aon TEGRA194_AON_GPIO(AA, 5) - GPIO_ACTIVE_HIGH>; - - phys = <&p2u_nvhs_0>, <&p2u_nvhs_1>, <&p2u_nvhs_2>, - <&p2u_nvhs_3>, <&p2u_nvhs_4>, <&p2u_nvhs_5>, - <&p2u_nvhs_6>, <&p2u_nvhs_7>; - - phy-names = "p2u-0", "p2u-1", "p2u-2", "p2u-3", "p2u-4", - "p2u-5", "p2u-6", "p2u-7"; - }; diff --git a/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml b/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml new file mode 100644 index 000000000000..4a49dddf33bb --- /dev/null +++ b/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml @@ -0,0 +1,254 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/pci/nvidia,tegra194-pcie.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: NVIDIA Tegra194 (and later) PCIe controller (Synopsys DesignWare Core based) + +maintainers: + - Thierry Reding <thierry.reding@gmail.com> + - Jon Hunter <jonathanh@nvidia.com> + - Vidya Sagar <vidyas@nvidia.com> + +description: | + This PCIe controller is based on the Synopsis Designware PCIe IP and thus inherits all the common + properties defined in snps,dw-pcie.yaml. Some of the controller instances are dual mode where in + they can work either in root port mode or endpoint mode but one at a time. + + See nvidia,tegra194-pcie-ep.yaml for details on the endpoint mode device tree bindings. + +properties: + compatible: + enum: + - nvidia,tegra194-pcie + + reg: + items: + - description: controller's application logic registers + - description: configuration registers + - description: iATU and DMA registers. This is where the iATU (internal Address Translation + Unit) registers of the PCIe core are made available for software access. + - description: The aperture where the root port's own configuration registers are available. + + reg-names: + items: + - const: appl + - const: config + - const: atu_dma + - const: dbi + + interrupts: + items: + - description: controller interrupt + - description: MSI interrupt + + interrupt-names: + items: + - const: intr + - const: msi + + clocks: + items: + - description: module clock + + clock-names: + items: + - const: core + + resets: + items: + - description: APB bus interface reset + - description: module reset + + reset-names: + items: + - const: apb + - const: core + + phys: + minItems: 1 + maxItems: 16 + + phy-names: + minItems: 1 + maxItems: 16 + items: + pattern: "^p2u-[0-9]+$" + + power-domains: + description: | + A phandle to the node that controls power to the respective PCIe controller and a specifier + name for the PCIe controller. Following are the specifiers for the different PCIe + controllers: + + - TEGRA194_POWER_DOMAIN_PCIEX8B: C0 + - TEGRA194_POWER_DOMAIN_PCIEX1A: C1 + - TEGRA194_POWER_DOMAIN_PCIEX1A: C2 + - TEGRA194_POWER_DOMAIN_PCIEX1A: C3 + - TEGRA194_POWER_DOMAIN_PCIEX4A: C4 + - TEGRA194_POWER_DOMAIN_PCIEX8A: C5 + + these specifiers are defined in "include/dt-bindings/power/tegra194-powergate.h" file. + + interconnects: + items: + - description: memory read client + - description: memory write client + + interconnect-names: + items: + - const: dma-mem # read + - const: write + + dma-coherent: true + + supports-clkreq: + description: see pci.txt for details + + nvidia,bpmp: + $ref: /schemas/types.yaml#/definitions/phandle-array + description: | + Must contain a pair of phandle to BPMP controller node followed by controller ID. Following + are the controller IDs for each controller: + + 0: C0 + 1: C1 + 2: C2 + 3: C3 + 4: C4 + 5: C5 + items: + - items: + - minimum: 0 + maximum: 0xffffffff + - enum: [ 0, 1, 2, 3, 4, 5 ] + + nvidia,update-fc-fixup: + description: | + This is a boolean property and needs to be present to improve performance when a platform is + designed in such a way that it satisfies at least one of the following conditions thereby + enabling root port to exchange optimum number of FC (Flow Control) credits with downstream + devices: + + 1. If C0/C4/C5 run at x1/x2 link widths (irrespective of speed and MPS) + 2. If C0/C1/C2/C3/C4/C5 operate at their respective max link widths and + a) speed is Gen-2 and MPS is 256B + b) speed is >= Gen-3 with any MPS + + $ref: /schemas/types.yaml#/definitions/flag + + nvidia,aspm-cmrt-us: + description: Common Mode Restore Time for proper operation of ASPM to be specified in + microseconds + + nvidia,aspm-pwr-on-t-us: + description: Power On time for proper operation of ASPM to be specified in microseconds + + nvidia,aspm-l0s-entrance-latency-us: + description: ASPM L0s entrance latency to be specified in microseconds + + vddio-pex-ctl-supply: + description: A phandle to the regulator supply for PCIe side band signals. + + vpcie3v3-supply: + description: A phandle to the regulator node that supplies 3.3V to the slot if the platform has + one such slot. (Ex:- x16 slot owned by C5 controller in p2972-0000 platform). + + vpcie12v-supply: + description: A phandle to the regulator node that supplies 12V to the slot if the platform has + one such slot. (Ex:- x16 slot owned by C5 controller in p2972-0000 platform). + +allOf: + - $ref: "/schemas/pci/pci-bus.yaml#" + - $ref: "/schemas/pci/snps,dw-pcie.yaml#" + +unevaluatedProperties: false + +required: + - compatible + - reg + - reg-names + - interrupts + - interrupt-names + - interrupt-map + - interrupt-map-mask + - clocks + - clock-names + - resets + - reset-names + - power-domains + - bus-range + - ranges + - vddio-pex-ctl-supply + - num-lanes + - phys + - phy-names + - nvidia,bpmp + +examples: + - | + #include <dt-bindings/clock/tegra194-clock.h> + #include <dt-bindings/interrupt-controller/arm-gic.h> + #include <dt-bindings/power/tegra194-powergate.h> + #include <dt-bindings/reset/tegra194-reset.h> + + bus@0 { + #address-cells = <2>; + #size-cells = <2>; + ranges = <0x0 0x0 0x0 0x8 0x0>; + + pcie@14180000 { + compatible = "nvidia,tegra194-pcie"; + power-domains = <&bpmp TEGRA194_POWER_DOMAIN_PCIEX8B>; + reg = <0x0 0x14180000 0x0 0x00020000>, /* appl registers (128K) */ + <0x0 0x38000000 0x0 0x00040000>, /* configuration space (256K) */ + <0x0 0x38040000 0x0 0x00040000>, /* iATU_DMA reg space (256K) */ + <0x0 0x38080000 0x0 0x00040000>; /* DBI reg space (256K) */ + reg-names = "appl", "config", "atu_dma", "dbi"; + + #address-cells = <3>; + #size-cells = <2>; + device_type = "pci"; + num-lanes = <8>; + linux,pci-domain = <0>; + + pinctrl-names = "default"; + pinctrl-0 = <&pex_rst_c5_out_state>, <&clkreq_c5_bi_dir_state>; + + clocks = <&bpmp TEGRA194_CLK_PEX0_CORE_0>; + clock-names = "core"; + + resets = <&bpmp TEGRA194_RESET_PEX0_CORE_0_APB>, + <&bpmp TEGRA194_RESET_PEX0_CORE_0>; + reset-names = "apb", "core"; + + interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>, /* controller interrupt */ + <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>; /* MSI interrupt */ + interrupt-names = "intr", "msi"; + + #interrupt-cells = <1>; + interrupt-map-mask = <0 0 0 0>; + interrupt-map = <0 0 0 0 &gic GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>; + + nvidia,bpmp = <&bpmp 0>; + + supports-clkreq; + nvidia,aspm-cmrt-us = <60>; + nvidia,aspm-pwr-on-t-us = <20>; + nvidia,aspm-l0s-entrance-latency-us = <3>; + + bus-range = <0x0 0xff>; + ranges = <0x81000000 0x0 0x38100000 0x0 0x38100000 0x0 0x00100000>, /* downstream I/O */ + <0x82000000 0x0 0x38200000 0x0 0x38200000 0x0 0x01e00000>, /* non-prefetch memory */ + <0xc2000000 0x18 0x00000000 0x18 0x00000000 0x4 0x00000000>; /* prefetchable memory */ + + vddio-pex-ctl-supply = <&vdd_1v8ao>; + vpcie3v3-supply = <&vdd_3v3_pcie>; + vpcie12v-supply = <&vdd_12v_pcie>; + + phys = <&p2u_hsio_2>, <&p2u_hsio_3>, <&p2u_hsio_4>, + <&p2u_hsio_5>; + phy-names = "p2u-0", "p2u-1", "p2u-2", "p2u-3"; + }; + }; diff --git a/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml b/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml index c90e5e2d25f6..7e0bf941fbfe 100644 --- a/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml +++ b/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml @@ -35,7 +35,7 @@ properties: maxItems: 5 items: enum: [ dbi, dbi2, config, atu, app, elbi, mgmt, ctrl, parf, cfg, link, - ulreg, smu, mpu, apb, phy ] + ulreg, smu, mpu, apb, phy, appl, atu_dma ] num-lanes: description: |