mbox series

[SRU,K/Unstable,0/1] Disable CONFIG_CONFIG on RISC-V

Message ID 20220628080015.1909398-1-emil.renner.berthing@canonical.com
Headers show
Series Disable CONFIG_CONFIG on RISC-V | expand

Message

Emil Renner Berthing June 28, 2022, 8 a.m. UTC
[Impact]

 * The 5.19 kernel adds RISC-V support for running 32bit binaries on
   64bit systems, but only with hardware support.
   So far no chips have been released that support it and it's not even
   implemented in upstream Qemu. Also neither Ubuntu nor any other
   mainstream Linux distro ships 32bit binaries, so this enables a
   bunch of code that will most likely never be used.

[Test Plan]

 * Setting CONFIG_COMPAT=n just disables a feature that was added in
   5.19, so should have no impact on userspace compared to earlier
   kernels.

[Where problems could occur]

 * This was implemented by T-Head (Alibaba) so will most likely be
   supported by one of their future designs. If it turns out to be
   useful on these cores we can always enable it later.

Emil Renner Berthing (1):
  UBUNTU: [Config] Disable CONFIG_COMPAT on RISC-V

 debian.master/config/amd64/config.common.amd64     | 1 +
 debian.master/config/annotations                   | 6 +++---
 debian.master/config/arm64/config.common.arm64     | 1 +
 debian.master/config/config.common.ubuntu          | 1 -
 debian.master/config/ppc64el/config.common.ppc64el | 1 +
 debian.master/config/riscv64/config.common.riscv64 | 2 +-
 debian.master/config/s390x/config.common.s390x     | 1 +
 7 files changed, 8 insertions(+), 5 deletions(-)

Comments

Dimitri John Ledkov June 28, 2022, 8:42 a.m. UTC | #1
Title of the email, and hence the git commit message online, has a
typpo. s/CONFIG_CONFIG/CONFIG_COMPAT/ ?

On Tue, 28 Jun 2022 at 09:00, Emil Renner Berthing
<emil.renner.berthing@canonical.com> wrote:
>
> [Impact]
>
>  * The 5.19 kernel adds RISC-V support for running 32bit binaries on
>    64bit systems, but only with hardware support.
>    So far no chips have been released that support it and it's not even
>    implemented in upstream Qemu. Also neither Ubuntu nor any other
>    mainstream Linux distro ships 32bit binaries, so this enables a
>    bunch of code that will most likely never be used.
>
> [Test Plan]
>
>  * Setting CONFIG_COMPAT=n just disables a feature that was added in
>    5.19, so should have no impact on userspace compared to earlier
>    kernels.
>
> [Where problems could occur]
>
>  * This was implemented by T-Head (Alibaba) so will most likely be
>    supported by one of their future designs. If it turns out to be
>    useful on these cores we can always enable it later.
>
> Emil Renner Berthing (1):
>   UBUNTU: [Config] Disable CONFIG_COMPAT on RISC-V
>
>  debian.master/config/amd64/config.common.amd64     | 1 +
>  debian.master/config/annotations                   | 6 +++---
>  debian.master/config/arm64/config.common.arm64     | 1 +
>  debian.master/config/config.common.ubuntu          | 1 -
>  debian.master/config/ppc64el/config.common.ppc64el | 1 +
>  debian.master/config/riscv64/config.common.riscv64 | 2 +-
>  debian.master/config/s390x/config.common.s390x     | 1 +
>  7 files changed, 8 insertions(+), 5 deletions(-)
>
> --
> 2.36.1
>
>
> --
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
Dimitri John Ledkov June 28, 2022, 8:42 a.m. UTC | #2
ah, just the cover letter, 1/1 has the typpo fixed.

On Tue, 28 Jun 2022 at 09:42, Dimitri John Ledkov 🏳️‍🌈
<dimitri.ledkov@canonical.com> wrote:
>
> Title of the email, and hence the git commit message online, has a
> typpo. s/CONFIG_CONFIG/CONFIG_COMPAT/ ?
>
> On Tue, 28 Jun 2022 at 09:00, Emil Renner Berthing
> <emil.renner.berthing@canonical.com> wrote:
> >
> > [Impact]
> >
> >  * The 5.19 kernel adds RISC-V support for running 32bit binaries on
> >    64bit systems, but only with hardware support.
> >    So far no chips have been released that support it and it's not even
> >    implemented in upstream Qemu. Also neither Ubuntu nor any other
> >    mainstream Linux distro ships 32bit binaries, so this enables a
> >    bunch of code that will most likely never be used.
> >
> > [Test Plan]
> >
> >  * Setting CONFIG_COMPAT=n just disables a feature that was added in
> >    5.19, so should have no impact on userspace compared to earlier
> >    kernels.
> >
> > [Where problems could occur]
> >
> >  * This was implemented by T-Head (Alibaba) so will most likely be
> >    supported by one of their future designs. If it turns out to be
> >    useful on these cores we can always enable it later.
> >
> > Emil Renner Berthing (1):
> >   UBUNTU: [Config] Disable CONFIG_COMPAT on RISC-V
> >
> >  debian.master/config/amd64/config.common.amd64     | 1 +
> >  debian.master/config/annotations                   | 6 +++---
> >  debian.master/config/arm64/config.common.arm64     | 1 +
> >  debian.master/config/config.common.ubuntu          | 1 -
> >  debian.master/config/ppc64el/config.common.ppc64el | 1 +
> >  debian.master/config/riscv64/config.common.riscv64 | 2 +-
> >  debian.master/config/s390x/config.common.s390x     | 1 +
> >  7 files changed, 8 insertions(+), 5 deletions(-)
> >
> > --
> > 2.36.1
> >
> >
> > --
> > kernel-team mailing list
> > kernel-team@lists.ubuntu.com
> > https://lists.ubuntu.com/mailman/listinfo/kernel-team
>
>
>
> --
> Happy Pride,
>
> Dimitri
Emil Renner Berthing June 28, 2022, 8:48 a.m. UTC | #3
Yes, sorry about that. The actually commit should be fine though.

On Tue, 28 Jun 2022 at 10:43, Dimitri John Ledkov 🏳️‍🌈
<dimitri.ledkov@canonical.com> wrote:
>
> ah, just the cover letter, 1/1 has the typpo fixed.
>
> On Tue, 28 Jun 2022 at 09:42, Dimitri John Ledkov 🏳️‍🌈
> <dimitri.ledkov@canonical.com> wrote:
> >
> > Title of the email, and hence the git commit message online, has a
> > typpo. s/CONFIG_CONFIG/CONFIG_COMPAT/ ?
> >
> > On Tue, 28 Jun 2022 at 09:00, Emil Renner Berthing
> > <emil.renner.berthing@canonical.com> wrote:
> > >
> > > [Impact]
> > >
> > >  * The 5.19 kernel adds RISC-V support for running 32bit binaries on
> > >    64bit systems, but only with hardware support.
> > >    So far no chips have been released that support it and it's not even
> > >    implemented in upstream Qemu. Also neither Ubuntu nor any other
> > >    mainstream Linux distro ships 32bit binaries, so this enables a
> > >    bunch of code that will most likely never be used.
> > >
> > > [Test Plan]
> > >
> > >  * Setting CONFIG_COMPAT=n just disables a feature that was added in
> > >    5.19, so should have no impact on userspace compared to earlier
> > >    kernels.
> > >
> > > [Where problems could occur]
> > >
> > >  * This was implemented by T-Head (Alibaba) so will most likely be
> > >    supported by one of their future designs. If it turns out to be
> > >    useful on these cores we can always enable it later.
> > >
> > > Emil Renner Berthing (1):
> > >   UBUNTU: [Config] Disable CONFIG_COMPAT on RISC-V
> > >
> > >  debian.master/config/amd64/config.common.amd64     | 1 +
> > >  debian.master/config/annotations                   | 6 +++---
> > >  debian.master/config/arm64/config.common.arm64     | 1 +
> > >  debian.master/config/config.common.ubuntu          | 1 -
> > >  debian.master/config/ppc64el/config.common.ppc64el | 1 +
> > >  debian.master/config/riscv64/config.common.riscv64 | 2 +-
> > >  debian.master/config/s390x/config.common.s390x     | 1 +
> > >  7 files changed, 8 insertions(+), 5 deletions(-)
> > >
> > > --
> > > 2.36.1
> > >
> > >
> > > --
> > > kernel-team mailing list
> > > kernel-team@lists.ubuntu.com
> > > https://lists.ubuntu.com/mailman/listinfo/kernel-team
> >
> >
> >
> > --
> > Happy Pride,
> >
> > Dimitri
>
>
>
> --
> Happy Pride,
>
> Dimitri
Andrea Righi June 28, 2022, 10:19 a.m. UTC | #4
On Tue, Jun 28, 2022 at 10:00:14AM +0200, Emil Renner Berthing wrote:
> [Impact]
> 
>  * The 5.19 kernel adds RISC-V support for running 32bit binaries on
>    64bit systems, but only with hardware support.
>    So far no chips have been released that support it and it's not even
>    implemented in upstream Qemu. Also neither Ubuntu nor any other
>    mainstream Linux distro ships 32bit binaries, so this enables a
>    bunch of code that will most likely never be used.
> 
> [Test Plan]
> 
>  * Setting CONFIG_COMPAT=n just disables a feature that was added in
>    5.19, so should have no impact on userspace compared to earlier
>    kernels.
> 
> [Where problems could occur]
> 
>  * This was implemented by T-Head (Alibaba) so will most likely be
>    supported by one of their future designs. If it turns out to be
>    useful on these cores we can always enable it later.

Applied to kinetic:linux, thanks!

-Andrea