| Message ID | 20220603121802.30320-2-kavyasree.kotagiri@microchip.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Add support for lan966x flexcom chip-select configuration | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 97 lines checked |
| robh/patch-applied | fail | build log |
On Fri, Jun 03, 2022 at 05:48:00PM +0530, Kavyasree Kotagiri wrote: > Convert the Atmel flexcom device tree bindings to json schema. > > Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com> > --- > .../bindings/mfd/atmel,flexcom.yaml | 97 +++++++++++++++++++ > .../devicetree/bindings/mfd/atmel-flexcom.txt | 63 ------------ > 2 files changed, 97 insertions(+), 63 deletions(-) > create mode 100644 Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml > delete mode 100644 Documentation/devicetree/bindings/mfd/atmel-flexcom.txt Doesn't apply for me. If there's some 5.19-rc1 dependency, then resend after the merge window. Otherwise, at least document the dependency. Rob
On 03/06/2022 14:18, Kavyasree Kotagiri wrote: > Convert the Atmel flexcom device tree bindings to json schema. > > Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com> > --- > .../bindings/mfd/atmel,flexcom.yaml | 97 +++++++++++++++++++ > .../devicetree/bindings/mfd/atmel-flexcom.txt | 63 ------------ > 2 files changed, 97 insertions(+), 63 deletions(-) > create mode 100644 Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml > delete mode 100644 Documentation/devicetree/bindings/mfd/atmel-flexcom.txt > > diff --git a/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml b/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml > new file mode 100644 > index 000000000000..221bd840b49e > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml > @@ -0,0 +1,97 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/atmel,flexcom.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Device tree bindings for Atmel Flexcom (Flexible Serial Communication Unit) There was a v2 of the same patch to which already commented. Now you send the same patch, without comments applied as v1. This does not make any sense. Please version your patches correctly and do not ignore received feedback. Best regards, Krzysztof
> > Convert the Atmel flexcom device tree bindings to json schema. > > > > Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com> > > --- > > .../bindings/mfd/atmel,flexcom.yaml | 97 +++++++++++++++++++ > > .../devicetree/bindings/mfd/atmel-flexcom.txt | 63 ------------ > > 2 files changed, 97 insertions(+), 63 deletions(-) > > create mode 100644 > Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml > > delete mode 100644 Documentation/devicetree/bindings/mfd/atmel- > flexcom.txt > > > > diff --git a/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml > b/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml > > new file mode 100644 > > index 000000000000..221bd840b49e > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml > > @@ -0,0 +1,97 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/mfd/atmel,flexcom.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Device tree bindings for Atmel Flexcom (Flexible Serial > Communication Unit) > > There was a v2 of the same patch to which already commented. Now you > send the same patch, without comments applied as v1. This does not make > any sense. > > Please version your patches correctly and do not ignore received feedback. > Hi, FYI, lan966x flexcom chip-select driver support is moved to atmel-flexcom.c rather than implementing a new mux driver. So, I sent new version now with driver changes in drives/mfd/atmel-flexcom.c I once again gone through your v2 comments. I missed this comment "s/Device tree bindings//". Except that I addressed remaining all other comments for dt-bindings patches. > > Best regards, > Krzysztof
> > > Convert the Atmel flexcom device tree bindings to json schema. > > > > > > Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com> > > > --- > > > .../bindings/mfd/atmel,flexcom.yaml | 97 +++++++++++++++++++ > > > .../devicetree/bindings/mfd/atmel-flexcom.txt | 63 ------------ > > > 2 files changed, 97 insertions(+), 63 deletions(-) > > > create mode 100644 > > Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml > > > delete mode 100644 Documentation/devicetree/bindings/mfd/atmel- > > flexcom.txt > > > > > > diff --git a/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml > > b/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml > > > new file mode 100644 > > > index 000000000000..221bd840b49e > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml > > > @@ -0,0 +1,97 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/mfd/atmel,flexcom.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Device tree bindings for Atmel Flexcom (Flexible Serial > > Communication Unit) > > > > There was a v2 of the same patch to which already commented. Now you > > send the same patch, without comments applied as v1. This does not make > > any sense. > > > > Please version your patches correctly and do not ignore received feedback. > > > > Hi, > > FYI, lan966x flexcom chip-select driver support is moved to atmel-flexcom.c > rather than > implementing a new mux driver. So, I sent new version now with driver > changes in drives/mfd/atmel-flexcom.c > I once again gone through your v2 comments. I missed this comment > "s/Device tree bindings//". > Except that I addressed remaining all other comments for dt-bindings > patches. > > Hi, Please let me know what you mean by " s/Device tree bindings//" comment? Thanks, Kavya > > Best regards, > > Krzysztof
On 07/06/2022 08:55, Kavyasree.Kotagiri@microchip.com wrote: >>>> Convert the Atmel flexcom device tree bindings to json schema. >>>> >>>> Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com> >>>> --- >>>> .../bindings/mfd/atmel,flexcom.yaml | 97 +++++++++++++++++++ >>>> .../devicetree/bindings/mfd/atmel-flexcom.txt | 63 ------------ >>>> 2 files changed, 97 insertions(+), 63 deletions(-) >>>> create mode 100644 >>> Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml >>>> delete mode 100644 Documentation/devicetree/bindings/mfd/atmel- >>> flexcom.txt >>>> >>>> diff --git a/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml >>> b/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml >>>> new file mode 100644 >>>> index 000000000000..221bd840b49e >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml >>>> @@ -0,0 +1,97 @@ >>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>>> +%YAML 1.2 >>>> +--- >>>> +$id: http://devicetree.org/schemas/mfd/atmel,flexcom.yaml# >>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>>> + >>>> +title: Device tree bindings for Atmel Flexcom (Flexible Serial >>> Communication Unit) >>> >>> There was a v2 of the same patch to which already commented. Now you >>> send the same patch, without comments applied as v1. This does not make >>> any sense. >>> >>> Please version your patches correctly and do not ignore received feedback. >>> >> >> Hi, >> >> FYI, lan966x flexcom chip-select driver support is moved to atmel-flexcom.c >> rather than >> implementing a new mux driver. So, I sent new version now with driver >> changes in drives/mfd/atmel-flexcom.c >> I once again gone through your v2 comments. I missed this comment >> "s/Device tree bindings//". >> Except that I addressed remaining all other comments for dt-bindings >> patches. >>> > Hi, > > Please let me know what you mean by " s/Device tree bindings//" comment? s/X/Y/ is search and replace X with Y, so here, please remove the "Device tree bindings" words. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml b/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml new file mode 100644 index 000000000000..221bd840b49e --- /dev/null +++ b/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml @@ -0,0 +1,97 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mfd/atmel,flexcom.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Device tree bindings for Atmel Flexcom (Flexible Serial Communication Unit) + +maintainers: + - Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com> + +description: + The Atmel Flexcom is just a wrapper which embeds a SPI controller, + an I2C controller and an USART. Only one function can be used at a + time and is chosen at boot time according to the device tree. + +properties: + compatible: + const: atmel,sama5d2-flexcom + + reg: + maxItems: 1 + + clocks: + maxItems: 1 + + "#address-cells": + const: 1 + + "#size-cells": + const: 1 + + ranges: + description: + One range for the full I/O register region. (including USART, + TWI and SPI registers). + items: + maxItems: 3 + + atmel,flexcom-mode: + description: | + Specifies the flexcom mode as follows: + 1: USART + 2: SPI + 3: I2C. + $ref: /schemas/types.yaml#/definitions/uint32 + enum: [1, 2, 3] + +patternProperties: + "^serial@[0-9a-f]+$": + description: See atmel-usart.txt for details of USART bindings. + type: object + + "^spi@[0-9a-f]+$": + description: See ../spi/spi_atmel.txt for details of SPI bindings. + type: object + + "^i2c@[0-9a-f]+$": + description: See ../i2c/i2c-at91.txt for details of I2C bindings. + type: object + +required: + - compatible + - reg + - clocks + - "#address-cells" + - "#size-cells" + - ranges + - atmel,flexcom-mode + +additionalProperties: false + +examples: + - | + flx0: flexcom@f8034000 { + compatible = "atmel,sama5d2-flexcom"; + reg = <0xf8034000 0x200>; + clocks = <&flx0_clk>; + #address-cells = <1>; + #size-cells = <1>; + ranges = <0x0 0xf8034000 0x800>; + atmel,flexcom-mode = <2>; + + spi0: spi@400 { + compatible = "atmel,at91rm9200-spi"; + reg = <0x400 0x200>; + interrupts = <19 4 7>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_flx0_default>; + #address-cells = <1>; + #size-cells = <0>; + clocks = <&flx0_clk>; + clock-names = "spi_clk"; + atmel,fifo-size = <32>; + }; + }; +... diff --git a/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt b/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt deleted file mode 100644 index 9d837535637b..000000000000 --- a/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt +++ /dev/null @@ -1,63 +0,0 @@ -* Device tree bindings for Atmel Flexcom (Flexible Serial Communication Unit) - -The Atmel Flexcom is just a wrapper which embeds a SPI controller, an I2C -controller and an USART. Only one function can be used at a time and is chosen -at boot time according to the device tree. - -Required properties: -- compatible: Should be "atmel,sama5d2-flexcom" -- reg: Should be the offset/length value for Flexcom dedicated - I/O registers (without USART, TWI or SPI registers). -- clocks: Should be the Flexcom peripheral clock from PMC. -- #address-cells: Should be <1> -- #size-cells: Should be <1> -- ranges: Should be one range for the full I/O register region - (including USART, TWI and SPI registers). -- atmel,flexcom-mode: Should be one of the following values: - - <1> for USART - - <2> for SPI - - <3> for I2C - -Required child: -A single available child device of type matching the "atmel,flexcom-mode" -property. - -The phandle provided by the clocks property of the child is the same as one for -the Flexcom parent. - -For other properties, please refer to the documentations of the respective -device: -- ../serial/atmel-usart.txt -- ../spi/spi_atmel.txt -- ../i2c/i2c-at91.txt - -Example: - -flexcom@f8034000 { - compatible = "atmel,sama5d2-flexcom"; - reg = <0xf8034000 0x200>; - clocks = <&flx0_clk>; - #address-cells = <1>; - #size-cells = <1>; - ranges = <0x0 0xf8034000 0x800>; - atmel,flexcom-mode = <2>; - - spi@400 { - compatible = "atmel,at91rm9200-spi"; - reg = <0x400 0x200>; - interrupts = <19 IRQ_TYPE_LEVEL_HIGH 7>; - pinctrl-names = "default"; - pinctrl-0 = <&pinctrl_flx0_default>; - #address-cells = <1>; - #size-cells = <0>; - clocks = <&flx0_clk>; - clock-names = "spi_clk"; - atmel,fifo-size = <32>; - - flash@0 { - compatible = "atmel,at25f512b"; - reg = <0>; - spi-max-frequency = <20000000>; - }; - }; -};
Convert the Atmel flexcom device tree bindings to json schema. Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com> --- .../bindings/mfd/atmel,flexcom.yaml | 97 +++++++++++++++++++ .../devicetree/bindings/mfd/atmel-flexcom.txt | 63 ------------ 2 files changed, 97 insertions(+), 63 deletions(-) create mode 100644 Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml delete mode 100644 Documentation/devicetree/bindings/mfd/atmel-flexcom.txt