| Message ID | 20220504115501.3490-1-rex-bc.chen@mediatek.com |
|---|---|
| Headers | show |
| Series | Support MediaTek devapc for MT8186 | expand |
Il 04/05/22 13:55, Rex-BC Chen ha scritto: > The register offsets is the same between MT6779 and MT8186. To reuse the > register offsets, we move these register offsets to another structure > "mtk_devapc_regs_ofs". > > Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Il 04/05/22 13:55, Rex-BC Chen ha scritto: > Add devapc data and compatible to support MT8186 devapc. > > Signed-off-by: Runyang Chen <runyang.chen@mediatek.com> > Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> 於 2022年5月6日 週五 下午4:26寫道： > > Il 04/05/22 13:55, Rex-BC Chen ha scritto: > > The register offsets is the same between MT6779 and MT8186. To reuse the > > register offsets, we move these register offsets to another structure > > "mtk_devapc_regs_ofs". > > > > Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com> > > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Reviewed-by: Chun-Kuang Hu <chunkuang.hu@kernel.org> > > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek
AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> 於 2022年5月6日 週五 下午4:26寫道： > > Il 04/05/22 13:55, Rex-BC Chen ha scritto: > > Add devapc data and compatible to support MT8186 devapc. > > > > Signed-off-by: Runyang Chen <runyang.chen@mediatek.com> > > Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com> > > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Reviewed-by: Chun-Kuang Hu <chunkuang.hu@kernel.org> > > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek
On Wed, 2022-05-04 at 19:54 +0800, Rex-BC Chen wrote: > This series is for supporting devapc implementation in MT8186. > > V2: > - Add a patch to separate register offsets from mtk_devapc_data. > > V1: > - Add dt-binding and add devapc data for MT8186. > > Rex-BC Chen (3): > dt-bindings: soc: mediatek: devapc: Add bindings for MT8186 > soc: mediatek: devapc: Separate register offsets from > mtk_devapc_data > soc: mediatek: devapc: Add support for MT8186 > > .../bindings/soc/mediatek/devapc.yaml | 1 + > drivers/soc/mediatek/mtk-devapc.c | 45 ++++++++++++----- > -- > 2 files changed, 31 insertions(+), 15 deletions(-) > Hello Matthias, Could you spare some time to review this series? Patches of this this series are reviewed. The purpose of this series is to add support for MT8186 devapc and it just adds some driver data and compatible for mt8186. Thanks for your support! BRs, Rex
On Wed, May 4, 2022 at 7:55 PM Rex-BC Chen <rex-bc.chen@mediatek.com> wrote: > > This series is for supporting devapc implementation in MT8186. > > V2: > - Add a patch to separate register offsets from mtk_devapc_data. > > V1: > - Add dt-binding and add devapc data for MT8186. > > Rex-BC Chen (3): > dt-bindings: soc: mediatek: devapc: Add bindings for MT8186 > soc: mediatek: devapc: Separate register offsets from mtk_devapc_data > soc: mediatek: devapc: Add support for MT8186 Applied this on next-20220602 (with a few fixes for other section mismatch errors), booted and got: [ 1.948483] mtk-devapc 10207000.devapc: Read Violation [ 1.948488] mtk-devapc 10207000.devapc: Bus ID:0x100, Dom ID:0x0, Vio Addr:0x13000000 [ 1.948520] mtk-devapc 10207000.devapc: Read Violation [ 1.948523] mtk-devapc 10207000.devapc: Bus ID:0x200, Dom ID:0x0, Vio Addr:0x140001a0 [ 1.948537] mtk-devapc 10207000.devapc: Read Violation [ 1.948540] mtk-devapc 10207000.devapc: Bus ID:0x200, Dom ID:0x0, Vio Addr:0x140001a0 [ 1.948555] mtk-devapc 10207000.devapc: Read Violation [ 1.948558] mtk-devapc 10207000.devapc: Bus ID:0x200, Dom ID:0x0, Vio Addr:0x14000100 [ 1.948573] mtk-devapc 10207000.devapc: Read Violation [ 1.948576] mtk-devapc 10207000.devapc: Bus ID:0x200, Dom ID:0x0, Vio Addr:0x14000100 [ 1.948590] mtk-devapc 10207000.devapc: Read Violation [ 1.948593] mtk-devapc 10207000.devapc: Bus ID:0x200, Dom ID:0x0, Vio Addr:0x14000100 [ 1.948607] mtk-devapc 10207000.devapc: Read Violation [ 1.948610] mtk-devapc 10207000.devapc: Bus ID:0x200, Dom ID:0x0, Vio Addr:0x14000100 [ 1.948624] mtk-devapc 10207000.devapc: Read Violation [ 1.948627] mtk-devapc 10207000.devapc: Bus ID:0x200, Dom ID:0x0, Vio Addr:0x14000100 during the boot process. So I think this works well. Manually reading a known secure address also triggers it: root@hayato:~# busybox devmem 0x1000e000 0x00000000 [ 135.069121] mtk-devapc 10207000.devapc: Read Violation [ 135.069132] mtk-devapc 10207000.devapc: Bus ID:0x482, Dom ID:0x0, Vio Addr:0x1000e000 So, Tested-by: Chen-Yu Tsai <wenst@chromium.org> BTW, looks like MT8186 support in mainline is shaping up real good. SCP firmware is still missing, so video codec stuff won't work.
On 02/06/2022 09:48, Chen-Yu Tsai wrote: > On Wed, May 4, 2022 at 7:55 PM Rex-BC Chen <rex-bc.chen@mediatek.com> wrote: >> >> This series is for supporting devapc implementation in MT8186. >> >> V2: >> - Add a patch to separate register offsets from mtk_devapc_data. >> >> V1: >> - Add dt-binding and add devapc data for MT8186. >> >> Rex-BC Chen (3): >> dt-bindings: soc: mediatek: devapc: Add bindings for MT8186 >> soc: mediatek: devapc: Separate register offsets from mtk_devapc_data >> soc: mediatek: devapc: Add support for MT8186 > > Applied this on next-20220602 (with a few fixes for other section mismatch > errors), booted and got: > > [ 1.948483] mtk-devapc 10207000.devapc: Read Violation > [ 1.948488] mtk-devapc 10207000.devapc: Bus ID:0x100, Dom ID:0x0, > Vio Addr:0x13000000 > [ 1.948520] mtk-devapc 10207000.devapc: Read Violation > [ 1.948523] mtk-devapc 10207000.devapc: Bus ID:0x200, Dom ID:0x0, > Vio Addr:0x140001a0 > [ 1.948537] mtk-devapc 10207000.devapc: Read Violation > [ 1.948540] mtk-devapc 10207000.devapc: Bus ID:0x200, Dom ID:0x0, > Vio Addr:0x140001a0 > [ 1.948555] mtk-devapc 10207000.devapc: Read Violation > [ 1.948558] mtk-devapc 10207000.devapc: Bus ID:0x200, Dom ID:0x0, > Vio Addr:0x14000100 > [ 1.948573] mtk-devapc 10207000.devapc: Read Violation > [ 1.948576] mtk-devapc 10207000.devapc: Bus ID:0x200, Dom ID:0x0, > Vio Addr:0x14000100 > [ 1.948590] mtk-devapc 10207000.devapc: Read Violation > [ 1.948593] mtk-devapc 10207000.devapc: Bus ID:0x200, Dom ID:0x0, > Vio Addr:0x14000100 > [ 1.948607] mtk-devapc 10207000.devapc: Read Violation > [ 1.948610] mtk-devapc 10207000.devapc: Bus ID:0x200, Dom ID:0x0, > Vio Addr:0x14000100 > [ 1.948624] mtk-devapc 10207000.devapc: Read Violation > [ 1.948627] mtk-devapc 10207000.devapc: Bus ID:0x200, Dom ID:0x0, > Vio Addr:0x14000100 > > during the boot process. So I think this works well. Manually reading a > known secure address also triggers it: > > root@hayato:~# busybox devmem 0x1000e000 > 0x00000000 > [ 135.069121] mtk-devapc 10207000.devapc: Read Violation > [ 135.069132] mtk-devapc 10207000.devapc: Bus ID:0x482, Dom ID:0x0, > Vio Addr:0x1000e000 > > So, > > Tested-by: Chen-Yu Tsai <wenst@chromium.org> > Whole series applied to v5.19-next/soc > BTW, looks like MT8186 support in mainline is shaping up real good. > SCP firmware is still missing, so video codec stuff won't work.