| Message ID | 20220530073429.17514-2-r-ravikumar@ti.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | Enable RPi header on j721e sk | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 30/05/2022 09:34, Rahul T R wrote: > Add a pattern property for clock, also update the example with > a clock node > > Signed-off-by: Rahul T R <r-ravikumar@ti.com> > --- > .../bindings/mfd/ti,j721e-system-controller.yaml | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml > index fa86691ebf16..290b22cab52f 100644 > --- a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml > +++ b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml > @@ -48,6 +48,10 @@ patternProperties: > description: > This is the SERDES lane control mux. > > + "^clock@[0-9a-f]+$": > + type: object > + $ref: /schemas/clock/ti,am654-ehrpwm-tbclk.yaml# > + Thanks for the changes, but the question what is this remains. Clock consumers use "clocks" property. Is this a clock controller (provider) instead? Best regards, Krzysztof
On 09:37-20220530, Krzysztof Kozlowski wrote: > On 30/05/2022 09:34, Rahul T R wrote: > > Add a pattern property for clock, also update the example with > > a clock node > > > > Signed-off-by: Rahul T R <r-ravikumar@ti.com> > > --- > > .../bindings/mfd/ti,j721e-system-controller.yaml | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml > > index fa86691ebf16..290b22cab52f 100644 > > --- a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml > > +++ b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml > > @@ -48,6 +48,10 @@ patternProperties: > > description: > > This is the SERDES lane control mux. > > > > + "^clock@[0-9a-f]+$": > > + type: object > > + $ref: /schemas/clock/ti,am654-ehrpwm-tbclk.yaml# > > + > > Thanks for the changes, but the question what is this remains. Clock > consumers use "clocks" property. Is this a clock controller (provider) > instead? > > Best regards, > Krzysztof Hi Krzysztof, Yes, this is a clock provider node, I will add the correct description and will also update the example with a clock consumer node that is using a clock from this That should be enough right? Regards Rahul T R
On 30/05/2022 09:51, Rahul T R wrote: > On 09:37-20220530, Krzysztof Kozlowski wrote: >> On 30/05/2022 09:34, Rahul T R wrote: >>> Add a pattern property for clock, also update the example with >>> a clock node >>> >>> Signed-off-by: Rahul T R <r-ravikumar@ti.com> >>> --- >>> .../bindings/mfd/ti,j721e-system-controller.yaml | 10 ++++++++++ >>> 1 file changed, 10 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml >>> index fa86691ebf16..290b22cab52f 100644 >>> --- a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml >>> +++ b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml >>> @@ -48,6 +48,10 @@ patternProperties: >>> description: >>> This is the SERDES lane control mux. >>> >>> + "^clock@[0-9a-f]+$": >>> + type: object >>> + $ref: /schemas/clock/ti,am654-ehrpwm-tbclk.yaml# >>> + >> >> Thanks for the changes, but the question what is this remains. Clock >> consumers use "clocks" property. Is this a clock controller (provider) >> instead? >> >> Best regards, >> Krzysztof > > Hi Krzysztof, > > Yes, this is a clock provider node, I will add the > correct description and will also update the > example with a clock consumer node that is using > a clock from this Thanks for the description. Skip the consumer example please, just mention shortly what is this. If this is one clock, then node name is correct. If there are more clocks inside, then the node name should be "clock-controller". Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml index fa86691ebf16..290b22cab52f 100644 --- a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml +++ b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml @@ -48,6 +48,10 @@ patternProperties: description: This is the SERDES lane control mux. + "^clock@[0-9a-f]+$": + type: object + $ref: /schemas/clock/ti,am654-ehrpwm-tbclk.yaml# + required: - compatible - reg @@ -79,5 +83,11 @@ examples: <0x40c0 0x3>, <0x40c4 0x3>, <0x40c8 0x3>, <0x40cc 0x3>; /* SERDES4 lane0/1/2/3 select */ }; + + clock@4140 { + compatible = "ti,am654-ehrpwm-tbclk", "syscon"; + reg = <0x4140 0x18>; + #clock-cells = <1>; + }; }; ...
Add a pattern property for clock, also update the example with a clock node Signed-off-by: Rahul T R <r-ravikumar@ti.com> --- .../bindings/mfd/ti,j721e-system-controller.yaml | 10 ++++++++++ 1 file changed, 10 insertions(+)