| Message ID | 20220519081632.1555666-1-acelan.kao@canonical.com |
|---|---|
| Headers | show |
| Series | Enable hotspot feature for Realtek 8821CE | expand |
Acked-by: Tim Gardner <tim.gardner@canonical.com> It would help if you described the extent of a backport (and also if you spell it right). Did you have to modify any code ? Was it just context adjustment ? These reviews go faster if I don't have to apply the original patch to see for myself what carnage ensues. rtg On 5/19/22 02:16, AceLan Kao wrote: > From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com> > > BugLink: https://bugs.launchpad.net/bugs/1969326 > > [Impact] > The wifi hotspot doesn't work without the fix. > > [Fix] > Realtek provides us the patches to add this feature which are still in linux-next. > https://patchwork.kernel.org/project/linux-wireless/cover/20220407095858.46807-1-pkshih@realtek.com/ > ece31c93d4d6 rtw88: 8821c: fix debugfs rssi value > f5207c122102 rtw88: do PHY calibration while starting AP > f1c4dabfe68d rtw88: 8821c: Enable TX report for management frames > f2217968ffda rtw88: Add update beacon flow for AP mode > 6723c0cde84f rtw88: fix incorrect frequency reported > c1edc86472fc rtw88: add ieee80211:sta_rc_update ops > > Realtek provides us another series of patches for 5.14, and it contains 5 commits, > we'd verified this series of patches on the target machine. > > [Test] > Verified on the Realtek 8821CE card. > > [Where problems could occur] > The patches are introducing new interfaces, I think it only has minimal > impact to the origin behaviors. > > Ping-Ke Shih (1): > rtw88: do PHY calibration while starting AP > > Po-Hao Huang (4): > rtw88: Add update beacon flow for AP mode > rtw88: 8821c: Enable TX report for management frames > rtw88: 8821c: fix debugfs rssi value > rtw88: add ieee80211:sta_rc_update ops > > drivers/net/wireless/realtek/rtw88/fw.c | 8 ++-- > drivers/net/wireless/realtek/rtw88/fw.h | 1 + > drivers/net/wireless/realtek/rtw88/mac80211.c | 44 ++++++++++++++++++- > drivers/net/wireless/realtek/rtw88/main.c | 12 ++++- > drivers/net/wireless/realtek/rtw88/main.h | 7 ++- > drivers/net/wireless/realtek/rtw88/pci.c | 3 ++ > drivers/net/wireless/realtek/rtw88/phy.c | 2 +- > drivers/net/wireless/realtek/rtw88/reg.h | 2 + > drivers/net/wireless/realtek/rtw88/rtw8821c.c | 4 ++ > .../wireless/realtek/rtw88/rtw8821c_table.c | 2 +- > drivers/net/wireless/realtek/rtw88/tx.c | 17 +++++++ > drivers/net/wireless/realtek/rtw88/tx.h | 4 ++ > 12 files changed, 94 insertions(+), 12 deletions(-) >
Tim Gardner <tim.gardner@canonical.com> 於 2022年5月20日 週五 下午8:05寫道： > > Acked-by: Tim Gardner <tim.gardner@canonical.com> > > It would help if you described the extent of a backport (and also if you > spell it right). Did you have to modify any code ? Was it just context > adjustment ? These reviews go faster if I don't have to apply the > original patch to see for myself what carnage ensues. My bad, I should have described this more clearly. The patches apply on top of 5.14/5.15 kernel are from Realtek directly, They help us to port the patches for 5.14 kernel, so the patches for 5.14 could be clearly applied onto the 5.14 & 5.15 kernel. I compared the patches they gave us and the patches submitted upstream, for those that can't be clearly applied, I marked them as backported. So, I didn't touch the code, just apply them, and there is no conflict. > > rtg > > On 5/19/22 02:16, AceLan Kao wrote: > > From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com> > > > > BugLink: https://bugs.launchpad.net/bugs/1969326 > > > > [Impact] > > The wifi hotspot doesn't work without the fix. > > > > [Fix] > > Realtek provides us the patches to add this feature which are still in linux-next. > > https://patchwork.kernel.org/project/linux-wireless/cover/20220407095858.46807-1-pkshih@realtek.com/ > > ece31c93d4d6 rtw88: 8821c: fix debugfs rssi value > > f5207c122102 rtw88: do PHY calibration while starting AP > > f1c4dabfe68d rtw88: 8821c: Enable TX report for management frames > > f2217968ffda rtw88: Add update beacon flow for AP mode > > 6723c0cde84f rtw88: fix incorrect frequency reported > > c1edc86472fc rtw88: add ieee80211:sta_rc_update ops > > > > Realtek provides us another series of patches for 5.14, and it contains 5 commits, > > we'd verified this series of patches on the target machine. > > > > [Test] > > Verified on the Realtek 8821CE card. > > > > [Where problems could occur] > > The patches are introducing new interfaces, I think it only has minimal > > impact to the origin behaviors. > > > > Ping-Ke Shih (1): > > rtw88: do PHY calibration while starting AP > > > > Po-Hao Huang (4): > > rtw88: Add update beacon flow for AP mode > > rtw88: 8821c: Enable TX report for management frames > > rtw88: 8821c: fix debugfs rssi value > > rtw88: add ieee80211:sta_rc_update ops > > > > drivers/net/wireless/realtek/rtw88/fw.c | 8 ++-- > > drivers/net/wireless/realtek/rtw88/fw.h | 1 + > > drivers/net/wireless/realtek/rtw88/mac80211.c | 44 ++++++++++++++++++- > > drivers/net/wireless/realtek/rtw88/main.c | 12 ++++- > > drivers/net/wireless/realtek/rtw88/main.h | 7 ++- > > drivers/net/wireless/realtek/rtw88/pci.c | 3 ++ > > drivers/net/wireless/realtek/rtw88/phy.c | 2 +- > > drivers/net/wireless/realtek/rtw88/reg.h | 2 + > > drivers/net/wireless/realtek/rtw88/rtw8821c.c | 4 ++ > > .../wireless/realtek/rtw88/rtw8821c_table.c | 2 +- > > drivers/net/wireless/realtek/rtw88/tx.c | 17 +++++++ > > drivers/net/wireless/realtek/rtw88/tx.h | 4 ++ > > 12 files changed, 94 insertions(+), 12 deletions(-) > > > > -- > ----------- > Tim Gardner > Canonical, Inc > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team
On 19.05.22 10:16, AceLan Kao wrote: > From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com> > > BugLink: https://bugs.launchpad.net/bugs/1969326 > > [Impact] > The wifi hotspot doesn't work without the fix. > > [Fix] > Realtek provides us the patches to add this feature which are still in linux-next. > https://patchwork.kernel.org/project/linux-wireless/cover/20220407095858.46807-1-pkshih@realtek.com/ > ece31c93d4d6 rtw88: 8821c: fix debugfs rssi value > f5207c122102 rtw88: do PHY calibration while starting AP > f1c4dabfe68d rtw88: 8821c: Enable TX report for management frames > f2217968ffda rtw88: Add update beacon flow for AP mode > 6723c0cde84f rtw88: fix incorrect frequency reported > c1edc86472fc rtw88: add ieee80211:sta_rc_update ops > > Realtek provides us another series of patches for 5.14, and it contains 5 commits, > we'd verified this series of patches on the target machine. > > [Test] > Verified on the Realtek 8821CE card. > > [Where problems could occur] > The patches are introducing new interfaces, I think it only has minimal > impact to the origin behaviors. > > Ping-Ke Shih (1): > rtw88: do PHY calibration while starting AP > > Po-Hao Huang (4): > rtw88: Add update beacon flow for AP mode > rtw88: 8821c: Enable TX report for management frames > rtw88: 8821c: fix debugfs rssi value > rtw88: add ieee80211:sta_rc_update ops > > drivers/net/wireless/realtek/rtw88/fw.c | 8 ++-- > drivers/net/wireless/realtek/rtw88/fw.h | 1 + > drivers/net/wireless/realtek/rtw88/mac80211.c | 44 ++++++++++++++++++- > drivers/net/wireless/realtek/rtw88/main.c | 12 ++++- > drivers/net/wireless/realtek/rtw88/main.h | 7 ++- > drivers/net/wireless/realtek/rtw88/pci.c | 3 ++ > drivers/net/wireless/realtek/rtw88/phy.c | 2 +- > drivers/net/wireless/realtek/rtw88/reg.h | 2 + > drivers/net/wireless/realtek/rtw88/rtw8821c.c | 4 ++ > .../wireless/realtek/rtw88/rtw8821c_table.c | 2 +- > drivers/net/wireless/realtek/rtw88/tx.c | 17 +++++++ > drivers/net/wireless/realtek/rtw88/tx.h | 4 ++ > 12 files changed, 94 insertions(+), 12 deletions(-) > With the typo on Patch 1/5 fixed as pointed out by Tim: Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com> Thanks
On 19.05.22 10:16, AceLan Kao wrote: > From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com> > > BugLink: https://bugs.launchpad.net/bugs/1969326 > > [Impact] > The wifi hotspot doesn't work without the fix. > > [Fix] > Realtek provides us the patches to add this feature which are still in linux-next. > https://patchwork.kernel.org/project/linux-wireless/cover/20220407095858.46807-1-pkshih@realtek.com/ > ece31c93d4d6 rtw88: 8821c: fix debugfs rssi value > f5207c122102 rtw88: do PHY calibration while starting AP > f1c4dabfe68d rtw88: 8821c: Enable TX report for management frames > f2217968ffda rtw88: Add update beacon flow for AP mode > 6723c0cde84f rtw88: fix incorrect frequency reported > c1edc86472fc rtw88: add ieee80211:sta_rc_update ops > > Realtek provides us another series of patches for 5.14, and it contains 5 commits, > we'd verified this series of patches on the target machine. > > [Test] > Verified on the Realtek 8821CE card. > > [Where problems could occur] > The patches are introducing new interfaces, I think it only has minimal > impact to the origin behaviors. > > Ping-Ke Shih (1): > rtw88: do PHY calibration while starting AP > > Po-Hao Huang (4): > rtw88: Add update beacon flow for AP mode > rtw88: 8821c: Enable TX report for management frames > rtw88: 8821c: fix debugfs rssi value > rtw88: add ieee80211:sta_rc_update ops > > drivers/net/wireless/realtek/rtw88/fw.c | 8 ++-- > drivers/net/wireless/realtek/rtw88/fw.h | 1 + > drivers/net/wireless/realtek/rtw88/mac80211.c | 44 ++++++++++++++++++- > drivers/net/wireless/realtek/rtw88/main.c | 12 ++++- > drivers/net/wireless/realtek/rtw88/main.h | 7 ++- > drivers/net/wireless/realtek/rtw88/pci.c | 3 ++ > drivers/net/wireless/realtek/rtw88/phy.c | 2 +- > drivers/net/wireless/realtek/rtw88/reg.h | 2 + > drivers/net/wireless/realtek/rtw88/rtw8821c.c | 4 ++ > .../wireless/realtek/rtw88/rtw8821c_table.c | 2 +- > drivers/net/wireless/realtek/rtw88/tx.c | 17 +++++++ > drivers/net/wireless/realtek/rtw88/tx.h | 4 ++ > 12 files changed, 94 insertions(+), 12 deletions(-) > Applied to jammy:linux, fixing the typo on Patch 1/5. Thanks, Kleber
From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com> BugLink: https://bugs.launchpad.net/bugs/1969326 [Impact] The wifi hotspot doesn't work without the fix. [Fix] Realtek provides us the patches to add this feature which are still in linux-next. https://patchwork.kernel.org/project/linux-wireless/cover/20220407095858.46807-1-pkshih@realtek.com/ ece31c93d4d6 rtw88: 8821c: fix debugfs rssi value f5207c122102 rtw88: do PHY calibration while starting AP f1c4dabfe68d rtw88: 8821c: Enable TX report for management frames f2217968ffda rtw88: Add update beacon flow for AP mode 6723c0cde84f rtw88: fix incorrect frequency reported c1edc86472fc rtw88: add ieee80211:sta_rc_update ops Realtek provides us another series of patches for 5.14, and it contains 5 commits, we'd verified this series of patches on the target machine. [Test] Verified on the Realtek 8821CE card. [Where problems could occur] The patches are introducing new interfaces, I think it only has minimal impact to the origin behaviors. Ping-Ke Shih (1): rtw88: do PHY calibration while starting AP Po-Hao Huang (4): rtw88: Add update beacon flow for AP mode rtw88: 8821c: Enable TX report for management frames rtw88: 8821c: fix debugfs rssi value rtw88: add ieee80211:sta_rc_update ops drivers/net/wireless/realtek/rtw88/fw.c | 8 ++-- drivers/net/wireless/realtek/rtw88/fw.h | 1 + drivers/net/wireless/realtek/rtw88/mac80211.c | 44 ++++++++++++++++++- drivers/net/wireless/realtek/rtw88/main.c | 12 ++++- drivers/net/wireless/realtek/rtw88/main.h | 7 ++- drivers/net/wireless/realtek/rtw88/pci.c | 3 ++ drivers/net/wireless/realtek/rtw88/phy.c | 2 +- drivers/net/wireless/realtek/rtw88/reg.h | 2 + drivers/net/wireless/realtek/rtw88/rtw8821c.c | 4 ++ .../wireless/realtek/rtw88/rtw8821c_table.c | 2 +- drivers/net/wireless/realtek/rtw88/tx.c | 17 +++++++ drivers/net/wireless/realtek/rtw88/tx.h | 4 ++ 12 files changed, 94 insertions(+), 12 deletions(-)