| Message ID | 1653502826-24256-1-git-send-email-quic_kriskura@quicinc.com |
|---|---|
| Headers | show |
| Series | USB DWC3 host wake up support from system suspend | expand |
On Wed, May 25, 2022 at 11:50:23PM +0530, Krishna Kurapati wrote: > From: Sandeep Maheswaram <quic_c_sanm@quicinc.com> > > Check wakeup-source property for dwc3 core node to set the > wakeup capability. Drop the device_init_wakeup call from > runtime suspend and resume. > > If the dwc3 is wakeup capable, don't power down the USB PHY(s). > The glue drivers are expected to take care of configuring the > additional wakeup settings if needed based on the dwc3 wakeup > capability status. In some SOC designs, powering off the PHY is > resulting in higher leakage, so this patch save power on such boards. > > Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com> > Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com> > Reviewed-by: Pavankumar Kondeti <quic_pkondeti@quicinc.com> > Reviewed-by: Matthias Kaehlcke <mka@chromium.org> > --- > drivers/usb/dwc3/core.c | 26 ++++++++++++-------------- > 1 file changed, 12 insertions(+), 14 deletions(-) > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > index e027c04..2b1b3f7 100644 > --- a/drivers/usb/dwc3/core.c > +++ b/drivers/usb/dwc3/core.c > @@ -1787,6 +1787,7 @@ static int dwc3_probe(struct platform_device *pdev) > > platform_set_drvdata(pdev, dwc); > dwc3_cache_hwparams(dwc); > + device_init_wakeup(&pdev->dev, of_property_read_bool(dev->of_node, "wakeup-source")); > > spin_lock_init(&dwc->lock); > mutex_init(&dwc->mutex); > @@ -1948,11 +1949,6 @@ static int dwc3_suspend_common(struct dwc3 *dwc, pm_message_t msg) > dwc3_core_exit(dwc); > break; > case DWC3_GCTL_PRTCAP_HOST: > - if (!PMSG_IS_AUTO(msg)) { > - dwc3_core_exit(dwc); > - break; > - } > - > /* Let controller to suspend HSPHY before PHY driver suspends */ > if (dwc->dis_u2_susphy_quirk || > dwc->dis_enblslpm_quirk) { > @@ -1967,6 +1963,11 @@ static int dwc3_suspend_common(struct dwc3 *dwc, pm_message_t msg) > > phy_pm_runtime_put_sync(dwc->usb2_generic_phy); > phy_pm_runtime_put_sync(dwc->usb3_generic_phy); > + > + if (!PMSG_IS_AUTO(msg)) { > + if (!device_can_wakeup(dwc->dev)) > + dwc3_core_exit(dwc); > + } > break; Earlier, the dwc3 which does not support wakeup just calls dwc3_core_exit(). With this patch we are modifying the behavior. Is that intentional? I expect it to be something like @@ -1761,8 +1782,10 @@ static int dwc3_suspend_common(struct dwc3 *dwc, pm_message_t msg) break; case DWC3_GCTL_PRTCAP_HOST: if (!PMSG_IS_AUTO(msg)) { - dwc3_core_exit(dwc); - break; + if (!device_can_wakeup(dwc->dev)) { + dwc3_core_exit(dwc); + break; + } } /* Let controller to suspend HSPHY before PHY driver suspends */ Thanks, Pavan
On Wed, May 25, 2022 at 11:50:25PM +0530, Krishna Kurapati wrote: > From: Sandeep Maheswaram <quic_c_sanm@quicinc.com> > > Configure DP/DM line interrupts based on the USB2 device attached to > the root hub port. When HS/FS device is connected, configure the DP line > as falling edge to detect both disconnect and remote wakeup scenarios. When > LS device is connected, configure DM line as falling edge to detect both > disconnect and remote wakeup. When no device is connected, configure both > DP and DM lines as rising edge to detect HS/HS/LS device connect scenario. > > Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com> > Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com> > --- > drivers/usb/dwc3/dwc3-qcom.c | 72 ++++++++++++++++++++++++++++++++++++++------ > 1 file changed, 62 insertions(+), 10 deletions(-) > > diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c > index 7352124..56ecee0 100644 > --- a/drivers/usb/dwc3/dwc3-qcom.c > +++ b/drivers/usb/dwc3/dwc3-qcom.c <snip> > static int dwc3_qcom_suspend(struct dwc3_qcom *qcom) > @@ -355,8 +405,10 @@ static int dwc3_qcom_suspend(struct dwc3_qcom *qcom) > if (ret) > dev_warn(qcom->dev, "failed to disable interconnect: %d\n", ret); > > - if (device_may_wakeup(qcom->dev)) > + if (device_may_wakeup(qcom->dev)) { > + qcom->usb2_speed = dwc3_qcom_update_usb2_speed(qcom); > dwc3_qcom_enable_interrupts(qcom); > + } dwc3_qcom_update_usb2_speed() is not updating anything. can you rename the function to dwc3_qcom_get_usb2_speed()? Thanks, Pavan
On Wed, May 25, 2022 at 11:50:26PM +0530, Krishna Kurapati wrote: > From: Sandeep Maheswaram <quic_c_sanm@quicinc.com> > > If dwc3 is wakeup capable, keep the power domain always ON so that > wakeup from system suspend can be supported. Otherwise, keep the > power domain ON only during runtime suspend to support wakeup from > runtime suspend. > > Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com> > Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com> > --- > drivers/usb/dwc3/dwc3-qcom.c | 28 +++++++++++++++++++++------- > 1 file changed, 21 insertions(+), 7 deletions(-) > > <snip> > - device_init_wakeup(&pdev->dev, 1); > + if (device_can_wakeup(&qcom->dwc3->dev)) { > + /* > + * Setting GENPD_FLAG_ALWAYS_ON flag takes care of keeping > + * GEMPD on in both RT suspend and System suspend cases. Few typos, otherwise looks good to me. %s/GEMPD/genpd %s/RT/runtime %s/System/system Thanks, Pavan
On 5/26/2022 8:13 AM, Pavan Kondeti wrote: > On Wed, May 25, 2022 at 11:50:23PM +0530, Krishna Kurapati wrote: >> From: Sandeep Maheswaram <quic_c_sanm@quicinc.com> >> >> Check wakeup-source property for dwc3 core node to set the >> wakeup capability. Drop the device_init_wakeup call from >> runtime suspend and resume. >> >> If the dwc3 is wakeup capable, don't power down the USB PHY(s). >> The glue drivers are expected to take care of configuring the >> additional wakeup settings if needed based on the dwc3 wakeup >> capability status. In some SOC designs, powering off the PHY is >> resulting in higher leakage, so this patch save power on such boards. >> >> Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com> >> Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com> >> Reviewed-by: Pavankumar Kondeti <quic_pkondeti@quicinc.com> >> Reviewed-by: Matthias Kaehlcke <mka@chromium.org> >> --- >> drivers/usb/dwc3/core.c | 26 ++++++++++++-------------- >> 1 file changed, 12 insertions(+), 14 deletions(-) >> >> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c >> index e027c04..2b1b3f7 100644 >> --- a/drivers/usb/dwc3/core.c >> +++ b/drivers/usb/dwc3/core.c >> @@ -1787,6 +1787,7 @@ static int dwc3_probe(struct platform_device *pdev) >> >> platform_set_drvdata(pdev, dwc); >> dwc3_cache_hwparams(dwc); >> + device_init_wakeup(&pdev->dev, of_property_read_bool(dev->of_node, "wakeup-source")); >> >> spin_lock_init(&dwc->lock); >> mutex_init(&dwc->mutex); >> @@ -1948,11 +1949,6 @@ static int dwc3_suspend_common(struct dwc3 *dwc, pm_message_t msg) >> dwc3_core_exit(dwc); >> break; >> case DWC3_GCTL_PRTCAP_HOST: >> - if (!PMSG_IS_AUTO(msg)) { >> - dwc3_core_exit(dwc); >> - break; >> - } >> - >> /* Let controller to suspend HSPHY before PHY driver suspends */ >> if (dwc->dis_u2_susphy_quirk || >> dwc->dis_enblslpm_quirk) { >> @@ -1967,6 +1963,11 @@ static int dwc3_suspend_common(struct dwc3 *dwc, pm_message_t msg) >> >> phy_pm_runtime_put_sync(dwc->usb2_generic_phy); >> phy_pm_runtime_put_sync(dwc->usb3_generic_phy); >> + >> + if (!PMSG_IS_AUTO(msg)) { >> + if (!device_can_wakeup(dwc->dev)) >> + dwc3_core_exit(dwc); >> + } >> break; > Earlier, the dwc3 which does not support wakeup just calls dwc3_core_exit(). > With this patch we are modifying the behavior. Is that intentional? I expect > it to be something like > > @@ -1761,8 +1782,10 @@ static int dwc3_suspend_common(struct dwc3 *dwc, pm_message_t msg) > break; > case DWC3_GCTL_PRTCAP_HOST: > if (!PMSG_IS_AUTO(msg)) { > - dwc3_core_exit(dwc); > - break; > + if (!device_can_wakeup(dwc->dev)) { > + dwc3_core_exit(dwc); > + break; > + } > } > > /* Let controller to suspend HSPHY before PHY driver suspends */ > > Thanks, > Pavan Hi Pavan, Thanks for pointing out that we are changing behavior. Will try to fix it in next series. Thanks, Krishna,